Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-04-01 Thread Doug Anderson
Thomas, On Mon, Mar 25, 2013 at 9:56 AM, Doug Anderson diand...@google.com wrote: Are you planning on doing this? I noticed that Chris pulled your sdhci-s3c change in recently but apparently skipped this one since it had outstanding comments. Can you address comments and re-send? This is

Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-25 Thread Doug Anderson
Thomas, On Mon, Mar 11, 2013 at 10:53 AM, Doug Anderson diand...@google.com wrote: It would be good to address Seungwon Jeon's comments (change prefix to dw_mmc and remove setup_bus), but in general this looks good to me, so... Are you planning on doing this? I noticed that Chris pulled your

Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-11 Thread Doug Anderson
Thomas, On Wed, Mar 6, 2013 at 4:04 AM, Thomas Abraham thomas.abra...@linaro.org wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham

Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
On Wed, Mar 6, 2013 at 1:04 PM, Thomas Abraham thomas.abra...@linaro.org wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham

RE: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-07 Thread Seungwon Jeon
Hi Thomas, On Wednesday, March 06, 2013, Thomas Abraham wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. 'setup_bus' callback is still useful in dw_mci_drv_data? Considering