Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-30 Thread Doug Anderson
Tomasz, On Sat, Sep 28, 2013 at 6:49 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa tomasz.f...@gmail.com wrote: So isn't the register in the PMU there to save power in the case that the watchdog timer isn't being used? How is the PMU driver to

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-30 Thread Tomasz Figa
Doug, On Monday 30 of September 2013 09:54:33 Doug Anderson wrote: Tomasz, On Sat, Sep 28, 2013 at 6:49 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa tomasz.f...@gmail.com wrote: So isn't the register in the PMU there to save power in the

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-28 Thread Tomasz Figa
On Friday 27 of September 2013 11:48:53 Doug Anderson wrote: Tomasz, On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa tomasz.f...@gmail.com wrote: So isn't the register in the PMU there to save power in the case that the watchdog timer isn't being used? How is the PMU driver to know

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala wrote: Tomasz, On Wed, Sep 18, 2013 at 10:04 AM, Doug Anderson

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Leela Krishna Amudala
Tomasz, On Fri, Sep 27, 2013 at 3:42 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Friday 27 of September 2013 16:48:34 Leela Krishna Amudala wrote: Tomasz, On Fri, Sep 27, 2013 at 3:42 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi,

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Friday 27 of September 2013 08:20:25 Doug Anderson wrote: Tomasz On Fri, Sep 27, 2013 at 4:25 AM, Tomasz Figa t.f...@samsung.com wrote: Since we already have PMU driver in mach-exynos, which already has suspend/resume syscore ops, what about placing such configuration there

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Doug Anderson
Tomasz, On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa tomasz.f...@gmail.com wrote: So isn't the register in the PMU there to save power in the case that the watchdog timer isn't being used? How is the PMU driver to know whether the watchdog is being used? Better IMHO that the watchdog

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala wrote: Tomasz, On Wed, Sep 18, 2013 at 10:04 AM, Doug Anderson diand...@chromium.org wrote: Tomasz, On Tue, Sep 17, 2013 at 6:30 AM, Tomasz Figa t.f...@samsung.com wrote: ---

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-23 Thread Tomasz Figa
On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala wrote: Tomasz, On Wed, Sep 18, 2013 at 10:04 AM, Doug Anderson diand...@chromium.org wrote: Tomasz, On Tue, Sep 17, 2013 at 6:30

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-18 Thread Leela Krishna Amudala
Tomasz, On Wed, Sep 18, 2013 at 10:04 AM, Doug Anderson diand...@chromium.org wrote: Tomasz, On Tue, Sep 17, 2013 at 6:30 AM, Tomasz Figa t.f...@samsung.com wrote: --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt +++

[PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Leela Krishna Amudala
This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com ---

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Tomasz Figa
Hi Leela, Please see my comments below. On Tuesday 17 of September 2013 16:13:42 Leela Krishna Amudala wrote: This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Reviewed-by: Doug Anderson

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Doug Anderson
Tomasz, On Tue, Sep 17, 2013 at 6:30 AM, Tomasz Figa t.f...@samsung.com wrote: --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt @@ -7,8 +7,20 @@ occurred. Required properties: - compatible : should be