Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Hi Doug, On Fri, Dec 21, 2012 at 10:35 PM, Doug Anderson diand...@chromium.org wrote: Vivek, Nothing really serious below and things look good to me, but figured I'd put a few nits in (sorry!). On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam gautam.vi...@samsung.com wrote: diff --git

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Changes from v2: - Removed the phandle type of device node properties, instead using sub-nodes now. - Removed the property 'samsung,enable-mask' since it is SoC dependent (SoCs like S5PV210 and S3C64XX have different bits to enable/disable phy controller in comparison to exysno4210

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/samsung-usbphy.txt | 28 drivers/usb/phy/samsung-usbphy.c | 145

Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Doug Anderson
Vivek, Nothing really serious below and things look good to me, but figured I'd put a few nits in (sorry!). On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam gautam.vi...@samsung.com wrote: diff --git a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt