Re: [PATCH] net: sxgbe: Added tail point update

2014-05-08 Thread Francois Romieu
Byungho An bh74...@samsung.com : Florian Fainelli wrote: [...] I think that at some point you should revisit your abstraction, all the patches that I see do take a void __iomem * argument as the first function argument, you should probably use your driver private context here. The day

RE: [PATCH] net: sxgbe: Added tail point update

2014-05-08 Thread Byungho An
Francois Romieu wrote : Byungho An bh74...@samsung.com : Florian Fainelli wrote: [...] I think that at some point you should revisit your abstraction, all the patches that I see do take a void __iomem * argument as the first function argument, you should probably use your driver

Re: [PATCH] net: sxgbe: Added tail point update

2014-05-07 Thread Florian Fainelli
2014-05-07 1:14 GMT-07:00 Byungho An bh74...@samsung.com: This patch adds tail point update function for rx path after rx_refill function. It indicates tail point for rx dma. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 14

RE: [PATCH] net: sxgbe: Added tail point update

2014-05-07 Thread Byungho An
Florian Fainelli wrote: 2014-05-07 1:14 GMT-07:00 Byungho An bh74...@samsung.com: This patch adds tail point update function for rx path after rx_refill function. It indicates tail point for rx dma. Signed-off-by: Byungho An bh74...@samsung.com ---