Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Marek Szyprowski
Hello, On 2015-11-25 19:09, Russell King - ARM Linux wrote: On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote: On 25 November 2015 at 14:34, Marek Szyprowski wrote: Is ignoring dev_pm_domain_attach() return value a solution for you? That's probably better

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Ulf Hansson
On 26 November 2015 at 09:39, Marek Szyprowski wrote: > Hello, > > On 2015-11-25 19:09, Russell King - ARM Linux wrote: >> >> On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote: >>> >>> On 25 November 2015 at 14:34, Marek Szyprowski

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Russell King - ARM Linux
On Thu, Nov 26, 2015 at 11:24:50AM +0100, Ulf Hansson wrote: > On 26 November 2015 at 09:39, Marek Szyprowski > wrote: > > Hello, > > > > On 2015-11-25 19:09, Russell King - ARM Linux wrote: > >> > >> On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote: > >>> >

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Marek Szyprowski
Hello, On 2015-11-26 11:59, Russell King - ARM Linux wrote: On Thu, Nov 26, 2015 at 11:24:50AM +0100, Ulf Hansson wrote: On 26 November 2015 at 09:39, Marek Szyprowski wrote: Hello, On 2015-11-25 19:09, Russell King - ARM Linux wrote: On Wed, Nov 25, 2015 at

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Marek Szyprowski
Hello, On 2015-11-26 11:24, Ulf Hansson wrote: On 26 November 2015 at 09:39, Marek Szyprowski wrote: On 2015-11-25 19:09, Russell King - ARM Linux wrote: On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote: On 25 November 2015 at 14:34, Marek Szyprowski

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-26 Thread Mathieu Poirier
On 26 November 2015 at 03:24, Ulf Hansson wrote: > On 26 November 2015 at 09:39, Marek Szyprowski > wrote: >> Hello, >> >> On 2015-11-25 19:09, Russell King - ARM Linux wrote: >>> >>> On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote:

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-25 Thread Russell King - ARM Linux
On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote: > On 25 November 2015 at 14:34, Marek Szyprowski > wrote: > > Is ignoring dev_pm_domain_attach() return value a solution for you? > > That's probably better than nothing, but I wonder if it in practice > will

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-25 Thread Russell King - ARM Linux
On Wed, Nov 25, 2015 at 01:58:09PM +0100, Marek Szyprowski wrote: > To read pid/cid registers, the probed device need to be properly turned on. > When it is inside a power domain, the bus code should ensure that the > given power domain is enabled before trying to access device's registers. > >

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-25 Thread Marek Szyprowski
Hello, On 2015-11-25 14:24, Russell King - ARM Linux wrote: On Wed, Nov 25, 2015 at 01:58:09PM +0100, Marek Szyprowski wrote: To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 14:34, Marek Szyprowski wrote: > Hello, > > On 2015-11-25 14:24, Russell King - ARM Linux wrote: >> >> On Wed, Nov 25, 2015 at 01:58:09PM +0100, Marek Szyprowski wrote: >>> >>> To read pid/cid registers, the probed device need to be properly turned

Re: [PATCH 1/2] drivers: amba: properly handle devices with power domains

2015-11-25 Thread Marek Szyprowski
Hello, On 2015-11-25 14:56, Ulf Hansson wrote: On 25 November 2015 at 14:34, Marek Szyprowski wrote: On 2015-11-25 14:24, Russell King - ARM Linux wrote: On Wed, Nov 25, 2015 at 01:58:09PM +0100, Marek Szyprowski wrote: To read pid/cid registers, the probed device