Martinez Canillas jav...@dowhile0.org
Thanks
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
this in the clock driver.
Signed-off-by: Doug Anderson diand...@chromium.org
---
drivers/clk/samsung/clk-exynos5420.c | 24
1 file changed, 24 insertions(+)
I tested your patch and it solves the issue for me, so feel free to add
Tested-by: Javier Martinez Canillas
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 320 +
1 file changed, 320 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 1c5b8f9
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/mfd/max77802.txt | 88
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs,
a Real-Time-Clock (RTC) and a I2C interface to program the individual
regulators, clocks and the RTC.
This series are based on drivers added by Simon Glass to
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77802.c | 3
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings/clock/maxim,max77802.txt | 40
drivers/clk/Kconfig
Hello Krzystof,
Thanks a lot for your feedback.
On 06/09/2014 06:04 PM, Doug Anderson wrote:
Krzystof,
On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote:
MAX77802 is a PMIC that contains 10
Hello Krzysztof,
On 06/09/2014 12:22 PM, Krzysztof Kozlowski wrote:
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote:
Maxim MAX77802 is a power management chip that contains 10 high
efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
to power up application
Hello Mark,
Thanks a lot for your feedback.
On 06/09/2014 09:38 PM, Mark Brown wrote:
On Mon, Jun 09, 2014 at 11:37:47AM +0200, Javier Martinez Canillas wrote:
+case REGULATOR_MODE_STANDBY:/* switch off */
+if (id != MAX77802_LDO1 id != MAX77802_LDO20
Hello Mark,
On 06/09/2014 09:47 PM, Mark Brown wrote:
On Mon, Jun 09, 2014 at 11:37:46AM +0200, Javier Martinez Canillas wrote:
+Optional node:
+- voltage-regulators : The regulators of max77802 have to be instantiated
+ under subnode named voltage-regulators using the following format
Martinez Canillas wrote:
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs,
a Real-Time-Clock (RTC) and a I2C interface to program the individual
regulators, clocks and the RTC.
This series are based on drivers
Hello Doug,
On 06/10/2014 07:39 PM, Doug Anderson wrote:
Hi,
On Mon, Jun 9, 2014 at 11:48 PM, Shaik Ameer Basha
shaik.sams...@gmail.com wrote:
Hi Kevin,
We tested on 3 peach-pi boards. We are not observing this issue.
Even I tried with the below defconfig mentioned by you. No issues
as a reference on how to fix their FDT in case this change broke their
platforms.
Respective changes are preposed to spi-s3c64xx.c driver.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Acked-by: Rob Herring r...@kernel.org
Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc
Hello Tushar,
On 06/11/2014 07:39 AM, Tushar Behera wrote:
On 06/11/2014 01:56 AM, Doug Anderson wrote:
Javier,
On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Yes, I did not have this issue before. However... I installed the latest
Peach
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Naveen,
On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote:
Hello Javier,
On 11 June 2014 16:43, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Hello Naveen,
Thanks a lot for your patches and sorry that I didn't review your prior two
versions but I didn't have
...@kernel.org
Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc: Doug Anderson diand...@chromium.org
Cc: Tomasz Figa t.f...@samsung.com
---
Usually when you send a new version of a series is good to keep a history of the
patch-set so reviewers don't have to look at the previous threads
to what you changed in Patch 1. But it's just a nitpick.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info
are preposed to spi-s3c64xx.c driver.
@ http://www.spinics.net/lists/linux-samsung-soc/msg32282.html
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Acked-by: Rob Herring r...@kernel.org
Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc: Doug Anderson diand...@chromium.org
Hello Lee,
On 06/16/2014 10:44 AM, Lee Jones wrote:
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings/clock
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs,
a Real-Time-Clock (RTC) and a I2C interface to program the individual
regulators, clocks and the RTC.
This second version of the patch-set addresses several
By using the generic IRQ support in the Register map API, it
is possible to get rid of max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/Kconfig
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77802.c | 1
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v1:
- Use regulators for child node instead of voltage-regulators to be
consistent with other PMIC. Suggested by Mark Brown.
- Use regulators node names instead of the deprecated regulator-compatible
property
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/clk/clk-max77686.c | 7
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings/clock/maxim,max77686.txt | 15
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v1:
- Convert max77{686,802} to regmap irq API
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v1:
- Use module_platform_driver() instead of having init/exit functions
Hello Mark,
Thanks a lot for your feedback.
On 06/16/2014 09:25 PM, Mark Brown wrote:
On Mon, Jun 16, 2014 at 08:02:35PM +0200, Javier Martinez Canillas wrote:
--- a/drivers/mfd/max77802.c
+++ b/drivers/mfd/max77802.c
@@ -37,6 +37,7 @@
#include linux/err.h
static const struct
Hello Mark,
On 06/16/2014 09:27 PM, Mark Brown wrote:
On Mon, Jun 16, 2014 at 08:02:34PM +0200, Javier Martinez Canillas wrote:
+- max77802,pmic-buck-dvs-gpios: The DVS GPIOs. We'll try to set these GPIOs
+ to match pmic-buck-default-dvs-idx at probe time if they are defined. If
+ some
Hello Mark,
On 06/17/2014 04:12 PM, Mark Brown wrote:
On Tue, Jun 17, 2014 at 12:49:56PM +0200, Javier Martinez Canillas wrote:
On 06/16/2014 09:25 PM, Mark Brown wrote:
+ config.dev = pdev-dev;
Are you sure this shouldn't be the MFD?
I just looked at regulator_register() and saw
Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Doug,
On 06/17/2014 10:57 PM, Doug Anderson wrote:
Javier,
On Mon, Jun 16, 2014 at 11:02 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
@@ -127,15 +175,48 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
}
i2c_set_clientdata(max77686-rtc
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2: None
Changes since v1:
- Use regulators for child node instead of voltage-regulators to be
consistent with other PMIC. Suggested by Mark Brown.
- Use regulators node names instead of the deprecated regulator
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/rtc/Kconfig| 10
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Split the DT binding documentation in a separate patch.
.../devicetree/bindings/clock/maxim
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2: None
Changes since v1:
- Use module_platform_driver() instead of having
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Split the DT binding docs in a separate
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators and the max77802,pmic-buck-{dvs,selb}-gpios properties
by holding the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base/regmap/regmap.c b/drivers
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings/clock/maxim,max77686.txt | 15
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
Signed-off-by: Doug Anderson diand...@chromium.org
---
drivers/rtc/rtc-max77686.c | 28
1 file changed,
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/clk/clk-max77686.c | 7
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
Hello Mark,
On 06/21/2014 10:40 PM, Mark Brown wrote:
On Tue, Jun 17, 2014 at 06:05:29PM +0200, Javier Martinez Canillas wrote:
On 06/17/2014 04:12 PM, Mark Brown wrote:
I just looked at regulator_register() and saw that it does
rdev-dev.parent =
dev, so yes this has to be the MFD
Hello Ajay,
Not an extensive review since I'm not familiar with the graphics stack
but a few things I noticed are commented below.
On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
This patch adds a simple driver to handle all the LCD and LED
powerup/down routines
Hello Ajay,
On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
From: Vincent Palatin vpala...@chromium.org
This patch adds drm_bridge driver for parade DisplayPort
to LVDS bridge chip.
Signed-off-by: Vincent Palatin vpala...@chromium.org
Signed-off-by: Andrew
Hello Doug,
On 06/24/2014 06:05 AM, Doug Anderson wrote:
Andreas,
On Mon, Jun 23, 2014 at 3:46 PM, Andreas Färber afaer...@suse.de wrote:
Hi Doug,
Am 23.06.2014 21:47, schrieb Doug Anderson:
Thanks for posting! A first pass on this is below...
Thanks a lot for your quick review! My
-by: Doug Anderson diand...@chromium.org
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Along with the dependency patches on next-20140623, tested keyboard on
Peach-Pi board.
Tested-by: Tushar Behera tusha...@samsung.com
Some comments below.
---
Changes in v2:
- Now just
Hello Mark,
On 06/23/2014 11:47 AM, Mark Brown wrote:
On Mon, Jun 23, 2014 at 11:28:25AM +0200, Javier Martinez Canillas wrote:
On 06/21/2014 10:40 PM, Mark Brown wrote:
That's not really relevant here - I'm asking if the regulators get their
own supplies rather than if anything uses them
Hello Naveen,
On Wed, Jun 25, 2014 at 7:04 AM, Naveen Krishna Ch
naveenkrishna...@gmail.com wrote:
Doug,
On 25 June 2014 03:24, Doug Anderson diand...@chromium.org wrote:
Naveen,
On Tue, Jun 24, 2014 at 5:19 AM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
Exynos5420 based Peach
Hello Krzysztof,
On 06/25/2014 12:05 PM, Krzysztof Kozlowski wrote:
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
index 5d49f2b..832fe8c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
+++ b
= adc 6;
+ };
+};
+
dp {
status = okay;
pinctrl-names = default;
--
1.7.9.5
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord
Hello Krzysztof,
On 06/25/2014 04:19 PM, Krzysztof Kozlowski wrote:
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote:
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code
,
+ .resume_noirq = s3c24xx_i2c_resume_noirq,
+ .freeze_noirq = s3c24xx_i2c_suspend_noirq,
+ .thaw_noirq = s3c24xx_i2c_resume_noirq,
+ .poweroff_noirq = s3c24xx_i2c_suspend_noirq,
+ .restore_noirq = s3c24xx_i2c_resume_noirq,
#endif
};
Looks good to me.
Reviewed-by: Javier Martinez
On 06/25/2014 07:24 PM, Doug Anderson wrote:
Hi,
On Wed, Jun 25, 2014 at 3:29 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Yes, the original Chrome OS 3.8 max77xxx also called the irq worker thread to
ack the interrupt.
So the real problem is that an interrupt
Hello Doug,
Thanks a lot for your feedback.
On 06/25/2014 08:06 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
@@ -33,6 +38,6 @@ Example: Clock consumer node
foo@0 {
compatible
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
drivers/rtc
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators and the max77802,pmic-buck-{dvs
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Keep the note that this patch needs another change due wakeup
ordering problems.
drivers/rtc/rtc
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
;
+ vdd-supply = ldo8_reg;
+ vdd_osc-supply = ldo10_reg;
+ vdd_pll-supply = ldo8_reg;
};
usbdrd_phy0 {
--
1l.7.9.5
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung
and also we may later factor out common
DTS fragments on these two boards in .dtsi include files so is better
to keep the diff as small as possible.
};
hsi2c_7 {
--
1.7.9.5
With that trivial change:
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Krzysztof,
Thanks a lot for your feedback.
On 06/26/2014 11:31 AM, Krzysztof Kozlowski wrote:
Hi,
Just a few nit-picks below but overall everything looks fine:
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
+
+static int max77802_i2c_probe(struct i2c_client *i2c,
+
Hello Krzysztof,
Thanks a lot for your feedback.
On 06/26/2014 12:08 PM, Krzysztof Kozlowski wrote:
On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote:
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote:
Hi Javier,
Sorry for jumping in late, but just one concern mentioned inline.
[ .. ]
+
+static unsigned long max_gen_recalc_rate(struct clk_hw *hw,
+
Hello Naveen,
Thanks a lot for testing!
On 06/26/2014 03:32 PM, Naveen Krishna Ch wrote:
Hello Javier,
On 26 June 2014 00:33, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
32 Low-dropout (LDO
Hello Naveen,
On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
This patchset does the following
1. Create a common dtsi file cros-exynos-peach.dtsi for
exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
There was some previous discussion in this list
Hello Doug,
On 06/26/2014 06:12 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
+
+#ifdef CONFIG_PM_SLEEP
+static int max77802_suspend(struct device *dev)
+{
+struct i2c_client *i2c = container_of(dev
Hello Doug,
On 06/26/2014 06:29 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 9:18 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Hello Doug,
On 06/26/2014 06:12 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v4: None
Changes since v3:
- Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson.
- Model the actual regulators relationship
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3:
- Don't use the same clock driver name in clock-names since it's a consumer
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v4: None
Changes
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3: None
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
):
mfd: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (13):
mfd: max77686: Convert to use regmap_irq
clk: max77686: Add DT include for MAX77686 PMIC clock
clk: max77686: Improve Maxim 77686 PMIC clocks binding
clk: Add generic driver for Maxim PMIC clocks
clk
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3: None
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Tested
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v4: None
Changes since v3:
- Keep the note
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
Hello Andreas,
On 06/27/2014 09:48 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
can be shared?
As it should be quite clear right now I'm
Hello Andres,
Thanks a lot for your feedback.
On 06/27/2014 09:52 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
1 - 100 of 1325 matches
Mail list logo