On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote:
With the addition of platform specific driver data in the spi-s3c64xx
driver, the device name of spi controllers are changed. Accordingly,
update the device name of spi clocks instances.
This should've been squashed into the patch
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote:
+ s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1);
Shouldn't we just set the name in the struct platform_device rather than
requiring the machine to pass it through by hand?
--
To unsubscribe from this list: send the line
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
+- gpios: The gpio specifier for clock, mosi and miso interface lines (in no
+ particular order). The format of the gpio specifier depends on the gpio
+ controller.
This seems odd... This isn't a bitbanging controller, and
On Wed, May 09, 2012 at 11:10:14AM +0200, Heiko Stübner wrote:
Similar to the adc and rtc driver, all Samsung platforms reuse a common
platform-device definition for the s3c64xx-spi and simply will set the
correct
name when the machine type is determined during boot.
Right, that doesn't
On Wed, May 09, 2012 at 09:40:26PM +0800, Thomas Abraham wrote:
On 9 May 2012 16:52, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
This should've been squashed into the patch that updated to use driver
data in order to avoid breaking bisection.
This patch updates clock devname
On Wed, May 09, 2012 at 10:13:28PM +0800, Thomas Abraham wrote:
On 9 May 2012 17:07, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
+- gpios: The gpio specifier for clock, mosi and miso interface lines
On Wed, May 09, 2012 at 10:22:26PM +0800, Thomas Abraham wrote:
On 9 May 2012 18:55, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Yes, that's the normal way of handling this and is actually what the
code was originally doing - there's a bunch of ifdefed devices in
plat-samsung
On Thu, May 10, 2012 at 12:39:29AM +0800, Thomas Abraham wrote:
On 9 May 2012 22:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Yeah, I know. I'm saying we should try to come up with a binding for
this that can be used by new SPI contollers going forward so things
On Wed, May 09, 2012 at 09:54:53PM +0530, Yadwinder Singh wrote:
This patch series adds support for max77686 which is a multifunction device
which
includes regulator (pmic), rtc and charger sub-blocks within it. The support
for
mfd driver and regulator driver are added by this patch series.
On Wed, May 09, 2012 at 09:54:54PM +0530, Yadwinder Singh wrote:
+int max77686_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
+{
+ int ret;
+
+ ret = i2c_smbus_read_byte_data(i2c, reg);
+ if (ret 0)
It would really be better if this used the regmap API - the regulator
API
On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
+/* Voltage maps in mV */
+static const struct voltage_map_desc ldo_voltage_map_desc = {
+ .min = 800, .max = 3950,.step = 50, .n_bits = 6,
+}; /* LDO3 ~ 5, 9 ~ 14, 16 ~ 26 */
Hrm,
On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote:
On Thu, May 10, 2012 at 12:17 AM, Mark Brown
On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
+ [MAX77686_EN32KHZ_AP] = NULL,
+ [MAX77686_EN32KHZ_CP] = NULL,
Now that the generic clock API
On Thu, May 10, 2012 at 01:17:32AM +0800, Thomas Abraham wrote:
On 9 May 2012 22:28, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
This means that bisection will be broken - anything with only one tree
won't be able to load the SPI driver successfully until it's merged
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
Are these patches ok for inclusion ?
you might want to include the maintainer
Kukjin Kim kgene@samsung.com
The Bells module now has a number assigned to it. Also hook up the WM9081
which is soldered down onto the board.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff
We now have an additional classs of modules which are enumerated at I2C
address 0x22. Add hookup for these modules.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410.c |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx
On Tue, May 15, 2012 at 05:58:12PM +0900, Kukjin Kim wrote:
Looks good to me, but there is no '{ I2C_BOARD_INFO(wlf-gf-module, 0x20)
},' in my tree.
Just adding address 0x22 stuff is enough now?
Yes, it is - sorry, context diff for another project.
signature.asc
Description: Digital
On Tue, May 15, 2012 at 07:17:11PM +0530, Yadwinder Singh Brar wrote:
On Thu, May 10, 2012 at 12:17 AM, Mark Brown
On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
+ if (iodev-dev-of_node) {
+ ret = max77686_pmic_dt_parse_pdata(iodev, pdata
On Mon, May 14, 2012 at 04:06:16PM +0200, Daniel Lezcano wrote:
The states are now part of the cpuidle_driver structure, so we can
declare the states in this structure directly. That saves us an extra
variable declaration and a memcpy.
Tested-by: Mark Brown broo...@opensource.wolfsonmicro.com
On Mon, May 14, 2012 at 04:06:17PM +0200, Daniel Lezcano wrote:
The timekeeping is computed from the cpuidle core if we set
the .en_core_tk_irqen flag. Let's use it and remove the duplicated
code.
Tested-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital
I2C
bus.It also includes IRQ and device tree support for MAX77686 chip.
Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Thu, May 17, 2012 at 07:09:27PM +0530, Yadwinder Singh Brar wrote:
Looks mostly good. A couple of fairly small things:
+static int max77686_get_voltage_sel(struct regulator_dev *rdev)
+{
This looks like it should be regulator_get_voltage_sel_regmap().
+static int
On Tue, May 22, 2012 at 03:53:11PM +0900, Kyungmin Park wrote:
BTW, do you know that you're reviewing the same device driver patch
from different person?
One from Mr. Lee and another from Yadwinder.
I wonder how to handle it finally. which one is choose?
Yes, I realise there's two different
On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote:
On Sun, May 20, 2012 at 2:21 AM, Mark Brown
This dev_name also isn't equivalent to dev_name() which makes matters
more confusing than they need to be.
Looks like they use the name as the magic string to pick initialization
On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote:
On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Right, and there's no problem at all with using the name. The thing is
that there's no need to set the name at runtime since the struct device
being
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index dbd5771..985e255 100644
No platform data yet as driver is not yet merged.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
b/arch/arm/mach-s3c64xx
On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote:
On 30 May 2012 18:13, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
No there isn't. You've got things like s3c64xx_device_spi0 in
arch/arm/plat-samsung/devs.c (which you'd expect since the resources
that are passed
On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote:
1. There is one instance of 'struct platform_device' for each of the
spi controller instances (0/1/2) named s3c64xx-spi (in
arch/arm/plat-samsung/devs.c).
Right, which looks rather like it is specific to s3c64xx at least given
Use the new irqdomain support in the WM8994 driver to dynamically allocate
the interrupt range for the WM8994 rather than doing it explicitly. This
is more idiomatic for modern interrupt usage.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/include/mach
Now that the WM831x driver uses irq_domain we can happily allow it to
assign its own IRQs.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/include/mach/crag6410.h |3 +--
arch/arm/mach-s3c64xx/mach-crag6410.c |1 -
2 files changed, 1
On Sun, Jun 03, 2012 at 03:29:55PM +0200, Heiko St??bner wrote:
request_threaded_irq(sc-ext_cd_irq, NULL,
sdhci_s3c_gpio_card_detect_thread,
- IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING,
+
On Mon, Jun 11, 2012 at 05:41:08PM +0530, Yadwinder Singh Brar wrote:
For some hardwares ramp_delay for BUCKs is a configurable parameter which can
be configured through DT or board file.This patch adds ramp_delay to regulator
constraints and allow user to configure it for regulators which
A small code saving and less error handling to worry about.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/i2c/busses/i2c-s3c2410.c | 35 +++
1 file changed, 7 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410
There's no point in using _sync() as we don't really care if the suspend
has completed immediately.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/i2c/busses/i2c-s3c2410.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi
On Thu, Jun 28, 2012 at 08:51:44PM +0200, Linus Walleij wrote:
I'm starting to wonder if it would not be possible to mass-convert these
using coccinelle.
Probably, yes. I'm not actually going through these particularly,
really what I'm doing is looking to find drivers I run on my systems
that
With the greater use of deferred probes we need to be more sure that
initdata is actually used only at system init rather than being used
by devices when they probe (which could happen after the main kernel
init has completed and is much more likely to now).
Signed-off-by: Mark Brown broo
On Tue, Jul 03, 2012 at 02:04:04PM +0530, Sachin Kamat wrote:
Current method for machine driver to register with the ASoC core is to use
snd_soc_register_card() instead of creating a soc-audio platform device.
Applied, thanks (it's not a generic Samsung patch, it's just for the one
board BTW).
a flag day to convert the entire family of devices over.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/plat-samsung/Kconfig |4
arch/arm/plat-samsung/Makefile |4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-samsung
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git
On Thu, Jul 05, 2012 at 10:41:04AM +0200, Sylwester Nawrocki wrote:
It doesn't seem right. Why is is the check for valid sdd-regs removed ?
This should have rather been:
Mostly just because the structure of the code is a bit error prone when
making quick updates with the if statement
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-s3c64xx.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/spi
On Mon, Jul 09, 2012 at 03:52:29PM +0200, Wolfram Sang wrote:
On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote:
A small code saving and less error handling to worry about.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
What about devm for the clocks, too
None of the GPIO IRQs are connected so there is no reason to specify a
base.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-smdk6410.c |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c
b/arch/arm/mach
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote:
The set_level callback in the controller data, which is used to configure
the slave select line, cannot be supported when migrating the driver to
device tree based discovery. Since all the platforms currently use gpio
as the slave
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote:
In non-dt case, the platform code supplying the gpio number (slave
select line) is responsible for requesting the gpio during the
machine_init call. So the gpio request is not called in the driver for
that gpio. In dt case, the
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote:
The set_level callback in the controller data, which is used to configure
the slave select line, cannot be supported when migrating the driver to
device tree based discovery. Since all the platforms currently use gpio
as the slave
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote:
Based on your comments to add the gpio request, only two patches 5/6
and 6/6 in this series have changed since. I have cc'ed you in the
other 4 patches as well. If you do not have those patches, please let
me know, I will repost
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote:
Changes since v4:
- Includes the missing gpio request for slave select line gpio as suggested
by Mark Brown.
These looked OK (and have had quite a bit of review already so we're
probably at the stage where incremental fixes
On Thu, Jul 12, 2012 at 06:11:05PM +0900, Kukjin Kim wrote:
And Mark, this touches various samsung stuff in arch/arm/ so if you're ok,
I'd like to pick this up in samsung tree. We don't want to see conflicts...
Well, simple conflicts aren't that big a deal... However, Thomas
mentioned that in
On Thu, Jul 12, 2012 at 07:13:37PM +0530, Thomas Abraham wrote:
On 12 July 2012 18:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Well, simple conflicts aren't that big a deal... However, Thomas
mentioned that in order to test this he merged the SPI tree into your
tree so
On Thu, Jul 12, 2012 at 03:56:36PM +0200, Sylwester Nawrocki wrote:
These are the only two patches (out of 15) that are now needed to remove
some obsolete s3c2410_gpio_* API. 1/2 was tested on Micro2440 board
and 2/2 is an identical change which wasn't tested on a real H/W since
I don't have
On Fri, Jul 13, 2012 at 10:37:12AM +0200, Wolfram Sang wrote:
On Mon, Jul 09, 2012 at 02:58:10PM +0100, Mark Brown wrote:
The devm_ versions of the API aren't exported there yet and there's a
bug fix pending too but Russell and Mike have ignored the patches thus
far.
I'd rather wait
On Thu, Jul 12, 2012 at 08:09:09PM +0200, Sylwester Nawrocki wrote:
Thanks, would that be Takashi Iwai and Jaroslav Kysela then ? I just
want to get it right this time...
Or perhaps could you take care of them ?
As with everything else look in MAINTAINERS, so me for ASoC.
signature.asc
On Tue, Jul 17, 2012 at 08:52:20AM +0900, Kukjin Kim wrote:
So may I take then send this series via samsung tree? Because for samsung
spi dt, the file has been touched in samsung tree so it helps to avoid bad
conflicts.
May as well, yes.
signature.asc
Description: Digital signature
Commit 1c20c2 (spi: s3c64xx: Remove the 'set_level' callback from
controller data) didn't update all the users, breaking the build. Fix
that.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 -
1 file changed, 1 deletion
On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote:
Fixes the following build error:
In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0,
from arch/arm/plat-samsung/include/plat/dma-ops.h:17,
from
SPI is also connected on the board, use that instead of I2C as it's much
faster. Also define platform data now the core driver is in mainline.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c | 35 ++
1 file
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410.c | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c
b/arch/arm/mach-s3c64xx/mach-crag6410.c
index ab8dbbe4..4103ed3 100644
--- a/arch/arm
On Fri, Aug 10, 2012 at 01:56:23PM +0900, Kukjin Kim wrote:
Probably, this patch needs following?
If you're ok, I will fix build error by above when I apply.
Yes, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote:
Fixes the following build error:
In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0,
from arch/arm/plat-samsung/include/plat/dma-ops.h:17,
Applied, thanks.
--
To unsubscribe from this list: send the
On Wed, Aug 22, 2012 at 06:38:36PM +0900, Kukjin Kim wrote:
Julia Lawall wrote:
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Acked-by: Kukjin Kim kgene@samsung.com
(Cc'ed Mark Brown who is handling spi for a moment)
Please resend the patch to me so I can apply
On Wed, Aug 22, 2012 at 01:42:47PM +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Initialize return variable before exiting on an error path.
Applied, thanks.
signature.asc
Description: Digital signature
On Thu, Aug 23, 2012 at 06:45:19PM +0900, Kukjin Kim wrote:
Yeah, actually SoC defconfig in mainline doesn't cover _real_ requirements
for (mass) product. But I think, it's time we need to sort out the
defconfigs so that we could use them efficiently on product. BTW, if
enabling board in
On Sun, Aug 26, 2012 at 05:04:37PM +0900, �ڻ��� wrote:
All EXYNOSs use SND_SOC_SAMSUNG configuration.
This patch change Kconfig to support all EXYNOSs like EXYNOS4 and EXYNOS5.
git can't figure out how to apply your patch due to your character set:
fatal: cannot convert from ks_c_5601-1987
On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause subsequent
module unload attempts to fail. Drop the calls.
Applied, thanks.
--
To unsubscribe from
On Sun, Aug 26, 2012 at 05:45:54PM +0900, �ڻ��� wrote:
SND_SOC_DAIFMT_CONT option is now needed because of below commit:
ASoC: Allow DAI formats to be specified in the dai_link
Clearly it's not a direct consequence of this commit, that just
introduces a new optional facility which...
On Tue, Aug 28, 2012 at 05:55:49PM +0900, Sangsu Park wrote:
All SAMSUNG ASoC needs SND_SOC_SAMSUNG configuration.
This patch change Kconfig to support all SAMSUNG ASoC.
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote:
Please check your mailer configuration, it looks like it's reformatting
all the text with much longer line widths.
On Sun, Aug 26, 2012 at 05:45:54PM +0900, Mark Brown wrote:
a whole lot of sense on the slave side, it's related
On Mon, Sep 03, 2012 at 11:10:03AM +0900, Sangsu Park wrote:
On Sun, Aug 31, 2012 at 2:43 AM +0900, Mark Brown wrote:
On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote:
Please check your mailer configuration, it looks like it's reformatting
all the text with much longer line
On Thu, Sep 13, 2012 at 04:31:30PM +0200, Sylwester Nawrocki wrote:
When s3c64xx-spi is instantiated from device tree an instance of
struct s3c64xx_spi_csinfo is dynamically allocated in the driver.
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
On Wed, Sep 26, 2012 at 12:03:44AM +0900, Inki Dae wrote:
2012/9/25 Laurent Pinchart laurent.pinch...@ideasonboard.com:
Aren't DT bindings considered as an ABI, and required to be supported more
or
less forever ? If you merge this DT binding you'll have to keep supporting
it.
That's
On Wed, Oct 03, 2012 at 08:30:12AM +0900, Thomas Abraham wrote:
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
calls as required by common clock framework.
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a
On Fri, Nov 02, 2012 at 01:04:14PM +, Dimitris Papastamos wrote:
We are using S3C_EINT(4) instead of S3C_EINT(5).
Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
A small code saving and less error handling to worry about.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/i2c/busses/i2c-s3c2410.c | 35 +++
1 file changed, 7 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410
Use the PM_SLEEP ifdef for system suspend and resume. This is partly
in preparation for adding runtime operations and partly because a user
may in theory choose to enable runtime suspend but not system suspend.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Reviewed
On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote:
On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
A small code saving and less error handling to worry about.
Looks good.
request irq could be devm_* also. Not an objection though
On Wed, Nov 07, 2012 at 11:40:12AM +0530, Naveen Krishna Chatradhi wrote:
From: Abhilash Kesavan a.kesa...@samsung.com
The SPI driver makes a gpio_request during initialization. The requested
gpios need to be populated as part of the s3c64xx_spi_driver_data so that
they can be released
On Mon, Nov 19, 2012 at 01:24:49PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devinitdata is no
longer needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Thu, Nov 15, 2012 at 05:43:32PM +0530, Naveen Krishna Chatradhi wrote:
+ iicstat = readl(i2c-regs + S3C2410_IICSTAT);
+ delay = 1;
+ while ((iicstat S3C2410_IICSTAT_START)
+ktime_us_delta(now, start) S3C2410_IDLE_TIMEOUT) {
+ usleep_range(delay, 2 *
On Tue, Nov 20, 2012 at 07:21:36AM +0100, Takashi Iwai wrote:
Yet another one for ASoC.
Date: Mon, 19 Nov 2012 13:21:35 -0500
From: Bill Pemberton wf...@virginia.edu
To: gre...@linuxfoundation.org
Cc: Jaroslav Kysela pe...@perex.cz, Takashi Iwai ti...@suse.de, M R
Swami Reddy
On Mon, Nov 19, 2012 at 01:21:12PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Mon, Nov 19, 2012 at 01:21:41PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Mon, Nov 19, 2012 at 01:22:59PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Mon, Nov 19, 2012 at 01:23:39PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Mon, Nov 19, 2012 at 01:25:57PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Mon, Nov 19, 2012 at 01:26:24PM -0500, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
signature.asc
Description: Digital signature
On Tue, Nov 20, 2012 at 02:27:04PM -0800, Doug Anderson wrote:
From: Padmavathi Venna padm...@samsung.com
Get the i2c bus number that the device is connected to using the alias
id. This makes debugging / grokking of kernel messages much easier.
This doesn't look like a s3c2410 specific
On Fri, Nov 23, 2012 at 04:40:59PM +0530, Padma Venkat wrote:
cc'ing Mark Brown.
On Tue, Nov 6, 2012 at 10:18 AM, Padmavathi Venna padm...@samsung.com wrote:
Changes since v2:
- Rebased on 3.7-rc3
Please don't do this, send the patches non-quoted.
signature.asc
Description
On Fri, Nov 23, 2012 at 01:33:13PM +0530, Thomas Abraham wrote:
The BUCKxDVSx register programming is now moved prior to setting up of the
gpio based dvs mode. This will ensure that all the BUCKxDVSx registers
are programmed with appropriate voltage values before the gpio based dvs
mode is
On Fri, Nov 23, 2012 at 01:33:14PM +0530, Thomas Abraham wrote:
In case the gpio based volatage selection mode is not used for either of
buck 1/2/5, then only the BUCKxDVS1 register need to be programmed. So
determine whether dvs mode is used and limit the loop count appropriately.
Applied,
On Fri, Nov 23, 2012 at 01:33:15PM +0530, Thomas Abraham wrote:
This v6 patch is rebased to the latest max8997 driver code and there are no
functional changes from v5.
That doesn't seem to be in mainline yet so the patch won't apply.
signature.asc
Description: Digital signature
On Sat, Nov 24, 2012 at 11:46:51PM +0530, Thomas Abraham wrote:
The max8997 driver is mainlined. I actually meant to say that, this v6
version of dt support patch for max8997, is similar in functionality
to the v5 version of this patch. I did prepare this patch based on
your latest for-next
On Mon, Nov 26, 2012 at 07:16:04PM +0530, Thomas Abraham wrote:
and this patch applied cleanly. Could you please let me know if there
is anything I need to be doing differently for this.
Hrm, try applying it on the relevant topic branch. Your comments about
rebasing on top of MFD changes did
On Mon, Nov 26, 2012 at 08:13:23PM +0530, Thomas Abraham wrote:
I tried applying this patch on the max8997 branch in your regulator
tree. But this patch does not apply cleanly on that branch because
commits 5eb9f2b96381 (regulator: remove use of __devexit_p),
a5023574d120 (regulator: remove
On Mon, Nov 26, 2012 at 08:15:12PM +0530, Padma Venkat wrote:
On Wed, Nov 14, 2012 at 5:39 PM, Padmavathi Venna padm...@samsung.com wrote:
+module_init(smdk_audio_init);
+module_exit(smdk_audio_exit);
Ping. Any comments on this patch?
Don't send contentless pings and delete irrelevant
should not be being made independently of removal of the
uses of the field since it will cause build failures in any tree where
it has been merged but the removals have not been merged. Currently
the removal of the users in the ASoC driver has not been merged.
Signed-off-by: Mark Brown broo
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
arch/arm/mach-s3c64xx/mach-crag6410.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c
b/arch/arm/mach-s3c64xx/mach-crag6410.c
index 2abe95d..c06bcfa 100644
1 - 100 of 1104 matches
Mail list logo
