Re: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message
On 04/02/2014 09:50 AM, Pankaj Dubey wrote: This patch corrects file path mentioned in file comment message. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/platsmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 03e5e9f..d8d1555 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -1,4 +1,4 @@ -/* linux/arch/arm/mach-exynos4/platsmp.c +/* linux/arch/arm/mach-exynos/platsmp.c * * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. * http://www.samsung.com Shouldn't you just remove it entirely? I had the same file names in the whole microblaze tree and some months/years later this was just broken everywhere. That's why it is just easier to remove it entirely. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform signature.asc Description: OpenPGP digital signature
Re: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message
Hi Michal, On 04/02/2014 09:01 PM, Michal Simek wrote: On 04/02/2014 09:50 AM, Pankaj Dubey wrote: This patch corrects file path mentioned in file comment message. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/platsmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 03e5e9f..d8d1555 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -1,4 +1,4 @@ -/* linux/arch/arm/mach-exynos4/platsmp.c +/* linux/arch/arm/mach-exynos/platsmp.c * * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. *http://www.samsung.com Shouldn't you just remove it entirely? I had the same file names in the whole microblaze tree and some months/years later this was just broken everywhere. That's why it is just easier to remove it entirely. Thanks for review and suggestion. Removing of file name makes more sense to me also. Will take care of this in some other files also under mach-exynos in next version of patch. Thanks, Michal -- Best Regards, Pankaj Dubey -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message
Pankaj Dubey wrote: Hi Michal, On 04/02/2014 09:01 PM, Michal Simek wrote: On 04/02/2014 09:50 AM, Pankaj Dubey wrote: This patch corrects file path mentioned in file comment message. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/platsmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach- exynos/platsmp.c index 03e5e9f..d8d1555 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -1,4 +1,4 @@ -/* linux/arch/arm/mach-exynos4/platsmp.c +/* linux/arch/arm/mach-exynos/platsmp.c * * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. * http://www.samsung.com Shouldn't you just remove it entirely? I had the same file names in the whole microblaze tree and some months/years later this was just broken everywhere. That's why it is just easier to remove it entirely. Thanks for review and suggestion. Removing of file name makes more sense to me also. Will take care of this in some other files also under mach-exynos in next version of patch. No, basically don't need it. And Sachin/Tushar have posted it before, I didn't agree at that time though. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html