Re: Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
Hi Sylwester,
On Sat, Jul 7, 2012 at 12:20 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Hi Shaik,
On 07/06/2012 02:45 PM, Shaik Ameer Basha wrote:
Adding all 4 gscalar devices from DT device list in machine file.
nit: s/gscalar/gscaler
The above sentence doesn't quite parse though.
OK. I will fix it.
Signed-off-by: Abhilash Kesavana.kesa...@samsung.com
Signed-off-by: Leela Krishna Amudalal.kris...@samsung.com
Signed-off-by: Shaik Ameer Bashashaik.am...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 31
+++
arch/arm/mach-exynos/mach-exynos5-dt.c |8
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = samsung,exynos5250;
interrupt-parent =gic;
+ aliases {
+ gsc0 =gsc_0;
+ gsc1 =gsc_1;
+ gsc2 =gsc_2;
+ gsc3 =gsc_3;
+ };
+
What are these aliases useful for ?
GScaler driver uses the of_alias_get_id() call to retrieve the device IDs,
which
internally uses these aliases...
Also I think all DT related patches should be posted to
devicetree-disc...@lists.ozlabs.org as well.
I will post the v2 version of this patch to the specified mailing list.
gic:interrupt-controller@10481000 {
compatible = arm,cortex-a9-gic;
#interrupt-cells =3;
@@ -424,4 +431,28 @@
#gpio-cells =4;
};
};
+
+ gsc_0: gsc@0x13e0 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e0 0x1000;
+ interrupts =0 85 0;
+ };
+
+ gsc_1: gsc@0x13e1 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e1 0x1000;
+ interrupts =0 86 0;
+ };
+
+ gsc_2: gsc@0x13e2 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e2 0x1000;
+ interrupts =0 87 0;
+ };
+
+ gsc_3: gsc@0x13e3 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e3 0x1000;
+ interrupts =0 88 0;
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata
exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA0, dma-pl330.0,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA1, dma-pl330.1,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_MDMA1, dma-pl330.2,
NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E0,
+ exynos-gsc.0, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E1,
+ exynos-gsc.1, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E2,
+ exynos-gsc.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E3,
+ exynos-gsc.3, NULL),
It's probably better to add relevant entry at
arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
/* x = 0...3 */
#define EXYNOS5_PA_GSC(x) (0x13e0 + ((x) * 0x1))
And use it here instead of plain numbers.
OK. will address these comments in v2.
--
Thanks,
Sylwester
Regards,
Shaik Ameer
BashaN‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±±©¬ºx,¡È§¶›¡Ü¨}©ž²Æ zÚj:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~††Ûiÿûàz¹ ®w¥¢¸?™¨èÚ¢)ߢf
Re: Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
Hi Sachin,
On Sat, Jul 7, 2012 at 11:58 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Shaik,
On 6 July 2012 18:15, Shaik Ameer Basha shaik.am...@samsung.com wrote:
Adding all 4 gscalar devices from DT device list in machine file.
Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 31
+++
arch/arm/mach-exynos/mach-exynos5-dt.c |8
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = samsung,exynos5250;
interrupt-parent = gic;
+ aliases {
+ gsc0 = gsc_0;
+ gsc1 = gsc_1;
+ gsc2 = gsc_2;
+ gsc3 = gsc_3;
+ };
+
gic:interrupt-controller@10481000 {
compatible = arm,cortex-a9-gic;
#interrupt-cells = 3;
@@ -424,4 +431,28 @@
#gpio-cells = 4;
};
};
+
+ gsc_0: gsc@0x13e0 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e0 0x1000;
+ interrupts = 0 85 0;
+ };
+
+ gsc_1: gsc@0x13e1 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e1 0x1000;
+ interrupts = 0 86 0;
+ };
+
+ gsc_2: gsc@0x13e2 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e2 0x1000;
+ interrupts = 0 87 0;
+ };
+
+ gsc_3: gsc@0x13e3 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e3 0x1000;
+ interrupts = 0 88 0;
+ };
};
Please also update the documentaion for these bindings.
Ok. I will update the documentation in the v2 release for this patch.
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata
exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA0, dma-pl330.0,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA1, dma-pl330.1,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_MDMA1, dma-pl330.2,
NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E0,
+ exynos-gsc.0, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E1,
+ exynos-gsc.1, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E2,
+ exynos-gsc.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E3,
+ exynos-gsc.3, NULL),
{},
};
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe
linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
---
Regards,
Shaik Ameer Basha
Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
Hi Shaik,
On 07/11/2012 03:06 PM, AMEER BASHA SHAIK wrote:
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = samsung,exynos5250;
interrupt-parent =gic;
+ aliases {
+ gsc0 =gsc_0;
+ gsc1 =gsc_1;
+ gsc2 =gsc_2;
+ gsc3 =gsc_3;
+ };
+
What are these aliases useful for ?
GScaler driver uses the of_alias_get_id() call to retrieve the device IDs,
which
internally uses these aliases...
Yeah, just figured it out already... I didn't know then it was a preferred
way to represent device IDs in DT. I looked at the driver's code and it
seemed slightly incorrect to me. Let me comment on the relevant patch shortly.
Would be good to have things like this documented in the GScaler bindings
documentation. These aliases seem quite essential for the driver to work.
Also I think all DT related patches should be posted to
devicetree-disc...@lists.ozlabs.org as well.
I will post the v2 version of this patch to the specified mailing list.
gic:interrupt-controller@10481000 {
compatible = arm,cortex-a9-gic;
#interrupt-cells =3;
@@ -424,4 +431,28 @@
#gpio-cells =4;
};
};
+
+ gsc_0: gsc@0x13e0 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e0 0x1000;
+ interrupts =0 85 0;
+ };
+
+ gsc_1: gsc@0x13e1 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e1 0x1000;
+ interrupts =0 86 0;
+ };
+
+ gsc_2: gsc@0x13e2 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e2 0x1000;
+ interrupts =0 87 0;
+ };
+
+ gsc_3: gsc@0x13e3 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e3 0x1000;
+ interrupts =0 88 0;
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata
exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA0, dma-pl330.0,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA1, dma-pl330.1,
NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_MDMA1, dma-pl330.2,
NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E0,
+ exynos-gsc.0, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E1,
+ exynos-gsc.1, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E2,
+ exynos-gsc.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E3,
+ exynos-gsc.3, NULL),
It's probably better to add relevant entry at
arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
/* x = 0...3 */
#define EXYNOS5_PA_GSC(x) (0x13e0 + ((x) * 0x1))
And use it here instead of plain numbers.
OK. will address these comments in v2.
Thanks.
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
Hi Shaik,
On 6 July 2012 18:15, Shaik Ameer Basha shaik.am...@samsung.com wrote:
Adding all 4 gscalar devices from DT device list in machine file.
Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 31 +++
arch/arm/mach-exynos/mach-exynos5-dt.c |8
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = samsung,exynos5250;
interrupt-parent = gic;
+ aliases {
+ gsc0 = gsc_0;
+ gsc1 = gsc_1;
+ gsc2 = gsc_2;
+ gsc3 = gsc_3;
+ };
+
gic:interrupt-controller@10481000 {
compatible = arm,cortex-a9-gic;
#interrupt-cells = 3;
@@ -424,4 +431,28 @@
#gpio-cells = 4;
};
};
+
+ gsc_0: gsc@0x13e0 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e0 0x1000;
+ interrupts = 0 85 0;
+ };
+
+ gsc_1: gsc@0x13e1 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e1 0x1000;
+ interrupts = 0 86 0;
+ };
+
+ gsc_2: gsc@0x13e2 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e2 0x1000;
+ interrupts = 0 87 0;
+ };
+
+ gsc_3: gsc@0x13e3 {
+ compatible = samsung,exynos-gsc;
+ reg = 0x13e3 0x1000;
+ interrupts = 0 88 0;
+ };
};
Please also update the documentaion for these bindings.
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata
exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA0, dma-pl330.0, NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA1, dma-pl330.1, NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_MDMA1, dma-pl330.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E0,
+ exynos-gsc.0, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E1,
+ exynos-gsc.1, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E2,
+ exynos-gsc.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E3,
+ exynos-gsc.3, NULL),
{},
};
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT
Hi Shaik,
On 07/06/2012 02:45 PM, Shaik Ameer Basha wrote:
Adding all 4 gscalar devices from DT device list in machine file.
nit: s/gscalar/gscaler
The above sentence doesn't quite parse though.
Signed-off-by: Abhilash Kesavana.kesa...@samsung.com
Signed-off-by: Leela Krishna Amudalal.kris...@samsung.com
Signed-off-by: Shaik Ameer Bashashaik.am...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 31 +++
arch/arm/mach-exynos/mach-exynos5-dt.c |8
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..b945c00 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,6 +23,13 @@
compatible = samsung,exynos5250;
interrupt-parent =gic;
+ aliases {
+ gsc0 =gsc_0;
+ gsc1 =gsc_1;
+ gsc2 =gsc_2;
+ gsc3 =gsc_3;
+ };
+
What are these aliases useful for ?
Also I think all DT related patches should be posted to
devicetree-disc...@lists.ozlabs.org as well.
gic:interrupt-controller@10481000 {
compatible = arm,cortex-a9-gic;
#interrupt-cells =3;
@@ -424,4 +431,28 @@
#gpio-cells =4;
};
};
+
+ gsc_0: gsc@0x13e0 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e0 0x1000;
+ interrupts =0 85 0;
+ };
+
+ gsc_1: gsc@0x13e1 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e1 0x1000;
+ interrupts =0 86 0;
+ };
+
+ gsc_2: gsc@0x13e2 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e2 0x1000;
+ interrupts =0 87 0;
+ };
+
+ gsc_3: gsc@0x13e3 {
+ compatible = samsung,exynos-gsc;
+ reg =0x13e3 0x1000;
+ interrupts =0 88 0;
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..76b081c 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,14 @@ static const struct of_dev_auxdata
exynos5250_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA0, dma-pl330.0, NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_PDMA1, dma-pl330.1, NULL),
OF_DEV_AUXDATA(arm,pl330, EXYNOS5_PA_MDMA1, dma-pl330.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E0,
+ exynos-gsc.0, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E1,
+ exynos-gsc.1, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E2,
+ exynos-gsc.2, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-gsc, 0x13E3,
+ exynos-gsc.3, NULL),
It's probably better to add relevant entry at
arch/arm/mach-exynos/include/mach/map. It's just a one line, e.g.
/* x = 0...3 */
#define EXYNOS5_PA_GSC(x) (0x13e0 + ((x) * 0x1))
And use it here instead of plain numbers.
--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
