Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-19 Thread James Bottomley
On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote: On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the grounds that you never fill it in unless CONFIG_COMPAT is defined)? At least the standard file_operations

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-19 Thread Andi Kleen
On Wed, Jan 19, 2005 at 07:55:01AM -0800, James Bottomley wrote: On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote: On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the grounds that you never fill it in unless

[PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Christoph Hellwig
I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. If you want these attributes talk to Greg about fiding a place in the common driver model code for them. p.s. I

RE: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread James . Smart
True. The only thing that made them FC-ish is that they were mandated by HBAAPI. The only other desire was to place all hbaapi-related data in a single place so users/applications don't have to trapse through the multiple directories in the class and device trees. I'll ping Greg on adding them

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then put them in the individual driver (not

RE: [PATCH] Add compat_ioctl to mptctl

2005-01-19 Thread Moore, Eric Dean
On Tuesday, January 18, 2005 4:22 AM, Andi Kleen wrote: Convert mptctl driver to new compat_ioctl entry point. Only compile tested. Signed-off-by: Andi Kleen [EMAIL PROTECTED] This doesn't compile. Andi - Pls fix, resend, and I will test. Three issues are: (1) incompatible number of

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Brian King
Greg KH wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then put them in the individual

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 12:38:31PM -0600, Brian King wrote: Greg KH wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to

Re: Fwd: Multi tape problems with cpio

2005-01-19 Thread Kai Makisara
On Tue, 18 Jan 2005, Tape Help wrote: Ok, I have the debug info, with comments where needed. Thanks alot! ... # find home -depth|cpio -o --format=newc --block-size=128 -F /dev/st0 14:24:48 kernel: st0: Block limits 1 - 16777215 bytes. 14:24:48 kernel: st0: Mode sense. Length 11, medium 0,

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Mike Anderson
Greg KH [EMAIL PROTECTED] wrote: On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote: I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. Then

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Greg KH
On Wed, Jan 19, 2005 at 11:03:50PM +, Christoph Hellwig wrote: On Wed, Jan 19, 2005 at 02:40:16PM -0800, Greg KH wrote: I had a patch to do that around here somewhere, but I think it was rejected as people can get the same info by using 'modinfo' instead. You know, the old, use a

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Matt Domsch
On Wed, Jan 19, 2005 at 03:42:19PM -0800, Greg KH wrote: Here it was against 2.6.9. Odds are it doesn't apply anymore due to some recent changes in this area. If anyone wants to take it and fix it up, please do so. Note, this patch needs the evil strdup() function to work properly. That's