Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Douglas Gilbert
Jeff Garzik wrote: > Does the attached look OK to everybody? > Jeff, Yes. And after an exchange with Jens, it would probably be safer to map transfer_length=0 for READ_10 and READ_16 (as well as WRITE_10 and WRITE_16) to a nop on the ATA side. Otherwise an ATA disk may attempt to transfer 2**16

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Jeff Garzik
Douglas Gilbert wrote: Jeff Garzik wrote: @@ -1093,28 +1189,54 @@ unsigned int buflen) { u8 *scsicmd = args->cmd->cmnd, *p, *last; -unsigned int page_control, six_byte, output_len; +const u8 sat_blk_desc[] = {0, 0, 0, 0, 0, 0, 0x2, 0x0}; +/* 512 byte blocks, num

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Jeff Garzik
Does the attached look OK to everybody? Jeff diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c --- a/drivers/scsi/libata-scsi.c +++ b/drivers/scsi/libata-scsi.c @@ -581,6 +581,12 @@ static unsigned int ata_scsi_rw_xlat(str if (scsicmd[0] == READ_6 || scsicm

Re: [PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling.

2005-08-26 Thread James Bottomley
On Fri, 2005-08-26 at 19:08 -0700, Andrew Vasquez wrote: > WRT_REG_DWORD(®->ctrl_status, > CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES); > - RD_REG_DWORD(®->ctrl_status); > + /* > + * It is necessary to delay here since t

Re: [PATCH 6/7] [PATCH] sg.c: fix a memory leak in devices seq_file implementation (2nd)

2005-08-26 Thread James Bottomley
On Fri, 2005-08-26 at 12:18 -0700, Chris Wright wrote: > plain text document attachment (fix-memory-leak-in-sg.c- > seq_file.patch) > -stable review patch. If anyone has any objections, please let us know. Looks fine to me. James - To unsubscribe from this list: send the line "unsubscribe lin

[PATCH 16/16] qla2xxx: Update version number to 8.01.00-k.

2005-08-26 Thread Andrew Vasquez
Update version number to 8.01.00-k. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) 9fdabc46aa84637af6518661786d624da60830c5 diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla

[PATCH 15/16] qla2xxx: Stop firmware execution at unintialization time.

2005-08-26 Thread Andrew Vasquez
Stop firmware execution at unintialization time. On ISP24xx parts, stop execution of firmware during ISP tear-down. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_gbl.h |3 +++ drivers/scsi/qla2xxx/qla_mbx.c | 30 +++

[PATCH 14/16] qla2xxx: Replace schedule_timeout().

2005-08-26 Thread Andrew Vasquez
Replace schedule_timeout(). From: Nishanth Aravamudan <[EMAIL PROTECTED]> Date: 1125377408 -0700 Replace schedule_timeout() with msleep()/msleep_interruptible() as appropriate, to guarantee the task delays as expected. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED

[PATCH 13/16] qla2xxx: Remove bad call to fc_remove_host() during probe failure.

2005-08-26 Thread Andrew Vasquez
Remove bad call to fc_remove_host() during probe failure. fc_remove_host() should only be called after a scsi_host has been successfully added via scsi_add_host() -- any failures while qla2xxx probing would result in an incorrect call to fc_remove_host() during cleanup. Signed-off-by: Andrew Vasq

[PATCH 12/16] qla2xxx: Generalize WWN to u64 interger conversions.

2005-08-26 Thread Andrew Vasquez
Generalize WWN to u64 interger conversions. On some platforms the hard-casting of the 8 byte node_name and port_name arrays to an u64 would cause unaligned-access warnings. Generalize the conversions with consistent shifting of WWN bytes. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- d

[PATCH 10/16] qla2xxx: Add change_queue_depth/type() API support.

2005-08-26 Thread Andrew Vasquez
Add change_queue_depth/type() API support. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_os.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) c61d82773aa6675dd6e8553f5aee97a743948689 diff --git a/drivers/scsi/qla2xxx/qla_o

[PATCH 11/16] qla2xxx: Add host attributes.

2005-08-26 Thread Andrew Vasquez
Add host attributes. Export additional host information vi the shost_attrs member in the scsi_host template. Attributes include: driver version, firmware version, ISP serial number, ISP type, ISP product ID, HBA model name, HBA model description, PCI interconnect information, and HBA port state.

[PATCH 9/16] qla2xxx: Remove redundant call to pci_unmap_sg().

2005-08-26 Thread Andrew Vasquez
Remove redundant call to pci_unmap_sg(). In a corner-case failure where the request-q does not contain enough entries for a given request, pci_unmap_sg() would be called twice. Remove direct call and let the failure-path logic handle the unmapping. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED

[PATCH 8/16] qla2xxx: Remove RISC pause/release barriers during flash manipulation.

2005-08-26 Thread Andrew Vasquez
Remove RISC pause/release barriers during flash manipulation. Remove unnecessary RISC pause/release barriers during ISP24xx flash manipulation. The ISP24xx can arbitrate flash access requests during RISC executions. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla

[PATCH 7/16] qla2xxx: Correct LED scheme definition.

2005-08-26 Thread Andrew Vasquez
Correct LED scheme definition. Original implementation used an overloaded bit in the EFI parameters. The correct bit is BIT_4 of the special_options section of NVRAM. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_def.h |4 ++-- drivers/scsi/qla2xxx/qla_ini

[PATCH 4/16] qla2xxx: Add FDMI support.

2005-08-26 Thread Andrew Vasquez
Add FDMI support. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_dbg.h |7 drivers/scsi/qla2xxx/qla_def.h | 151 ++ drivers/scsi/qla2xxx/qla_gbl.h |4 drivers/scsi/qla2xxx/qla_gs.c | 564 +++ drivers/scs

[PATCH 6/16] qla2xxx: Simplify redundant target/device reset logic.

2005-08-26 Thread Andrew Vasquez
Simplify redundant target/device reset logic. Remove redundant qla2x00_target_reset() function in favour of the equivalent qla2x00_device_reset(). Update callers of old function. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_gbl.h |3 -- drivers/scsi/qla2xx

[PATCH 5/16] qla2xxx: Correct domain/area exclusion logic.

2005-08-26 Thread Andrew Vasquez
Correct domain/area exclusion logic. In an FL topology, limit port recognition to those devices not within the same area and domain of the ISP. The firmware will recogonize such devices during local-loop discovery. Some devices may respond to a PLOGI before they have completed their fabric login

[PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling.

2005-08-26 Thread Andrew Vasquez
Correct ISP24xx soft-reset handling. A driver must wait 100us before attempting an MMIO operation to the RISC after a soft-reset has been initiated. A similar delay was needed with earlier ISPs. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_dbg.c | 10 ++

[PATCH 2/16] qla2xxx: Export class-of-service (COS) information.

2005-08-26 Thread Andrew Vasquez
Export class-of-service (COS) information. Export COS information for the fc_host and fc_remote_port objects added by the driver. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_attr.c |4 drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla

[PATCH 1/16] qla2xxx: Use dma_get_required_mask() in determining the 'ideal' DMA mask.

2005-08-26 Thread Andrew Vasquez
Use dma_get_required_mask() in determining the 'ideal' DMA mask. In order to efficiently utilise the ISP's IOCB request-queue, use the dma_get_required_mask() function to determine the use of command-type 2 or 3 IOCBs when queueing SCSI commands. This applies to ISP2[123]xx chips only, as the ISP

[PATCH 0/16] qla2xxx: update qla2xxx driver to 8.01.00.

2005-08-26 Thread Andrew Vasquez
James, Here's a set of patches which fix a handful of outstanding issues with the qla2xxx driver. Please apply. Summary of patches: Use dma_get_required_mask() in determining the 'ideal' DMA mask. Export class-of-service (COS) information. Correct ISP24xx soft-reset handling. Add FDMI s

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Jeff Garzik
Luben Tuikov wrote: On 08/26/05 15:24, Jeff Garzik wrote: Luben Tuikov wrote: Even simpler: the transport layer, calls SCSI Core, saying: "Hey here is a pointer to struct scsi_domain_device. If you want, you an send REPORT LUNS and other things to it." For the SG_IO ioctl, /dev/sg and re

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Jeff Garzik
Luben Tuikov wrote: On 08/26/05 14:48, Jeff Garzik wrote: No host numbers, no routing information. This is all transparent to SCSI Core, and NONE of its business. Routing is an essential part of the SCSI core's duties. [I'm not a big fan of reading mixed-message emails, but what can you d

Re: regression w/ qla2300 - oopses..

2005-08-26 Thread Andrew Vasquez
On Fri, 26 Aug 2005, James Bottomley wrote: > On Fri, 2005-08-26 at 14:52 -0700, Andrew Morton wrote: > > Is there not some nasty little hack we can do to make the crash go away in > > the interim? > > Well, it's nasty. The problem is that klist_next() refers to the > previous element to get the

Adaptec DPT call schedule_timeout with irq off

2005-08-26 Thread Dave Jiang
I noticed that in the Adaptec DPT driver, drivers/scsi/dpt_i2o.c in funciton adapt_i2o_post_wait() around line 1161ish. spin_lock_irqsave() is called. However then spin_unlock() is called 2 lines later and leaving IRQ disabled. Then a little bit later, schedule_timeout() is called with IRQ off.

RE: [PATCH 0/2] fusion SAS support

2005-08-26 Thread Moore, Eric Dean
On Wednesday, August 24, 2005 3:14 AM, Christoph Hellwig wrote: > On Wed, Aug 24, 2005 at 02:10:14AM -0700, Jeremy Higdon wrote: > > However, after updating firmware on the 1064, this latter problem > > seems to be fixed (still doesn't discover devices on the expander > > at driver init). > > As m

Re: regression w/ qla2300 - oopses..

2005-08-26 Thread Andrew Morton
James Bottomley <[EMAIL PROTECTED]> wrote: > > This is known and fixed here: > > http://marc.theaimsgroup.com/?l=linux-scsi&m=112485448830217 > > Andrew and Greg, could we look at actually getting this fix in too, > please? yowch, that's fairly non-trivial.And Greg didn't comment. Is the

Re: Oops on scsi_remove_target

2005-08-26 Thread Andrew Morton
James Bottomley <[EMAIL PROTECTED]> wrote: > > > [] die+0xfa/0x19c > > [] do_page_fault+0x239/0x6ee > > [] error_code+0x4f/0x54 > > [] sysfs_remove_link+0x1b/0x1d > > [] class_device_del+0x8e/0xed > > This is known and reported and the fix is here: > > http://marc.theaimsgroup.com/?l=li

Re: regression w/ qla2300 - oopses..

2005-08-26 Thread James Bottomley
On Sat, 2005-08-27 at 00:29 +0300, Matti Aarnio wrote: > Well, not in normal operation, but when I do "rmmod qla2300", > I do get most impressive oops backtrace. (With Amd64 machine.) [...] > Aug 26 10:40:14 sisakko kernel: general protection fault: [1] SMP > Aug 26 10:40:14 sisakko kernel:

Re: Oops on scsi_remove_target

2005-08-26 Thread James Bottomley
On Fri, 2005-08-26 at 16:14 -0500, Stephen Lord wrote: > Oops: [#1] > SMP > Modules linked in: sg qla2300 qla2xxx scsi_transport_fc aic7xxx > scsi_transport_spi sd_mod scsi_mod > CPU:2 > EIP:0060:[]Not tainted VLI > EFLAGS: 00010282 (2.6.12-kdb) > EIP is at sysfs_hash_and_remove

Re: Oops on scsi_remove_target

2005-08-26 Thread Andrew Vasquez
On Fri, 26 Aug 2005, Stephen Lord wrote: > Running 2.6.12 (or one of several descendents of it), someone just let > loose a new device on our fabric, it is causing one of our hosts no > end of grief: > > scsi: unknown device type 12 > Vendor: ADIC Model: SNC Rev: 42dF > Typ

Re: [RFC] SCSI EH document

2005-08-26 Thread Jeff Garzik
Tejun Heo wrote: Hello, fellow SCSI/ATA developers. This is the first draft of SCSI EH document. This document tries to describe how SCSI EH works and what choirs should be done to maintain SCSI midlayer integrity. It's intended that this document can be used as reference for implementing ei

regression w/ qla2300 - oopses..

2005-08-26 Thread Matti Aarnio
Well, not in normal operation, but when I do "rmmod qla2300", I do get most impressive oops backtrace. (With Amd64 machine.) This oops does happen with lattest Fedora Core Development kernel (as of yesterday) which is up to Linus 2.6.13-rc7. This crash didn't happen with vmlinuz-2.6.11-1.122

Oops on scsi_remove_target

2005-08-26 Thread Stephen Lord
Running 2.6.12 (or one of several descendents of it), someone just let loose a new device on our fabric, it is causing one of our hosts no end of grief: scsi: unknown device type 12 Vendor: ADIC Model: SNC Rev: 42dF Type: RAID ANSI SCSI revi

Re: fibre channel/multipath questions

2005-08-26 Thread Stefan Richter
Rik Bobbaers wrote: 2. Is it possible to make the fibrechannel driver get loaded AFTER the others? (Our kernels have no modules support, so i built it all in the kernel for security reasons etc...) The reason is very simple. If I have 1 disk on ESS, it now becomes /dev/sda on scsi0, /dev/sdb on

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Luben Tuikov
On 08/26/05 15:24, Jeff Garzik wrote: > Luben Tuikov wrote: > >>Even simpler: the transport layer, calls SCSI Core, saying: "Hey here is >>a pointer to struct scsi_domain_device. If you want, you an send REPORT >>LUNS and other things to it." > > > For the SG_IO ioctl, /dev/sg and request_queue

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Luben Tuikov
On 08/26/05 14:48, Jeff Garzik wrote: >>No host numbers, no routing information. This is all >>transparent to SCSI Core, and NONE of its business. > > Routing is an essential part of the SCSI core's duties. [I'm not a big fan of reading mixed-message emails, but what can you do...] > The SCSI

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Jeff Garzik
Luben Tuikov wrote: Even simpler: the transport layer, calls SCSI Core, saying: "Hey here is a pointer to struct scsi_domain_device. If you want, you an send REPORT LUNS and other things to it." For the SG_IO ioctl, /dev/sg and request_queue usage, SCSI core must map an address (currently HCI

[PATCH 6/7] [PATCH] sg.c: fix a memory leak in devices seq_file implementation (2nd)

2005-08-26 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. -- I know that scsi procfs is legacy code but this is a fix for a memory leak. While reading through sg.c I realized that the implementation of /proc/scsi/sg/devices with seq_file is leaking memory due to fr

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Jeff Garzik
Luben Tuikov wrote: On 08/26/05 13:22, James Bottomley wrote: On Fri, 2005-08-26 at 12:43 -0400, Luben Tuikov wrote: A move away from forced HCIL addressing would be a good thing. However, its impossible to completely move away from addressing, as userspace and the SCSI core need ways to r

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Luben Tuikov
On 08/26/05 13:22, James Bottomley wrote: > On Fri, 2005-08-26 at 12:43 -0400, Luben Tuikov wrote: > >>>A move away from forced HCIL addressing would be a good thing. >>> >>>However, its impossible to completely move away from addressing, as >>>userspace and the SCSI core need ways to route CDBs

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread James Bottomley
On Fri, 2005-08-26 at 12:43 -0400, Luben Tuikov wrote: > > A move away from forced HCIL addressing would be a good thing. > > > > However, its impossible to completely move away from addressing, as > > userspace and the SCSI core need ways to route CDBs to devices based on > > address. > > They

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Luben Tuikov
On 08/25/05 16:06, Jeff Garzik wrote: > Stefan Richter wrote: > >>Luben Tuikov wanted... >> >> >>>to move _away_ from HCIL. So that addressing of devices in SCSI Core >>>is _completely_ independent of addressing at the protocol layer. >> >> >>I second that. > > > > A move away from forced HCIL

Re: Process in D state with st driver

2005-08-26 Thread Kai Makisara
On Wed, 24 Aug 2005, Hans-Joachim Baader wrote: > Hi, > > > This kind of a problem of a process using a tape hanging in D state has > > occurred sometimes for numerous years. When the user has waited long > > enough (the default timeouts are lng), the process has continued. When > > st has

Re: Fw: [Bugme-new] [Bug 5117] New: Panic when accessing scsi-tapedrives with 4G-remap

2005-08-26 Thread Kai Makisara
On Thu, 25 Aug 2005, Andrew Morton wrote: > > > Begin forwarded message: > > Date: Tue, 23 Aug 2005 12:53:38 -0700 > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: [Bugme-new] [Bug 5117] New: Panic when accessing scsi-tapedrives > with 4G-remap > > > http://bugzilla.kernel.org/s

Re: SAS Management Protocol (SMP)

2005-08-26 Thread Luben Tuikov
On 08/24/05 08:46, Douglas Gilbert wrote: > > Well lets talk about SMP for a bit. We need to > be able to use this protocol for more complex SAS > topologies. Monitoring simple SAS topologies with > only one expander would be aided by using SMP. > > Like many management protocols, SMP violates >

scsi device driver

2005-08-26 Thread Yijian Wang
Hello,all, I am going to develop a program that can dynamically capture all the SCSI disk I/O traffic generated by user applications in the system. Is there any API library that can help me do this? I am very new to this area. Any helps are highly appreciated. Thanks, Yijian Wang - To unsub

fibre channel/multipath questions

2005-08-26 Thread Rik Bobbaers
Hey guys, Let me introduce myself. I'm Rik Bobbaers, working at the KULeuven (university in belgium) I'm a linux sysadmin, followed a linux kernel internals course and a device drivers course. I have some machines that i want to connect to a SAN, which also has an IBM/ESS (shark) connection. Th

Re: [PATCH] minimal SAS transport class

2005-08-26 Thread Luben Tuikov
On 08/24/05 05:12, Christoph Hellwig wrote: > On Tue, Aug 23, 2005 at 08:02:39PM -0400, Luben Tuikov wrote: > >>In effect FC tells SCSI Core: here is a device I do not know anything >>about, other than the fact that it is on the fabric and it has >>a SCSI Target (or Initiator) Port: how you get to

RE: SCSI_OWNER_LOWLEVEL, scsicmd->owner & scsicmd->state visibility in the LLD

2005-08-26 Thread Salyzyn, Mark
Answer was not forthcoming regarding deprecation of scsicmd->owner and scsicmd->state, thus no API to determine if the command is currently owned by the low level driver. Need to move this functionality into the driver, so can I count on scsicmd->SCp.phase sticking around? For example: static int