Aboo Valappil wrote:
I actually uses the openers field in scsi_disk to find out if anyone
has the scsi_device open or not.
There are several issues with this approach.
- It will fail eventually because some day there may be other users of
a LU than sd. How would sg, sr, st be accommodated?
On Sat, Jan 20 2007, FUJITA Tomonori wrote:
This enables bsg to resize the queue depth via
SG_SET_COMMAND_Q. bsg_command structures are allocated via mempool
because the previous way to use contiguous memory makes it difficult
to resize the queue depth when a bsg_device has outstanding
seagate_st0x_detect() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This patch was already sent on:
- 6 Jan 2007
--- linux-2.6.20-rc3-mm1/drivers/scsi/seagate.c.old 2007-01-05
22:53:13.0 +0100
+++ linux-2.6.20-rc3-mm1/drivers/scsi/seagate.c 2007-01-05
Using assembler code for performance in drivers might have been a good
idea 15 years ago when this code was written, but with today's compilers
that's unlikely to be an advantage.
Besides this, it also hurts the readability.
Simply use the C code that was already there as an alternative.
The SCSI_ACORNSCSI_3 driver:
- has been marked as BROKEN for more than one year and
- is still marked as BROKEN.
Drivers that had been marked as BROKEN for such a long time seem to be
unlikely to be revived in the forseeable future.
But if anyone wants to ever revive this driver, the code is
- Instantiate another request_io_part in request for bidi_read.
- Define Implement new API for accessing bidi parts.
- API to Build bidi requests and map to sglists.
- Define new end_that_request_block() function to end a complete request.
Signed-off-by: Benny Halevy [EMAIL PROTECTED]
- Add bidi members to struct scsi_cmnd.
- Add API at the SCSI level for bidirectional commands.
- Implement support for BIDI requests in scsi_setup_blk_pc_cmnd() and
scsi_io_completion().
Signed-off-by: Benny Halevy [EMAIL PROTECTED]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
- Add support for varlen CDBs or large vendor specific commands in
struct request.
- Add support for above at SCSI level API's and devices.
- Add the OSD device type.
Signed-off-by: Benny Halevy [EMAIL PROTECTED]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
block/ll_rw_blk.c |
This patch is intended to provide a working example of a use case
for bidi and varlen CDBs. The actual patches will be sent via the
open-iscsi project.
- Use proposed SCSI implementation for iSCSI bidirectional commands.
- Use proposed block layer implementation for iSCSI extended CDBs.
-
Hi Stefan,
I understand, using the scsi_disk is really ugrly, Infact I knew it before.
There are no options without patching the kernel SCSI sub system? From your
last email, you explained such an approach. I really do not want to write a
patch. I wanted to impliment this in existing SCSI
Hi Stefan Richter,
Can I use the following method safely to know if a scsi_device is open or not?
if ( atomic_read(sdev-sdev_gendev.kobj.kref.refcount) 14 ) {
//sdev is in use
}
As soon as the scsi_device is created and after it passed through the 'sd'
driver, it has got 14 references
Boaz Harrosh wrote:
- Introduce a new enum dma_data_direction data_dir member in struct request.
and remove the RW bit from request-cmd_flag
- Add new API to query request direction.
- Adjust existing API and implementation.
- Cleanup wrong use of DMA_BIDIRECTIONAL
- Introduce new
On Sun, 21 Jan 2007 03:14:33 +0100 Bauke Jan Douma wrote:
OnStream Di30 (using ide-scsi and osst drivers), when reading
or writing I regularly get these kernel messages:
3ide-scsi: CoD != 0 in idescsi_pc_intr
Let's assume flaky hardware; nothing we can hold the kernel to
blame for (which
Following are 6 (large) patches that introduce support
for bidirectional requests in the kernel.
Since all this is going to interfere with everyone's
work, let us all comment on the implementation, naming,
and future directions. (or forever hold your peace).
The submitted work is against
On Mon, Jan 22, 2007 at 01:21:28AM +0200, Boaz Harrosh wrote:
- Introduce a new enum dma_data_direction data_dir member in struct request.
and remove the RW bit from request-cmd_flag
Some architecture use 'enum dma_data_direction' and some 'int
dma_data_direction'. The consensus was to move
Douglas Gilbert wrote:
Boaz Harrosh wrote:
- Introduce a new enum dma_data_direction data_dir member in struct request.
and remove the RW bit from request-cmd_flag
- Add new API to query request direction.
- Adjust existing API and implementation.
- Cleanup wrong use of DMA_BIDIRECTIONAL
16 matches
Mail list logo