[PATCH] aic79xx: use dma_get_required_mask()

2007-02-07 Thread Hannes Reinecke
Hi James, this patch corrects the issue originally noted by Frederic Temporelli: aic79xx uses the wrong logic to determine the addressing mode. I've converted the original patch to use the dma_get_required_mask() macros as you requested. Please apply. Cheers, Hannes -- Dr. Hannes Reinecke

Re: aic79xx noise on hot insert in 2.6.19.x and 2.6.20

2007-02-07 Thread Darrick J. Wong
Mark Rustad wrote: I have systems with Supermicro X6-class (Nocona/Lindenhurst) motherboards with Adaptec SCSI and SAFTE backplanes running software RAID-1 (md) on a pair of drives. When I hot-insert a drive, I get a lot of noise from the kernel apparently due to lack of handling something in

Re: [PATCH] scsi: Update Aic94xx SAS/SATA Linux open source devicedriver for new sequence firmware.

2007-02-07 Thread Darrick J. Wong
Wu, Gilbert wrote: Hi James, We are investigating this issue here. We will update the status when we can duplicate the problem here and root cause. FWIW, v17 looks good for both SAS/SATA load testing. The 24-disk x260 seems to have crapped out after about 800 rounds of load/unload due to

Re: aic79xx noise on hot insert in 2.6.19.x and 2.6.20

2007-02-07 Thread Hannes Reinecke
Darrick J. Wong wrote: Mark Rustad wrote: I have systems with Supermicro X6-class (Nocona/Lindenhurst) motherboards with Adaptec SCSI and SAFTE backplanes running software RAID-1 (md) on a pair of drives. When I hot-insert a drive, I get a lot of noise from the kernel apparently due to lack

[PATCH] zfcp: Invalid locking order

2007-02-07 Thread Swen Schillig
From: Swen Schillig [EMAIL PROTECTED] Invalid locking order. Kernel hangs after trying to take two locks which are dependend on each other. Introducing temporary variable to free requests. Free lock after requests are copied. Signed-off-by: Swen Schillig [EMAIL PROTECTED] ---

Emulex HBA Issues

2007-02-07 Thread Chris Knipe
Hi, I have a RedHat 9 system running kernel 2.6.16... The system is attached to 3 x EMC FC4700 DOE's operating as simple JBODs Looking at /proc/scsi/scsi, I can clearly see all the devices are visable (see below) However, each time RedHat boots it assigns a different device to a

[PATCH]indistinguishable devices with broken and unbroken firmware

2007-02-07 Thread Oliver Neukum
Hi, there's a USB mass storage device which exists in two version. One reports the correct size and the other does not. Apart from that they are identical and cannot be told apart. Here's a heuristic based on the empirical finding that drives have even sizes. I know it's ugly, but it fixes an

Re: Emulex HBA Issues

2007-02-07 Thread James Smart
Everything is working, as it should, on a 2.6 kernel. see comments below... Chris Knipe wrote: Hi, I have a RedHat 9 system running kernel 2.6.16... The system is attached to 3 x EMC FC4700 DOE's operating as simple JBODs Looking at /proc/scsi/scsi, I can clearly see all the devices are

Re: [PATCH]indistinguishable devices with broken and unbroken firmware

2007-02-07 Thread Christoph Hellwig
On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote: Hi, there's a USB mass storage device which exists in two version. One reports the correct size and the other does not. Apart from that they are identical and cannot be told apart. Here's a heuristic based on the empirical

Re: [PATCH]indistinguishable devices with broken and unbroken firmware

2007-02-07 Thread Oliver Neukum
Am Mittwoch, 7. Februar 2007 16:05 schrieb Christoph Hellwig: On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote: Hi, there's a USB mass storage device which exists in two version. One reports the correct size and the other does not. Apart from that they are identical and

Re: [PATCH] zfcp: Invalid locking order

2007-02-07 Thread Andreas Herrmann
On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote: From: Swen Schillig [EMAIL PROTECTED] Invalid locking order. Kernel hangs after trying to take two locks which are dependend on each other. Introducing temporary variable to free requests. Free lock after requests are copied.

Re: [PATCH] zfcp: Invalid locking order

2007-02-07 Thread Swen Schillig
Hi Andreas No, not those. We got a possible recursive locking on the adapter-request_queue.queue_lock Cheers Swen On Wednesday 07 February 2007 17:06, Andreas Herrmann wrote: On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote: From: Swen Schillig [EMAIL PROTECTED] Invalid

RE: chip 1000:0055 (LSI1068 PCI-X) Fusion-MPT/MegaRAID

2007-02-07 Thread Bagalkote, Sreenivas
Hello Fred, There's a LSI 1068 chip that can be found on NEC hardware (also Intel/Supermicro/Hitachi, ...) and that can provide RAID 0 and 1 based on a MegaRAID BIOS. Hmm, no. This is not MegaRAID BIOS. - LSI1068 'MegaRAID': pciid 1000:0055 embedded MegaRAID BIOS, providing RAID 0

Re: [PATCH 06/12] sas_ata: Implement SATA PHY control

2007-02-07 Thread Tejun Heo
Darrick J. Wong wrote: This patch requires libsas: Add a sysfs knob to enable/disable a phy to be applied. It hooks the SControl write function to provide basic SATA phy control for phy enable/disable and speed limits. Power management is still broken, though it is unclear that libata actually

Re: [PATCH 04/12] sas_ata: ata_post_internal should abort the sas_task

2007-02-07 Thread Tejun Heo
Darrick J. Wong wrote: This patch adds a new field, lldd_task, to ata_queued_cmd so that libata users such as libsas can associate some data with a qc. The particular ambition with this patch is to associate a sas_task with a qc; that way, if libata decides to timeout a command, we can come

Re: [PATCH 08/12] libsas: Unknown STP devices should be reported to libata as unknown.

2007-02-07 Thread Tejun Heo
Darrick J. Wong wrote: When libsas encounters a STP device whose protocol isn't recognized (i.e. not ATA or ATAPI), we should set the ata_device's class to ATA_DEV_UNKNOWN instead of ATA_DEV_ATA. Signed-off-by: Darrick J. Wong [EMAIL PROTECTED] --- drivers/scsi/libsas/sas_ata.c |2 +- 1

Re: [usb-storage] [PATCH]indistinguishable devices with broken and unbroken firmware

2007-02-07 Thread Alan Stern
On Wed, 7 Feb 2007, Oliver Neukum wrote: --- a/drivers/scsi/sd.c 2007-02-06 14:14:48.0 +0100 +++ b/drivers/scsi/sd.c 2007-02-07 15:14:01.0 +0100 @@ -1273,6 +1273,13 @@ if (sdp-fix_capacity) --sdkp-capacity; + /* Some devices have

Re: [usb-storage] [PATCH]indistinguishable devices with broken and unbroken firmware

2007-02-07 Thread Alan Stern
On Wed, 7 Feb 2007, Oliver Neukum wrote: Am Mittwoch, 7. Februar 2007 16:05 schrieb Christoph Hellwig: On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote: Hi, there's a USB mass storage device which exists in two version. One reports the correct size and the other does

RE: [PATCH] scsi: Update Aic94xx SAS/SATA Linux open source devicedriver for new sequence firmware.

2007-02-07 Thread Wu, Gilbert
Hi Darrick, We can duplicate the problem here. The aic94xx with V28 passed IO testing overnight if we apply IO directly to /dev/sd?. But it fails very quickly when we create a partition and format it as ext3. The V17 sequencer works fine with both cases. We are looking into it and find the root

Re: [PATCH] aic79xx: use dma_get_required_mask()

2007-02-07 Thread James Bottomley
On Wed, 2007-02-07 at 09:47 +0100, Hannes Reinecke wrote: + const uint64_t mask_39bit = 0x7FULL; Actually there's no need for this ... the mask_39bit references can just become DMA_39BIT_MASK constants. I made this cosmetic change to the patch. James - To unsubscribe from this

Re: Random scsi disk disappearing

2007-02-07 Thread Randy Dunlap
[lkml dropped] [old thread] On Fri, 18 Aug 2006 11:11:39 +0200 Andreas Herrmann wrote: On 18.08.2006 00:33 Stefan Richter [EMAIL PROTECTED] wrote: Andreas Herrmann wrote: Anyone interested in a script to conveniently interpret or change the SCSI logging level? Such a script

SCSI logging sucks

2007-02-07 Thread Chuck Ebbert
SCSI logging isn't documented very well, and what little there is has a problem: In Documentation/kernel-parameters.txt we have: scsi_logging= [SCSI] but it's really scsi_logging_level, as seen here in drivers/scsi/scsi.c: module_param(scsi_logging_level, int, S_IRUGO|S_IWUSR);

Re: Writing performance problem with SAS1068

2007-02-07 Thread Bernardo Innocenti
Douglas Gilbert wrote: You may like to check that Write Cache Enable is on with: 'sdparm --get=WCE /dev/sdd'. Yeah, yeah! Works fine once I toggled the WCE to 1. Writing flies at 70MB/s, which is extremely good for those desktop-grade disks (Seagate Barracuda SATA 250GB @7200RPM). Thank you

Re: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set

2007-02-07 Thread Andrew Morton
On Tue, 06 Feb 2007 13:49:24 -0800 Sumant Patro [EMAIL PROTECTED] wrote: + /* Don't process if we have already declared adapter dead */ + if(instance-hw_crit_error) Preferred kernel coding style is if (. [p1-crit_err.patch text/x-patch (1.3KB)] argh. Please don't send two copies

Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-07 Thread Andrew Morton
On Tue, 06 Feb 2007 14:19:54 -0800 Sumant Patro [EMAIL PROTECTED] wrote: Preallocate memory for ioctl processing. This is to avoid situations where ioctl fails for lack of memory (when system under heavy stress). The memory pool will have 8*4K, 4*8K and 1*64K memory chunks mutter. I suspect

Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

2007-02-07 Thread James Bottomley
On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote: I suspect all this horror is due to stupidity in the DMA API. pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy to use GFP_KERNEL. I bet this fixes it

[patch] Re: SCSI logging sucks

2007-02-07 Thread Randy Dunlap
On Wed, 07 Feb 2007 12:06:30 -0500 Chuck Ebbert wrote: SCSI logging isn't documented very well, and what little there is has a problem: In Documentation/kernel-parameters.txt we have: scsi_logging= [SCSI] but it's really scsi_logging_level, as seen here in

Re: [patch] Re: SCSI logging sucks

2007-02-07 Thread Martin K. Petersen
Randy == Randy Dunlap [EMAIL PROTECTED] writes: Randy There are a number of things that can be used for 'token' (you Randy can find them in the source: file:drivers/scsi/scsi.c), and Randy this allows you to select the types of information you want, Randy and the level allows you to select the

Re: Random scsi disk disappearing

2007-02-07 Thread Douglas Gilbert
Randy Dunlap wrote: [lkml dropped] [old thread] On Fri, 18 Aug 2006 11:11:39 +0200 Andreas Herrmann wrote: On 18.08.2006 00:33 Stefan Richter [EMAIL PROTECTED] wrote: Andreas Herrmann wrote: Anyone interested in a script to conveniently interpret or change the SCSI logging level? Such a

Re: Random scsi disk disappearing

2007-02-07 Thread Randy Dunlap
Douglas Gilbert wrote: Randy Dunlap wrote: [lkml dropped] [old thread] On Fri, 18 Aug 2006 11:11:39 +0200 Andreas Herrmann wrote: On 18.08.2006 00:33 Stefan Richter [EMAIL PROTECTED] wrote: Andreas Herrmann wrote: Anyone interested in a script to conveniently interpret or change the SCSI

RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing

2007-02-07 Thread Patro, Sumant
Thanks. I will resubmit the patch. Regards, Sumant -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 07, 2007 2:02 PM To: Andrew Morton Cc: Patro, Sumant; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Kolli, Neela; Yang, Bo; Patro,

RE: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set

2007-02-07 Thread Patro, Sumant
I will correct the formatting and will resubmit. Regards, Sumant -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 07, 2007 1:18 PM To: Patro, Sumant Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Kolli, Neela;

Re: [patch] Re: SCSI logging sucks

2007-02-07 Thread Volker Sameske
There's a very convenient script called scsi_logging_level included in (of all things) the s390-tools package. Maybe provide a pointer to it -- or even just include it. It's not very big... http://www-128.ibm.com/developerworks/linux/linux390/s390-tools-1.5.4.html The