Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Rene Herman wrote: > On 06/20/2007 02:24 PM, Jens Axboe wrote: > > >On Wed, Jun 20 2007, Christoph Hellwig wrote: > >>On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > > >>> drivers/cdrom/aztcd.c > >>> drivers/cdrom/cm206.c > >>> drivers/cdrom/gscd.c > >>> drive

Re: [PATCH] aacraid: add cpu cache flush after kmapping and modifying a page

2007-06-20 Thread Tejun Heo
Salyzyn, Mark wrote: > Updated patch to address overlap with patches introduced by FUJITA > Tomonori <[EMAIL PROTECTED]>. Tejun, please inspect. I'm sorry but this patch is really out of my hand. James? -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Rene Herman
On 06/20/2007 02:24 PM, Jens Axboe wrote: On Wed, Jun 20 2007, Christoph Hellwig wrote: On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: drivers/cdrom/aztcd.c drivers/cdrom/cm206.c drivers/cdrom/gscd.c drivers/cdrom/mcdx.c drivers/cdrom/optcd.c drivers/cdrom/sjcd.c These

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-20 Thread Kristen Carlson Accardi
Enable Aggressive Link Power management for AHCI controllers. This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI

Re: [patch 2b/3] Expose Power Management Policy option to users

2007-06-20 Thread Kristen Carlson Accardi
Enable link power management for ata drivers libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be acti

Re: Very slow writes with mptsas

2007-06-20 Thread Douglas Gilbert
[EMAIL PROTECTED] wrote: > On Tue, 05 Jun 2007, [EMAIL PROTECTED] wrote: > >> Hello >> >> I'm seeing very slow writes on a Dell Precision 690 with the Dell SAS5 >> adapter, serving a RAID1 array of SATA-II disks. >> >> It's very similar to the problem in FreeBSD, described here: >> >> http://unix.

[PATCH] aacraid: add SCSI SYNCHONIZE_CACHE range checking (take 2)

2007-06-20 Thread Salyzyn, Mark
There was some overlap with another patch (?) this one has not shown in scsi-pending-2.6. Modernized to apply cleanly and did some extra cleanup. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachmen

[PATCH] aacraid: add cpu cache flush after kmapping and modifying a page

2007-06-20 Thread Salyzyn, Mark
Updated patch to address overlap with patches introduced by FUJITA Tomonori <[EMAIL PROTECTED]>. Tejun, please inspect. This attached aacraid specific portion of the patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch co

Re: [PATCH] bsg: fix the deadlock on discarding done commands

2007-06-20 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: [PATCH] bsg: fix the deadlock on discarding done commands Date: Fri, 8 Jun 2007 17:20:49 +0200 > On Sat, Jun 09 2007, FUJITA Tomonori wrote: > > I'll submit the bsg bidi patches shortly. > > Great - I see them, will review and integrate next week.

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 02:24:09PM +0200, Jens Axboe wrote: > > These are old cdrom drivers that are broken in various ways and probably > > should be killed off aswell. > > I agree (with both sentiments), would anyone mind if I just killed them > off? mitsumi support is being reworked, that can g

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Christoph Hellwig wrote: > On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > > Jens Axboe wrote: > > > > > > If you look at most of the code, it's inside ifdef debug statements or > > > comments most of them. So I don't think you can base any removal > > > sugges

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote: > Jens Axboe wrote: > > > > If you look at most of the code, it's inside ifdef debug statements or > > comments most of them. So I don't think you can base any removal > > suggestion on that. > > > > The patch itself looks fine though,

Re: [PATCH v2] fix request->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Boaz Harrosh wrote: > > - I have unearthed very old bugs in stale drivers that still >used request->cmd as a READ|WRITE int > - This patch is maybe a proof that these drivers have not been >used for a long time. Should they be removed completely? Applies fine now, t

[PATCH v2] fix request->cmd == INT cases

2007-06-20 Thread Boaz Harrosh
- I have unearthed very old bugs in stale drivers that still used request->cmd as a READ|WRITE int - This patch is maybe a proof that these drivers have not been used for a long time. Should they be removed completely? Drivers that currently do not work for sure: drivers/acorn/block/fd17

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Boaz Harrosh
Jens Axboe wrote: > On Wed, Jun 20 2007, Boaz Harrosh wrote: >> Jens Axboe wrote: >>> If you look at most of the code, it's inside ifdef debug statements or >>> comments most of them. So I don't think you can base any removal >>> suggestion on that. >>> >>> The patch itself looks fine though, if yo

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Jens Axboe
On Wed, Jun 20 2007, Boaz Harrosh wrote: > Jens Axboe wrote: > > > > If you look at most of the code, it's inside ifdef debug statements or > > comments most of them. So I don't think you can base any removal > > suggestion on that. > > > > The patch itself looks fine though, if you send one that

Re: [PATCH] fix req->cmd == INT cases

2007-06-20 Thread Boaz Harrosh
Jens Axboe wrote: > > If you look at most of the code, it's inside ifdef debug statements or > comments most of them. So I don't think you can base any removal > suggestion on that. > > The patch itself looks fine though, if you send one that isn't mangled > I'll apply it to the 2.6.23 branch. >