Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-06 Thread Douglas Gilbert
James Bottomley wrote: > On Thu, 2007-07-05 at 14:06 -0700, Kristen Carlson Accardi wrote: >> Since gendisk will now become part of struct scsi_device, we don't need >> to store this value in any private data structs where they already store >> scsi_device. This series cleans up a few drivers whic

Re: [PATCH] 3w-xxxx: Add tw_sysfs_init() so udev will create /dev/twe* devices.

2007-07-06 Thread Joshua Daniel Franklin
--- adam radford wrote: > I have one problem with this patch: > > You are calling "class_device_create()" from 0 to "TW_MAX_UNITS" > which is 16... > shouldn't you be calling this only once per each controller instance > that is discovered > via twa_probe() ? Well, I was just trying to emulate wh

Re: [PATCH] 3w-xxxx: Add tw_sysfs_init() so udev will create /dev/twe* devices.

2007-07-06 Thread adam radford
On 7/6/07, Joshua Daniel Franklin <[EMAIL PROTECTED]> wrote: Add tw_sysfs_init() to register 3w- driver with sysfs. This also causes udev to create /dev/twe* devices with the correct SELinux security context. Signed-off-by: Joshua Daniel Franklin <[EMAIL PROTECTED]> Thanks for the patch.

[PATCH] 3w-xxxx: Add tw_sysfs_init() so udev will create /dev/twe* devices.

2007-07-06 Thread Joshua Daniel Franklin
Add tw_sysfs_init() to register 3w- driver with sysfs. This also causes udev to create /dev/twe* devices with the correct SELinux security context. Signed-off-by: Joshua Daniel Franklin <[EMAIL PROTECTED]> --- _

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-06 Thread James Bottomley
On Thu, 2007-07-05 at 14:06 -0700, Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. Actually, as Al