Re: [PATCH 1/2] bsg: use lib/idr.c to find a unique minor number

2007-07-23 Thread Jens Axboe
On Mon, Jul 23 2007, FUJITA Tomonori wrote: This replaces the current linear search for a unique minor number with lib/idr.c. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] Awesome, that's a very nice improvement both for code and performance. Acked-by: Jens Axboe [EMAIL PROTECTED] --

[PATCH] Enable 16-bit CDBs for aic7xxx/aic79xxx

2007-07-23 Thread Hannes Reinecke
Hi James, this patch enables 16-bit CDBs for aic7xxx and aic79xx. aic7xxx actuallys supports up to 32-bit CDBs, so it might be that aic79xx does that, too. But this would include some more hacking, so this is way easier. Please apply. Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH] Enable 16-bit CDBs for aic7xxx/aic79xxx

2007-07-23 Thread Hannes Reinecke
Hannes Reinecke wrote: Hi James, this patch enables 16-bit CDBs for aic7xxx and aic79xx. aic7xxx actuallys supports up to 32-bit CDBs, so it might be that aic79xx does that, too. But this would include some more hacking, so this is way easier. Yeah, grand. That should read '16-byte CDBs',

Re: [2/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Andi Kleen 4 Linus Torvalds

Re: [PATCH] unexport sg v3 helper functions

2007-07-23 Thread Jens Axboe
On Sun, Jul 22 2007, FUJITA Tomonori wrote: blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were exported for bsg, however bsg was changed to support only sg v4. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] Acked-by: Jens Axboe [EMAIL PROTECTED] -- Jens Axboe - To

drivers/message/fusion/mptscsih.c: inconsequent NULL checking

2007-07-23 Thread Adrian Bunk
The Coverity checker spotted the following inconsequent NULL checking in drivers/message/fusion/mptscsih.c: -- snip -- ... int mptscsih_qcmd(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *)) { ... if (vdev (vdev-vtarget-tflags MPT_TARGET_FLAGS_Q_YES)

[PATCH] aacraid: Resend, Fix security hole

2007-07-23 Thread Alan Cox
On the SCSI layer ioctl path there is no implicit permissions check for ioctls (and indeed other drivers implement unprivileged ioctls). aacraid however allows all sorts of very admin only things to be done so should check. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive

RE: [PATCH] aacraid: Resend, Fix security hole

2007-07-23 Thread Salyzyn, Mark
ACK. Unit tested with Adaptec RAID management applications with apparently no issue. Will push this into matrix testing in the coming week. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Alan Cox Sent: Monday, July 23,

[PATCH] sgtable over sglist (Re: [RFC 4/8] scsi-ml: scsi_sgtable implementation)

2007-07-23 Thread FUJITA Tomonori
From: Jens Axboe [EMAIL PROTECTED] Subject: Re: [RFC 4/8] scsi-ml: scsi_sgtable implementation Date: Wed, 18 Jul 2007 22:17:10 +0200 On Wed, Jul 18 2007, Benny Halevy wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Boaz Harrosh wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Boaz Harrosh

[PATCH] aacraid: sysfs adapter reset/status format change.

2007-07-23 Thread Salyzyn, Mark
We need to newline terminate responses from nodes within the sysfs tree, the Adapter status value reported by the reset adapter node is adjusted. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch

Re: [patch] drivers/scsi/scsi_sysfs.c:718: warning: unused variable `rq'

2007-07-23 Thread James Bottomley
On Mon, 2007-07-23 at 16:36 +0200, Frederik Deweerdt wrote: - struct request_queue *rq = sdev-request_queue; if ((error = scsi_device_set_state(sdev, SDEV_RUNNING)) != 0) return error; @@ -736,7 +735,8 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) *

QLGC,ISP SCSI driver not finding attached devices

2007-07-23 Thread Mark Fortescue
Hi James, Can you point me in the direction of any documentation to aid me in identifing what debugging I need to work out what is going on? For targets without any connected disk, I get scan responses of: scsi scan: INQUIRY failed with code 0x4 after app 417ms. For targets with a

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-23 Thread Moore, Eric
Tomo - do you have any documentation on how to specify a bsg device? I was trying to run the smp_rep_manufacture from sgv4_tools, and I got that error. Due to that, I have not able to test this patch. However, here are some feedback with regards to the patch: On Sunday, July 08, 2007 9:52 PM,

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-23 Thread David Miller
From: Mark Fortescue [EMAIL PROTECTED] Date: Mon, 23 Jul 2007 23:41:34 +0100 (BST) I can also get the ESP driver to fail to find disks with the same error codes if I build it as a module driver however if I build the ESP driver into the kernel, it does not fail (ESP BUS_TIMEOUT=275). That's

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-23 Thread James Bottomley
On Mon, 2007-07-23 at 23:41 +0100, Mark Fortescue wrote: Hi James, Can you point me in the direction of any documentation to aid me in identifing what debugging I need to work out what is going on? they're all in include/scsi/scsi.h The code is divided into four bytes (from LSB): status,

Re: [PATCH] unexport sg v3 helper functions

2007-07-23 Thread Douglas Gilbert
Jens Axboe wrote: On Sun, Jul 22 2007, FUJITA Tomonori wrote: blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were exported for bsg, however bsg was changed to support only sg v4. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] Acked-by: Jens Axboe [EMAIL PROTECTED] Why?

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-23 Thread FUJITA Tomonori
From: Moore, Eric [EMAIL PROTECTED] Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Mon, 23 Jul 2007 18:11:34 -0600 Tomo - do you have any documentation on how to specify a bsg device? Sorry, I don't. But it's not difficult. With 2.6.23-rc1 + mptsas smp patch, you