Re: unexpected scsi timeout

2007-07-25 Thread Vasily Averin
Albert Lee wrote: Vasily Averin wrote: I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status register. As result for each command Error

Re: unexpected scsi timeout

2007-07-25 Thread Tejun Heo
Vasily Averin wrote: Albert Lee wrote: Vasily Averin wrote: I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status register. As result for each

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-25 Thread Benny Halevy
James Bottomley wrote: On Tue, 2007-07-24 at 17:01 +0300, Benny Halevy wrote: FUJITA Tomonori wrote: I should have said that, was the approach to use separate buffer for sglists instead of putting the sglists and the parameters in one buffer completely rejected? I think that James should be

Re: [PATCH AB1/5] SCSI: SG pools allocation cleanup.

2007-07-25 Thread Boaz Harrosh
I have a very serious and stupid bug in this patch which did not show in my tests. Please forgive me. Below is a diff of the bug. As an answer to this mail I will resend 2 revised patches AB1, and A2 is also affected. Sorry Boaz diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-25 Thread FUJITA Tomonori
From: Benny Halevy [EMAIL PROTECTED] Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Wed, 25 Jul 2007 11:26:44 +0300 However, I'm perfectly happy to go with whatever the empirical evidence says is best .. and hopefully, now we don't have to

[PATCH A2/5 ver2] SCSI: scsi_sgtable implementation

2007-07-25 Thread Boaz Harrosh
As proposed by James Bottomley all I/O members of struc scsi_cmnd and the resid member, which need to be duplicated for bidirectional transfers. Can be allocated together with the sg-list they are pointing to. This way when bidi comes the all structure can be duplicated with minimal

[PATCH AB1/5 ver2] SCSI: SG pools allocation cleanup.

2007-07-25 Thread Boaz Harrosh
- The code Automatically calculates at compile time the maximum size sg-array that will fit in a memory-page and will allocate pools of BASE_2 size, up to that maximum size. - split scsi_alloc() into an helper scsi_sgtable_index() that will return the index of the pool for a given

[PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h

2007-07-25 Thread Michael S. Tsirkin
scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Signed-off-by: Michael S. Tsirkin [EMAIL PROTECTED] --- diff --git

Re: unexpected scsi timeout

2007-07-25 Thread James Bottomley
On Wed, 2007-07-25 at 16:42 +0900, Tejun Heo wrote: Vasily Averin wrote: Albert Lee wrote: Vasily Averin wrote: I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of

Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h

2007-07-25 Thread Mike Christie
Michael S. Tsirkin wrote: scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Is that part about always including the header directly right? If so then

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-25 Thread Boaz Harrosh
FUJITA Tomonori wrote: From: Benny Halevy [EMAIL PROTECTED] Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Wed, 25 Jul 2007 11:26:44 +0300 However, I'm perfectly happy to go with whatever the empirical evidence says is best .. and

Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h

2007-07-25 Thread Michael S. Tsirkin
Quoting Mike Christie [EMAIL PROTECTED]: Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin wrote: scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the

Re: [PATCH] sgtable over sglist (Re: [RFC 4/8] scsi-ml: scsi_sgtable implementation)

2007-07-25 Thread Boaz Harrosh
Comments about this patch embedded inside FUJITA Tomonori wrote: I've attached the sgtable patch for review. It's against the sglist-arch branch in Jens' tree. --- From: FUJITA Tomonori [EMAIL PROTECTED] Subject: [PATCH] move all the I/O descriptors to a new scsi_sgtable structure

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-25 Thread Boaz Harrosh
FUJITA Tomonori wrote: From: Benny Halevy [EMAIL PROTECTED] Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Wed, 25 Jul 2007 11:26:44 +0300 However, I'm perfectly happy to go with whatever the empirical evidence says is best .. and

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-25 Thread Moore, Eric
On Tuesday, July 24, 2007 6:48 PM, FUJITA Tomonori wrote: I hadn't enabled bsg support in the linux kernel, that was my problem. What do you mean? You might hit the bug that you can't build scsi as a modular. It was fixed before rc1. The issue is I'm new to BSG, and I didn't know I

(resend) scsi0: Unexpected busfree while idle - Adaptec 29160N Ultra160 SCSI adapter

2007-07-25 Thread Jesper Juhl
Resending this since all I'm getting is silence and it's quite a problem for this box. I did a few google searches and aparently I'm not the only one having this problem - I see reports going back for years, but no solutions. I've got heaps of dmesg output if wanted/needed, I'll test patches,

2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error

2007-07-25 Thread Adrian Bunk
On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote: Of the machines we test releases on automatically this only compiles on NUMA-Q and does not boot there (some PCI issue). ppc64 (beavis): drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add': : undefined reference