RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-29 Thread FUJITA Tomonori
From: FUJITA Tomonori [EMAIL PROTECTED] Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Sun, 29 Jul 2007 14:07:01 +0900 From: Moore, Eric [EMAIL PROTECTED] Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Fri, 27 Jul 2007 17:24:19 -0600

[PATCH] zfcp: convert to use the data buffer accessors

2007-07-29 Thread FUJITA Tomonori
The patch is only compile tested. --- From: FUJITA Tomonori [EMAIL PROTECTED] Subject: [PATCH] zfcp: convert to use the data buffer accessors - remove the unnecessary map_single path. - convert to use the new accessors for the sg lists and the parameters. Signed-off-by: FUJITA Tomonori [EMAIL

Re: [RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation

2007-07-29 Thread Benny Halevy
FUJITA Tomonori wrote: From: Boaz Harrosh [EMAIL PROTECTED] Subject: [RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation Date: Thu, 05 Jul 2007 16:44:04 +0300 - sd and sr would adjust IO size to align on device's block size. So code needs to change once we move to scsi_sgtable

[PATCH] bsg: update sg_io_v4 structure

2007-07-29 Thread FUJITA Tomonori
This updates sg_io_v4 structure (based on Doug's RFC, release 1.3). The major changes are: - add dout_resid field - increase tag size to 64 bits to comply with SAM-4 and SRP - add dout_iovec_count and din_iovec_count dout_iovec_count and din_iovec_count aren't supported now. I'm not sure

[GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread James Bottomley
This is basically a set of bug fixes with a few minor cleanups thrown in. There are also a few bsg fixes we're taking through this tree because SCSI is the current sole consumer. The reason for the huge size is the lindent of the advansys driver along with a few cleanups. The patch is available

[2.6 patch] drivers/scsi/scsi_error.c should #include scsi_transport_api.h

2007-07-29 Thread Adrian Bunk
Every file should #include the headers containing the prototypes for its global functions (in this case for scsi_schedule_eh()). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28 17:10:48.0 +0200 +++

[2.6 patch] drivers/scsi/constants.c: make 2 functions static

2007-07-29 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 24 Mar 2007 drivers/scsi/constants.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.21-rc4-mm1/drivers/scsi/constants.c.old

Re: [RFC: 2.6 patch] remove the broken SCSI_ACORNSCSI_3 driver

2007-07-29 Thread Russell King
On Sun, Jul 29, 2007 at 04:59:15PM +0200, Adrian Bunk wrote: The SCSI_ACORNSCSI_3 driver: - has been marked as BROKEN for more than one year and - is still marked as BROKEN. Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable

[PATCH one more update] firewire: fw-sbp2: add support for multiple logical units per target

2007-07-29 Thread Stefan Richter
This makes multiple logical units on a single target accessible to fw-sbp2. Successfully tested with the IOI FWB-IDE01AB dual LU bridge. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- update 2: - rectify and refactor sbp2_probe drivers/firewire/fw-sbp2.c | 207

[PATCH 1/6] aha152x.c - In debug mode

2007-07-29 Thread Boaz Harrosh
The symbol debug_locks conflicts with the rather global one in include/linux/locks.h. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/aha152x.c | 10 +- drivers/scsi/aha152x.h |2 +- 2 files changed, 6 insertions(+), 6

[PATCH 2/6] aha152x.c - use bounce buffer

2007-07-29 Thread Boaz Harrosh
Cause highmem buffers to be bounced to low memory until this driver supports highmem addresses. Otherwise it just oopses on NULL buffer addresses. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/aha152x.c |7 +++ 1 files

[PATCH 3/6] aha152x.c - Preliminary fixes and some comments

2007-07-29 Thread Boaz Harrosh
hunk by hunk: - CHECK_CONDITION is what happens to cmnd-status 1 or after status_byte() macro. But here it is used directly on status which means 0x1 which is an undefined bit in the standard. And is a status that will never return from a target. - in busfree_run at the

[PATCH 4/6] aha152x.c - Clean Reset path

2007-07-29 Thread Boaz Harrosh
What Reset code was doing: Save command's important/dangerous Info on stack. NULL those members from scsi_cmnd. Issue a Reset. wait for it to finish than restore members and return. What I do is save or NULL nothing. But use the resetting hint in aha152x_internal_queue() to NULL out

[PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-29 Thread Boaz Harrosh
check_condition code-path was similar but more complicated to Reset. It went like this: 1. extra space was allocated at aha152x_scdata for mirroring scsi_cmnd members. 2. At aha152x_internal_queue() every not check_condition (REQUEST_SENSE) command was copied to above members in

[patch 0/6] aha152x.c - Cleanup, bugfixes, convert to accessors

2007-07-29 Thread Boaz Harrosh
In motivation for the !use_sg cleanup and use of accessors I needed to do some restructuring of the aha152x.c driver. The patchset has been tested by Randy Dunlap on a PCMCIA hardware based on aha152x.c. And some bugs where fixed in the process by Randy. The problematic parts were that the

[PATCH 6/6] aha152x.c - use data accessors and !use_sg cleanup

2007-07-29 Thread Boaz Harrosh
And finally this is the regular !use_sg cleanup and use of data accessors. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/aha152x.c | 91 +--- 1 files changed, 47 insertions(+), 44 deletions(-) diff --git

[PATCH 2/5] Use mutex instead of semaphore in the OnStream SCSI Tape driver

2007-07-29 Thread Matthias Kaehlcke
The OnStream SCSI Tape driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 08060fb..0e2452c 100644 --- a/drivers/scsi/osst.c +++

[PATCH 3/5] Use mutex instead of semaphore in the SCSI Tape driver

2007-07-29 Thread Matthias Kaehlcke
The SCSI Tape driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index a4f7b84..73c44cb 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -1485,7

Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread Jeff Garzik
James Bottomley wrote: This is basically a set of bug fixes with a few minor cleanups thrown in. There are also a few bsg fixes we're taking through this tree because SCSI is the current sole consumer. The reason for the huge size is the lindent of the advansys driver along with a few cleanups.

Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread James Bottomley
On Sun, 2007-07-29 at 18:51 -0400, Jeff Garzik wrote: James Bottomley wrote: This is basically a set of bug fixes with a few minor cleanups thrown in. There are also a few bsg fixes we're taking through this tree because SCSI is the current sole consumer. The reason for the huge size is

Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread Jeff Garzik
James Bottomley wrote: msleep_interruptible - ssleep is a change with zero practical impact for this driver, eh, how do you figure? A signal can clearly cause the abort-related functions to delay far shorter than the driver wishes. The msleep_interruptible() in arcmsr_wait_msgint_ready()

Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread James Bottomley
On Sun, 2007-07-29 at 21:04 -0400, Jeff Garzik wrote: James Bottomley wrote: msleep_interruptible - ssleep is a change with zero practical impact for this driver, eh, how do you figure? A signal can clearly cause the abort-related functions to delay far shorter than the driver wishes.

Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

2007-07-29 Thread Jeff Garzik
James Bottomley wrote: On Sun, 2007-07-29 at 21:04 -0400, Jeff Garzik wrote: James Bottomley wrote: msleep_interruptible - ssleep is a change with zero practical impact for this driver, eh, how do you figure? A signal can clearly cause the abort-related functions to delay far shorter than

Re: [PATCH 2/5] Use mutex instead of semaphore in the OnStream SCSI Tape driver

2007-07-29 Thread Satyam Sharma
Hi, On Sun, 29 Jul 2007, Matthias Kaehlcke wrote: The OnStream SCSI Tape driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] [...] @@ -3298,7 +3298,7 @@ static ssize_t osst_write(struct file * filp,

Re: [PATCH 3/5] Use mutex instead of semaphore in the SCSI Tape driver

2007-07-29 Thread Satyam Sharma
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote: The SCSI Tape driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Reviewed-by: Satyam Sharma [EMAIL PROTECTED] - To unsubscribe from this list: send the line