Not doing this can cause cards less than u160 capable to send out PPR
offers to devices they can't then deliver on ... causing some devices to
get a bit confused. Fix by capping the start syncrate at the
appropriate level according to the card capabilities.
James
diff --git
Since the srp transport class was added, if scsi tgt support is not
selected, the current Kconfig allows for enabling a dependent device
driver, such as ibmvscsi, which does a select of SCSI_SRP_ATTRS. This
does not, however, enable SCSI_TGT also. This fixes this up to prevent
the following build
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:
The SCSI Tape driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
Signed-off-by: Kai Makisara [EMAIL PROTECTED]
Thanks.
--
Kai
-
To unsubscribe from this
Kristen Carlson Accardi wrote:
@@ -42,6 +42,16 @@ enum scsi_eh_timer_return {
EH_RESET_TIMER,
};
+/*
+ * shost pm policy: If you alter this, you also need to alter scsi_sysfs.c
+ * (for the ascii descriptions)
+ */
+enum scsi_host_link_pm {
+ SHOST_NOT_AVAILABLE,
+
Hi all,
Here is a list of some known regressions in 2.6.23-rc1.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk6
Andi Kleen
Reverting 281afe1947d855661754850de29d7530b2ff18dc fixes this panic:
qla2xxx :42:07.0: Found an ISP2322, irq 19, iobase 0xf8812000
qla2xxx :42:07.0: Configuring PCI space...
qla2xxx :42:07.0: Configure NVRAM parameters...
BUG: unable to handle kernel NULL pointer dereference at
It's Monday morning, so time for another round of patches.
I'd like to thank jejb for merging the Lindent patch into Linus'
tree already. And I'd like to thank jgarzik for being indefatigable
in his reviews. I'd also like to thank jgarzik for telling me about
isa_register_driver which I wasn't
Update the version to 3.4
Add my copyright
Add myself to MAINTAINERS
Exercise my right to change the license from dual BSD/GPL to GPL
Don't force the definition of CONFIG_ISA on x86
Always include pci.h
Stop including stat.h
---
MAINTAINERS |6 ++
drivers/scsi/advansys.c |
Pass the Scsi_Host to the interrupt handler, rather than polling all
hosts for each interrupt.
Return IRQ_NONE if we didn't handle this interrupt
Don't set the IRQF_DISABLED flag; this is not a fast-executing interrupt
handler.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
Just use the Scsi_Host passed in, rather than looking through the driver's
own array of boards for one that matches it.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 36
1 files changed, 12 insertions(+), 24 deletions(-)
The interrupt routines used to walk the list of Scsi_Hosts belonging to
this driver to make sure that the scsi_cmnd belonged to one of them.
This is a waste of time and gets in the way of later cleanups, so
delete it.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c |
According to the AdvanSys driver, this device has a problem with tagged
queueing.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/scsi_devinfo.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
Make sure the resources are reserved and released by all the callers of
advansys_board_found(). This eliminates the check_region-style race.
It also allows us to use the pci_request_regions() API.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 70
AscCompareString() is just another name for strncmp
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 23 +++
1 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 424549d..277002a
- Switch EISA probing to the driver model
- Remove some now-unused macros and functions
- Update the FIXME now that we use the correct driver model probing API
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 175 +--
1
Register two isa_drivers, one for ISA and one for VLB, in order to
preserve detection order. When deleting advansys_detect, we lose the
last vestiges of the code that limited IO port scanning. This code
has been effectively disabled for many years anyway; I'll restore it
in a module_param later.
- Put all the error cleanup at the end of the function and goto the
appropriate label
- Split advansys_wide_init_chip out of advansys_board_found
- Split advansys_wide_free_mem out of advansys_board_found. Use it
from advansys_release
- Use GFP_KERNEL, not GFP_ATOMIC, when allocating
At some point during Linux 2.1 development, ioremap() gained the ability
to handle addresses which weren't page-aligned. Also expand the CONFIG_PCI
range to encompass that entire section of wide board initialisation, since
all wide boards are PCI.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
Remove some useless forward declarations
Reformat some comments, debug messages, and the occasional piece of real code
Removal of unnecessary braces
Remove duplicate setting of shost-irq
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 260
Convert adv_isr_callback, adv_async_callback and asc_isr_callback into
direct calls. Remove the unused asc_exe_callback.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 50 +++---
1 files changed, 8 insertions(+), 42
- Remove wrappers around the PCI configuration space accessors
- Call pci_set_master() instead of poking at config space directly
- Move the latency setting into one function called for both narrow and
wide boards.
- Tidy up AdvInitGetConfig() a little.
- Delete a few unused prototypes and
By moving a test from AscGetChipBusType into its only caller, we can delete
the whole function
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 36
1 files changed, 4 insertions(+), 32 deletions(-)
diff --git
n_io_port isn't suitable for advansys because some of the boards have
more than 255 bytes of io port space. There's already a driver-private
replacement, asc_n_io_port, but for some reason the driver was still
setting and occasionally reporting n_io_port.
Signed-off-by: Matthew Wilcox [EMAIL
The cfg structures are supposed to be disposable after initialisation;
with the 'dev' used for DMA mapping in there, that's not possible. Move
the dev to the board.
Also inline AscInitFromAscDvcVar into its only caller, remove some
unnecessary prototypes and sort out a few minor formatting
Use slave_configure() to do all the work that used to be done in
AscInquiryHandling and AdvInquiryHandling. Split slave_configure into
two functions, one for wide and one for narrow controllers.
Remove some unused definitions, duplicate definitions, unnecessary
declarations, and scsireqq,
- Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host, scsi_scan_host and scsi_host_put.
- Rename the scsi_host_template to advansys_template
- Use module_init and module_exit instead of scsi_module.c
- Remove protection against advansys_detect being called twice
The driver kept a copy of the PCI config address; refer to the pci_dev
associated with the card instead.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 29 +
1 files changed, 9 insertions(+), 20 deletions(-)
diff --git
- Add a pci_driver interface for the PCI advansys devices (for
ISA/EISA/VLB devices, we still call advansys_detect).
- Many functions are converted from __init to __devinit to allow hotplug
PCI to work.
- Only keep devices found by advansys_detect in the asc_host list.
- Rename
Use memcpy to initialise eep_config instead of a loop. For
AdvInitFrom38C1600EEP where we need to modify the default EEPROM
configuration, do it after the loop, and do it using the structure
definition, not by finding the right byte. I think it was wrong for
big-endian machines.
Also delete
The 700+-line comment at the top of the advansys driver fits more comfortably
in Documentation/scsi.
Delete the sections on:
- kernels supported
- other files modified (obsolete)
- source comments (obsolete)
- tests to run
- release history (that's what a VCS is for)
- contacting connectcom
On Sunday, July 29, 2007 1:37 AM, FUJITA Tomonori wrote:
Eric, can I get your ACK on this patch?
One comment on the the patch:
+ if (!(ioc-sas_mgmt.status MPT_IOCTL_STATUS_COMMAND_GOOD)) {
+ printk(KERN_ERR %s: smp response invalid!\n,
__FUNCTION__);
+ ret
Matthew Wilcox wrote:
Reverting 281afe1947d855661754850de29d7530b2ff18dc fixes this panic:
It turned out that one of changes didn't committed into local git tree that is
being used to generate the patch.
I'm sorry for creating a serious problem on the kernel.
The patch that fixes the problem
As a fix to the issue initiated by the email thread 'qla2xyz broken in current
Linus tree',
Following patch should fix the problem.
Thank you,
Seokmann
---
From d0355c3c61a12ce466c87d8ef953425d2b21725b Mon Sep 17 00:00:00 2001
From: Seokmann Ju [EMAIL PROTECTED]
Date: Mon, 30 Jul 2007 13:12:17
Matthew Wilcox wrote:
It's Monday morning, so time for another round of patches.
I'd like to thank jejb for merging the Lindent patch into Linus'
tree already. And I'd like to thank jgarzik for being indefatigable
in his reviews. I'd also like to thank jgarzik for telling me about
On Mon, Jul 30, 2007 at 11:01:07AM -0700, Seokmann Ju wrote:
As a fix to the issue initiated by the email thread 'qla2xyz broken in
current Linus tree',
Following patch should fix the problem.
Confirmed. Thanks!
--
Bill, look, we understand that you're interested in selling us this
We are releasing code to add support for iSCSI Extensions for RDMA
(iSER) to the existing STGT user space SCSI target. It uses
OpenFabrics libraries and kernel drivers to act as a SCSI target
over RDMA-capable devices. The code has been tested against
the existing Linux iSER initiator over
On Saturday, July 28, 2007 11:40 AM, James Bottomley wrote:
I tell you what, let me just show you the actual patch. This
allows you
to write to the
/sys/module/mptbase/parameters/mpt_debug_level and have
it take effect in every ioc.
ACK, If possible, I would like this patch thrown
dpt_i2o: Convert to new SCSI driver model
- Delete refereces to HOSTS_C
- Switch to module_init/module_exit instead of detect/release
- Don't pass around the host template and rename it to adpt_template
- Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host,
On Mon, Jul 30, 2007 at 03:19:18PM -0600, Matthew Wilcox wrote:
dpt_i2o: Convert to new SCSI driver model
- Delete refereces to HOSTS_C
- Switch to module_init/module_exit instead of detect/release
- Don't pass around the host template and rename it to adpt_template
- Switch from
Matthew Wilcox wrote:
dpt_i2o: Convert to new SCSI driver model
- Delete refereces to HOSTS_C
- Switch to module_init/module_exit instead of detect/release
- Don't pass around the host template and rename it to adpt_template
- Switch from scsi_register/scsi_unregister to scsi_host_alloc,
The Coverity checker spotted that we have already oops'ed if cmd
was NULL.
Since cmd being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/imm.c.old 2007-07-30
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 0/5] mpt fusion: Add logging support
Date: Mon, 30 Jul 2007 12:33:00 -0600
On Saturday, July 28, 2007 11:40 AM, James Bottomley wrote:
I tell you what, let me just show you the actual patch. This
allows you
to write to the
James, please push upstream, thanks a lot!
[SCSI] ESP: Drop ESP_BUS_TIMEOUT back down to 250
This reverts d73f5222a618a91452d41c29f5996ce3d9c63673
The bug that made us increase ESP_BUS_TIMEOUT to 275 turned out to be
a memset bug on 32-bit sparc.
It is better to put this back at the correct
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Mon, 30 Jul 2007 11:10:07 -0600
On Sunday, July 29, 2007 1:37 AM, FUJITA Tomonori wrote:
Eric, can I get your ACK on this patch?
One comment on the the patch:
+ if
On Sun, 29 Jul 2007 22:27:06 +0300 Boaz Harrosh wrote:
check_condition code-path was similar but more
complicated to Reset. It went like this:
1. extra space was allocated at aha152x_scdata for mirroring
scsi_cmnd members.
2. At aha152x_internal_queue() every not
Hi,
I have just sent a patch-set to linux-kernel that touches quite a
number of block device drives, with particular relevance to md and
dm.
Rather than fill lots of peoples mailboxes multiple times (35 patches
in the set), I only sent the full set to linux-kernel, and am just
sending this
46 matches
Mail list logo
