Re: [PATCH] Fix race with shared tag queue maps

2007-09-14 Thread Jens Axboe
On Thu, Sep 13 2007, Linus Torvalds wrote: On Thu, 13 Sep 2007, Jens Axboe wrote: My bad, I think I added the smp_mb__before_clear_bit() when it was __test_and_set_bit() like in the first hunk. Ahh, that wouldn't work at all. The __test_and_set_bit() thing isn't atomic at all, and

Re: 2.6.23-rc4-mm1

2007-09-14 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote: [...] The only patch which touches qla1280 is git-block.patch. From a quick squizz the change looks OK, although it's tricky and something might have broken. (the dprintk at line 2929 needs to print remseg, not seg_cnt).

Re: PATCH 2/4] scsi: megaraid_sas -- add module param fast_load

2007-09-14 Thread Andrew Morton
On Tue, 11 Sep 2007 08:28:14 -0400 linux-box [EMAIL PROTECTED] wrote: Driver will skip physical devices scan for the first time if the fast_load is set When preparing changelogs it is often good to describe _why_ the change is being made, as well as what the change does. It may be obvious to

Re: [PATCH 3/4] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-14 Thread Andrew Morton
On Tue, 11 Sep 2007 08:34:33 -0400 linux-box [EMAIL PROTECTED] wrote: + struct megasas_instance *instance = + (struct megasas_instance *)host-hostdata; y'know, if some brave soul were to write static inline void *scsi_host_data(struct Scsi_Host *host) {

Re: [PATCH 3/4] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-14 Thread Christoph Hellwig
On Fri, Sep 14, 2007 at 03:32:16AM -0700, Andrew Morton wrote: y'know, if some brave soul were to write y'know - some brave sould already did it. static inline void *scsi_host_data(struct Scsi_Host *host) { return (void *)host-hostdata; } we could remove about 1000 ugly

Re: 2.6.23-rc4-mm1

2007-09-14 Thread Torsten Kaiser
On 9/14/07, Andy Whitcroft [EMAIL PROTECTED] wrote: On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote: [...] Even if we revert the qla1280 patch, scsi-ml still sends chaining sg list. So it doesn't work. The following patch disables chaining sg list for qla1280. If the

Re: [PATCH 1/4] scsi: megaraid_sas -- add hibernation support

2007-09-14 Thread James Bottomley
On Tue, 2007-09-11 at 12:21 +, linux-box wrote: The megaraid_sas driver doesn't support the hibernation, the suspend/resume routine implemented to support the hibernation. Signed-off-by: Bo Yang [EMAIL PROTECTED] Just from a process point of view, your email from: is linux-box [EMAIL

Re: sata scsi suggestion for make menuconfig

2007-09-14 Thread Stefan Richter
Adrian Bunk wrote: On Sun, Sep 09, 2007 at 05:11:44PM -0400, Jeff Garzik wrote: Let's step back a moment and consider the actual scale and impact of the problem at hand. The vast majority of users are consumers of pre-compiled kernels, built by People With Clue(tm), who figured this stuff

Re: sata scsi suggestion for make menuconfig

2007-09-14 Thread Adrian Bunk
On Fri, Sep 14, 2007 at 04:54:07PM +0200, Stefan Richter wrote: Adrian Bunk wrote: On Sun, Sep 09, 2007 at 05:11:44PM -0400, Jeff Garzik wrote: Let's step back a moment and consider the actual scale and impact of the problem at hand. The vast majority of users are consumers of

[PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Applicable to 2.6.23-rc6 and to scsi-misc. drivers/scsi/Kconfig | 32 1 file changed, 20 insertions(+), 12 deletions(-) Index: linux-2.6.23-rc6/drivers/scsi/Kconfig

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Jeff Garzik
Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Applicable to 2.6.23-rc6 and to scsi-misc. drivers/scsi/Kconfig | 32 1 file changed, 20 insertions(+), 12 deletions(-) ACK - To unsubscribe from this list: send the line

Re: sata scsi suggestion for make menuconfig

2007-09-14 Thread Stefan Richter
Adrian Bunk wrote: On Fri, Sep 14, 2007 at 05:37:37PM +0200, Stefan Richter wrote: In practice, this takes too much time, hence you take an existing .config (yours or somebody else's) and go from there. Kconfig let's you start with the defconfig when doing make menuconfig without any

[PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Gilbert Wu
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ bit from status

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Wu, Gilbert
HI Jeff, Oops! I missed that one and will resend again. Thanks! Gilbert -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, September 14, 2007 10:27 AM To: Wu, Gilbert Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] aic94xx: fix smartctl utility problem

[PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Gilbert Wu
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ bit from status

[PATCH] SCSI: trailing whitespace in Kconfig

2007-09-14 Thread Stefan Richter
Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Applies after patch SCSI: split Kconfig menu into two. I didn't want to change whitespace in the portions that this patch moved from drivers/scsi/Kconfig to drivers/scsi/Kconfig.lowlevel, hence produced this follow-up.

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not work on SATA device. ( The smartctl v5.38 does need -d ata option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the DRQ

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Lennart Sorensen
On Fri, Sep 14, 2007 at 06:01:53PM +0200, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Applicable to 2.6.23-rc6 and to scsi-misc. drivers/scsi/Kconfig | 32 1 file changed, 20 insertions(+), 12 deletions(-) Index:

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-14 Thread Sam Ravnborg
Hi Stefan. Such a patch really calls for some minimal unifacation among the architectures. arch/alpha/Kconfig|2 arch/arm/Kconfig |2 arch/avr32/Kconfig|2 arch/blackfin/Kconfig |2 arch/cris/Kconfig |2

Power management for SCSI transports

2007-09-14 Thread Alan Stern
Kristen: You've been doing a lot of work on link power management for SCSI buses. It would be good if we could integrate this with the USB power-management implementation in the usb-storage driver -- but I'm not sure whether our requirements and feature sets really match up. I'm not at all

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-14 Thread Adrian Bunk
On Fri, Sep 14, 2007 at 09:00:33PM +0200, Sam Ravnborg wrote: Hi Stefan. Such a patch really calls for some minimal unifacation among the architectures. arch/alpha/Kconfig|2 arch/arm/Kconfig |2 arch/avr32/Kconfig|2

Re: CONFIG_BLK_DEV_BSG=n

2007-09-14 Thread James Bottomley
On Fri, 2007-09-14 at 12:50 -0700, Medve Emilian-EMMEDVE1 wrote: Which solution would you be more comfortable with? The one which is currently in -mm is this one: http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a James - To

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
On 14 Sep, Lennart Sorensen wrote: On Fri, Sep 14, 2007 at 06:01:53PM +0200, Stefan Richter wrote: ... + - for non-SCSI hardware whose drivers translate from and to SCSI +protocols, like the IDE-SCSI emulation driver and most notably +for all SATA drivers. ... You left

Re: 2.6.23-rc4-mm1

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 15:01:03 +0200 Torsten Kaiser [EMAIL PROTECTED] wrote: On 9/14/07, Andy Whitcroft [EMAIL PROTECTED] wrote: On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote: [...] Even if we revert the qla1280 patch, scsi-ml still sends chaining sg list. So it

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Lennart Sorensen
On Fri, Sep 14, 2007 at 10:14:16PM +0200, Stefan Richter wrote: - If you want to use a SCSI or FireWire CD-ROM under Linux, + If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM, say Y and read the SCSI-HOWTO and the CDROM-HOWTO at

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-14 Thread Stefan Richter
I wrote: Applies after patch SCSI: update Kconfig help text to indicate SCSI core's widespread usage, Actually the addition This menu also presents options for specific SCSI controllers... from that patch is then no longer true. These two patches could very well be collapsed into one. (I'll

Re: [Bugme-new] [Bug 9018] New: Kernel bug in aic94xx driver shipped with kernel 2.6.21.7

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 07:11:54 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9018 Summary: Kernel bug in aic94xx driver shipped with kernel 2.6.21.7 Product: Drivers Version: 2.5 KernelVersion:

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
On 14 Sep, Lennart Sorensen wrote: On Fri, Sep 14, 2007 at 10:14:16PM +0200, Stefan Richter wrote: - If you want to use a SCSI or FireWire CD-ROM under Linux, + If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM, say Y and read the SCSI-HOWTO and the

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Lennart Sorensen
On Fri, Sep 14, 2007 at 11:06:44PM +0200, Stefan Richter wrote: On 14 Sep, Lennart Sorensen wrote: On Fri, Sep 14, 2007 at 10:14:16PM +0200, Stefan Richter wrote: -If you want to use a SCSI or FireWire CD-ROM under Linux, +If you want to use a SCSI, SATA, USB or FireWire CD-ROM or

Re: [Bugme-new] [Bug 9018] New: Kernel bug in aic94xx driver shipped with kernel 2.6.21.7

2007-09-14 Thread James Bottomley
On Fri, 2007-09-14 at 13:56 -0700, Andrew Morton wrote: On Fri, 14 Sep 2007 07:11:54 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9018 Summary: Kernel bug in aic94xx driver shipped with kernel 2.6.21.7

[PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- And one more update: There is SAS too, and I forgot 'is' in on a disk which __ accessed via. drivers/scsi/Kconfig | 67 ++- 1 file changed, 35 insertions(+), 32 deletions(-) Index:

command failing at iSCSI disconnect

2007-09-14 Thread Dave Jiang
I'm using the latest linus git tree. This is in fileio mode with IOMode=wb. It seems that if I do I/O and then immediately disconnect then the cache sync commands fail. Is this expected behavior or should the connection wait till all existing commands has been flushed before logout? Thanks!

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread FUJITA Tomonori
On Fri, 14 Sep 2007 23:14:21 +0200 (CEST) Stefan Richter [EMAIL PROTECTED] wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- And one more update: There is SAS too, and I forgot 'is' in on a disk which __ accessed via. drivers/scsi/Kconfig | 67

[PATCH 0/8] mpt fusion

2007-09-14 Thread Eric Moore
These set of patchs are for scsi-misc git, hence post 2.6.23 kernels. These basically cleaning up a large part of the code. Contents of this series of patchs: 1) mm merges 2) standardize printks and debug info 3) adding/removing white space 4) rename vdev to vdevice 5) removing references to

[PATCH 1/8] mpt fusion: mm merges

2007-09-14 Thread Eric Moore
These fixes from -mm tree need to be merged in James git tree. Here is a single patch containing all four patchs changes. They address some memory leaks, menuobject support, kill redundant memset, and using kzalloc. List of patchs, and pointers to archives: [patch 08/30] Use menuconfig

[PATCH 3/8] mpt fusion: adding/removing white space

2007-09-14 Thread Eric Moore
cleaning up some white space that was introduce in a recent cb_idx int to u8 patch. Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/mptbase.c a/drivers/message/fusion/mptbase.c --- b/drivers/message/fusion/mptbase.c 2007-09-14 17:23:24.0 -0600 +++

[PATCH 4/8] mpt fusion: rename vdev to vdevice

2007-09-14 Thread Eric Moore
common naming of vdevice through out driver Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/mptctl.c a/drivers/message/fusion/mptctl.c --- b/drivers/message/fusion/mptctl.c 2007-09-14 12:35:20.0 -0600 +++ a/drivers/message/fusion/mptctl.c 2007-09-14

[PATCH 5/8] mpt fusion: removing references to hd-ioc

2007-09-14 Thread Eric Moore
Cleaning up code by accesing the ioc pointer directly instead of via hd-ioc. In the future, most data members of struct MPT_SCSI_HOST will be either deleted or moved to struct MPT_ADAPTER. Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/mptfc.c

[PATCH 6/8] mpt fusion: removing Dell copyright

2007-09-14 Thread Eric Moore
Some other vender has concerns over this copyright, and Dell has approved removing it. Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/mptsas.c a/drivers/message/fusion/mptsas.c --- b/drivers/message/fusion/mptsas.c 2007-09-14 17:09:59.0 -0600 +++

[PATCH 7/8] mpt fusion: Kconfig cleanup

2007-09-14 Thread Eric Moore
Adding 949X, 949E, and 1078 to Kconfig. Adding depends on FUSION required in the FUSION_LOGGING section, and fixing a spelling error. Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/Kconfig a/drivers/message/fusion/Kconfig --- b/drivers/message/fusion/Kconfig

[PATCH 8/8] mpt fusion: bump version to 3.04.06

2007-09-14 Thread Eric Moore
bump version Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/drivers/message/fusion/mptbase.h a/drivers/message/fusion/mptbase.h --- b/drivers/message/fusion/mptbase.h 2007-09-13 14:30:29.0 -0600 +++ a/drivers/message/fusion/mptbase.h 2007-09-14 17:52:30.0 -0600 @@

[PATCH] MAINTAINERS : mpt fusion mailing list change

2007-09-14 Thread Eric Moore
Mailing list changed. The former list at [EMAIL PROTECTED] is no longer in service. Please use the new email provided listed in this patch. Signed-off-by: Eric Moore [EMAIL PROTECTED] diff -uarpN b/MAINTAINERS a/MAINTAINERS --- b/MAINTAINERS 2007-08-15 16:33:58.0 -0600 +++

Re: 2.6.23-rc4-mm1

2007-09-14 Thread Paul Jackson
FUJITA Tomonori wrote: Can you try this patch (against 2.6.23-rc4-mm1)? From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori [EMAIL PROTECTED] Date: Mon, 10 Sep 2007 04:17:13 +0100 Subject: [PATCH] qla1280: sg chaining fixes Signed-off-by: FUJITA