Re: slow after upgrade to CentOS 5 (RHEL5)

2007-10-28 Thread James Bottomley
On Sat, 2007-10-27 at 13:21 -0700, Anthony Ewell wrote: James Bottomley wrote: On Wed, 2007-10-24 at 18:04 -0700, Anthony Ewell wrote: Hi All, If you all would not mind a post from the general public Linux user, after doing a complete disk wipe of CentOS 4 and installing CentOS5,

[PATCH] sym53c8xx_2: compilation warning fix

2007-10-28 Thread Krzysztof Helt
From: Krzysztof Helt [EMAIL PROTECTED] Small code rearrangement to kill this compilation warning: drivers/scsi/sym53c8xx_2/sym_glue.c:612: warning: io_reset may be used uninitialized in this function Signed-off-by: Krzysztof Helt [EMAIL PROTECTED] --- diff -urp

[2.6 patch] scsi/seagate.c: remove dead code

2007-10-28 Thread Adrian Bunk
This patch removes obviously dead code. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/seagate.c |2 -- 1 file changed, 2 deletions(-) c0807bbefb65ef679b7d2ec13d14c35f2e927404 diff --git a/drivers/scsi/seagate.c b/drivers/scsi/seagate.c index b113244..2d31ed4 100644 ---

Re: [2.6 patch] scsi/seagate.c: remove dead code

2007-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2007 at 04:51:42PM +0100, Adrian Bunk wrote: This patch removes obviously dead code. case LINKED_WRONG: WRITE_DATA (ABORT); linked_connected = 0;

[PATCH] scsi_aen: fix event locking problems

2007-10-28 Thread James Bottomley
There was a fundamental flaw in the initial code, in that it had no locking around scsi_device_event_notify(). This is a problem because execute_in_process_context() also has no locking (it expects the caller to do the work). This means that two events firing simultaneously could potentially

Re: [PATCH] scsi_aen: fix event locking problems

2007-10-28 Thread Jeff Garzik
James Bottomley wrote: There was a fundamental flaw in the initial code, in that it had no locking around scsi_device_event_notify(). This is a problem because execute_in_process_context() also has no locking (it expects the caller to do the work). This means that two events firing

Re: [PATCH] scsi_aen: fix event locking problems

2007-10-28 Thread James Bottomley
On Sun, 2007-10-28 at 16:52 -0400, Jeff Garzik wrote: You missed an updated version (which was CC'd to you). No ... I was coming to yours next. James - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at

trivial annotations in arcmsr

2007-10-28 Thread Al Viro
driver still has serious portability problems Signed-off-by: Al Viro [EMAIL PROTECTED] --- drivers/scsi/arcmsr/arcmsr.h | 32 --- drivers/scsi/arcmsr/arcmsr_attr.c |6 +- drivers/scsi/arcmsr/arcmsr_hba.c | 170 ++--- 3 files changed, 103

deal with resource allocation bugs in arcmsr

2007-10-28 Thread Al Viro
a) for type B we should _not_ iounmap() acb-pmu; it's not ioremapped. b) for type B we should iounmap() two regions we _do_ ioremap. c) if ioremap() fails, we need to bail out (and clean up). Signed-off-by: Al Viro [EMAIL PROTECTED] --- drivers/scsi/arcmsr/arcmsr.h |9 -

arcmsr: endianness bug

2007-10-28 Thread Al Viro
initializing a field in data shared with the card with cpu_to_le32(something) | 0x10 is broken - the field is, indeed, little-endian and we need cpu_to_le32() on both parts. Signed-off-by: Al Viro [EMAIL PROTECTED] --- drivers/scsi/arcmsr/arcmsr_hba.c |2 +- 1 files changed, 1

fix reentrancy bug in arcmsr_get_iop_{r,w}qbuffer()

2007-10-28 Thread Al Viro
doh... Signed-off-by: Al Viro [EMAIL PROTECTED] --- drivers/scsi/arcmsr/arcmsr_hba.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index acbc50f..d466a2d 100644 ---