On Mon, Dec 03 2007, [EMAIL PROTECTED] wrote:
Matthew Wilcox [EMAIL PROTECTED] wrote:
On Sun, Dec 02, 2007 at 05:53:30PM -0800, [EMAIL PROTECTED] wrote:
Can I suggest running 'pahole' over this when compiled on 64-bit?
You've just introduced a 4-byte hole.
This one fixes the 4-byte hole.
* Bob Tracy [EMAIL PROTECTED] wrote:
Finally got back in town. Starting the git-bisect process. I've got
a relatively slow network connection, and the PWS 433au isn't exactly
what I would call fast by modern standards, so bear with me while I
get things set up and crank through this.
On Fri, Nov 30 2007, Kiyoshi Ueda wrote:
Hello Jens,
The following is the updated patch-set for blk_end_request().
Changes since the last version are only minor updates to catch up
with the base kernel changes.
Do you agree the implementation of blk_end_request()?
If there's no problem,
On Fri, Nov 30 2007, Kiyoshi Ueda wrote:
Hello Jens,
The following is the updated patch-set for blk_end_request().
Changes since the last version are only minor updates to catch up
with the base kernel changes.
Do you agree the implementation of blk_end_request()?
If there's no problem,
* Kamalesh Babulal [EMAIL PROTECTED] wrote:
So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not?
Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4.
just to make sure: this is a real lockup and failed bootup (or device
init), not just a message, right?
Ingo
-
To
Hi,
On Monday 03 December 2007, Kiyoshi Ueda wrote:
[...]
Thank you for the comments.
I rebased my patch on top of 2.6.24-rc3-mm2 + the patch to remove
post_transform_command().
As a result, one callback function for DMA mode has been removed.
What do you think about the patch below?
On Tuesday 04 December 2007, Kiyoshi Ueda wrote:
Hi Bartlomiej,
On Sat, 1 Dec 2007 23:53:05 +0100, Bartlomiej Zolnierkiewicz [EMAIL
PROTECTED] wrote:
On Saturday 01 December 2007, Kiyoshi Ueda wrote:
This patch converts normal parts of ide to use blk_end_request().
Signed-off-by:
On Sat, Dec 01 2007 at 1:24 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
This patch adds 2 new interfaces for request completion:
o blk_end_request() : called without queue lock
o __blk_end_request() : called with queue lock held
Some device drivers call some generic functions below
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
This patch converts bidi of scsi mid-layer to use blk_end_request().
rq-next_rq represents a pair of bidi requests.
(There are no other use of 'next_rq' of struct request.)
For both requests in the pair,
On Tue, Dec 04 2007 at 14:16 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Fri, Nov 30 2007, Kiyoshi Ueda wrote:
Hello Jens,
The following is the updated patch-set for blk_end_request().
Changes since the last version are only minor updates to catch up
with the base kernel changes.
Do you
Tony Battersby wrote:
Hello,
I am sending this message to check up on the merge status of my recent
sym53c8xx patches to make sure they aren't forgotten. Matthew Wilcox,
could you give an ack/nak for these merge requests? Also, please let me
know if I need to do anything else (such as
Ingo Molnar wrote:
* Kamalesh Babulal [EMAIL PROTECTED] wrote:
So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not?
Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4.
just to make sure: this is a real lockup and failed bootup (or device
init), not just a message, right?
I was doing some performance comparisons between the aic94xx sas adapter
and the mptsas (lsi1078 chip) and saw that performance was slightly
lower on lsi using the same drive. One thing I noticed the mptsas driver
was only setting sg_tablesize to 40 which restricts the maximum size of
the IO
Ingo Molnar wrote:
once you are done with the download of the initial cloned git repository
(which is 200MB+), all the bisection steps will be local and you'll be
only limited by kernel rebuild speed and by bootup and testing speed,
not by network bandwidth.
ACK. Have tested two kernels
On Mon, Nov 26 2007 at 17:35 +0200, Alan Stern [EMAIL PROTECTED] wrote:
Not all devices correctly report the error-causing LBA in the
Information field of their sense data -- even when they set the Valid
bit. This patch (as1019) makes sd much more cautious about accepting
the reported LBA.
On Tue, 4 Dec 2007, Boaz Harrosh wrote:
perhaps below hunk should be added to your patch.
It looks like a good idea.
Was it decided when this data corruption bugfix is
merged.
I don't know -- I haven't heard anything back from James.
Also in sr.c. It does the range check but it might
Hi Bartlomiej,
On Tue, 4 Dec 2007 14:47:00 +0100, Bartlomiej Zolnierkiewicz wrote:
Hmmm, this seems to change the old behavior (the request should
be dequeued from the queue only if 'dequeue' variable is set)
and AFAIR some error handling code (in ide-cd?) depends on the
old behavior
On Tuesday, December 04, 2007 8:45 AM, Steven Pratt wrote:
Also, is there any reason we can't increase sg_tablesize for mptsas?
The default 128, set in Kconfig (look at FUSION_MAX_SGE).It only set
to 40 when that is not defined. What is in your kernel .config, e.g
look for
* Kamalesh Babulal [EMAIL PROTECTED] wrote:
Hi Ingo,
This softlockup is seen in the 2.6.24-rc4 either and looks like a
message because this is seen while running tbench and machine
continues running other test's after the softlockup messages and some
times seen with the bootup, but the
akpm reported that:
make mrproper
make allmodconfig
make drivers/scsi/aic7xxx/
were broken in recent kbuild.git - and as a logical consequence
removed kbuild.git from his -mm lineup.
I have now fixed it (stupid bug I made) and pushed out
a fresh kbuild.git tree.
As previously announced I am not
Hi Boaz,
On Tue, 04 Dec 2007 15:56:32 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
+int blk_end_request(struct request *rq, int uptodate, int nr_bytes)
+{
+ struct request_queue *q = rq-q;
+ unsigned long flags = 0UL;
+
+ if (blk_fs_request(rq) || blk_pc_request(rq)) {
+
Hi Boaz and Jens,
On Tue, 04 Dec 2007 15:56:32 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
+/**
+ * blk_end_request - Helper function for drivers to complete the request.
+ * @rq: the request being processed
+ * @uptodate: 1 for success, 0 for I/O error, 0 for specific error
+ *
Hrm... does this patch help? You'll get a bunch of ATA/SAS disk errors
printed to the screen if you yank the disk, but at least libsas won't
get stuck waiting for the cache-flush commands to time out.
---
sd will get hung up issuing commands to flush write cache if a SAS device
is unplugged
Moore, Eric wrote:
On Tuesday, December 04, 2007 8:45 AM, Steven Pratt wrote:
Also, is there any reason we can't increase sg_tablesize for mptsas?
The default 128, set in Kconfig (look at FUSION_MAX_SGE).It only set
to 40 when that is not defined. What is in your kernel
Darrick J. Wong wrote:
Hrm... does this patch help? You'll get a bunch of ATA/SAS disk errors
printed to the screen if you yank the disk, but at least libsas won't
get stuck waiting for the cache-flush commands to time out.
---
sd will get hung up issuing commands to flush write cache if a SAS
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote:
As an aside, issues like this really really imply a need to move libsas
away from the old libata EH stuff (like brking did with ipr, in patches).
Hm... does the new libata EH handle the case of device was
unplugged, don't bother
Darrick J. Wong wrote:
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote:
As an aside, issues like this really really imply a need to move libsas
away from the old libata EH stuff (like brking did with ipr, in patches).
Hm... does the new libata EH handle the case of device was
This patchset was made over scsi-rc-fixes (it also applies to Linus's git
tree). It will not apply over scsi-misc, because there are some patches
which went into scsi-rc-fixes/2.6.24-rc4 and scsi-misc has not been updated
for the scsi-rc-fixes patches.
Sorry for the bigger than normal update.
From: Mike Christie [EMAIL PROTECTED]
This patch adds logical unit reset support. This should work for ib_iser,
but I have not finished testing that driver so it is not hooked in yet.
This patch also temporarily reverts the iscsi_tcp r2t write out patch.
That code is completely rewritten in this
From: Mike Christie [EMAIL PROTECTED]
There is not need to block the session during logout. Since
we are going to fail the commands that were blocked just fail them
immediately instead.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/infiniband/ulp/iser/iser_initiator.c | 11 +--
From: Mike Christie [EMAIL PROTECTED]
There is just too much going on through the common workq and
something like a scsi device removal through sysfs affects
how long it will take to recover the transport, mark it as
failed, or shut it down gracefully.
Signed-off-by: Mike Christie [EMAIL
From: Mike Christie [EMAIL PROTECTED]
I thought we may not need the eh mutex during host reset, but that is wrong
with the new shutdown code. When start_session_recovery sets the state to
terminate then drops the session lock. The scsi eh thread could then grab the
session lock see that we are
From: Mike Christie [EMAIL PROTECTED]
We were using the device delete sysfs file to remove each device
then logout. Now in 2.6.21 and .22 this will not work because
the sysfs delete file returns immediately and does not wait for
the device removal to complete. This causes a hang if a cache sync
From: Mike Christie [EMAIL PROTECTED]
During root boot and shutdown the target could send us nops.
At this time iscsid cannot be running, so the target will drop
the session and the boot or shutdown will hang.
To handle this and allow us to better control when to check the network
this patch
From: Mike Christie [EMAIL PROTECTED]
If the target requests a logout, then we do not want
to fail commands to scsi-ml right away. This patch just
fails in pending commands for a requeue immediately, and then lets
iscsid handle running commands like normal recovery.
Signed-off-by: Mike Christie
From: Mike Christie [EMAIL PROTECTED]
If the current ctask is failed early, we legt the conn-ctask pointer
pointing to a invalid task. When the xmit thread would send data for
it, we would then oops.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/libiscsi.c |5 -
1
From: Mike Christie [EMAIL PROTECTED]
The driver does not need the host lock in queuecommand so drop it.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/libiscsi.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libiscsi.c
From: Mike Christie [EMAIL PROTECTED]
from [EMAIL PROTECTED]
iscsi_pool_init simplified
iscsi_pool_init currently has a lot of duplicate kfree() calls it does
when some allocation fails. This patch simplifies the code a little by
using iscsi_pool_free to tear down the pool in case of an error.
From: Mike Christie [EMAIL PROTECTED]
From Olaf Kirch:
Rewrite recv path. Fixes:
- data digest processing and error handling.
- ahs support.
Some fixups by Mike Christie
Signed-off-by: [EMAIL PROTECTED]
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/iscsi_tcp.c | 1018
From: Mike Christie [EMAIL PROTECTED]
A target should never send us a itt that does not match a running
task. If it does we do not really know what is coming down after the header,
unless we evaluate the hdr and do some guessing sometimes. However,
even if we know what is coming we probably do
From: Mike Christie [EMAIL PROTECTED]
Older tools will not be setting the tmf time outs since they
did not exists, so set them to a safe default.
And export abort and lu reset timeout values in sysfs.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/libiscsi.c |2
From: Mike Christie [EMAIL PROTECTED]
The previous patches converted iscsi_tcp to support sg chaining.
This patch sets the proper flags and sets sg_table size to
4096. This allows fs io to be capped at max_sectors, but passthrough
IO to be limited by some other part of the kernel.
Signed-off-by:
From: Mike Christie [EMAIL PROTECTED]
iscsi_data_rsp needs to hold the sesison lock when it calls
iscsi_update_cmdsn.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/iscsi_tcp.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git
From: Mike Christie [EMAIL PROTECTED]
Patch from vignesh babu [EMAIL PROTECTED]:
Replacing n (n - 1) for power of 2 check by is_power_of_2(n)
Signed-off-by: vignesh babu [EMAIL PROTECTED]
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/libiscsi.c |3 ++-
1 files changed, 2
From: Mike Christie [EMAIL PROTECTED]
If we negotiate for X r2ts we have to use only X r2ts. We cannot
round up (we could send less though). It is ok to fail if it
is not something the driver can handle, so this patch just does
that.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
From: FUJITA Tomonori [EMAIL PROTECTED]
Use open-iscsi.org instead of linux-iscsi.sf.net, which hasn't been
updated for ages.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/Kconfig |2 +-
1 files changed, 1 insertions(+), 1
From: Mike Christie [EMAIL PROTECTED]
from Boaz Harrosh:
- Check to see that OVERFLOW is not negative indicating
a bug.
- Unify handling of UNDERFLOW and OVERFLOW to the same
code.
- Also handle BIDI_OVERFLOW.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: Mike
From: Mike Christie [EMAIL PROTECTED]
from [EMAIL PROTECTED]:
iscsi_r2t_rsp checks the incoming R2T for sanity, and if it
thinks it's fishy, it will drop it silently. In this case, we
leaked an r2t_info object. If we do this often enough, we run
into a BUG_ON some time later.
Removed r2t
From: Mike Christie [EMAIL PROTECTED]
at libiscsi generic code
- currently code assumes a storage space of pdu header is allocated
at llds ctask and is pointed to by iscsi_cmd_task-hdr. Here I add
a hdr_max field pertaining to that storage, and an hdr_len that
accumulates the
From: Mike Christie [EMAIL PROTECTED]
from Boaz Harrosh [EMAIL PROTECTED]
- The default initialization of hdr_max is the minimum -
sizeof(struct iscsi_cmd) - Once this patch goes into iser the default
initialization at libiscsi can be removed.
- This is not yet full support for AHSs
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/openfc/openfc_scsi.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c
Don't deliver BLS frames to the fast path.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/libfc/fc_local_port.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ofc/libfc/fc_local_port.c
b/drivers/scsi/ofc/libfc/fc_local_port.c
index
fcoe_create() fails without destroying the kmem slab.
This causes the next create to panic.
The destroy should be done in openfc_put_dev.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/openfc/openfc_if.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff
If expecting pre-T11 frames, a T11 frame caused a data fault.
This is because the T11 frames have zeros where the old length/SOF
field was, and a length of less than the size of the FC header was
not checked for.
Also limit length error messages to frames (per-CPU actually).
Signed-off-by: Joe
[PATCH] Performance improvement, combine received data copy with CRC.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/openfc/openfc_scsi.c | 130 +++--
1 files changed, 90 insertions(+), 40 deletions(-)
diff --git
Don't use netdev for FCoE if pause is not correctly set, even for VLANs.
This modifies the previous tests to require that the underlying net-dev
supports the ethtool get_pauseparam operation.
NICs that are 10/100/1000 must have pause autonegotiation turned on.
All NICs must have RX and TX pause
Joe Eykholt wrote:
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Please disregard this patch. It got merged into the wrong function. A better
one is coming.
Joe
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/openfc/openfc_scsi.c |
On Thu, 29 Nov 2007 13:31:50 +0100
Anders Henke [EMAIL PROTECTED] wrote:
On November 28 2007, Anders Henke wrote:
As everything is reported as being zero is quite odd an Jan took a
guess that it might be block-layer or driver-related, I've assumed
that the driver is responsible for this;
On Tue, 4 Dec 2007 16:57:38 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 29 Nov 2007 13:31:50 +0100
Anders Henke [EMAIL PROTECTED] wrote:
On November 28 2007, Anders Henke wrote:
As everything is reported as being zero is quite odd an Jan took a
guess that it might be
On Wed, 05 Dec 2007 10:04:03 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 4 Dec 2007 16:57:38 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 29 Nov 2007 13:31:50 +0100
Anders Henke [EMAIL PROTECTED] wrote:
On November 28 2007, Anders Henke wrote:
As everything is
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
drivers/scsi/ofc/openfc/openfc_scsi.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c
On Tue, 4 Dec 2007 17:11:55 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Wed, 05 Dec 2007 10:04:03 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 4 Dec 2007 16:57:38 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 29 Nov 2007 13:31:50 +0100
Anders Henke [EMAIL
Don't deliver BLS frames to the fast path.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
usr/common/libfc/src/fc/fc_local_port.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/usr/common/libfc/src/fc/fc_local_port.c
b/usr/common/libfc/src/fc/fc_local_port.c
Change the default FCoE protocol version to the T11 standard-track one.
The old version can still be selected using 'fcconf ethX fcoe_version old'.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
usr/ofc/tools/fcconf/src/fcc_adapt.c |1 +
usr/ofc/tools/fcconf/src/fcc_eth.c |1 +
2
Change the default FCoE protocol version to the T11 (Aug. 2007) version.
Use environment to override: export FCOE_OLD_ALL=1 to use the old protocol
on all interfaces, or FCOE_OLD_eth0=1 to use it on eth0.
Signed-off-by: Joe Eykholt [EMAIL PROTECTED]
---
usr/common/libfc/src/encaps/fcoe.c |
On Wed, 05 Dec 2007 10:30:54 +0900 FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 4 Dec 2007 17:11:55 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Wed, 05 Dec 2007 10:04:03 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 4 Dec 2007 16:57:38 -0800
Andrew Morton [EMAIL
Convert SG from nopage to fault.
Signed-off-by: Nick Piggin [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Cc: linux-scsi@vger.kernel.org
Cc: [EMAIL PROTECTED]
---
drivers/scsi/sg.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
Index: linux-2.6/drivers/scsi/sg.c
67 matches
Mail list logo
