[PATCH] Undo __scsi_kill_request()

2007-12-06 Thread Hannes Reinecke
Hi all, the main goal of using FAILFAST is to have requests terminated early if the link to the target is lost. This is indicated by the device state SDEV_BLOCK. So we only have to check for the FAILFAST flag when we check the queue state in scsi_prep_fn(). This patch reverts parts of the

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Boaz Harrosh
On Thu, Dec 06 2007 at 2:26 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi Boaz, On Tue, 04 Dec 2007 15:39:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts bidi of scsi mid-layer to use

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-12-06 Thread Swen Schillig
On Monday 26 November 2007 11:23, Swen Schillig wrote: On Sunday 25 November 2007 12:16, James Bottomley wrote: On Wed, 2007-10-31 at 11:33 +0100, Swen Schillig wrote: From: Swen Schillig [EMAIL PROTECTED] add some statistics provided by the zFCP adapter to the sysfs The new

Re: 2.6.24-rc4-mm1: hostbyte=0x01 driverbyte=0x00 (now bisected)

2007-12-06 Thread Jens Axboe
On Thu, Dec 06 2007, Hannes Reinecke wrote: Alexey Dobriyan wrote: git-scsi-misc.patch Apologies for not looking into the problem earlier. See http://marc.info/?t=11962802235r=1w=2 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O error for previous

[PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-06 Thread Denis Cheng
single list_head variable initialized with LIST_HEAD_INIT could almost always can be replaced with LIST_HEAD declaration, this shrinks the code and looks better. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/scsi/ipr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-06 Thread Brian King
Darrick J. Wong wrote: In general, I agree that sas-ata should adopt the new EH. Unfortunately, I believe the old way of sas-ata configuring ATA ports is somehow not compatible with the new EH stuff and causes a crash during the device probe with my patch to move sas-ata to the new EH. If I

Re: [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-06 Thread Brian King
Acked-by: Brian King [EMAIL PROTECTED] Denis Cheng wrote: single list_head variable initialized with LIST_HEAD_INIT could almost always can be replaced with LIST_HEAD declaration, this shrinks the code and looks better. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/scsi/ipr.c

Re: BUG 2.6.24-rc4-mm1 -- Boot still hangs w/ async scsi scan

2007-12-06 Thread Lee Schermerhorn
On Wed, 2007-12-05 at 13:20 -0800, Andrew Morton wrote: On Wed, 05 Dec 2007 11:36:39 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: As reported here: http://marc.info/?l=linux-scsim=119645761124683w=4 against 24-rc3-mm2, I'm still seeing the hang on my HP ia64 NUMA platform

Re: BUG 2.6.24-rc4-mm1 -- Boot still hangs w/ async scsi scan

2007-12-06 Thread Andrew Morton
On Thu, 06 Dec 2007 13:14:22 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: On Wed, 2007-12-05 at 13:20 -0800, Andrew Morton wrote: On Wed, 05 Dec 2007 11:36:39 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: As reported here:

Re: BUG 2.6.24-rc4-mm1 -- Boot still hangs w/ async scsi scan

2007-12-06 Thread Lee Schermerhorn
On Thu, 2007-12-06 at 10:35 -0800, Andrew Morton wrote: On Thu, 06 Dec 2007 13:14:22 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: On Wed, 2007-12-05 at 13:20 -0800, Andrew Morton wrote: On Wed, 05 Dec 2007 11:36:39 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: As reported

Re: 2.6.24-rc4-mm1: hostbyte=0x01 driverbyte=0x00 (now bisected)

2007-12-06 Thread Alexey Dobriyan
On Thu, Dec 06, 2007 at 08:52:29AM +0100, Hannes Reinecke wrote: Alexey Dobriyan wrote: git-scsi-misc.patch Apologies for not looking into the problem earlier. See http://marc.info/?t=11962802235r=1w=2 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Kiyoshi Ueda
Hi Boaz, Jens, On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c === --- 2.6.24-rc3-mm2.orig/drivers/scsi/scsi_lib.c +++

Re: Patch submission question [not in the FAQ]

2007-12-06 Thread adam radford
On Dec 5, 2007 3:36 AM, Gabriele Gorla [EMAIL PROTECTED] wrote: Hello, I have submitted a patch for the 3x- driver on alpha several months ago to both the driver maintainer and the linux-scsi mailing list. I have read all the FAQ and I tried to stick to the instructions to the letter.

Re: [PATCH] Reduce stack used by lib/hexdump.c

2007-12-06 Thread Joe Perches
On Wed, 2007-12-05 at 16:01 -0800, Andrew Morton wrote: No, I think print_hex_dump() is too low-level to be doing allocations. For example, one could easily choose to call print_hex_dump() at oops time, and then what happens if we oops in kmalloc() (as we often do...)? You could trim

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-06 Thread Andrew Morton
On Thu, 6 Dec 2007 18:16:12 -0600 (CST) [EMAIL PROTECTED] (Bob Tracy) wrote: OK. Finally have this thing painted into a corner: git has identified 6f37ac793d6ba7b35d338f791974166f67fdd9ba as the first bad commit. From git bisect log, this corresponds to # bad:

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-06 Thread Rafael J. Wysocki
On Friday, 7 of December 2007, Bob Tracy wrote: OK. Finally have this thing painted into a corner: git has identified 6f37ac793d6ba7b35d338f791974166f67fdd9ba as the first bad commit. From git bisect log, this corresponds to # bad: [6f37ac793d6ba7b35d338f791974166f67fdd9ba] Merge branch

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-06 Thread Bob Tracy
OK. Finally have this thing painted into a corner: git has identified 6f37ac793d6ba7b35d338f791974166f67fdd9ba as the first bad commit. From git bisect log, this corresponds to # bad: [6f37ac793d6ba7b35d338f791974166f67fdd9ba] Merge branch 'master' of

Re: [OpenFCoE PATCH] [PATCH] Performance improvement, combine received data copy with CRC.

2007-12-06 Thread Joe Eykholt
Rob Love wrote: Joe Eykholt wrote: [PATCH] Performance improvement, combine received data copy with CRC. Shouldn't we remove openfc_cp_to_user() if we're moving that functionality into openfc_scsi_recv_data()? Yes. That was an oversight. I did intend to remove it. Do you want a new

Re: [OpenFCoE PATCH] [PATCH] Performance improvement, combine received data copy with CRC.

2007-12-06 Thread Rob Love
Joe Eykholt wrote: [PATCH] Performance improvement, combine received data copy with CRC. Shouldn't we remove openfc_cp_to_user() if we're moving that functionality into openfc_scsi_recv_data()? I don't see anything calling it anymore. My guess is that your leaving it in there for future

Re: everything in wait_for_completion, what is my system doing?

2007-12-06 Thread Andrew Morton
On Wed, 5 Dec 2007 21:44:54 +0100 Bernd Schubert [EMAIL PROTECTED] wrote: after scsi-recovery a system here went into some kind lock-up, everything seems to be in wait_for_completion(). Please see the attached blocked_states.txt and all_states.txt files. This is 2.6.22.12, I can easily find

[PATCH 2.6.23] 3w-xxxx: Fix bad unaligned accesses on alpha SMP

2007-12-06 Thread Gabriele Gorla
disable packing of the TAG_TW_Device_Extension structure to prevent kernel unaligned accesses when accessing the spinlock inside the ioctl_wqueue structure. Fixes smartmontools kernel panic on alpha SMP Signed-off-by: Gabriele Gorla [EMAIL PROTECTED] --- --- linux-2.6.23/drivers/scsi/3w-.h

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-06 Thread Bob Tracy
Andrew Morton wrote: commit 6f37ac793d6ba7b35d338f791974166f67fdd9ba Merge: 2f1f53b... d90bf5a... Author: Linus Torvalds [EMAIL PROTECTED] Date: Wed Nov 14 18:51:48 2007 -0800 Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/n * 'master' of

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-06 Thread Bob Tracy
I wrote: If the implicated commit is the next one in time sequence relative to # good: [2f1f53bdc6531696934f6ee7bbdfa2ab4f4f62a3] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better then the test of whether I bisected correctly is as simple as applying the commit and seeing if