Re: MPTSAS Driver and scatter gather lists

2007-12-11 Thread Zhao Forrest
Steve, Do you use a 10k RPM SAS hard drive? Could you share that what test tools(or test cases) are you using to do the block IO test? We have a LSI SAS1068E chip and 10k RPM SAS hard drive in our lab. I'll find some time to reproduce the issue and do some investigation. Thanks, Forrest On

Re: MPTSAS Driver and scatter gather lists

2007-12-11 Thread Steven Pratt
Zhao Forrest wrote: Steve, Do you use a 10k RPM SAS hard drive? Could you share that what test tools(or test cases) are you using to do the block IO test? We have a LSI SAS1068E chip and 10k RPM SAS hard drive in our lab. I'll find some time to reproduce the issue and do some investigation.

Re: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry in directory) (fwd)

2007-12-11 Thread Miquel van Smoorenburg
On Fri, 2007-11-30 at 11:34 +0100, Anders Henke wrote: Am 30.11.2007 schrieb FUJITA Tomonori: According to the 2.6.23-rc1 short-form changelog, there is one major edit on the dpt_i2o driver: FUJITA Tomonori [SCSI] dpt_i2o: convert to use the data buffer

Re: MPTSAS Driver and scatter gather lists

2007-12-11 Thread Steven Pratt
Zhao Forrest wrote: Steve, Do you use a 10k RPM SAS hard drive? Could you share that what test tools(or test cases) are you using to do the block IO test? We have a LSI SAS1068E chip and 10k RPM SAS hard drive in our lab. I'll find some time to reproduce the issue and do some investigation.

RE: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry indirectory) (fwd)

2007-12-11 Thread Salyzyn, Mark
Miquel van Smoorenburg sez: I got the 64-bit dpt_i2o driver from Adaptec some time ago, and I have added 64-bit support to the 2.6.23.1 dpt_i2o driver based on that driver. I intended to submit it for 2.6.25 or so ... if I have some time later today or tomorrow I'll try that next to see if

Re: FC-LTO4 tape drive: Sense Key : Illegal Request

2007-12-11 Thread Douglas Gilbert
Sven Rudolph wrote: Hello, I have a strange problem with writing to a fiberchannel LTO-4 tape drive. First my environment: From /proc/scsi/scsi: Host: scsi8 Channel: 00 Id: 00 Lun: 00 Vendor: IBM Model: ULTRIUM-TD4 Rev: 74H4 Type: Sequential-Access

Re: 2.6.24-rc3-mm1

2007-12-11 Thread James Bottomley
On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote: OK, thanks. I'll assume that James and Hannes have this in hand (or will have, by mid-week) and I won't do anything here. Just to confirm what I think I'm going to be doing: rebasing the scsi-misc tree to remove this commit: commit

Re: BUG 2.6.24-rc4-mm1 -- Boot still hangs w/ async scsi scan

2007-12-11 Thread Lee Schermerhorn
On Thu, 2007-12-06 at 14:01 -0500, Lee Schermerhorn wrote: On Thu, 2007-12-06 at 10:35 -0800, Andrew Morton wrote: On Thu, 06 Dec 2007 13:14:22 -0500 Lee Schermerhorn [EMAIL PROTECTED] wrote: On Wed, 2007-12-05 at 13:20 -0800, Andrew Morton wrote: On Wed, 05 Dec 2007 11:36:39 -0500

Re: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry in directory) (fwd)

2007-12-11 Thread Miquel van Smoorenburg
On Tue, 2007-12-11 at 15:40 +0100, Miquel van Smoorenburg wrote: I just noticed the same bug when I tried to update a 2.6.18 server to 2.6.23.9 .. also tried 2.6.24-rc4. The symptom I'm seeing is that init segfaults, or can't be found .. anyway, driver/fs errors. In the kernel config, under

scsi/lpfc/lpfc_attr.c: bogus code

2007-12-11 Thread Adrian Bunk
Commit 2e0fef85e098f6794956b8b80b79fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code: -- snip -- ... lpfc_state_show(struct class_device *cdev, char *buf) { ... switch (vport-port_state) {

Re: FC-LTO4 tape drive: Sense Key : Illegal Request

2007-12-11 Thread James Smart
This sounds like the recent lpfc bug found on the LTO-3 or LTO-4. The lpfc driver had messed up tag handling (a long time bug). The patch was posted at http://marc.info/?l=linux-scsim=119367024313743w=2 and has been pulled into scsi-rc-fixes, and I believe will be in 2.6.24. Try this, and if it

[2.6 patch] scsi/megaraid.c: __devexit annotation

2007-12-11 Thread Adrian Bunk
megaraid_remove_one() can become __devexit. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- b7d71f38d1c1aa66311e862b58f36aa34c888f98 diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 66c6520..765c24d 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@

[2.6 patch] drivers/scsi/advansys.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'exit_this_scsi_driver') ... -- snip -- Signed-off-by: Adrian Bunk

[2.6 patch] drivers/scsi/aic94xx/ section fixes

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.init.text.20+0xb3061): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'ips_insert_device') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] scsi/aic94xx/: cleanups

2007-12-11 Thread Adrian Bunk
On Mon, Nov 05, 2007 at 11:43:35AM -0800, Darrick J. Wong wrote: On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote: This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline - make needlessly global code static - #if 0 unused code

Re: [2.6 patch] drivers/scsi/advansys.c section fix

2007-12-11 Thread Randy Dunlap
On Tue, 11 Dec 2007 23:23:53 +0100 Adrian Bunk wrote: This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and

[PATCH 01/30] blk_end_request: add new request completion interface (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch adds 2 new interfaces for request completion: o blk_end_request() : called without queue lock o __blk_end_request() : called with queue lock held blk_end_request takes 'error' as an argument instead of 'uptodate', which current end_that_request_* take. The meanings of values are

[PATCH 02/30] blk_end_request: add/export functions to get request size (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch adds/exports functions to get the size of request in bytes. They are useful because blk_end_request interfaces take bytes as a completed I/O size instead of sectors. Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- block/ll_rw_blk.c

[PATCH 00/30] blk_end_request: full I/O completion handler (take 4)

2007-12-11 Thread Kiyoshi Ueda
Hi Jens, Boaz, The following is the updated patch-set for blk_end_request(). I have done some interface/implementation changes based on feedbacks/discussions since the previous version. (Although this patch-set was made on top of 2.6.24-rc4, I confirmed it can be applied to 2.6.24-rc5, too.

[PATCH 04/30] blk_end_request: changing arm (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts arm's OMAP mailbox driver to use blk_end_request interfaces. If the original code was converted literally, blk_end_request would be called with '-EIO' because end_that_request_last() were called with '0' (i.e. failure). But I think these '0's are bugs in the original code

[PATCH 03/30] blk_end_request: changing block layer core (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts core parts of block layer to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. 'dequeue' argument was originally introduced for end_dequeued_request(), where no attempt should be made to dequeue the request as it's already dequeued.

[PATCH 07/30] blk_end_request: changing floppy (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts floppy to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, floppy_end_request(), is changed. Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]

[PATCH 05/30] blk_end_request: changing um (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts um to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, ubd_end_request(), is changed. Cc: Jeff Dike [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi

[PATCH 06/30] blk_end_request: changing DAC960 (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts DAC960 to use blk_end_request interfaces. Related 'UpToDate' arguments are converted to 'Error'. Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/DAC960.c | 11 ++- 1 files changed, 2 insertions(+), 9

[PATCH 08/30] blk_end_request: changing nbd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts nbd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Paul Clements [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/nbd.c |8 +++- 1 files

[PATCH 10/30] blk_end_request: changing sunvdc (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts sunvdc to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, vdc_end_request(), is changed. Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by:

[PATCH 09/30] blk_end_request: changing ps3disk (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ps3disk to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Geoff Levand [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] ---

[PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ub to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Pete Zaitcev [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/ub.c | 10 +- 1 files

[PATCH 11/30] blk_end_request: changing sx8 (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts sx8 to use blk_end_request interfaces. Related 'uptodate' and 'is_ok' arguments are converted to 'error'. As a result, the interfaces of internal functions below are changed. o carm_end_request_queued o carm_end_rq o carm_handle_array_info o carm_handle_scan_chan o

[PATCH 13/30] blk_end_request: changing viodasd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts viodasd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viodasd_end_request(), is changed. Cc: Stephen Rothwell [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]

[PATCH 16/30] blk_end_request: changing i2o_block (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts i2o_block to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, i2o_block_end_request(), is changed. Cc: Markus Lidel [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]

[PATCH 14/30] blk_end_request: changing xen-blkfront (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts xen-blkfront to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Jeremy Fitzhardinge [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/xen-blkfront.c |

[PATCH 15/30] blk_end_request: changing viocd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts viocd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viocd_end_request(), is changed. Cc: Stephen Rothwell [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]

[PATCH 18/30] blk_end_request: changing s390 (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts s390 to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interfaces of internal functions below are changed: o dasd_end_request o tapeblock_end_request Cc: Martin Schwidefsky [EMAIL PROTECTED] Cc: Heiko Carstens

[PATCH 19/30] blk_end_request: changing ide-scsi (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ide-scsi to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c |8

[PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts cciss to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. cciss is a little bit different from normal drivers. cciss directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with

[PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts xsysace to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. xsysace is a little bit different from normal drivers. xsysace driver has a state machine in it. It calls end_that_request_first() and end_that_request_last() from different

[PATCH 23/30] blk_end_request: changing ide normal caller (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts normal parts of ide to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. The conversion of 'uptodate' to 'error' is done only for the internal function, __ide_end_request(). ide_end_request() was not changed since it's exported and used by

[PATCH 24/30] blk_end_request: add callback feature (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch adds a variant of the interface, blk_end_request_callback(), which has driver callback feature. Drivers may need to do special works between end_that_request_first() and end_that_request_last(). For such drivers, blk_end_request_callback() allows it to pass a callback function which is

[PATCH 22/30] blk_end_request: changing cpqarray (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts cpqarray to use blk_end_request interfaces. Related 'ok' arguments are converted to 'error'. cpqarray is a little bit different from normal drivers. cpqarray directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with

[PATCH 25/30] blk_end_request: changing ide-cd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. In PIO mode, ide-cd (cdrom_newpc_intr()) needs to defer end_that_request_last() until the device clears DRQ_STAT and raises an interrupt after

[PATCH 26/30] blk_end_request: add bidi completion interface (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch adds a variant of the interface, blk_end_bidi_request(), which completes a bidi request. Bidi request must be completed as a whole, both rq and rq-next_rq at once. So the interface has 2 arguments for completion size. As for -end_io, only rq-end_io is called (rq-next_rq-end_io is not

[PATCH 27/30] blk_end_request: changing scsi (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts scsi mid-layer to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, scsi_end_request(), is changed. Cc: James Bottomley [EMAIL PROTECTED] Cc: Boaz Harrosh [EMAIL PROTECTED] Signed-off-by:

[PATCH 28/30] blk_end_request: remove/unexport end_that_request_* (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch removes the following functions: o end_that_request_first() o end_that_request_chunk() and stops exporting the functions below: o end_that_request_last() Cc: Boaz Harrosh [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL

[PATCH 30/30] blk_end_request: cleanup of request completion (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch merges complete_request() into end_that_request_last() for cleanup. complete_request() was introduced by earlier part of this patch-set, not to break the existing users of end_that_request_last(). Since all users are converted to blk_end_request interfaces and end_that_request_last()

[PATCH 29/30] blk_end_request: cleanup 'uptodate' related code (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts 'uptodate' arguments of no longer exported interfaces, end_that_request_first/last, to 'error', and removes internal conversions for it in blk_end_request interfaces. Also, this patch removes no longer needed end_io_error(). Cc: Boaz Harrosh [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-11 Thread Grant Likely
On 12/11/07, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts xsysace to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. xsysace is a little bit different from normal drivers. xsysace driver has a state machine in it. It calls

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Pete Zaitcev
On Tue, 11 Dec 2007 17:46:47 -0500 (EST), Kiyoshi Ueda [EMAIL PROTECTED] wrote: if (scsi_status == 0) { - uptodate = 1; + error = 0; } else { - uptodate = 0; + error = -EIO; rq-errors = scsi_status; } -

Re: [PATCH acs_ame scsi driver 000 of 1] Introduction

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 17:01:48 -0800 Andrew Morton [EMAIL PROTECTED] wrote: More hm. It was from [EMAIL PROTECTED] which perhaps means that some attempt to recall it was made. Oh well. argh. [EMAIL PROTECTED] really is our Jeff's email address. And I went and cc'ed [EMAIL PROTECTED] on my

fix cciss locking bug.

2007-12-11 Thread Dave Jones
do_cciss_intr takes the controller lock on entry, and if something goes wrong, it calls fail_all_cmds which tries to take the same lock. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 7d70496..1c57583 100644 ---

[PATCH][SCSI] resend: hptiop: add more adapter models and other fixes

2007-12-11 Thread HighPoint Linux Team
this patch is against 2.6.24-rc4-mm1. last one was made agaist 2.6.24-rc5 so it does not compile in the -mm tree. Most code changes were made to support adapters based on Marvell IOP, plus some other fixes. - add more PCI device IDs - support for adapters based on Marvell IOP - fix a result