Re: [PATCH 0/5] sg_ring for scsi

2007-12-27 Thread Rusty Russell
On Thursday 27 December 2007 13:09:27 FUJITA Tomonori wrote: On Wed, 26 Dec 2007 11:27:40 +1100 Rusty Russell [EMAIL PROTECTED] wrote: There are many signs through the code that it needs a great deal of work: what is the purpose of sg_break? Why does the code check if kmap_atomic fails?

RE: [PATCH 1/3] cciss: export more attributes to sysfs (repost)

2007-12-27 Thread Miller, Mike (OS Dev)
Mike, what's going on? I definitely told you last time I looked at this patch that it is a bug to call sysfs_remove_group() under spinlock, because sysfs_remove_group() takes sleeping locks. Yet here it is again. Maybe you lost my email. It is here: http://lkml.org/lkml/2007/11/20/77

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-27 Thread FUJITA Tomonori
On Thu, 27 Dec 2007 11:15:37 +0530 Balbir Singh [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Thu, 27 Dec 2007 10:08:25 +0530 Balbir Singh [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh [EMAIL PROTECTED] wrote: [snip] I

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-27 Thread FUJITA Tomonori
On Fri, 28 Dec 2007 13:05:39 +0530 Balbir Singh [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: [snip] Thanks, Can you try this? diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c index e7d8544..495575a 100644 --- a/lib/iommu-helper.c +++ b/lib/iommu-helper.c @@ -8,15