[PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
This is the second version of http://marc.info/?l=linux-scsim=119933628210006w=2 I gave up once, but I found that the performance loss is negligible (within 1%) by using kmem_cache_alloc instead of mempool. I use scsi_debug with fake_rw=1 and disktest (DIO reads with 8 threads) again:

Re: [RFC] A SCSI fault injection framework using SystemTap.

2008-01-15 Thread K.Tanaka
Matthew Wilcox wrote: On Tue, Jan 15, 2008 at 12:04:09PM +0900, K.Tanaka wrote: I would like to introduce a SCSI fault injection framework using SystemTap. Currently, kernel has Fault-injection framework and Faulty mode for md, which can also be used for testing the error handling. But, they

Re: [dm-devel] [RFC] A SCSI fault injection framework using SystemTap.

2008-01-15 Thread Alasdair G Kergon
On Tue, Jan 15, 2008 at 12:04:09PM +0900, K.Tanaka wrote: -dm-mirror's redundancy doesn't work. A read error from the disk consisting the array will be directory passed to the userspace, without reading from the other mirror. (It turns out that this issue is a known issue, but the

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread Boaz Harrosh
On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: This is the second version of http://marc.info/?l=linux-scsim=119933628210006w=2 I gave up once, but I found that the performance loss is negligible (within 1%) by using kmem_cache_alloc instead of mempool. I

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread James Bottomley
On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote: This is the second version of http://marc.info/?l=linux-scsim=119933628210006w=2 I gave up once, but I found that the performance loss is negligible (within 1%) by using kmem_cache_alloc instead of mempool. I use scsi_debug with

Re: INITIO scsi driver fails to work properly

2008-01-15 Thread James Bottomley
On Sun, 2008-01-13 at 14:28 +0200, Filippos Papadopoulos wrote: On 1/11/08, James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-11 at 18:44 +0200, Filippos Papadopoulos wrote: On Jan 11, 2008 5:44 PM, James Bottomley [EMAIL PROTECTED] wrote: I havent reported initio: I/O

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 15:56:56 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: This is the second version of http://marc.info/?l=linux-scsim=119933628210006w=2 I gave up once, but I found that the performance loss

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread Boaz Harrosh
On Tue, Jan 15 2008 at 17:08 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Tue, 15 Jan 2008 15:56:56 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: This is the second version of

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread Boaz Harrosh
On Tue, Jan 15 2008 at 17:20 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote: This is the second version of http://marc.info/?l=linux-scsim=119933628210006w=2 I gave up once, but I found that the performance loss is negligible (within

Actually using the sg table/chain code

2008-01-15 Thread James Bottomley
I thought, now we had this new shiny code to increase the scatterlist table size I'd try it out. It turns out there's a pretty vast block conspiracy that prevents us going over 128 entries in a scatterlist. The first problems are in SCSI: The host parameters sg_tablesize and max_sectors are

Re: Actually using the sg table/chain code

2008-01-15 Thread Boaz Harrosh
On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED] wrote: I thought, now we had this new shiny code to increase the scatterlist table size I'd try it out. It turns out there's a pretty vast block conspiracy that prevents us going over 128 entries in a scatterlist. The

Re: MPT Fusion initialization in 2.6.23.12

2008-01-15 Thread Karen Shaeffer
Hi Eric and Grant, These messages, all 15 of them only appear during the boot sequence. I never see them at any other time. The messages are in dmesg and syslog. This is a Sun X4200 M2 Netra server. The LSI SAS1064 RAID enabled Ultra320 SCSI controller supports RAID0, RAID1, and RAID1E modes.

Re: Actually using the sg table/chain code

2008-01-15 Thread James Bottomley
On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote: On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED] wrote: I thought, now we had this new shiny code to increase the scatterlist table size I'd try it out. It turns out there's a pretty vast block conspiracy that

Re: MPT Fusion initialization in 2.6.23.12

2008-01-15 Thread Grant Grundler
On Jan 15, 2008 8:37 AM, Karen Shaeffer [EMAIL PROTECTED] wrote: Hi Eric and Grant, These messages, all 15 of them only appear during the boot sequence. I never see them at any other time. The messages are in dmesg and syslog. This is a Sun X4200 M2 Netra server. The LSI SAS1064 RAID enabled

Re: Actually using the sg table/chain code

2008-01-15 Thread Boaz Harrosh
On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote: On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED] wrote: I thought, now we had this new shiny code to increase the scatterlist table size

[PATCH] remove use_sg_chaining

2008-01-15 Thread James Bottomley
this patch depends on the sg branch of the block tree James --- From: James Bottomley [EMAIL PROTECTED] Date: Tue, 15 Jan 2008 11:11:46 -0600 Subject: remove use_sg_chaining With the sg table code, every SCSI driver is now either chain capable or broken, so there's no need to have a check in

Re: Actually using the sg table/chain code

2008-01-15 Thread Jeff Garzik
James Bottomley wrote: if (BLK_DEF_MAX_SECTORS max_sectors) q-max_hw_sectors = q-max_sectors = max_sectors; else { q-max_sectors = BLK_DEF_MAX_SECTORS; q-max_hw_sectors = max_sectors; } } So it imposes a maximum possible

[PATCH] firewire: fw-sbp2: prepare for s/g chaining

2008-01-15 Thread Stefan Richter
Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Replacement of patch firewire: fw-sbp2: enable s/g chaining. It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk to prevent conflicts when James is going to remove .use_sg_chaining. drivers/firewire/fw-sbp2.c |7 ---

SCSI power management for AHCI

2008-01-15 Thread Pavel Machek
Hi! This is my first attempt at ahci autosuspend. It is _very_ hacky at this moment, I'll seriously need to clean it up. But it seems to work here. It includes Alan Stern's patches. I guess I could/should produce separate version.

[PATCH] ieee1394: sbp2: prepare for s/g chaining

2008-01-15 Thread Stefan Richter
Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Replacement of patch ieee1394: sbp2: enable s/g chaining. It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk to prevent conflicts when James is going to remove .use_sg_chaining. drivers/ieee1394/sbp2.c |3 ++- 1 file

Re: Actually using the sg table/chain code

2008-01-15 Thread James Bottomley
On Tue, 2008-01-15 at 14:52 -0500, Jeff Garzik wrote: James Bottomley wrote: if (BLK_DEF_MAX_SECTORS max_sectors) q-max_hw_sectors = q-max_sectors = max_sectors; else { q-max_sectors = BLK_DEF_MAX_SECTORS; q-max_hw_sectors = max_sectors;

Re: [PATCH] ieee1394: sbp2: prepare for s/g chaining

2008-01-15 Thread Stefan Richter
Stefan Richter wrote: drivers/firewire/fw-sbp2.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) drivers/ieee1394/sbp2.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Never mind the diffstats. I forgot to refresh them. -- Stefan Richter -=-==--- ---=

Re: [Bugme-new] [Bug 9752] New: getting FAULT code message at startup in mpt fusion scsi driver

2008-01-15 Thread Andrew Morton
On Tue, 15 Jan 2008 06:30:11 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9752 Summary: getting FAULT code message at startup in mpt fusion scsi driver Product: SCSI Drivers Version: 2.5

RE: [Bugme-new] [Bug 9752] New: getting FAULT code message at startup in mpt fusion scsi driver

2008-01-15 Thread Moore, Eric
On Tuesday, January 15, 2008 1:37 PM, Andrew Morton wrote: On blade startup we're seeing the following message: Fusion MPT base driver 3.02.55 Copyright (c) 1999-2005 LSI Logic Corporation Fusion MPT SAS Host driver 3.02.55 mptbase: Initiating ioc0 bringup mptbase: ioc0: WARNING -

Re: Open-FCoE on linux-scsi

2008-01-15 Thread James Smart
Love, Robert W wrote: The interconnect layer could be split further: SCSI command set layer -- SCSI core -- SCSI transport layer (FCP) -- Fibre Channel core -- Fibre Channel card drivers, FCoE drivers. This is how I see the comparison. ('/' indicates 'or') You suggest

Re: [PATCH 5/7] scsi : use class iteration api

2008-01-15 Thread Dave Young
update the patch with minor return path changes in match function: Convert to use the class iteration api. Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/scsi/hosts.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff -upr

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 17:44:14 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: If __scsi_put_command puts a command to shost-free_list, it doesn't free scmd-sense_buffer since it's the sense_buffer for the backup sense_buffer. If __scsi_put_command puts a command to shost-cmd_pool-slab (if

[PATCH v3] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
This is the third version of: http://marc.info/?l=linux-scsim=120038907123706w=2 The changes from the second version are: - Fixed the memory leak bug that Boaz pointed out. shots-backup_sense_buffer has gone. One sense buffer is allocated per host and it's always attached to the scsi_cmnd

Re: INITIO scsi driver fails to work properly

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 09:16:06 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Sun, 2008-01-13 at 14:28 +0200, Filippos Papadopoulos wrote: On 1/11/08, James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-11 at 18:44 +0200, Filippos Papadopoulos wrote: On Jan 11, 2008 5:44 PM,