Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-08 Thread Geert Uytterhoeven
On Thu, 7 Feb 2008, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: Quite a bit of this is fixing things broken previously (the advansys fix is still pending resolution, but I'll send it as an -rc

Re: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-08 Thread Jens Axboe
On Fri, Feb 08 2008, S, Chandrakala (STSD) wrote: Hi, Thanks for the information! We would like to know when does the 2.6.25 kernel will be available at kernel.org. So would I, if I locate my crystal ball I'll be sure to let you know :-) Seriously, given past experience, it's probably

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Vladislav Bolkhovitin
[EMAIL PROTECTED] wrote: On Thu, 7 Feb 2008, Vladislav Bolkhovitin wrote: Bart Van Assche wrote: - It has been discussed which iSCSI target implementation should be in the mainstream Linux kernel. There is no agreement on this subject yet. The short-term options are as follows: 1) Do not

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Vladislav Bolkhovitin
Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? What do you mean? To call directly low level backstorage SCSI drivers queuecommand() routine? What are advantages of it?

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Nicholas A. Bellinger
On Thu, 2008-02-07 at 12:37 -0800, Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? Luben Hi Luben, I am guessing you mean futher down the stack, which I don't know

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Nicholas A. Bellinger
On Thu, 2008-02-07 at 14:51 -0800, [EMAIL PROTECTED] wrote: On Thu, 7 Feb 2008, Vladislav Bolkhovitin wrote: Bart Van Assche wrote: - It has been discussed which iSCSI target implementation should be in the mainstream Linux kernel. There is no agreement on this subject yet. The

[PATCH 3/3] mpt fusion: Avoid racing when mptsas and mptcl module are loaded in parallel

2008-02-08 Thread Prakash, Sathya
This patch sets the IOC pointer in drvrdata of pcidev before adding the IOC into the list of IOCs. Without this patch the driver oops when the mptsas and mptctl modules are loaded in parallel. signed-off-by: Sathya Prakash [EMAIL PROTECTED] --- diff --git a/drivers/message/fusion/mptbase.c

[Bug 9769] CONFIG_SCSI_WAIT_SCAN configure error

2008-02-08 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9769 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |REJECTED Resolution|

[PATCH] megaraid: outb_p extermination

2008-02-08 Thread Alan Cox
From conversations with the maintainers the _p isn't needed so kill it. That removes the last non ISA _p user from the SCSI layer to my knowledge. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 15:32 +, Alan Cox wrote: The word illegal has a precise dictionary meaning of prohibited by law. The error messages are therefore incorrect as so far nobody has made SCSI violations a criminal offence. Um, I'm really reluctant to do this without an incredibly good

[PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread Alan Cox
The word illegal has a precise dictionary meaning of prohibited by law. The error messages are therefore incorrect as so far nobody has made SCSI violations a criminal offence. This corrects scsi to match various other subsystems I've slowly been ridding of this. Pedantically-signed-off-by:

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-08 Thread Alan Stern
On Tue, 5 Feb 2008, Matthew Dharm wrote: We both agree that the code shouldn't run off the end of the s-g list. Incidentally, if people want a simple bugfix patch for 2.6.24.stable, this should do it. Mark, can you confirm that this patch alone fixes the problem? Alan Stern Index:

RE: [PATCH 3/3] mpt fusion: Avoid racing when mptsas and mptclmodule are loaded in parallel

2008-02-08 Thread Prakash, Sathya
James, I tried to submit set of three patches, the other two patches are not showing in the list yet, I don't know the reason, I have resent them again few minutes back. Thanks Sathya -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Friday, February 08, 2008

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread Mark Hounschell
linux-os (Dick Johnson) wrote: The correct word should be invalid, in spite of the fact that the SCSI committee used invalid syntax. Alan is right. There is nothing illegal in the kernel and if there is, it must be removed as soon as it is discovered! il·le·gal (-lgl) adj. 1.

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: On Thu, 7 Feb 2008, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: Quite a bit of this is fixing things broken previously (the advansys

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 15:59 +, Alan Cox wrote: http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf By a simple text search. I don't think the pedantry is worth the confusion ... Ok so we should file a formal change request with T10 instead perhaps ? As long as that we is royal,

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Vladislav Bolkhovitin
Nicholas A. Bellinger wrote: On Thu, 2008-02-07 at 12:37 -0800, Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? Luben Hi Luben, I am guessing you mean futher down

[PATCH 1/3] mpt fusion: Request I/O resources only when required

2008-02-08 Thread Prakash, Sathya
This patch modifies the I/O resource allocation behavior of FUSION driver. The current version of driver allocates the I/O resources even if they are not required and this creates trouble in low resource environments. This driver now uses pci_enable_device_mem/pci_enable_device functions to

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread linux-os (Dick Johnson)
The correct word should be invalid, in spite of the fact that the SCSI committee used invalid syntax. Alan is right. There is nothing illegal in the kernel and if there is, it must be removed as soon as it is discovered! On Fri, 8 Feb 2008, James Bottomley wrote: On Fri, 2008-02-08 at

[PATCH 1/1] aacraid: ignore adapter reset check polarity

2008-02-08 Thread Salyzyn, Mark
The Adapter's Ignore Reset flag and insmod parameter boolean polarity is incorrect in the driver. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn [EMAIL

[PATCH 1/1] aacraid: informational sysfs value corrections

2008-02-08 Thread Salyzyn, Mark
Some sysfs problems reported. The serial number on late model controllers was truncated. Non-DASD devices (tapes and CDROMs) were showing up as JBOD in the level report on the physical channel. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my

Re: [PATCH 1/3] mpt fusion: Request I/O resources only when required

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 22:05 +0530, Prakash, Sathya wrote: This patch modifies the I/O resource allocation behavior of FUSION driver. The current version of driver allocates the I/O resources even if they are not required and this creates trouble in low resource environments. This driver now

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-08 Thread Jens Axboe
On Fri, Feb 08 2008, Jeff Garzik wrote: Jeff Garzik wrote: Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some modifications.

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-08 Thread Mark Glines
On Fri, 8 Feb 2008 11:46:13 -0500 (EST) Alan Stern [EMAIL PROTECTED] wrote: On Tue, 5 Feb 2008, Matthew Dharm wrote: We both agree that the code shouldn't run off the end of the s-g list. Incidentally, if people want a simple bugfix patch for 2.6.24.stable, this should do it. Mark,

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-08 Thread Jeff Garzik
Jeff Garzik wrote: Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some modifications. Please read the following thread for more

Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scsi_add_device if bus generation changed

2008-02-08 Thread Stefan Richter
(Adding Cc: LSML) Jarod Wilson wrote: On Wednesday 06 February 2008 04:09:47 pm Stefan Richter wrote: take care that __scsi_add_device does not return success even though the SCSI high-level driver probing failed (sd READ_CAPACITY and friends) due to bus reset. The trick to do so is to use a

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-08 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Feb 08 2008, Jeff Garzik wrote: Jeff Garzik wrote: Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some

[PATCH 1/1] aacraid: add optional MSI support (take 2)

2008-02-08 Thread Salyzyn, Mark
Thanks for performing my compile check for me ;-}. You nailed the problem on the head. excuseIn my efforts to trim down the patch from my internal version of the driver, I neglected to pass the '#include linux/pci.h' chunk. Sadly, my only compile check was done against an older FC release,

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread Alan Cox
http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf By a simple text search. I don't think the pedantry is worth the confusion ... Ok so we should file a formal change request with T10 instead perhaps ? Alan - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH 3/3] mpt fusion: Avoid racing when mptsas and mptcl module are loaded in parallel

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 16:35 +0530, Prakash, Sathya wrote: This patch sets the IOC pointer in drvrdata of pcidev before adding the IOC into the list of IOCs. Without this patch the driver oops when the mptsas and mptctl modules are loaded in parallel. Much better, thanks. Would I be correct in

[Bug 9769] CONFIG_SCSI_WAIT_SCAN configure error

2008-02-08 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9769 --- Comment #2 from [EMAIL PROTECTED] 2008-02-08 07:01 --- Reply-To: [EMAIL PROTECTED] On Thu, 2008-02-07 at 23:28 -0800, [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9769 [EMAIL PROTECTED] changed:

[PATCH 2/6] lpfc 8.2.5 : Miscellaneous Fixes

2008-02-08 Thread James Smart
Miscellaneous fixes: - Fix ERRATT flag which was overlapping - Allow RESTART mbx commands through when stopped. - Accept incoming PLOGI when connected to an N_Port. - Fix NPort to NPort pt2pt problems: ADISC and reg_vpi issues - Fix vport unloading error that erroneously cleaned up RSCN buffers -

[PATCH 3/6] lpfc 8.2.5 : Add MSI-X single message support

2008-02-08 Thread James Smart
Add MSI-X single message support Signed-off-by: James Smart [EMAIL PROTECTED] --- lpfc.h | 10 +- lpfc_attr.c |6 ++- lpfc_init.c | 97 3 files changed, 91 insertions(+), 22 deletions(-) diff -upNr

[PATCH 4/6] lpfc 8.2.5 : Miscellaneous discovery Fixes

2008-02-08 Thread James Smart
Miscellaneous discovery fixes: - Flush RSCN buffers on vports when reseting HBA. - Fix incorrect FLOGI after vport reg failed - Fix a potential fabric ELS race condition - Fix handling of failed PLOGI command under high lip rates - Fix FDISC handling - Fix debug logging for npiv handling

[PATCH 5/6] lpfc 8.2.5 : Fix buffer leaks

2008-02-08 Thread James Smart
Fix buffer leaks: - HBQ dma buffer leak at dma_pool_destroy when unloading driver - Fix missing buffer free in slow ring buffer handling Signed-off-by: James Smart [EMAIL PROTECTED] --- lpfc.h |2 + lpfc_hbadisc.c | 17 +++-- lpfc_hw.h | 17 + lpfc_init.c

[PATCH 6/6] lpfc 8.2.5 : Update lpfc driver version to 8.2.5

2008-02-08 Thread James Smart
Update lpfc driver version to 8.2.5 Signed-off-by: James Smart [EMAIL PROTECTED] --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2008-01-14

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Vladislav Bolkhovitin
Nicholas A. Bellinger wrote: - It has been discussed which iSCSI target implementation should be in the mainstream Linux kernel. There is no agreement on this subject yet. The short-term options are as follows: 1) Do not integrate any new iSCSI target implementation in the mainstream Linux

[PATCH 0/6] lpfc 8.2.5 : lpfc 8.2.5 patches

2008-02-08 Thread James Smart
lpfc driver updates for revision 8.2.5. Patches based on scsi-misc-2.6 Changes include: - Correct ndlp referencing issues - Miscellaneous fixes - Add MSI-X single message support - Miscellaneous discovery fixes: - Fix buffer leaks: - Update lpfc driver version to 8.2.5 -- james s - To

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Nicholas A. Bellinger
On Fri, 2008-02-08 at 17:36 +0300, Vladislav Bolkhovitin wrote: Nicholas A. Bellinger wrote: - It has been discussed which iSCSI target implementation should be in the mainstream Linux kernel. There is no agreement on this subject yet. The short-term options are as follows: 1) Do not

scsi/arm/fas216.c compile error

2008-02-08 Thread Adrian Bunk
Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following compile error: -- snip -- ... CC drivers/scsi/arm/fas216.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In function 'fas216_std_done':

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Nicholas A. Bellinger
On Fri, 2008-02-08 at 17:42 +0300, Vladislav Bolkhovitin wrote: Nicholas A. Bellinger wrote: On Thu, 2008-02-07 at 12:37 -0800, Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-08 Thread Tejun Heo
Jeff Garzik wrote: Jens Axboe wrote: On Fri, Feb 08 2008, Jeff Garzik wrote: Jeff Garzik wrote: Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are

[PATCH 6/7] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-08 Thread Tejun Heo
From: James Bottomley [EMAIL PROTECTED] ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a dma_alignment variable which ensures both the

[PATCH 1/7] libata: update ATAPI overflow draining

2008-02-08 Thread Tejun Heo
For misc ATAPI commands which transfer variable length data to the host, overflow can occur due to application or hardware bug. Such overflows can be ignored safely as long as overflow data is properly drained. libata HSM implementation has this implemented in __atapi_pio_bytes() and recently

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread Douglas Gilbert
Alan Cox wrote: The word illegal has a precise dictionary meaning of prohibited by law. Also contrary to or forbidden by official rules, regulations, etc. So word meanings are like standards, there are so many to choose from. The error messages are therefore incorrect as so far nobody has

[PATCH 2/7] block: update bio according to DMA alignment padding

2008-02-08 Thread Tejun Heo
DMA start address and transfer size alignment for PC requests are achieved using bio_copy_user() instead of bio_map_user(). This works because bio_copy_user() always uses full pages and block DMA alignment isn't allowed to go over PAGE_SIZE. However, the implementation didn't update the last bio

[PATCHSET #upstream] block/libata: update and use block layer padding and draining, take 2

2008-02-08 Thread Tejun Heo
This is the second take of blk-layer-padding-and-draining patchset. Changes from the last take[L] are... * libata-update-ATAPI-overflow-draining patch added. This patch fixes up ATAPI PIO handling before updating it to use block layer draining. consumed accounting and

[PATCH 3/7] block: add request-raw_data_len

2008-02-08 Thread Tejun Heo
With padding and draining moved into it, block layer now may extend requests as directed by queue parameters, so now a request has two sizes - the original request size and the extended size which matches the size of area pointed to by bios and later by sgs. The latter size is what lower layers

[PATCH 5/7] block: clear drain buffer if draining for write command

2008-02-08 Thread Tejun Heo
Clear drain buffer before chaining if the command in question is a write. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- block/blk-merge.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index d50cfc8..d0b9031 100644 ---

[PATCH 7/7] libata: implement drain buffers

2008-02-08 Thread Tejun Heo
From: James Bottomley [EMAIL PROTECTED] This just updates the libata slave configure routine to take advantage of the block layer drain buffers. It also adjusts the size lengths in the atapi code to add the drain buffer to the DMA length so the driver knows it can rely on it. I suspect I should

[PATCH 4/7] block: implement request_queue-dma_drain_needed

2008-02-08 Thread Tejun Heo
Draining shouldn't be done for commands where overflow may indicate data integrity issues. Add dma_drain_needed callback to request_queue. Drain buffer is appened iff this function returns non-zero. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] ---

[Bug 9775] HOST_MSG_LOOP invalid SCB ff

2008-02-08 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9775 --- Comment #8 from [EMAIL PROTECTED] 2008-02-08 18:52 --- Ok, I've spent some time trying different combinations of devices. Against kernel 2.6.24 T0 is Quantum DLT8000 ID0 T1 is Quantum DLT8000 ID1 MTX is STK L80 ID 15

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread david
On Fri, 8 Feb 2008, Vladislav Bolkhovitin wrote: 2. I think, everybody will agree that Linux iSCSI target should work over some standard SCSI target framework. Hence the choice gets narrower: SCST vs STGT. I don't think there's a way for a dedicated iSCSI target (i.e. PyX/LIO) in the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Luben Tuikov
--- On Fri, 2/8/08, Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? What do you mean? To call directly low level backstorage SCSI drivers

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Luben Tuikov
--- On Fri, 2/8/08, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? Luben Hi Luben, I am guessing you mean futher down the