[PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-14 Thread Chanho Min
We don't need to unlock the queue before put_device in scsi_request_fn() If we trigger the -remove() function, It occur a oops from the caller. So sdev reference count should not be dropped to zero here. Also It was added before scsi_device_dev_release() was moved to user context, so it is

[PATCH 1/3] Documentation: scsi.txt: Remove unused abbreviation lk

2012-08-14 Thread Paul Menzel
From: Paul Menzel paulepan...@users.sourceforge.net Date: Tue, 14 Aug 2012 11:48:04 +0200 »lk« is not used anywhere in the document. Signed-off-by: Paul Menzel paulepan...@users.sourceforge.net --- Documentation/scsi/scsi.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] Documentation/scsi/scsi.txt: Clean up typography and fix grammar

2012-08-14 Thread Paul Menzel
From: Paul Menzel paulepan...@users.sourceforge.net Date: Tue, 14 Aug 2012 11:59:31 +0200 1. Consistently use SCSI und Linux. 2. Use two spaces between sentences. 3. Remove trailing white space. Signed-off-by: Paul Menzel paulepan...@users.sourceforge.net --- Documentation/scsi/scsi.txt | 30

[PATCH 3/3] Documentation/scsi/scsi.txt: Remove wrong superfluous word »built«

2012-08-14 Thread Paul Menzel
From: Paul Menzel paulepan...@users.sourceforge.net Date: Tue, 14 Aug 2012 12:01:51 +0200 Signed-off-by: Paul Menzel paulepan...@users.sourceforge.net --- I am sending this as a separate patch, because I am no native speaker. But I am pretty sure because the either is after the first built.

[PATCH] drivers/scsi/Kconfig: Remove reference to non-existent howtos

2012-08-14 Thread Paul Menzel
From: Paul Menzel paulepan...@users.sourceforge.net Date: Tue, 14 Aug 2012 12:22:43 +0200 Searching for »scsi« at http://www.tldp.org/HOWTO/html_single/ I only found »SCSI-2.4-HOWTO« [1]. The Linux 2.4 SCSI subsystem HOWTO [1] http://www.tldp.org/HOWTO/html_single/SCSI-2.4-HOWTO/

[Bug 20072] tapeinfo reports MaxBlock: 16777215 but writes with blocksize 2M fail

2012-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=20072 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added Status|NEW |RESOLVED

Re: [RFC - PATCH 0/3] SCSI: Initiator based LUN Masking - SCSI mid-layer

2012-08-14 Thread Steffen Maier
Hi Krishna, On 08/14/2012 12:48 AM, Krishna Gudipati wrote: From: Steffen Maier [mailto:ma...@linux.vnet.ibm.com] On 08/11/2012 04:35 AM, kgudi...@brocade.com wrote: [KRISHNA]: Steffen, yes you are right, currently in this proposal we only have 3 interfaces exported from SCSI mid-layer for

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-14 Thread James Bottomley
On Tue, 2012-08-14 at 18:48 +0900, Chanho Min wrote: We don't need to unlock the queue before put_device in scsi_request_fn() If we trigger the -remove() function, It occur a oops from the caller. So sdev reference count should not be dropped to zero here. Also It was added before

[Bug 24512] Burning CD-R fails and burning CD-RW succeeds on 2.6.32. Both work on 2.6.26

2012-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=24512 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added Status|NEW |RESOLVED

[bug report] [SCSI] mvumi: GFP_KERNEL under spin lock

2012-08-14 Thread Dan Carpenter
Hello Jianyun Li, The patch f0c568a478f0: [SCSI] mvumi: Add Marvell UMI driver from May 11, 2011, leads to the following warning: drivers/scsi/mvumi.c:121 mvumi_alloc_mem_resource() error: scheduling with locks held: 'spin_lock:host_lock' The problem is that we do a couple GPF_KERNEL

[Bug 26692] Fusion MPT SPI bringup takes 80 seconds when the kernel is quiet

2012-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=26692 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added Status|NEW |NEEDINFO

[PATCH 2/5] drivers/scsi/bnx2fc/bnx2fc_io.c: Remove potential NULL dereference

2012-08-14 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ type T; expression E;

[PATCH 1/2] qla2xxx: Fix use after free in qla2x000_process_loopback.

2012-08-14 Thread steve
From: Steve Hodgson st...@purestorage.com Don't touch fc_bsg_job after calling job_done() which completes the bio freeing the memory. Whilst here fix a few other intsances of this error. Signed-off-by: Steve Hodgson st...@purestorage.com --- drivers/scsi/qla2xxx/qla_bsg.c |8 1

[PATCH 0/2] Fix the qla2xxx loopback selftests

2012-08-14 Thread steve
From: Steve Hodgson st...@purestorage.com A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after free. Whilst here fix an error path memory leak.

[PATCH 2/2] qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

2012-08-14 Thread steve
From: Steve Hodgson st...@purestorage.com Signed-off-by: Steve Hodgson st...@purestorage.com --- drivers/scsi/qla2xxx/qla_bsg.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 765be8e..f465c3e

[PATCH 00/12] lpfc 8.3.34: Update lpfc to revision 8.3.34

2012-08-14 Thread James Smart
This patch set updates the lpfc driver to revision 8.3.34 The patches for 8.3.34 contain: - Add LOGO support after ABTS compliance - Add SLI-4 V1 Capacity and Resource Descriptor support - Fix number of IO channels to match CPUs - Fix parameter field in CQE to mask for LOCAL_REJECT status -

[PATCH 01/12] lpfc 8.3.34: Add LOGO support after ABTS compliance

2012-08-14 Thread James Smart
Make compliant with FC specs by sending LOGO after ABTS timeouts Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_crtn.h |2 lpfc_debugfs.c | 12 lpfc_disc.h | 10 ++-- lpfc_els.c | 137 ++-

[PATCH 02/12] lpfc 8.3.34: Add SLI-4 V1 Capacity and Resource Descriptor support

2012-08-14 Thread James Smart
Add SLI-4 V1 Capacity and Resource Descriptor support Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw4.h | 17 - lpfc_init.c | 25 +++-- 2 files changed, 31 insertions(+), 11 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hw4.h

[PATCH 03/12] lpfc 8.3.34: Fix number of IO channels to match CPUs

2012-08-14 Thread James Smart
Fix number of IO channels to match CPUs Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 14 ++ 1 file changed, 14 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c 2012-08-11

[PATCH 04/12] lpfc 8.3.34: Fix parameter field in CQE to mask for LOCAL_REJECT status

2012-08-14 Thread James Smart
Fix parameter field in CQE to mask for LOCAL_REJECT status Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |6 +++--- lpfc_ct.c | 16 +++- lpfc_els.c | 17 +++-- lpfc_hw.h |1 + lpfc_hw4.h |2 +- lpfc_scsi.c |2 +- lpfc_sli.c

[PATCH 05/12] lpfc 8.3.34: Simplify BlockGuard lpfc_printf_vlog messages

2012-08-14 Thread James Smart
Simplify BlockGuard lpfc_printf_vlog messages Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c | 58 ++ 1 file changed, 14 insertions(+), 44 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 06/12] lpfc 8.3.34: Correct typecasts for snprintf messages

2012-08-14 Thread James Smart
Correct typecasts for snprintf messages Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_debugfs.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c ---

[PATCH 07/12] lpfc 8.3.34: Streamline fcp underrun message printing

2012-08-14 Thread James Smart
Streamline fcp underrun message printing Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 08/12] lpfc 8.3.34: Add XRI to abort handler timeout log message

2012-08-14 Thread James Smart
Add XRI to abort handler timeout log message Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 09/12] lpfc 8.3.34: Adjust IO Channels to 1 when INTx

2012-08-14 Thread James Smart
Adjust IO Channels to 1 when INTx Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c 2012-08-11

[PATCH 10/12] lpfc 8.3.34: Correct lock handling to eliminate reset escalation on I/O abort

2012-08-14 Thread James Smart
Correct lock handling to eliminate reset escalation on I/O abort Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 11/12] lpfc 8.3.34: Fixed leaking memory from pci dma pool

2012-08-14 Thread James Smart
Fixed leaking memory from pci dma pool Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c | 25 - lpfc_mbox.c|2 +- 2 files changed, 17 insertions(+), 10 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c

[PATCH 12/12] lpfc 8.3.34: Update lpfc version for 8.3.34 driver release

2012-08-14 Thread James Smart
Update lpfc version for 8.3.34 driver release Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h ---

Re: [PATCH 0/2] Fix the qla2xxx loopback selftests

2012-08-14 Thread Chad Dupuis
On Tue, 14 Aug 2012, st...@purestorage.com wrote: From: Steve Hodgson st...@purestorage.com A few months ago our 2.6.39 based kernel started crashing almost 100% of the time when running the selftests, after seeminly unrelated kernel changes. In the end it was traced down to this use after