Re: [PATCH] Fix a use-after-free triggered by device removal

2012-09-11 Thread Bart Van Assche
On 09/11/12 01:38, Tejun Heo wrote: On Fri, Sep 07, 2012 at 08:57:10AM +0200, Bart Van Assche wrote: Also, as far as I can see the functions that can insert a request into the queue (blk_insert_cloned_request(), queue_unplugged(), blk_execute_rq_nowait()) all check whether the queue is dead

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Aaron Lu
On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver Neukum wrote: On Monday 10 September 2012 17:16:22 Aaron Lu wrote: +static int sr_resume(struct device *dev) +{ + struct scsi_cd *cd; + struct scsi_sense_hdr sshdr; + + cd = dev_get_drvdata(dev); + + if

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Oliver Neukum
On Tuesday 11 September 2012 14:44:30 Aaron Lu wrote: On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver Neukum wrote: On Monday 10 September 2012 17:16:22 Aaron Lu wrote: +static int sr_resume(struct device *dev) +{ + struct scsi_cd *cd; + struct scsi_sense_hdr sshdr; + + cd

[V3 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission

2012-09-11 Thread Naresh Kumar Inna
This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel. This driver currently supports FCoE offload functionality over Chelsio T4-based 10Gb Converged Network Adapters. The following patches contain the driver sources for csiostor driver and updates to

[V3 PATCH 7/9] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-09-11 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h |

[V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread Naresh Kumar Inna
This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff

[V3 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates).

2012-09-11 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4 source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Aaron Lu
On Tue, Sep 11, 2012 at 10:55:44AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 14:44:30 Aaron Lu wrote: On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver Neukum wrote: On Monday 10 September 2012 17:16:22 Aaron Lu wrote: +static int sr_resume(struct device *dev) +{

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Oliver Neukum
On Tuesday 11 September 2012 17:24:13 Aaron Lu wrote: On Tue, Sep 11, 2012 at 10:55:44AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 14:44:30 Aaron Lu wrote: On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver Neukum wrote: On Monday 10 September 2012 17:16:22 Aaron Lu wrote:

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Aaron Lu
On Tue, Sep 11, 2012 at 11:30:35AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 17:24:13 Aaron Lu wrote: On Tue, Sep 11, 2012 at 10:55:44AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 14:44:30 Aaron Lu wrote: On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Oliver Neukum
On Tuesday 11 September 2012 19:11:08 Aaron Lu wrote: On Tue, Sep 11, 2012 at 11:30:35AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 17:24:13 Aaron Lu wrote: Yes, but because the whole system had been suspended. In that case you can have a locked door. By locked, do you

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Aaron Lu
On Tue, Sep 11, 2012 at 11:30:35AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 17:24:13 Aaron Lu wrote: On Tue, Sep 11, 2012 at 10:55:44AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 14:44:30 Aaron Lu wrote: On Mon, Sep 10, 2012 at 12:45:51PM +0200, Oliver

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Aaron Lu
On Tue, Sep 11, 2012 at 02:10:18PM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 19:11:08 Aaron Lu wrote: On Tue, Sep 11, 2012 at 11:30:35AM +0200, Oliver Neukum wrote: On Tuesday 11 September 2012 17:24:13 Aaron Lu wrote: Yes, but because the whole system had been suspended.

4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread Dorau, Lukasz
Hi James What are you going to do with the following four ISCI patches from isci-for-3.6 tag?: 6734092e66011def7875bd67beef889d0fee1cc9isci: add a couple __iomem annotations 67787c330762eb884bf8c169fe942263d55ec162isci: make function declaration match implementation

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-11 Thread Oliver Neukum
On Tuesday 11 September 2012 20:31:17 Aaron Lu wrote: OK, I think I got your meaning. For a simpler scenario: 1 User application did an ioctl to lock the door of the ODD when there is no medium inside(but why? :-); 2 The ODD is runtime suspended; 3 The ODD is runtime powered off; 4 User

Re: 4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread James Bottomley
On Tue, 2012-09-11 at 12:29 +, Dorau, Lukasz wrote: Hi James What are you going to do with the following four ISCI patches from isci-for-3.6 tag?: 6734092e66011def7875bd67beef889d0fee1cc9isci: add a couple __iomem annotations 67787c330762eb884bf8c169fe942263d55ec162isci:

Wrong SSD sector count with after reboot

2012-09-11 Thread Michael J Gruber
[Originally posted to fedora-general, where Alan Cox suspected a usb issue and suggested linux-usb; they suggested linux-scsi.] F17 with current updates gets the sector count wrong (too large by 5) for my SSD (Jetflash USB), resulting in read errors (during boot, fdisk reading the disk etc.) for

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, On Fri, Jul 20, 2012 at 06:30:01PM +0200, Paolo Bonzini wrote: These commands cannot be issued right now without giving CAP_SYS_RAWIO to the process who wishes to send them. These commands can be useful also to non-privileged programs who have access to the block devices. For example

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi bprak...@broadcom.com wrote: I'm concerned that we will be breaking user space compatibility with this change, as there should be a corresponding fcoemon/fipvlan change along with this, and existing utilities will not work. Also the way

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread David Miller
From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:07 +0530 This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com You cannot submit a patch set that

Re: [V3 PATCH 5/9] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-09-11 Thread David Miller
From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:03 +0530 +#include linux/moduleparam.h This header include is not necessary. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No discovery or login # echo eth3.172-fcoe

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:12:09 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi bprak...@broadcom.com wrote: I'm concerned that we will be breaking user space compatibility with this change, as there should be a corresponding fcoemon/fipvlan change along with

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:36:35 AM PDT, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip That being said, I'm glad this is being reworked. Do you have any other functionality in mind

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Paolo Bonzini
Il 11/09/2012 18:59, Tejun Heo ha scritto: FWIW, I don't think this is the right way to expose functionality which needs management in terms of access control, interpretation (stacking drivers) and serving concurrent users. SG_IO filtering was mostly for cd/dvd burning and other removeable

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, Paolo. On Tue, Sep 11, 2012 at 07:56:53PM +0200, Paolo Bonzini wrote: Understood; unfortunately, there is another major user of it (virtualization). If you are passing raw LUNs down to a virtual machine, there's no possibility at all to use a properly encapsulated Is there still

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Bhanu Prakash Gollapudi
On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No

Re: 4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread Dan Williams
On Tue, Sep 11, 2012 at 5:41 AM, James Bottomley jbottom...@parallels.com wrote: On Tue, 2012-09-11 at 12:29 +, Dorau, Lukasz wrote: Hi James What are you going to do with the following four ISCI patches from isci-for-3.6 tag?: 6734092e66011def7875bd67beef889d0fee1cc9isci: add a

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 11:31:08 AM PDT, Bhanu Prakash Gollapudi wrote: On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Paolo Bonzini
Il 11/09/2012 20:29, Tejun Heo ha scritto: Hello, Paolo. On Tue, Sep 11, 2012 at 07:56:53PM +0200, Paolo Bonzini wrote: Understood; unfortunately, there is another major user of it (virtualization). If you are passing raw LUNs down to a virtual machine, there's no possibility at all to use

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, Paolo. On Tue, Sep 11, 2012 at 08:54:03PM +0200, Paolo Bonzini wrote: On Tue, Sep 11, 2012 at 07:56:53PM +0200, Paolo Bonzini wrote: Understood; unfortunately, there is another major user of it (virtualization). If you are passing raw LUNs down to a virtual machine, there's no

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Paolo Bonzini
Il 11/09/2012 21:13, Tejun Heo ha scritto: Hello, Paolo. On Tue, Sep 11, 2012 at 08:54:03PM +0200, Paolo Bonzini wrote: On Tue, Sep 11, 2012 at 07:56:53PM +0200, Paolo Bonzini wrote: Understood; unfortunately, there is another major user of it (virtualization). If you are passing raw LUNs

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, Paolo. On Tue, Sep 11, 2012 at 09:24:32PM +0200, Paolo Bonzini wrote: Couldn't it intercept some of them - e.g. RWs and discards? What's the benifit / use case of doing pure bypass? Basically, using the same storage technology for bare metal and virtualized systems. IMHO losing

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Paolo Bonzini
[Al: you can jump down to One problem:] Il 11/09/2012 22:01, Tejun Heo ha scritto: Hello, Paolo. On Tue, Sep 11, 2012 at 09:24:32PM +0200, Paolo Bonzini wrote: Couldn't it intercept some of them - e.g. RWs and discards? What's the benifit / use case of doing pure bypass? Basically, using

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, Paolo. On Tue, Sep 11, 2012 at 11:50:38PM +0200, Paolo Bonzini wrote: Either way, with or without virtualization, making detailed error information to userland is a valid goal. I *think* we're finally getting there after years of talking via structured printk. I don't know much

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Paolo Bonzini
Il 12/09/2012 00:02, Tejun Heo ha scritto: SG_IO itself is a bypassing interface. It bypasses most of block layer and the kernel doesn't have any idea (apart from the adhoc filtering) about what's going on. That's very much the point. The guest must have free reins. You asked Could being

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-11 Thread Tejun Heo
Hello, On Tue, Sep 11, 2012 at 3:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/09/2012 00:02, Tejun Heo ha scritto: SG_IO itself is a bypassing interface. It bypasses most of block layer and the kernel doesn't have any idea (apart from the adhoc filtering) about what's going on.

Re: [PATCH] scsi_netlink: Remove dead and buggy code

2012-09-11 Thread Eric W. Biederman
James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2012-09-10 at 15:07 -0400, David Miller wrote: From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 07 Sep 2012 15:39:21 -0700 The scsi netlink code confuses the netlink port id with a process id, going so far

Re: [PATCH] scsi_netlink: Remove dead and buggy code

2012-09-11 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Tue, 11 Sep 2012 15:40:08 -0700 So just for curiosity I searched the entire git history for scsi_nl_add_ and the only commit that I found was the addition of that code to the tree in August of 2008. Does anyone have any reason to keep

A oops bug

2012-09-11 Thread Jianpeng Ma
Today, when i removed some disks from softraid and found this oops. But i did not find how to reproduce. The message is: [ 2796.107120] BUG: unable to handle kernel NULL pointer dereference at 0837 [ 2796.107123] IP: [813d2839] scsi_eh_flush_done_q+0x49/0xe0 [ 2796.107129]

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread Naresh Kumar Inna
On 9/11/2012 11:03 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:07 +0530 This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna

Re: [V3 PATCH 5/9] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-09-11 Thread Naresh Kumar Inna
On 9/11/2012 11:05 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:03 +0530 +#include linux/moduleparam.h This header include is not necessary. I will remove it, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread David Miller
From: Naresh Kumar Inna nar...@chelsio.com Date: Wed, 12 Sep 2012 11:05:22 +0530 On 9/11/2012 11:03 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:07 +0530 This patch contains minor fixes to make cxgb4vf driver work with the updates to