Re: [PATCH v2 0/5] Multiqueue virtio-scsi, and API for piecewise buffer submission

2012-12-19 Thread Paolo Bonzini
Il 18/12/2012 23:18, Rolf Eike Beer ha scritto: Paolo Bonzini wrote: Hi all, this series adds multiqueue support to the virtio-scsi driver, based on Jason Wang's work on virtio-net. It uses a simple queue steering algorithm that expects one queue per CPU. LUNs in the same target always

Re: [PATCH 06/10] fnic: New debug flags and debug log messages

2012-12-19 Thread James Bottomley
On Mon, 2012-12-17 at 15:29 -0800, Hiral Patel wrote: Added new fnic debug flags for identifying IO state at every stage of IO while debugging and also added more log messages for better debugging capability. Signed-off-by: Sesidhar Baddela sebad...@cisco.com Signed-off-by: Hiral Patel

Re: megaraid_sas: problem with specific hardware only with kernel 3.2.5 and above

2012-12-19 Thread Matthias Prager
Hello everyone, hello Michal, I can confirm and reproduce this issue on a different set of hardware: Intel S1200BTLR Mainboard LSI MegaRAID 9266-4i Raid-Controller I haven't tried using a kernel older than 3.2.5 so far, but with kernels 3.2.24 and 3.5.0 I get the following dmesg output: [

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-12-19 Thread Scott Guthridge
The patch we suggested where we simply changed BLK_MAX_CDB and MAX_COMMAND_SIZE from 16 to 32 was meant to be a stick in the sand. It's the simplest description of the functionality we're looking for. Other approaches that accomplish the same thing would be fine. I don't know if the reason

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: +/** + * virtqueue_start_buf - start building buffer for the other end + * @vq: the struct virtqueue we're talking about. + * @buf: a struct keeping the state of the buffer + * @data: the token identifying the buffer. + * @count:

Re: [PATCH v2 5/5] virtio-scsi: introduce multiqueue support

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:52PM +0100, Paolo Bonzini wrote: struct virtio_scsi_target_state { - /* Never held at the same time as vq_lock. */ + /* This spinlock ever held at the same time as vq_lock. */ s/ever/is never/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 0/5] Multiqueue virtio-scsi, and API for piecewise buffer submission

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 09:52:59AM +0100, Paolo Bonzini wrote: Il 18/12/2012 23:18, Rolf Eike Beer ha scritto: Paolo Bonzini wrote: Hi all, this series adds multiqueue support to the virtio-scsi driver, based on Jason Wang's work on virtio-net. It uses a simple queue steering

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Wed, Dec 19, 2012 at 1:04 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: What is the purpose of count_sg? It is needed to decide whether to use an indirect or a direct buffer. The

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-12-19 Thread Rob Evers
On 11/21/2012 03:07 PM, Rob Evers wrote: These patches replace the original t10 type 2 dif mempool implementation by increasing the block and scsi cdb maximum sizes from 16 to 32 bytes. The cdb embedded in the request structure can then be used for type 2 dif commands, or other 32 byte cdbs as

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 01:04:08PM +0100, Paolo Bonzini wrote: Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: +/** + * virtqueue_start_buf - start building buffer for the other end + * @vq: the struct virtqueue we're talking

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 06:51:30PM +0200, Michael S. Tsirkin wrote: On Wed, Dec 19, 2012 at 01:04:08PM +0100, Paolo Bonzini wrote: Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: +/** + * virtqueue_start_buf - start

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-12-19 Thread Martin K. Petersen
Scott == Scott Guthridge guthr...@us.ibm.com writes: Scott, Scott I don't know if the reason that sd went with the mempool for Scott 32-byte commands was binary compatibility with modules, concerns Scott about memory usage on small/embedded systems, or both. The latter. Type 2 is an edge

RE: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-12-19 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Martin K. Petersen Sent: Wednesday, 19 December, 2012 10:56 AM To: Scott Guthridge Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH 0/2] Change type-2 dif to use rq

[PATCH 06/10] fnic: New debug flags and debug log messages

2012-12-19 Thread Hiral Patel
Added new fnic debug flags for identifying IO state at every stage of IO while debugging and also added more log messages for better debugging capability. Signed-off-by: Sesidhar Baddela sebad...@cisco.com Signed-off-by: Hiral Patel hiral...@cisco.com --- drivers/scsi/fnic/fnic.h | 31

Re: [PATCH 06/10] fnic: New debug flags and debug log messages

2012-12-19 Thread Hiral Patel (hiralpat)
Hi James, I agree with your comment. I missed on duplicate definition, as gcc didn¹t give me error while compiling. I just resubmitted patch 06 after removing duplicate definition. Thanks, Hiral On 12/19/12 2:01 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon,

Re: Odd behavior of a SAS-2 backplane with SGPIO commands

2012-12-19 Thread Pasi Kärkkäinen
On Wed, Dec 19, 2012 at 02:00:43PM -0500, Rich wrote: From the LSI P15 F/W release notes: SCGCQ00342805 (DFCT) Â - SlotStatus updates to SES managed Enclosure may update incorrect slots Modified FW to use SES diag page 0Ah mapping only if SMP Discover DeviceSlotNum is used for

Re: Odd behavior of a SAS-2 backplane with SGPIO commands

2012-12-19 Thread Pasi Kärkkäinen
On Wed, Dec 19, 2012 at 02:35:02PM -0500, Rich wrote: Nope, I'm wrong. :( I flashed P15 on a machine, and the same behavior persisted, right up to and including the groups of 3 devices light up when I do my own smp_write_gpio. Whereas if I flash the experimental blob I was

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-19 Thread Aaron Lu
Hi Tejun, On 12/04/2012 12:23 AM, Tejun Heo wrote: Hello, James. On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index e65c62e..1756151 100644 --- a/include/scsi/scsi_device.h +++