Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-18 Thread Hannes Reinecke
On 03/15/2013 08:13 PM, Bart Van Assche wrote: On 03/15/13 19:51, Mike Christie wrote: On 03/15/2013 08:41 AM, Bart Van Assche wrote: How about using the value of scsi_cmnd.jiffies_at_alloc to finish only those SCSI commands in the host reset handler that exceeded a certain processing time ?

[PATCH 1/1] aacraid: Dual firmware image support

2013-03-18 Thread Mahesh Rajashekhara
This patch adds dual flash firmware support for Series 7 and above controllers. Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h |6 +- drivers/scsi/aacraid/comminit.c |2 +- drivers/scsi/aacraid/src.c | 31

[Bug 53281] megaraid_mbox kernel panic during boot

2013-03-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53281 justgivemeafkenaccount...@yahoo.co.uk changed: What|Removed |Added CC|

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread Namjae Jeon
2013/3/18, James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com Introduce msgbyte and statusbyte in the prints as part of the result which is returned by the lower layer driver in response to

Re: [PATCH 1/1] aacraid: Dual firmware image support

2013-03-18 Thread Tomas Henzl
On 03/18/2013 05:58 AM, Mahesh Rajashekhara wrote: This patch adds dual flash firmware support for Series 7 and above controllers. Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h |6 +- drivers/scsi/aacraid/comminit.c |2 +-

Possible reentrancy issue in be_iopoll

2013-03-18 Thread Shlomo Pongratz
Hi Jayamohan. I think that there is a reentrancy issue in drivers/scsi/be2iscsi/be_main.c::be_iopoll. The driver creates NAPI context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable, so if this routine is

Re: [PATCH][RFC] scsi: Use W_LUN for scanning

2013-03-18 Thread Hannes Reinecke
On 03/15/2013 04:54 PM, Steffen Maier wrote: While we're at it: I recently figured that there are targets responding to inquiry with PQ=1 PDT=31 for LUN0 if LUN0 has no backing device (e.g. no disk mapped for the initiator host). While this is likely to work with in-kernel lun scanning, the

Re: [PATCH -next] [SCSI] lpfc 8.3.36: fix potential NULL pointer dereference in lpfc_sli4_rq_put()

2013-03-18 Thread James Smart
James, Can you please merge this fix into scsi git for merging into 3.9 ? -- james s On 12/6/2012 10:46 AM, James Smart wrote: Acked-By: James Smart james.sm...@emulex.com Thanks -- james s On 12/2/2012 8:33 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The

Re: [PATCH] tcm_fc: using kfree_rcu() to simplify the code

2013-03-18 Thread Nicholas A. Bellinger
Hi Wei, On Mon, 2013-03-11 at 21:48 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The callback function of call_rcu() just calls a kfree(), so we can use kfree_rcu() instead of call_rcu() + callback function. Signed-off-by: Wei Yongjun

Re: [PATCH -next] target: fix possible memory leak in core_tpg_register()

2013-03-18 Thread Nicholas A. Bellinger
On Fri, 2013-03-15 at 17:19 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn 'se_tpg-tpg_lun_list' is malloced in core_tpg_register() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. 'se_tpg' is malloced out of

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-18 Thread Jeremy Linton
On 3/15/2013 8:28 AM, Bryn M. Reeves wrote: On 03/15/2013 12:46 PM, Bart Van Assche wrote: The SCSI EH keeps trying until all outstanding request have been finished. Does lpfc_host_reset_handler() invoke scsi_done() for I don't think so (ends up calling lpfc_sli_cancel_iocbs() via