[patch] [SCSI] fnic: potential dead lock in fnic_is_abts_pending()

2013-05-30 Thread Dan Carpenter
There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is false. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Static analysis. I can't test this. diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index be99e75..a97e6e5 100644 ---

Re: [PATCH 0/4] New FC timeout handler

2013-05-30 Thread Ren Mingxin
Hi, Hannes: On 05/24/2013 05:50 PM, Hannes Reinecke wrote: this is the first step towards a new FC error handler. This patch implements a new FC command timeout handler which will be sending command aborts inline without engaging SCSI EH. In addition the commands will be returned directly if

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-30 Thread Tomas Henzl
On 05/30/2013 04:32 AM, Libo Chen wrote: On 2013/5/30 9:38, Libo Chen wrote: On 2013/5/29 23:03, Tomas Henzl wrote: On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1

[PATCH 2/5] scsi: sun: use module_platform_driver() and platform_{set,get}_drvdata

2013-05-30 Thread Kefeng Wang
Use helper macro and wrapper functions to simpily code. Meanwhile, remove unnecessary drvdata set to null due to commint 0998d0631 (device-core: Ensure drvdata = NULL when no driver is bound). Signed-off-by: Kefeng Wang wangkefeng.w...@huawei.com --- drivers/scsi/sun_esp.c | 19

[PATCH 1/5] scsi: jazz: use module_platform_driver() and platform_{set,get}_drvdata

2013-05-30 Thread Kefeng Wang
Use helper macro and wrapper functions to simpily code. Signed-off-by: Kefeng Wang wangkefeng.w...@huawei.com --- drivers/scsi/jazz_esp.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/jazz_esp.c b/drivers/scsi/jazz_esp.c index

[PATCH 5/5] scsi: sni: use module_platform_driver() and platform_{set,get}_drvdata

2013-05-30 Thread Kefeng Wang
Use helper macro and wrapper functions to simpily code. Signed-off-by: Kefeng Wang wangkefeng.w...@huawei.com --- drivers/scsi/sni_53c710.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/sni_53c710.c b/drivers/scsi/sni_53c710.c index

[PATCH 3/5] scsi: qlogicpti: use module_platform_driver() and platform_{set,get}_drvdata

2013-05-30 Thread Kefeng Wang
Use helper macro and wrapper functions to simpily code. Signed-off-by: Kefeng Wang wangkefeng.w...@huawei.com --- drivers/scsi/qlogicpti.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c index

[PATCH] [SCSI] Fix incorrect comment in scsi_logging.h

2013-05-30 Thread Ewan D. Milne
From: Ewan D. Milne emi...@redhat.com The scsi_logging_level word contains 10 3-bit fields, not 8 nibbles. Fix the incorrect comment. Signed-off-by: Ewan D. Milne emi...@redhat.com --- drivers/scsi/scsi_logging.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 0/5] scsi: use platform helper macro and wrapper functions

2013-05-30 Thread James Bottomley
On Thu, 2013-05-30 at 20:09 +0800, Kefeng Wang wrote: use module_platform_driver() and paltform{set,get}_drvdata to simpily code, and patch 2/5 delete unnecessery drvdate set to null. Kefeng Wang (5): scsi: jazz: use module_platform_driver() and platform_{set,get}_drvdata scsi:

Re: [PATCH 0/5] scsi: use platform helper macro and wrapper functions

2013-05-30 Thread Kefeng Wang
On 2013-05-30 22:38, James Bottomley wrote: There doesn't seem to be much point to these patches since either idiom is fine and easily understood. We also try to touch the ancient drivers as little as possible since it can be months before anyone actually tries them out and notices that