Re: [PATCH] sg: atomize check and set sdp-exclude in sg_open

2013-06-06 Thread vaughan
于 2013年06月05日 23:41, Jörn Engel 写道: On Thu, 6 June 2013 00:16:45 +0800, vaughan wrote: 于 2013年06月05日 21:27, Jörn Engel 写道: On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: Check and set sdp-exclude should be atomic when set in sg_open(). The patch is line-wrapped. More importantly, it

Re: [PATCH] sg: atomize check and set sdp-exclude in sg_open

2013-06-06 Thread vaughan
于 2013年06月06日 15:19, vaughan 写道: 于 2013年06月05日 23:41, Jörn Engel 写道: On Thu, 6 June 2013 00:16:45 +0800, vaughan wrote: 于 2013年06月05日 21:27, Jörn Engel 写道: On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: Check and set sdp-exclude should be atomic when set in sg_open(). The patch is

Re: [PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-06 Thread Ren Mingxin
Hi, Hannes: On 06/05/2013 03:11 PM, Hannes Reinecke wrote: When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reineckeh...@suse.de --- drivers/scsi/scsi_error.c | 7 ++- drivers/scsi/scsi_lib.c | 5 +

[PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com The comment says the function does this but it does not. Reported luns change from weirdly high numbers (like 16640) to something saner (256), when using flat space addressing. CC: James Bottomley jbottom...@parallels.com CC: Dan Williams

[PATCHv2 0/3] scsi: More detailed I/O errors

2013-06-06 Thread Hannes Reinecke
As discussed at LSF the SCSI stack already knows about several error conditions, it's just not well documented. Also there are some more conditions upper layers might be interested in. This patchset improves the documentation of the existing I/O error codes and adds two more error codes, ENOSPC

[PATCH 1/3] scsi: Document enhanced error codes

2013-06-06 Thread Hannes Reinecke
Document the various error codes returned on I/O failure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 8 ++-- drivers/scsi/scsi_lib.c | 12 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_error.c

[PATCH 2/3] scsi: Return ENOSPC on thin provisioning failure

2013-06-06 Thread Hannes Reinecke
When the thin provisioning hard threshold is reached we should return ENOSPC to inform upper layers about this fact. Signed-off-by: Hannes Reinecke h...@suse.de --- block/blk-core.c | 3 +++ drivers/scsi/scsi_error.c | 12 +++- drivers/scsi/scsi_lib.c | 5 +

[PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-06 Thread Hannes Reinecke
When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reinecke h...@suse.de --- block/blk-core.c | 3 +++ drivers/scsi/scsi_error.c | 7 ++- drivers/scsi/scsi_lib.c | 5 + include/scsi/scsi.h | 2 ++ 4 files

Re: [PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 10:18 AM, Jan Vesely wrote: From: Jan Vesely jves...@redhat.com The comment says the function does this but it does not. Reported luns change from weirdly high numbers (like 16640) to something saner (256), when using flat space addressing. CC: James Bottomley

[PATCH] user_space_eject: unlock door before issuing CDROMEJECT command

2013-06-06 Thread Aaron Lu
Hi Karel Michal, Not sure if I should send this to you, please kindly forward it to other people if they should take care of this instead, thanks. Note that this is a patch for user space tool eject, but since it also has something to do with the SCSI driver, the SCSI mailing list is CC-ed in

PROCES A ODKUPU VAŠÍ VYHRÁL CENU £ 7.500,000LIBRA BRITSKÁ LIBRA { GBP }

2013-06-06 Thread www.swisslotto.ch
www.swisslotto.ch 2013 SWISSLOTTO Gratulujeme: Toto je oficiálně přinést do vaší pozornosti, že vaše e-mailová adresa získal pro vás on-line elektronickou loterii o probíhajícím Swisslotto platby loterie on-line přes náhodné elektronickým systémem e-mailovou volební qualification.The součet

[PATCH 0/4] New SCSI command timeout handler

2013-06-06 Thread Hannes Reinecke
Hi all, this is the first step towards a new non-blocking error handler. This patch implements a new command timeout handler which will be sending command aborts inline without engaging SCSI EH. In addition the commands will be returned directly if the command abort succeeded, cutting down

[PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code

2013-06-06 Thread Hannes Reinecke
Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate that a delayed error recovery has been initiated. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 3 +++ include/linux/blkdev.h| 1 + 2 files changed, 4 insertions(+) diff --git

[PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the error handler. This patch implements a new scsi_abort_command()

[PATCH 4/4] virtio_scsi: use improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
Hook in the improved eh timeout handler for virtio. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/virtio_scsi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 2168258..3fb588d 100644 ---

[PATCH 1/4] scsi: move initialization of scmd-eh_entry

2013-06-06 Thread Hannes Reinecke
The 'eh_entry' list might be used even before scsi_softirq_done() is called. Hence we should rather initialize it together with the other eh-related variables. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Jan Vesely
On Thu 06 Jun 2013 10:42:16 CEST, Hannes Reinecke wrote: On 06/06/2013 10:18 AM, Jan Vesely wrote: From: Jan Vesely jves...@redhat.com The comment says the function does this but it does not. Reported luns change from weirdly high numbers (like 16640) to something saner (256), when using

[Bug 59301] mpt2sas0 fails after short time of work

2013-06-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59301 Anton Pomozov pomoz...@gmail.com changed: What|Removed |Added Kernel Version|3.5.0-32-generic ubuntu |3.5.0 --- Comment

[PATCH RESEND] scsi_debug: Fix endianess in partition table

2013-06-06 Thread Martin Peschke
James, could you pick up this fix, please? Btw., it looks like others where bitten by this one: https://nazar.karan.org/blob/distro! parted.git/8780c767126938173f49dfbcd4360813932f7756/SOURCES! disable-t9020.patch Thanks, Martin Both start_sect and nr_sects in struct partition are __le32

[PATCH 3/3] scsi_debug: fix do_device_access() with wrap around range

2013-06-06 Thread Akinobu Mita
do_device_access() is a function that abstracts copying SG list from/to ramdisk storage (fake_storep). It must deal with the ranges exceeding actual fake_storep size, because such ranges are valid if virtual_gb is set greater than zero, and they should be treated as fake_storep is repeatedly

[PATCH 0/3] introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-06 Thread Akinobu Mita
This patch set introduces sg_pcopy_from_buffer() and sg_pcopy_to_buffer(), which copy data between a linear buffer and an SG list. The only difference between sg_pcopy_{from,to}_buffer() and sg_copy_{from,to}_buffer() is an additional argument that specifies the number of bytes to skip the SG

[PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-06 Thread Akinobu Mita
The only difference between sg_pcopy_{from,to}_buffer() and sg_copy_{from,to}_buffer() is an additional argument that specifies the number of bytes to skip the SG list before copying. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Tejun Heo t...@kernel.org Cc: Imre Deak

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-06 Thread Imre Deak
On Thu, 2013-06-06 at 21:52 +0900, Akinobu Mita wrote: The only difference between sg_pcopy_{from,to}_buffer() and sg_copy_{from,to}_buffer() is an additional argument that specifies the number of bytes to skip the SG list before copying. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com

Re: [PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 09:52 AM, Ren Mingxin wrote: Hi, Hannes: On 06/05/2013 03:11 PM, Hannes Reinecke wrote: When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reineckeh...@suse.de --- drivers/scsi/scsi_error.c | 7 ++-

Re: [PATCH v3, part1 03/10] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-06-06 Thread Jiang Liu
On Thu 06 Jun 2013 04:07:18 AM CST, Bjorn Helgaas wrote: On Sat, May 25, 2013 at 7:48 AM, Jiang Liu liu...@gmail.com wrote: From: Gu Zheng guz.f...@cn.fujitsu.com Use the new pci_alloc_dev(bus) to replace the existing using of alloc_pci_dev(void). ... diff --git a/drivers/pci/probe.c

Re: [PATCH 1/4] scsi: move initialization of scmd-eh_entry

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 11:43:52 +0200, Hannes Reinecke wrote: The 'eh_entry' list might be used even before scsi_softirq_done() is called. Hence we should rather initialize it together with the other eh-related variables. Signed-off-by: Hannes Reinecke h...@suse.de Tested-by: Joern Engel

Re: [PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 11:43:53 +0200, Hannes Reinecke wrote: Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate that a delayed error recovery has been initiated. Signed-off-by: Hannes Reinecke h...@suse.de Since the patch I tested diverged from your patches 2-4, this is only

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 06:23 PM, Jörn Engel wrote: On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-06 Thread Tejun Heo
Hello, On Thu, Jun 06, 2013 at 09:52:56PM +0900, Akinobu Mita wrote: +static bool sg_miter_get_next_page(struct sg_mapping_iter *miter) +{ + if (!miter-__remaining) { + struct scatterlist *sg; + unsigned long pgoffset; + + if

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Jörn Engel
On Thu, 6 June 2013 22:39:14 +0200, Hannes Reinecke wrote: + spin_unlock_irqrestore(sdev-list_lock, flags); + SCSI_LOG_ERROR_RECOVERY(3, + scmd_printk(KERN_INFO, scmd, + aborting command %p\n, scmd)); + rtn =

Re: [PATCH] scsi: Check if the device support WRITE_SAME_10

2013-06-06 Thread Martin K. Petersen
Bernd == Bernd Schubert bernd.schub...@itwm.fraunhofer.de writes: max_t(unsigned long, max, SD_MAX_WS10_BLOCKS); Bernd Max? Not min_t()? Brain fart. Updated patch with a few other adjustments. I have tested this on a couple of JBODs with a mishmash of SATA and SAS drives, including a few

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-06 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu So Martin and Douglas, can I have your ACKs on this patch Akinobu series for now? Only concern is the one I mentioned before: You're mapping and unmapping the ppage for every 8 bytes of protection information. That seems a bit