[PATCH v3 0/13] IB SRP initiator patches for kernel 3.11

2013-07-03 Thread Bart Van Assche
The purpose of this InfiniBand SRP initiator patch series is as follows: - Make the SRP initiator driver better suited for use in a H.A. setup. Add fast_io_fail_tmo and dev_loss_tmo parameters. These can be used either to speed up failover or to avoid device removal when e.g. using

Re: Can not see/access devices on Marvell 88SE9485 + SiI 3726 PMP

2013-07-03 Thread Hajo Möller
On 01.07.2013 16:38, James Bottomley wrote: mv_sas is a libsas based driver. libsas doesn't have any support for SATA PMPs. When it was added they were left as a todo item but then in the field everyone deployed enterprise type SATA devices in SAS expander chassis, so PMP support just got

[PATCH v3 06/13] IB/srp: Keep rport as long as the IB transport layer

2013-07-03 Thread Bart Van Assche
Keep the rport data structure around after srp_remove_host() has finished until cleanup of the IB transport layer has finished completely. This is necessary because later patches use the rport pointer inside the queuecommand callback. Without this patch accessing the rport from inside a

[PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-03 Thread Bart Van Assche
Add the necessary functions in the SRP transport module to allow an SRP initiator driver to implement transport layer error handling similar to the functionality already provided by the FC transport layer. This includes: - Support for implementing fast_io_fail_tmo, the time that should elapse

Re: [PATCH v3 0/13] IB SRP initiator patches for kernel 3.11

2013-07-03 Thread Or Gerlitz
On 03/07/2013 15:41, Bart Van Assche wrote: [...] Bart, The individual patches in this series are as follows: 0001-IB-srp-Fix-remove_one-crash-due-to-resource-exhausti.patch 0002-IB-srp-Fix-race-between-srp_queuecommand-and-srp_cla.patch

Re: [PATCH v3 0/13] IB SRP initiator patches for kernel 3.11

2013-07-03 Thread Bart Van Assche
On 07/03/13 15:38, Or Gerlitz wrote: Some of these patches were already picked by Roland (SB), I would suggest that you post V4 and drop the ones which were accepted. One of the patches that is already in Roland's tree and that was in v1 of this series has been split into two patches in v2

atomic write T10 standards

2013-07-03 Thread Ric Wheeler
On 07/03/2013 11:00 AM, James Bottomley wrote: On Wed, 2013-07-03 at 10:56 -0400, Ric Wheeler wrote: On 07/03/2013 10:38 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 10:34:04) As I was out walking Skeeter this morning, I was thinking a bit about the new T10 atomic write proposal

Re: Can not see/access devices on Marvell 88SE9485 + SiI 3726 PMP

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 14:52 +0200, Hajo Möller wrote: On 01.07.2013 16:38, James Bottomley wrote: mv_sas is a libsas based driver. libsas doesn't have any support for SATA PMPs. When it was added they were left as a todo item but then in the field everyone deployed enterprise type SATA

Re: atomic write T10 standards

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: On 07/03/2013 11:00 AM, James Bottomley wrote: On Wed, 2013-07-03 at 10:56 -0400, Ric Wheeler wrote: On 07/03/2013 10:38 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 10:34:04) As I was out walking Skeeter this morning, I was

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-03 Thread David Dillow
On Wed, 2013-07-03 at 14:54 +0200, Bart Van Assche wrote: +int srp_tmo_valid(int fast_io_fail_tmo, int dev_loss_tmo) +{ + return (fast_io_fail_tmo 0 || dev_loss_tmo 0 || + fast_io_fail_tmo dev_loss_tmo) + fast_io_fail_tmo = SCSI_DEVICE_BLOCK_MAX_TIMEOUT +

Re: atomic write T10 standards

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: Why not have the atomic write actually imply that it is atomic and durable for just that command? I don't understand why you think

Re: atomic write T10 standards

2013-07-03 Thread Ric Wheeler
On 07/03/2013 11:37 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: Why not have the atomic write actually imply that it is atomic and durable for just that

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Sujit Reddy Thumma
On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags); task_req_descp = hba-utmrdl_base_addr; task_req_descp +=

Re: atomic write T10 standards

2013-07-03 Thread Chris Mason
Quoting Ric Wheeler (2013-07-03 11:42:38) On 07/03/2013 11:37 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: Why not have the atomic write actually imply

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Santosh Y
On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags);

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Sujit Reddy Thumma
On 7/3/2013 9:53 PM, Santosh Y wrote: On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: +

Re: [PATCH V2 3/4] scsi: ufs: Fix device and host reset methods

2013-07-03 Thread Sujit Reddy Thumma
On 7/3/2013 11:19 AM, Santosh Y wrote: + +/** + * ufshcd_eh_device_reset_handler - device reset handler registered to + *scsi layer. + * @cmd - SCSI command pointer + * + * Returns SUCCESS/FAILED + */ +static int ufshcd_eh_device_reset_handler(struct scsi_cmnd

Re: [PATCH V2 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-03 Thread Santosh Y
+ +/** + * ufshcd_fatal_err_handler - handle fatal errors + * @work: pointer to work structure */ static void ufshcd_fatal_err_handler(struct work_struct *work) { struct ufs_hba *hba; + unsigned long flags; + u32 err_xfer = 0; + u32 err_tm = 0; + int

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-03 Thread Bart Van Assche
On 07/03/13 19:27, David Dillow wrote: On Wed, 2013-07-03 at 18:00 +0200, Bart Van Assche wrote: The combination of dev_loss_tmo off and reconnect_delay 0 worked fine in my tests. An I/O failure was detected shortly after the cable to the target was pulled. I/O resumed shortly after the cable

Re: atomic write T10 standards

2013-07-03 Thread Ric Wheeler
On 07/03/2013 11:54 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 11:42:38) On 07/03/2013 11:37 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: Why

Re: atomic write T10 standards

2013-07-03 Thread Chris Mason
Quoting Ric Wheeler (2013-07-03 14:31:59) On 07/03/2013 11:54 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 11:42:38) On 07/03/2013 11:37 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed,

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-03 Thread David Dillow
On Wed, 2013-07-03 at 20:24 +0200, Bart Van Assche wrote: On 07/03/13 19:27, David Dillow wrote: On Wed, 2013-07-03 at 18:00 +0200, Bart Van Assche wrote: The combination of dev_loss_tmo off and reconnect_delay 0 worked fine in my tests. An I/O failure was detected shortly after the cable

Re: atomic write T10 standards

2013-07-03 Thread Ric Wheeler
On 07/03/2013 02:54 PM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 14:31:59) On 07/03/2013 11:54 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 11:42:38) On 07/03/2013 11:37 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-03 Thread Vu Pham
David Dillow wrote: On Wed, 2013-07-03 at 20:24 +0200, Bart Van Assche wrote: On 07/03/13 19:27, David Dillow wrote: On Wed, 2013-07-03 at 18:00 +0200, Bart Van Assche wrote: The combination of dev_loss_tmo off and reconnect_delay 0 worked fine in my tests. An I/O failure was

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-07-03 Thread Shaohua Li
On Thu, Jun 20, 2013 at 04:17:13PM -0400, Matthew Wilcox wrote: A paper at FAST2012 (http://static.usenix.org/events/fast12/tech/full_papers/Yang.pdf) pointed out the performance overhead of taking interrupts for low-latency block I/Os. The solution the author investigated was to spin

Re: atomic write T10 standards

2013-07-03 Thread Vladislav Bolkhovitin
Ric Wheeler, on 07/03/2013 11:31 AM wrote: Journals are normally big (128MB or so?) - I don't think that this is unique to xfs. We're mixing a bunch of concepts here. The filesystems have a lot of different requirements, and atomics are just one small part. Creating a new file often uses