Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

2014-01-10 Thread vaughan
On 01/10/2014 03:41 PM, Mike Christie wrote: On 1/10/14 12:11 AM, vaughan wrote: I haven't figure out why it's rejected with bookmark invalid(9) reason, rather than command not supported. IMO bookmark invalid is used when minor protocol conflict such as final flag not set with non-write

Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

2014-01-10 Thread vaughan
On 01/10/2014 03:41 PM, Mike Christie wrote: On 1/10/14 12:11 AM, vaughan wrote: I haven't figure out why it's rejected with bookmark invalid(9) reason, rather than command not supported. IMO bookmark invalid is used when minor protocol conflict such as final flag not set with non-write

Re: Terrible performance of sequential O_DIRECT 4k writes in SAN environment. ~3 times slower then Solars 10 with the same HBA/Storage.

2014-01-10 Thread Jan Kara
On Thu 09-01-14 12:11:16, Sergey Meirovich wrote: Hi Jan, On 8 January 2014 22:55, Jan Kara j...@suse.cz wrote: So far I've seen so massive degradation only in SAN environment. I started my investigation with RHEL6.5 kernel so below table is from it but the trend is the same as for

Re: Terrible performance of sequential O_DIRECT 4k writes in SAN environment. ~3 times slower then Solars 10 with the same HBA/Storage.

2014-01-10 Thread Sergey Meirovich
Hi Jan, On 10 January 2014 11:36, Jan Kara j...@suse.cz wrote: On Thu 09-01-14 12:11:16, Sergey Meirovich wrote: ... I've done preallocation on fnic/XtremIO as Christoph suggested. [root@dca-poc-gtsxdb3 mnt]# sysbench --max-requests=0 --file-extra-flags=direct --test=fileio --num-threads=4

Re: Terrible performance of sequential O_DIRECT 4k writes in SAN environment. ~3 times slower then Solars 10 with the same HBA/Storage.

2014-01-10 Thread Jan Kara
On Fri 10-01-14 12:36:22, Sergey Meirovich wrote: Hi Jan, On 10 January 2014 11:36, Jan Kara j...@suse.cz wrote: On Thu 09-01-14 12:11:16, Sergey Meirovich wrote: ... I've done preallocation on fnic/XtremIO as Christoph suggested. [root@dca-poc-gtsxdb3 mnt]# sysbench --max-requests=0

Re: [PATCH 1/1] aacraid: kdump fix

2014-01-10 Thread Tomas Henzl
On 01/08/2014 07:34 AM, Mahesh Rajashekhara wrote: Hi James, Can you please let me know the status of this patch which I submitted sometime back. Thanks Regards, Mahesh -Original Message- From: Mahesh Rajashekhara Sent: Monday, December 23, 2013 3:38 PM To:

[PATCH 12/14] scsi: use device_remove_file_self() instead of device_schedule_callback()

2014-01-10 Thread Tejun Heo
driver-core now supports synchrnous self-deletion of attributes and the asynchrnous removal mechanism is scheduled for removal. Use it instead of device_schedule_callback(). This makes delete behave synchronously. Signed-off-by: Tejun Heo t...@kernel.org Cc: James E.J. Bottomley

[PATCH 12/14] scsi: use device_remove_file_self() instead of device_schedule_callback()

2014-01-10 Thread Tejun Heo
driver-core now supports synchrnous self-deletion of attributes and the asynchrnous removal mechanism is scheduled for removal. Use it instead of device_schedule_callback(). This makes delete behave synchronously. Signed-off-by: Tejun Heo t...@kernel.org Cc: James E.J. Bottomley

[PATCH 9/9] Xen / PCI: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between the Xen pcifront device addition and removal and the generic PCI device addition and removal that can be triggered via sysfs. To avoid those race conditions make the Xen pcifront code use global PCI

[PATCH 7/9] MPT / PCI: Use pci_stop_and_remove_bus_device_locked()

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Race conditions are theoretically possible between the MPT PCI device removal and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make the MPT PCI code use

[PATCH 4/9] PCMCIA / cardbus: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between the cardbus PCI device addition and removal and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make the cardbus code use global PCI

[PATCH 8/9] powerpc / eeh_driver: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Race conditions are theoretically possible between the PCI device addition and removal in the PPC64 PCI error recovery driver and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make

[PATCH 0/9] PCI: Eliminate race conditions between hotplug and sysfs rescan/remove (Was: Re: [PATCH v2 04/10] PCI: Destroy pci dev only once)

2014-01-10 Thread Rafael J. Wysocki
[Cc: adding linux-scsi for the MPT changes, Ben for powerpc, Matthew for platform/x86 and Konrad for Xen] On Friday, December 06, 2013 02:21:50 AM Rafael J. Wysocki wrote: [...] OK To be a bit more constructive, as the next step I'd try to use pci_remove_rescan_mutex to serialize all

[PATCH 6/9] platform / x86: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between the rfkill hotplug in the asus-wmi and eeepc-laptop drivers and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make asus-wmi and

[PATCH 1/9] PCI: Global rescan-remove lock

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com There are multiple PCI device addition and removal code paths that may be run concurrently with the generic PCI bus rescan and device removal that can be triggered via sysfs. If that happens, it may lead to multiple different, potentially

[PATCH 2/9] ACPI / PCI: Use global PCI rescan-remove locking in PCI root hotplug

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between the addition and removal of PCI devices during ACPI PCI host bridge hotplug and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make the

[PATCH 3/9] ACPI / hotplug / PCI: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between the ACPI-based PCI hotplug (ACPIPHP) and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make the ACPIPHP code use global PCI

[PATCH 5/9] PCI / hotplug: Use global PCI rescan-remove locking

2014-01-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Multiple race conditions are possible between PCI hotplug and the generic PCI bus rescan and device removal that can be triggered via sysfs. To avoid those race conditions make PCI hotplug use global PCI rescan-remove locking. Signed-off-by:

Re: REQ_PM vs REQ_TYPE_PM_RESUME

2014-01-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/10/2014 12:23 AM, Douglas Gilbert wrote: It is a command in the Sense Data Reporting feature set which is optional for ATA devices and P as in Prohibited for ATAPI devices. See the Feature set summary table. Oops, you're right. You had me

Re: Terrible performance of sequential O_DIRECT 4k writes in SAN environment. ~3 times slower then Solars 10 with the same HBA/Storage.

2014-01-10 Thread Sergey Meirovich
Hi Jan, On 10 January 2014 12:48, Jan Kara j...@suse.cz wrote: On Fri 10-01-14 12:36:22, Sergey Meirovich wrote: Hi Jan, On 10 January 2014 11:36, Jan Kara j...@suse.cz wrote: On Thu 09-01-14 12:11:16, Sergey Meirovich wrote: ... I've done preallocation on fnic/XtremIO as Christoph

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-10 Thread walt
On 01/09/2014 03:50 PM, Sarah Sharp wrote: On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: The aftermarket usb3 adapter card and the usb3 outboard hard-drive docking station are the only two usb3 devices I have. I've wondered if my xhci problems might be caused by hardware quirks, and

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-10 Thread David Laight
From: walt In the meantime, try this patch, which is something of a long shot. No difference. But I notice the code enables the TRB quirk only if the xhci_version is specifically 0x95. My debug messages claim that xHCI doesn't need link TRB QUIRK so I'm wondering if adding my asmedia

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-10 Thread Alan Stern
On Thu, 9 Jan 2014, Sarah Sharp wrote: I can't see anything obvious either. However there is no response to the 'stop endpoint' command. Section 4.6.9 (page 107 of rev1.0) states that the controller will complete any USB IN or OUT transaction before raising the command completion event.

[PATCH] gdth: Fixup section annotations

2014-01-10 Thread Hannes Reinecke
Fixup section annotations so that kbuild doesn't complain anymore. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/gdth.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index ce5ef01..98bd66e 100644 ---

[PATCH -next] target/rd: remove unused variable from target_core_rd.c

2014-01-10 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable 'sg_table' is initialized but never used otherwise, so remove the unused variable. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/target/target_core_rd.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH -next] target/sbc: Fix sparse non static symbol warning

2014-01-10 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warning: drivers/target/target_core_sbc.c:573:1: warning: symbol 'sbc_check_prot' was not declared. Should it be static? Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/target/target_core_sbc.c | 2

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-10 Thread Chen Gang
On 01/10/2014 01:47 PM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 11:17 +0100, Hannes Reinecke wrote: On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: SNIP Other than that the sector_div() patch is correct. nod

Re: [PATCH] gdth: Fixup section annotations

2014-01-10 Thread James Bottomley
On Fri, 2014-01-10 at 16:31 +0100, Hannes Reinecke wrote: Fixup section annotations so that kbuild doesn't complain anymore. This doesn't look right: __devinit is now an obsolete annotation. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

[LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

2014-01-10 Thread Mike Snitzer
I would like to attend to participate in discussions related to topics listed in the subject. As a maintainer of DM I'd be interested to learn/discuss areas that should become a development focus in the months following LSF. Thanks, Mike -- To unsubscribe from this list: send the line

Question about submitting large patchset for hpsa driver

2014-01-10 Thread scameron
Hi James, I have a large patch set for hpsa that's been brewing for awhile and it's finally stabilized. I notice you have a for-next and misc branches that are slightly different, and was wondering which branch of your tree you'd prefer the patches be tailored for, or if you'd prefer I hold off

Re: randconfig build error with next-20140110, in drivers/target/target_core_sbc.c

2014-01-10 Thread Nicholas A. Bellinger
Hi Jim, On Fri, 2014-01-10 at 06:57 -0700, Jim Davis wrote: Building with the attached random configuration file, LD init/built-in.o drivers/built-in.o: In function `sbc_dif_v1_verify': /home/jim/linux/drivers/target/target_core_sbc.c:1019: undefined reference to `crc_t10dif' make:

Re: [PATCH -next] target/rd: remove unused variable from target_core_rd.c

2014-01-10 Thread Nicholas A. Bellinger
On Fri, 2014-01-10 at 23:38 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable 'sg_table' is initialized but never used otherwise, so remove the unused variable. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] target/sbc: Fix sparse non static symbol warning

2014-01-10 Thread Nicholas A. Bellinger
Hi Wei, On Fri, 2014-01-10 at 23:39 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warning: drivers/target/target_core_sbc.c:573:1: warning: symbol 'sbc_check_prot' was not declared. Should it be static? Signed-off-by: Wei Yongjun

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-10 Thread David Milburn
Loc Ho wrote: This patch adds support for the APM X-Gene SoC SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/Kconfig

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Andy Grover
On 01/09/2014 10:21 PM, Nicholas A. Bellinger wrote: What about FORMAT_UNIT emulation? Would certainly be useful to have.. The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF support in INQUERY_EVPD/READ_CAPACITY you need to accept

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-10 Thread David Milburn
Loc Ho wrote: This patch adds support for the APM X-Gene SoC SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/Kconfig

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Nicholas A. Bellinger
On Fri, 2014-01-10 at 11:50 -0800, Andy Grover wrote: On 01/09/2014 10:21 PM, Nicholas A. Bellinger wrote: What about FORMAT_UNIT emulation? Would certainly be useful to have.. The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index 52ae54e..600ffcb 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -563,6 +563,27 @@ sbc_compare_and_write(struct

Re: [PATCH 05/14] target/spc: Add protection bit to standard INQUIRY output

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates spc_emulate_inquiry_std() to set the PROTECT bit nab when DIF emulation is enabled by the backend device. Technically, PROTECT only indicates whether a device is *capable* of storing PI. But in our case I guess that's

Re: [PATCH 06/14] target/spc: Add protection related bits to INQUIRY EVPD=0x86

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates spc_emulate_evpd_86() (extended INQUIRY) to nab report GRD_CHK (Guard Check) and REF_CHK (Reference Check) bits nab when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and nab PROT_EN bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@linux-iscsi.org writes: The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF support in INQUERY_EVPD/READ_CAPACITY you need to accept protection information format? nab Mmmm, these two bits bits are

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
Andy == Andy Grover agro...@redhat.com writes: Andy Yes, don't you need FORMAT UNIT because protection information is Andy going to mean the pi-enabled lun will need to report less blocks? Modern disk drives won't shrink when you reformat them with PI. This is a result of an IDEMA agreement

Re: [PATCH 08/14] target/spc: Expose ATO bit in control mode page

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates spc_modesense_control() to set the Application nab Tag Owner (ATO) bit when when DIF emulation is enabled by the nab backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch adds support for exposing DIF protection device nab attributes via configfs. This includes: nabpi_prot_type: Protection Type (0, 1, 3 currently support) nabpi_prot_version: Protection Version (DIF v1 currently

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-10 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi I wander how we can skip sbc_dif_verify_ if the transport Sagi already offloaded DIF verify. I think that the transport should Sagi signal the core layer that it is able to offload DIF Sagi (ADD/STRIP/PASS/VERIFY), in which case the core

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates tcm_loop_driver_probe() to set protection nab information using scsi_host_set_prot() and scsi_host_set_guard(), nab which currently enabled all modes of DIF/DIX protection, minus DIF nab TYPE0. ITYM, DIX Type 0. And

Re: [PATCH 3/6] scsi_debug: fix duplicate dif_errors increment

2014-01-10 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu It is unnecessary to increase dif_errors in dif_verify(), Akinobu because the caller will increment it when dif_verify() detects Akinobu failure. Akinobu This bug was introduced by commit beb40ea42bd6 ([SCSI] Akinobu scsi_debug:

Re: [PATCH 1/6] scsi_debug: fix false positive logical block reference tag check fail

2014-01-10 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu Reading partially unwritten sectors generates a false positive Akinobu logical block reference tag check failure when DIF is enabled. Akinobu This bug is caused by missing ei_lba increment in loop of Akinobu dif_verify() when

Re: [PATCH 3/6] libata: resume in the background

2014-01-10 Thread Dan Williams
On Mon, Dec 16, 2013 at 3:30 PM, Phillip Susi ps...@ubuntu.com wrote: Don't block the resume path waiting for the disk to spin up. --- drivers/ata/libata-core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c

RE: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-10 Thread Brandt, Todd E
On Thursday, January 09, 2014 9:04 AM, Phillip Susi wrote: I think my patch for this libata: resume in the background was a LOT simpler. It just used the existing behavior of becoming async when the async argument was !NULL, and fixed the one caller that didn't actually care about the result

Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

2014-01-10 Thread Vaughan Cao
On 2014年01月11日 04:24, Mike Christie wrote: On 01/10/2014 02:09 AM, vaughan wrote: On 01/10/2014 03:41 PM, Mike Christie wrote: On 1/10/14 12:11 AM, vaughan wrote: I haven't figure out why it's rejected with bookmark invalid(9) reason, rather than command not supported. IMO bookmark invalid

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/10/2014 06:11 PM, Brandt, Todd E wrote: Yes yours is simpler, but it also opens a potential memory issue by passing a static int as the return location for the error value. I think it's just safer to tell the callback to attempt no return