Private Message

2014-01-12 Thread Osbornes Solicitors LLP
My late client made his last will and testament in your favour, i sent letters to you but got no response, i advise you contact me immediately. Barr Mark Freedman -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-12 Thread Tejun Heo
Hello, On Sat, Jan 11, 2014 at 07:58:04PM -0800, Loc Ho wrote: The flush has to occurred immediately after reading the CI register. It can not wrap around the isr routine and issue the flush after or before the library ahci isr routine. I see. So, you're saying that if PMP support is

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:46 PM, Martin K. Petersen wrote: Andy == Andy Grover agro...@redhat.com writes: Andy Yes, don't you need FORMAT UNIT because protection information is Andy going to mean the pi-enabled lun will need to report less blocks? Modern disk drives won't shrink when you reformat them

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-12 Thread Sagi Grimberg
SNIP I wander how we can skip sbc_dif_verify_ if the transport already offloaded DIF verify. I think that the transport should signal the core layer that it is able to offload DIF (ADD/STRIP/PASS/VERIFY), in which case the core should turn off the backstore DIF verify emulation to sustain

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks,

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:39 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 9:00 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for exposing DIF protection device attributes via configfs. This

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:39 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Sagi Grimberg
SNIP nab This patch adds support for exposing DIF protection device nab attributes via configfs. This includes: nabpi_prot_type: Protection Type (0, 1, 3 currently support) nabpi_prot_version: Protection Version (DIF v1 currently supported) What's DIF v2? nabpi_guard_type: Guard

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done using the array management interface. Sagi So this takes me to a corner I still don't understand, if a LUN is Sagi pre-formatted

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-12 Thread Sagi Grimberg
On 1/11/2014 11:09 PM, Or Gerlitz wrote: On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: @@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event) goto out_mr; } + if (pi_support

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: The IP checksum is only supported by DIX between OS and initiator, not by the target. I guess we could signal to the initiator via a vendor-private VPD that IP checksum is supported directly. But now what we have hardware-accelerated T10

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/12/2014 2:33 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done using the array management interface. Sagi So this takes me to a corner I still

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-12 Thread Or Gerlitz
On 12/01/2014 14:41, Sagi Grimberg wrote: --- a/drivers/infiniband/ulp/isert/ib_isert.h +++ b/drivers/infiniband/ulp/isert/ib_isert.h @@ -48,11 +48,21 @@ struct iser_tx_desc { struct ib_send_wr send_wr; } __packed; +struct pi_context { + struct ib_mr *prot_mr;

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
Doug == Douglas Gilbert dgilb...@interlog.com writes: So this takes me to a corner I still don't understand, if a LUN is pre-formatted as T10-protected, what happens to unwritten blocks read? I mean, SCSI login executes some reads from sevel LBAs which will probably fail as blocks are

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Douglas Gilbert
On 14-01-12 12:21 PM, Martin K. Petersen wrote: Doug == Douglas Gilbert dgilb...@interlog.com writes: So this takes me to a corner I still don't understand, if a LUN is pre-formatted as T10-protected, what happens to unwritten blocks read? I mean, SCSI login executes some reads from sevel

[PATCH 1/7] be2iscsi: Fix handling timed out MBX completion from FW

2014-01-12 Thread Jayamohan Kallickal
When an MBX command timeout happens,the resources associated with the MBX command were freed. If FW were to give the response to host after the timeout value set by driver then driver crashes as the MBX Cmd resources were already freed. This patch fixes this issue by maintaing a state flag

[PATCH 2/7] be2iscsi: Fix port speed typo in driver.

2014-01-12 Thread Jayamohan Kallickal
The 100Mbps port speed macro used was not proper. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_iscsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/7] be2iscsi: Update to 10.2.84.0

2014-01-12 Thread Jayamohan Kallickal
This patchset updates be2iscsi driver to 10.2.84.0 and contains the following patches based of scsi.git for-next-base ` PATCH 0001 - Fix handling MBX completion time out PATCH 0002 - Fix typo in port speed PATCH 0003 - Fix IRQ Affinity Support in driver PATCH 0004 - Fix updating

[PATCH 7/7] be2iscsi : Bump driver version

2014-01-12 Thread Jayamohan Kallickal
Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index

[PATCH 6/7] be2iscsi: Fix the session cleanup when reboot/shutdown happens

2014-01-12 Thread Jayamohan Kallickal
In iSCSI Boot scenario, when machine is reboot/shutdown phase the active sessions are not closed. Driver queue cleanup is done as part of unload and device is disabled. Sessions are still active, iSCSI commands are issued from session which comes to driver, as driver cleanup and device

[PATCH 4/7] be2iscsi : Fix statistics update in the driver.

2014-01-12 Thread Jayamohan Kallickal
Statistics counters which are added is - NOP IN/OUT counters - Login PDU counters - Text PDU counters - Logout PDU counters - ASYNC_PDU counters - Reject PDU counters - Digest Error counters Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal

[PATCH 5/7] be2iscsi: Fix doorbell format for EQ/CQ/RQ s per SLI spec.

2014-01-12 Thread Jayamohan Kallickal
The doorbel format has been updated to support additonal functionalities of SKH-R adapter. These changes are made such that older FW also works fine. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com ---

[PATCH 3/7] be2iscsi : Fix IRQ_Affinity support in driver.

2014-01-12 Thread Jayamohan Kallickal
Provides IRQ_Affinity setting for the driver. Enabling IRQ_Affinity is through module params. Default IRQ_AFFINITY support is OFF. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.h |

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-12 Thread Loc Ho
Hi, On Sat, Jan 11, 2014 at 07:58:04PM -0800, Loc Ho wrote: The flush has to occurred immediately after reading the CI register. It can not wrap around the isr routine and issue the flush after or before the library ahci isr routine. I see. So, you're saying that if PMP support is disabled