Re: [PATCH 25/41] hpsa: teach hpsa_device_reset to do either target or lun reset

2014-01-16 Thread Hannes Reinecke
On 01/15/2014 11:38 PM, Stephen M. Cameron wrote: From: Scott Teel scott.t...@hp.com Signed-off-by: Scott Teel scott.t...@hp.com Acked-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH 38/41] hpsa: improve error messages for driver initiated commands

2014-01-16 Thread Hannes Reinecke
On 01/15/2014 11:39 PM, Stephen M. Cameron wrote: From: Stephen M. Cameron scame...@beardog.cce.hp.com On encountering unexpected error conditions from driver initiated commands, print something useful like CDB and sense data rather than something useless like the kernel virtual address of

[PATCH 2/6] megaraid_sas_fusion: Fixup fire_cmd syntax

2014-01-16 Thread Hannes Reinecke
The syntax for the 'fire_cmd' callback is not used correctly, so fix it up to be consistent with the original definition. Cc: Kashyap Desai kashyap.de...@lsi.com Cc: Adam Radford aradf...@gmail.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 26

[PATCH 1/6] megaraid_sas: Do not wait forever

2014-01-16 Thread Hannes Reinecke
If the firmware is incommunicado for whatever reason the driver will wait forever during initialisation, causing all sorts of hangcheck timers to trigger. We should rather wait for a defined time, and give up on the command if no response was received. Cc: Kashyap Desai kashyap.de...@lsi.com Cc:

[PATCH 3/6] megaraid_sas_fusion: correctly pass queue info pointer

2014-01-16 Thread Hannes Reinecke
The pointer to the queue info structure is potentially a 64-bit value, so we should be using the correct macros to set the values in the init frame. Cc: Kashyap Desai kashyap.de...@lsi.com Cc: Adam Radford aradf...@gmail.com Signed-off-by: Hannes Reinecke h...@suse.de ---

[PATCH 6/6] megaraid_sas: check return value for megasas_get_pd_list()

2014-01-16 Thread Hannes Reinecke
When megasas_get_pd_list() fails we cannot detect any drives, so we should be checking the return value accordingly. Cc: Kashyap Desai kashyap.de...@lsi.com Cc: Adam Radford aradf...@gmail.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/megaraid/megaraid_sas_base.c | 8 ++--

[PATCH 5/6] megaraid_sas_fusion: Return correct error value in megasas_get_ld_map_info()

2014-01-16 Thread Hannes Reinecke
When no HBA is found we should be returning '-ENXIO' to be consistent with the other return values. Cc: Kashyap Desai kashyap.de...@lsi.com Cc: Adam Radford aradf...@gmail.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- 1 file changed, 1

[PATCH 4/6] megaraid_sas: catch errors from megasas_get_map_info()

2014-01-16 Thread Hannes Reinecke
megasas_get_map_info() might fail, after which it'll be pointless to call megasas_sync_map_info(). So update megasas_get_map_info() to correctly handle errors and call megasas_sync_map_info() only if no error occurred. Cc: Kashyap Desai kashyap.de...@lsi.com Cc: Adam Radford aradf...@gmail.com

[PATCH 0/6] megaraid_sas: Fix system stall with iommu enabled

2014-01-16 Thread Hannes Reinecke
Hi all, recently I've enabled VT-d on one of my systems, which happened to have one of the latest Megaraid SAS cards (Fury) installed. And it failed miserably due to invalid DMAR tables. Which would be okay, if just the HBA failed to initialize. But the entire system stalled as the megaraid_sas

Re: [PATCH v9 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding

2014-01-16 Thread Arnd Bergmann
On Wednesday 15 January 2014 15:59:27 Loc Ho wrote: May be I misread what Mark mentioned. The binding documentation should not specify the requirement of 0. And the binding of the dts should be as is: phy1 { #phy-cells = 1; }; sata1 { ::: phys = phy1 0; where 0

[PATCH V2] pm80xx: Spinlock fix

2014-01-16 Thread Viswas G
From dfaae38ba7b6b7260fb3209d2dd12d70f0a8e306 Mon Sep 17 00:00:00 2001 From: Suresh Thiagarajan suresh.thiagara...@pmcs.com Date: Thu, 16 Jan 2014 15:26:21 +0530 Subject: [PATCH V2] pm80xx: Spinlock fix spin_lock_irqsave for the HBA lock is called in one function where flag is local to that

[LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread sagi grimberg
Hey SCSI folks, I'd like to propose the following topic for upcoming LSF-MM: T10-PI standard is becoming more and more appealing for storage and cloud solutions. Since error-detection coding comes with its cost of CPU computation overhead, state-of-the-art ASICs offer the ability to offload

[PATCH] isci: reformulate for_each_isci_host macro to fix an oops

2014-01-16 Thread Lukasz Dorau
The loop 'for' in macro 'for_each_isci_host' (drivers/scsi/isci/init.c:717) is executed more times than it can be. Regardless the condition: 'id ARRAY_SIZE(to_pci_info(pdev)-hosts)' (drivers/scsi/isci/host.h:315) it is executed when id equals ARRAY_SIZE(to_pci_info(pdev)-hosts) too. (Remark:

RE: [PATCH 25/41] hpsa: teach hpsa_device_reset to do either target or lun reset

2014-01-16 Thread Gates, Matt
Hi Hannes, Just want to chime in to clarify that in the case of a 'device reset', I think the driver's use of LUN Reset to the Smart Array controller is the correct choice here. This is because the 'device' is actually a single logical unit on the controller (logical RAID volume). Sending a

[PATCH v1 7/7] Target/configfs: Expose iSCSI network portal group T10-PI support

2014-01-16 Thread Sagi Grimberg
User may enable T10-PI support per network portal group. any connection established on top of it, will be required to serve protected transactions. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/target/iscsi/iscsi_target_configfs.c |6 ++

[PATCH v1 5/7] IB/isert: Accept RDMA_WRITE completions

2014-01-16 Thread Sagi Grimberg
In case of protected transactions, we will need to check the protection status of the transaction before sending SCSI response. So be ready for RDMA_WRITE completions. currently we don't ask for these completions, but for T10-PI we will. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH v1 3/7] IB/isert: Initialize T10-PI resources

2014-01-16 Thread Sagi Grimberg
Upon connection establishment check if network portal is T10-PI enabled and allocate T10-PI resources if necessary, allocate signature enabled memory regions and mark connection queue-pair as signature enabled. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH v1 2/7] Target/iscsi: Add T10-PI indication for iscsi_portal_group

2014-01-16 Thread Sagi Grimberg
In case an iscsi portal group will be defined as t10_pi enabled, all connections on top of it will support protected transactions. T10-PI support may require extra reource allocation and maintenance by the transport layer, so we don't want to apply them on non-t10_pi network portals. This is a

[PATCH v1 4/7] IB/isert: pass mr and frpl to isert_fast_reg_mr routine

2014-01-16 Thread Sagi Grimberg
This commit generalizes isert_fast_reg_mr to receive mr and frpl instead of fr_desc to do registration. In T10-PI we also register protection memory region so we want to use this routine. This commit does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH v1 0/7] iSER target initial support for T10-DIF offload

2014-01-16 Thread Sagi Grimberg
This patchset adds basic support for T10-DIF protection information offload in iSER target on top of Nic's recent work and RDMA signature verbs API. This code was tested with my own implementation of the target core T10-PI support which was designed mainly to activate the transport DIF offload.

Re: [PATCH 38/41] hpsa: improve error messages for driver initiated commands

2014-01-16 Thread scameron
On Thu, Jan 16, 2014 at 09:42:52AM +0100, Hannes Reinecke wrote: On 01/15/2014 11:39 PM, Stephen M. Cameron wrote: From: Stephen M. Cameron scame...@beardog.cce.hp.com On encountering unexpected error conditions from driver initiated commands, print something useful like CDB and sense

[LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread Sagi Grimberg
Hey SCSI (and LSF) folks, I'd like to propose the following topic for upcoming LSF-MM: T10-PI standard is becoming more and more appealing for storage and cloud solutions. Since error-detection coding comes with its cost of CPU computation overhead, state-of-the-art ASICs offer the ability to

Re: [PATCH V2] pm80xx: Spinlock fix

2014-01-16 Thread Jack Wang
On 01/16/2014 11:15 AM, Viswas G wrote: From dfaae38ba7b6b7260fb3209d2dd12d70f0a8e306 Mon Sep 17 00:00:00 2001 From: Suresh Thiagarajan suresh.thiagara...@pmcs.com Date: Thu, 16 Jan 2014 15:26:21 +0530 Subject: [PATCH V2] pm80xx: Spinlock fix spin_lock_irqsave for the HBA lock is called in

[PATCH v10 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-16 Thread Loc Ho
This patch adds support for the APM X-Gene SoC SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/Kconfig |8 +

[PATCH v10 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding

2014-01-16 Thread Loc Ho
Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- .../devicetree/bindings/ata/apm-xgene.txt | 70 1 files changed, 70 insertions(+), 0 deletions(-) create mode 100644

[PATCH v8 1/4] PHY: Add function set_speed to generic PHY framework

2014-01-16 Thread Loc Ho
This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. Signed-off-by: Loc Ho l...@apm.com --- drivers/phy/phy-core.c | 21

[PATCH v8 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2014-01-16 Thread Loc Ho
Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- .../devicetree/bindings/phy/apm-xgene-phy.txt | 79 1 files changed, 79 insertions(+), 0 deletions(-) create mode 100644

[PATCH v10 1/4] ata: Export required functions by APM X-Gene SATA driver

2014-01-16 Thread Loc Ho
This patch exports functions required by APM X-Gene SoC SATA host controller driver to avoid duplication of code. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci.h|9 +

[PATCH v10 4/4] arm64: Add APM X-Gene SoC SATA host controller DTS entries

2014-01-16 Thread Loc Ho
Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- arch/arm64/boot/dts/apm-storm.dtsi | 75 1 files changed, 75 insertions(+), 0 deletions(-) diff --git

[PATCH v8 4/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-01-16 Thread Loc Ho
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose PHY driver. The PHY for SATA controller 2 and 3 are enabled by default. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com ---

[no subject]

2014-01-16 Thread Loc Ho
This patch adds support for the APM X-Gene SoC SATA host controller. In order for the host controller to work, the corresponding PHY driver musts also be available. v10: * Update binding documentation v9: * Remove ACPI/EFI include files * Remove the IO flush support, interrupt routine, and

[no subject]

2014-01-16 Thread Loc Ho
This patch adds support for APM X-Gene SoC 15Gbps Multi-purpose PHY. This is the physical layer interface for the corresponding host controller. This driver uses the new PHY generic framework posted by Kishon Vijay Abrahm. In addition, the new PHY generic framework is patched to provide an

Re: [LSF/MM TOPIC] [ATTEND] scsi-mq

2014-01-16 Thread Sagi Grimberg
On 1/16/2014 1:05 AM, Nicholas A. Bellinger wrote: Hi all, I'd like to discuss the current state of scsi-mq prototype code. And now that blk-mq is upstream for v3.13, exploring the remaining TODO items towards an initial scsi-mq merge sometime before 2015 is upon us. The benefits of scsi-mq

Disk spin-up optimization during system resume

2014-01-16 Thread Alan Stern
Folks: I would like to tie together separate email threads regarding disk spin-up time during system resume. Todd has posted some patches to make spin-up occur asynchronously, thus not delaying the return of the system to normal operation. Phillip and I have been designing an approach to allow

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Todd E Brandt
On Thu, Jan 16, 2014 at 11:59:43AM -0500, Alan Stern wrote: Folks: I would like to tie together separate email threads regarding disk spin-up time during system resume. Todd has posted some patches to make spin-up occur asynchronously, thus not delaying the return of the system to normal

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/16/2014 1:04 PM, Todd E Brandt wrote: Both approaches employ non-blocking resume of the scsi disks so why don't we treat these two patch sets as parts one and two. My patch just spins everything up but sets everything to non-blocking, so it

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/16/2014 11:59 AM, Alan Stern wrote: Since the START-STOP and TEST UNIT READY (or REQUEST SENSE or whatever) commands are likely to take a long time, they should all be carried out asynchronously with respect to the resume procedure. I don't

[PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-16 Thread Mike Miller
From: Mike Miller mike.mil...@hp.com This patch has every ID we have in our svn repository. Some controllers were cancelled, others added, now the cancelled ones are back. Apparently the debate rages on about which controllers are cancelled, which are not, whatever. Please accept this patch. It

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Alan Stern
On Thu, 16 Jan 2014, Todd E Brandt wrote: Does this plan sound reasonable to everyone? Are there important aspects I haven't considered (such as interactions between the SCSI and ATA layers)? Alan Stern Both approaches employ non-blocking resume of the scsi disks so why don't

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Alan Stern
On Thu, 16 Jan 2014, Phillip Susi wrote: On 1/16/2014 11:59 AM, Alan Stern wrote: Since the START-STOP and TEST UNIT READY (or REQUEST SENSE or whatever) commands are likely to take a long time, they should all be carried out asynchronously with respect to the resume procedure. I don't

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-16 Thread Sarah Sharp
On Tue, Jan 14, 2014 at 01:27:25PM -0800, walt wrote: On 01/14/2014 09:20 AM, Sarah Sharp wrote: On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote: Sarah, I just fixed my xhci bug for US$19.99 :) #lspci | tail -1 04:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host

Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2014-01-16 Thread Alan Stern
It's now clear that this is _not_ an XHCI issue, contrary to what $SUBJECT says. On Thu, 16 Jan 2014, Peter PalĂșch wrote: Alan, I am attaching the usbmon trace after the drive has been plugged into the USB-2 port. Record of the drive in stall should occur around the file offset 87808

Re: [PATCH] qla2xxx: Configure NPIV fc_vport via tcm_qla2xxx_npiv_make_lport

2014-01-16 Thread Quinn Tran
Nicholas, Comments inline. Thanks. SNIP Bullet 3) Generating NPIV WWPN id: Qlogic overall strategy for this question is: Qla2xxx driver is a common driver being used by various hardware vendors(HP, IBM, Dell, etc..). Each vendors have a different scheme on how to generate the WWPN value.

Re: [LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread Nicholas A. Bellinger
On Thu, 2014-01-16 at 17:12 +0200, Sagi Grimberg wrote: Hey SCSI (and LSF) folks, I'd like to propose the following topic for upcoming LSF-MM: T10-PI standard is becoming more and more appealing for storage and cloud solutions. Since error-detection coding comes with its cost of CPU

Re: [PATCH] qla2xxx: Configure NPIV fc_vport via tcm_qla2xxx_npiv_make_lport

2014-01-16 Thread Nicholas A. Bellinger
On Thu, 2014-01-16 at 20:54 +, Quinn Tran wrote: Nicholas, Comments inline. Thanks. SNIP Bullet 3) Generating NPIV WWPN id: Qlogic overall strategy for this question is: Qla2xxx driver is a common driver being used by various hardware vendors(HP, IBM, Dell, etc..). Each vendors

Re: Disk spin-up optimization during system resume

2014-01-16 Thread Todd E Brandt
On Thu, Jan 16, 2014 at 03:05:40PM -0500, Alan Stern wrote: On Thu, 16 Jan 2014, Todd E Brandt wrote: Does this plan sound reasonable to everyone? Are there important aspects I haven't considered (such as interactions between the SCSI and ATA layers)? Alan Stern Both

Re: [LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

2014-01-16 Thread Giridhar Malavali
On 1/10/14 10:27 AM, Mike Snitzer snit...@redhat.com wrote: I would like to attend to participate in discussions related to topics listed in the subject. As a maintainer of DM I'd be interested to learn/discuss areas that should become a development focus in the months following LSF. +1 for

Re: [PATCH/RESEND v2 0/2] Hard disk S3 resume time optimization

2014-01-16 Thread Gwendal Grignou
You're right, staggered spinup is not enforced today when the disks are behind several ATA ports. Only the disks behind a port multiplier are spun up one at a time. We are currently waiting for all the device(s) on the slowest port to resume to continue. Gwendal. On Tue, Jan 14, 2014 at 1:45 PM,

[GIT PULL] target fixes for v3.13

2014-01-16 Thread Nicholas A. Bellinger
Hello Linus, Here are the outstanding target fixes for v3.13 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master This series addresses a specific = v3.12 regression related to the iscsi-target percpu_ida conversion that has been

Re: [LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread Quinn Tran
On 1/16/14 7:12 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: Hey SCSI (and LSF) folks, I'd like to propose the following topic for upcoming LSF-MM: T10-PI standard is becoming more and more appealing for storage and cloud solutions. Since error-detection coding comes with its cost of CPU

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-16 Thread Nicholas A. Bellinger
On Fri, 2014-01-03 at 15:09 -0500, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@linux-iscsi.org writes: nab Given that bio_integrity_verify() is using bio_for_each_segment(), nab the loop starts from the updated bio-bi_idx, and not a zero value, nab which ends up skipping

Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2014-01-16 Thread Hannes Reinecke
On 01/16/2014 09:48 PM, Alan Stern wrote: It's now clear that this is _not_ an XHCI issue, contrary to what $SUBJECT says. On Thu, 16 Jan 2014, Peter PalĂșch wrote: Alan, I am attaching the usbmon trace after the drive has been plugged into the USB-2 port. Record of the drive in stall