[PATCH] scsi: storvsc_device_destroy NULL pointer fix

2014-02-27 Thread Ales Novak
If the initialization of storvsc fails, the storvsc_device_destroy() causes NULL pointer dereference. storvsc_bus_scan() scsi_scan_target() __scsi_scan_target() scsi_probe_and_add_lun(hostdata=NULL) scsi_alloc_sdev(hostdata=NULL) sdev-hostdata = hostdata

[PATCH v1.4 1/11] arcmsr: Rewrite interrupt service routine to fix command timeout

2014-02-27 Thread Huang ching-lung
From: Ching ching2...@areca.com.tw Rewrite interrupt service routine to fix command timeout on controller too heavy loading. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1 02/13] IB/iser: Push the desicion what memory key to use into fast_reg_mr routine

2014-02-27 Thread Sagi Grimberg
This is a preparation step for T10-PI offload support. We prefer to push the desicion of which mkey to use (global or fastreg) to iser_fast_reg_mr. We choose to do this since it in T10-PI we may need to register for protection buffers and in this case we wish to simplify iser_fast_reg_mr instead

[PATCH v1 05/13] IB/iser: Replace fastreg descriptor valid bool with indicators container

2014-02-27 Thread Sagi Grimberg
In T10-PI support we will have memory keys for protection buffers and signature transactions. We prefer to compact indicators rather than keeping multiple bools. This commit does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Alex Tabachnik

[PATCH v1 04/13] IB/iser: Keep IB device attributes under iser_device

2014-02-27 Thread Sagi Grimberg
For T10-PI offload support, we will need to know the device signature offload capability upon every connection establishment. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Alex Tabachnik al...@mellanox.com ---

[PATCH v1 03/13] IB/iser: Move fast_reg_descriptor initialization to a function

2014-02-27 Thread Sagi Grimberg
fastreg descriptor will include protection information context. In order to place the logic in one place we introduce iser_create_fr_desc function. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Alex Tabachnik al...@mellanox.com ---

[PATCH v1 07/13] IB/iser: Generalize fall_to_bounce_buf routine

2014-02-27 Thread Sagi Grimberg
Unaligned SG-lists may also happen for protection information. Genrelize bounce buffer routine to handle any iser_data_buf which may be data and/or protection. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-02-27 Thread Sagi Grimberg
iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike transport errors, DIF errors should not prevent successful completion of the

[PATCH v1 09/13] IB/iser: Initialize T10-PI resources

2014-02-27 Thread Sagi Grimberg
From: Alex Tabachnik al...@mellanox.com During connection establishment we also initiatlize T10-PI resources (QP, PI contexts) in order to support SCSI's protection operations. Signed-off-by: Alex Tabachnik al...@mellanox.com Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH v1 08/13] IB/iser: Introduce pi_enable, pi_guard module parameters

2014-02-27 Thread Sagi Grimberg
From: Alex Tabachnik al...@mellanox.com Use modparams to activate protection information support. pi_enable bool: Based on this parameter iSER will know if it should support T10-PI. We don't want to do this by default as it requires to allocate and initiatlize extra resources. In case

[PATCH v1 01/13] IB/iser: Avoid FRWR notation, use fastreg instead

2014-02-27 Thread Sagi Grimberg
FRWR stands for fast registration work request. We want to avoid calling the fastreg pool with that name, instead we name it fastreg which stands for fast registration. This pool will include more elements in the future, so it is a good idea to generalize the name. Signed-off-by: Sagi Grimberg

[PATCH v1 12/13] IB/iser: Implement check_protection

2014-02-27 Thread Sagi Grimberg
Once the iSCSI transaction is completed we must imeplement check_protection in order to notify on DIF errors that may have occured. The routine boils down to calling ib_check_mr_status to get the signature status of the transaction. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by:

[PATCH v1 00/13] T10-PI support for iSER initiator

2014-02-27 Thread Sagi Grimberg
Hey Roland, Nic and Co This patchset adds T10 protection information offload support over RDMA signature verbs API. This set, along with the iSER target set, allow end-to-end protection information passthrough and validation. The patchset was tested against Linux SCSI target with iSER DIF support

[PATCH v1 06/13] IB/iser: Generalize iser_unmap_task_data and finalize_rdma_unaligned_sg

2014-02-27 Thread Sagi Grimberg
This routines operates on data buffers and may also work with protection infomation buffers. So we generalize them to handle an iser_data_buf which can be the command data or command protection information. This patch does not change any functionality. Signed-off-by: Sagi Grimberg

[PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-02-27 Thread Sagi Grimberg
Add logic to initialize protection information entities. Upon each iSCSI task, we keep the scsi_cmnd in order to query the scsi protection operations and reference to protection buffers. Modify iser_fast_reg_mr to receive indication weather it is registering the data or protection buffers. In

[PATCH v1 13/13] IB/iser: Publish T10-PI support to SCSI midlayer

2014-02-27 Thread Sagi Grimberg
After allocating a scsi_host we set protection types and guard type supported. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Alex Tabachnik al...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++- 1 files changed, 22 insertions(+), 1

Re: [PATCH 00/16] sleep_on removal, second try

2014-02-27 Thread Geert Uytterhoeven
Hi Michael, Arnd, On Thu, Feb 27, 2014 at 7:37 AM, Michael Schmitz schm...@biophys.uni-duesseldorf.de wrote: It's been a while since the first submission of these patches, but a lot of them have made it into linux-next already, so here is the stuff that is not merged yet, hopefully addressing

[Bug 71231] New: System unresponsable after a lot of LUNs have been added to the system

2014-02-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71231 Bug ID: 71231 Summary: System unresponsable after a lot of LUNs have been added to the system Product: IO/Storage Version: 2.5 Kernel Version: 3.10.32 Hardware: x86-64

[Bug 71231] System unresponsable after a lot of LUNs have been added to the system

2014-02-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71231 --- Comment #1 from Alex alexandernaum...@gmx.de --- Created attachment 127591 -- https://bugzilla.kernel.org/attachment.cgi?id=127591action=edit Kernel messages -- You are receiving this mail because: You are the assignee for the bug. -- To

[Bug 71231] System unresponsable after a lot of LUNs have been added to the system

2014-02-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71231 --- Comment #2 from Alex alexandernaum...@gmx.de --- Part of the attached kernel messages: [ 119.504736] Code: 00 48 89 f0 48 c7 06 00 00 00 00 48 89 e5 48 87 07 48 85 c0 75 09 c7 46 08 01 00 00 00 5d c3 48 89 30 8b 46 08 85 c0 75 f4 f3 90 8b 46

[PATCH v12 0/4] PHY: Add APM X-Gene SoC 15Gbps Multi-purpose PHY support

2014-02-27 Thread Loc Ho
This patch adds support for APM X-Gene SoC 15Gbps Multi-purpose PHY. This is the physical layer interface for the corresponding host controller. This driver uses the PHY generic framework. In addition, the PHY generic framework is patched to provide an function to set the speed of the PHY. v12: *

[PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Loc Ho
This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. Signed-off-by: Loc Ho l...@apm.com --- drivers/phy/phy-core.c | 30

[PATCH v12 4/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-02-27 Thread Loc Ho
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose PHY driver. The PHY for SATA controller 2 and 3 are enabled by default. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com ---

[PATCH v12 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2014-02-27 Thread Loc Ho
This patch adds APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- .../devicetree/bindings/phy/apm-xgene-phy.txt | 79 1

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote: +/* + * This function is used to configure the PHY to operation as either SATA Gen1 + * or Gen2 speed. + */ +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, + int lane, int gen)

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Loc Ho
Hi Balbi, On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Loc Ho
Hi Balbi, +/* + * This function is used to configure the PHY to operation as either SATA Gen1 + * or Gen2 speed. + */ +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, + int lane, int gen) why do you need to *force* the generation ? Is

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-27 Thread Arnd Bergmann
On Thursday 27 February 2014, Michael Schmitz wrote: Arnd Bergmann wrote: Nack - the completion condition in the first hunk has its logic reversed. Try this instead (while() loops while condition true, do {} until () loops while condition false, no?) Sorry about messing it up again. I

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:57:44AM -0800, Loc Ho wrote: On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Loc Ho
Hi, This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like clk_set_rate() is your friend here. Can you be more

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 01:09:57PM -0800, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Loc Ho
HI, This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like clk_set_rate() is your friend here. Can

Outlook gebruiker waarschuwing.

2014-02-27 Thread Karen Williams
Geachte Webmail Gebruiker, Uw twee inkomende mails hangende toestand geplaatst als gevolg van de recente upgrade in onze database. in volgorde te ontvangen uw berichten KLIK HIERhttp://goorsoicuesaeorusdoisda.webs.com/ Login met uw juiste Webmail informatie en wachten op antwoordt van onze

[PATCH] scsi_dh_alua: Requeue another not ready check condition at ML

2014-02-27 Thread Stewart, Sean
This allows the sd driver to retry commands like read capacity until a LUN is ready, rather than giving up after three retries. In NetApp E-Series, a controller can return not ready like this when it quiesces I/O on the controller that just came on the network, during a firmware upgrade

[RESEND PATCH v3] scsi: Add timeout to avoid infinite command retry

2014-02-27 Thread Eiichi Tsukata
Currently, scsi error handling in scsi_io_completion() tries to unconditionally requeue scsi command when device keeps some error state. For example, UNIT_ATTENTION causes infinite retry with action == ACTION_RETRY. This is because retryable errors are thought to be temporary and the scsi device

RE: [PATCH] scsi: storvsc_device_destroy NULL pointer fix

2014-02-27 Thread KY Srinivasan
-Original Message- From: Ales Novak [mailto:alno...@suse.cz] Sent: Thursday, February 27, 2014 2:04 AM To: KY Srinivasan; James E.J. Bottomley Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; jkos...@suse.cz; Ales Novak; Thomas Abraham Subject: [PATCH] scsi:

Re: [PATCH 7/8] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2014-02-27 Thread Ren Mingxin
Hi, Hannes: On 10/23/2013 04:51 PM, Hannes Reinecke wrote: This patchs adds an 'eh_deadline' sysfs attribute to the scsi host which limits the overall runtime of the SCSI EH. As you known, adding to scsi host means such interface has also been added to the SATA and USB controllers. But to

Re: [PATCH 7/8] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2014-02-27 Thread Hannes Reinecke
On 02/28/2014 08:01 AM, Ren Mingxin wrote: Hi, Hannes: On 10/23/2013 04:51 PM, Hannes Reinecke wrote: This patchs adds an 'eh_deadline' sysfs attribute to the scsi host which limits the overall runtime of the SCSI EH. As you known, adding to scsi host means such interface has also been

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-02-27 Thread Hannes Reinecke
On 02/13/2014 11:27 AM, Hannes Reinecke wrote: Hi all, After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the patch, and we don't have to worry