Re: [PATCH 4/6] iser-target: Fix post_send_buf_count for RDMA READ/WRITE

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 9:49 AM, Or Gerlitz wrote: On 04/03/2014 02:01, Nicholas A. Bellinger wrote: This is necessary because even though IB_SEND_SIGNALED is not set for RDMA WRITEs + READs, during a QP failure event the work requests will be returned with exception status from the TX completion queue.

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in the init_task callout instead. If it makes it easier on the driver implementation then

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in the init_task callout instead. If it makes it

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 04/03/2014 11:59, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 1:25 PM, Or Gerlitz wrote: On 04/03/2014 11:59, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would

Re: [PATCH 5/6] iser-target: Ignore completions for FRWRs in isert_cq_tx_work

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 2:01 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch changes IB_WR_FAST_REG_MR + IB_WR_LOCAL_INV related work requests to include a ISER_FRWR_LI_WRID value in order to signal isert_cq_tx_work() that these requests should be ignored. This is

Re: [PATCH 0/6] iser-target: Fix active I/O shutdown related issues

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Or Sagi, This series addresses a number of active I/O shutdown related issues in iser-target code that have come up recently during stress testing. Note there is still a seperate iser-target

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Or Gerlitz
On 04/03/2014 16:44, Sagi Grimberg wrote: @@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) goto prepd_fault; } } - if (session-tt-xmit_task(task)) { -

Re: [PATCH v14 2/3] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday, February 24, 2014 10:28:06 PM Loc Ho wrote: This patch adds support for the APM X-Gene SoC AHCI SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by:

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-04 Thread Sagi Grimberg
On 3/4/2014 6:16 PM, Or Gerlitz wrote: On 04/03/2014 16:44, Sagi Grimberg wrote: @@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) goto prepd_fault; } } - if

Re: [PATCH v2 23/23] vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-03-04 Thread Arvind Kumar
Hi Alexander, This looks fine to me. Acked-by: Arvind Kumar arvindku...@vmware.com Thanks! Arvind - Original Message - From: Alexander Gordeev agord...@redhat.com To: linux-ker...@vger.kernel.org Cc: Alexander Gordeev agord...@redhat.com, Arvind Kumar arvindku...@vmware.com,

Re: [PATCH 5/6] iser-target: Ignore completions for FRWRs in isert_cq_tx_work

2014-03-04 Thread Nicholas A. Bellinger
On Tue, 2014-03-04 at 16:51 +0200, Sagi Grimberg wrote: On 3/4/2014 2:01 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch changes IB_WR_FAST_REG_MR + IB_WR_LOCAL_INV related work requests to include a ISER_FRWR_LI_WRID value in order to signal

[PATCH] [RESEND] [SCSI] NCR5380: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag from drivers/scsi/NCR5380.c It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/NCR5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] [RESEND] [SCSI] aacraid: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of IRQF_DISABLED from code in drivers/scsi/aacraid/ It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/aacraid/rx.c | 2 +- drivers/scsi/aacraid/sa.c | 3 +--

[PATCH] [RESEND] [SCSI] aha152x: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag from drivers/scsi/aha152x.c It's a NOOP since 2.6.35 and it will be removed one day. Also taking the opportunity to fix checkpatch issues on the lines I modified Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com ---

[PATCH] [RESEND] [SCSI] aic7xxx: remove duplicate define

2014-03-04 Thread Michael Opdenacker
Remove duplicate define in drivers/scsi/aic7xxx/aicasm/aicasm_insformat.h Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com Acked-by: Hannes Reinecke h...@suse.de --- drivers/scsi/aic7xxx/aicasm/aicasm_insformat.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] [RESEND] [SCSI] eata: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag from drivers/scsi/eata* It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/eata.c | 2 +- drivers/scsi/eata_pio.c | 4 ++-- 2 files changed, 3

[PATCH] [RESEND] [SCSI] ibmvstgt: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag from drivers/scsi/ibmvscsi/ibmvstgt.c It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/ibmvscsi/ibmvstgt.c | 2 +- 1 file changed, 1

[PATCH] [RESEND] [SCSI] u14-34f: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the the use of the IRQF_DISABLED flag from drivers/scsi/u14-34f.c It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/u14-34f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] [RESEND] [SCSI] wd7000: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag from drivers/scsi/wd7000.c It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/wd7000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] [RESEND] [SCSI] misc drivers: remove deprecated IRQF_DISABLED

2014-03-04 Thread Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag in several drivers in drivers/scsi/ It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com --- drivers/scsi/dtc.c| 2 +-

Re: [PATCH 1/2] megaraid_sas: fix a small problem when reading state value from hw

2014-03-04 Thread Minemoto, Shintaro
Hi Tomas, When the driver reads state values from the hw it might happen that different values are read in subsequent reads and this can cause problems, this may lead to a timeout in this function and a non working adapter. I reviewed your patch and it looks good to me. Reviewed-by:

Re: [PATCH 2/2] megaraid_sas: remove unused variables

2014-03-04 Thread Minemoto, Shintaro
Hi Tomas, Some, almost not used variables removed. I reviewed your patch and it looks good to me. Reviewed-by: Shintaro Minemoto fj320...@aa.jp.fujitsu.com # I'm not in scsi-linux mailing list. Please cc me when you reply. Thanks, Shintaro Minemoto -- To unsubscribe from this list: send

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-04 Thread Hannes Reinecke
On 02/28/2014 06:01 PM, Christoph Hellwig wrote: On Thu, Feb 13, 2014 at 11:07:11AM +0100, Hannes Reinecke wrote: EVPD page 0x83 is used to uniquely identify the device. So instead of having each and every program issue a separate SG_IO call to retrieve this information it does make far more

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-04 Thread Hannes Reinecke
On 03/02/2014 09:36 AM, Bart Van Assche wrote: On 02/13/14 11:28, Hannes Reinecke wrote: -return 0; +return (buffer[2] 8) + buffer[3] + 4; Has it been considered to use get_unaligned_be16() instead of open coding this function ? Ok. Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-04 Thread Hannes Reinecke
On 03/02/2014 09:34 AM, Bart Van Assche wrote: On 02/13/14 11:28, Hannes Reinecke wrote: static ssize_t -show_iostat_counterbits(struct device *dev, struct device_attribute *attr, char *buf) +show_vpd_pg(const unsigned char *pg_buf, int pg_len, char *buf) +{ +