-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/17/2014 11:11 PM, Jeremy Linton wrote:
On 3/15/2014 3:51 AM, Hannes Reinecke wrote:
Add a flag 'vpd_invalid' to the SCSI device to indicate that
the VPD data needs to be refreshed. This is required if
either a manual rescan is triggered or
This patch removes the use of the IRQF_DISABLED flag
from drivers/scsi/NCR5380.c
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/NCR5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch removes the use of IRQF_DISABLED
from code in drivers/scsi/aacraid/
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/aacraid/rx.c | 2 +-
drivers/scsi/aacraid/sa.c | 3 +--
This patch removes the use of the IRQF_DISABLED flag
from drivers/scsi/aha152x.c
It's a NOOP since 2.6.35 and it will be removed one day.
Also taking the opportunity to fix checkpatch issues on the lines I modified
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
Remove duplicate define
in drivers/scsi/aic7xxx/aicasm/aicasm_insformat.h
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
Acked-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/aic7xxx/aicasm/aicasm_insformat.h | 1 -
1 file changed, 1 deletion(-)
diff --git
This patch removes the use of the IRQF_DISABLED flag
from drivers/scsi/eata*
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/eata.c | 2 +-
drivers/scsi/eata_pio.c | 4 ++--
2 files changed, 3
This patch removes the use of the IRQF_DISABLED flag
from drivers/scsi/ibmvscsi/ibmvstgt.c
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/ibmvscsi/ibmvstgt.c | 2 +-
1 file changed, 1
This patch removes the the use of the IRQF_DISABLED flag
from drivers/scsi/u14-34f.c
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/u14-34f.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch removes the use of the IRQF_DISABLED flag
from drivers/scsi/wd7000.c
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/wd7000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch removes the use of the IRQF_DISABLED flag
in several drivers in drivers/scsi/
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
---
drivers/scsi/dtc.c| 2 +-
If during data-transfer a data-integrity error was detected we
must fail the command with CHECK_CONDITION and not execute
the command.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
On Mon, 17 Mar 2014, Joe Perches wrote:
My preference would be to change dprintk to scsi_dbg
Can you be more specific? I gather you're not referring to the debugging
routines in include/scsi/scsi_dbg.h as they aren't equivalent.
Is it the name dprintk you object to?
I went looking in
Oleg Nesterov wrote:
If we need the urgent hack to fix the regression, then I suggest to change
scsi_host_alloc() temporary until mptsas (or whatever) is fixed.
Device initialization taking longer than 30 seconds is possible and is not a
hang up. It is systemd which needs to be fixed.
---
On Tue, Mar 18, 2014 at 1:45 PM, Joe Perches j...@perches.com wrote:
NCR does use pr_debug for the dprintk call, but
it also doesn't verify fmt/arg matching when not
compiled in
drivers/scsi/NCR5380.h-#if NDEBUG
drivers/scsi/NCR5380.h:#define dprintk(flg, fmt, args...) \
On 18/03/2014 14:52, Sagi Grimberg wrote:
If during data-transfer a data-integrity error was detected we
must fail the command with CHECK_CONDITION and not execute
the command.
Cnages from v0:
- Added reported-by Or gerlitz
Signed-off-by: Sagi Grimbergsa...@mellanox.com
Reported-by: Or
If during data-transfer a data-integrity error was detected we
must fail the command with CHECK_CONDITION and not execute
the command.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Reported-by: Or Gerlitz ogerl...@mellanox.com
---
Changes from v1:
- Fixed typo
Changes from v0:
- Added
GOOGLE INTERNATIONALE Förderung-GEWINNZUTEILUNG
GOOGLE Förderung
GOOGLE Einarbeitung©
UROPA INTERLOTTO/EUROMILLINEN LOTTO BONUS-PROGRAMM
BEL-GRAVE HOUSE, 76 BUCKINGHAM PALACE ROAD,
LONDON SW1W 9TQ, UNITED KINGDOM.OFFICE;
VOM SCHREIBTISCH VON VICE PRESIDENT INTERNATIONAL
On Tue, 2014-03-18 at 13:55 +0100, Geert Uytterhoeven wrote:
On Tue, Mar 18, 2014 at 1:45 PM, Joe Perches j...@perches.com wrote:
Hi Geert.
#define dprintk(flg, fmt, ...) \
do { if (0) pr_debug(fmt, ##__VA_ARGS__); } while (0)
Na, no_printk():
#define dprintk(flg, fmt, ...)
Hi Joe,
On Tue, Mar 18, 2014 at 2:07 PM, Joe Perches j...@perches.com wrote:
On Tue, 2014-03-18 at 13:55 +0100, Geert Uytterhoeven wrote:
On Tue, Mar 18, 2014 at 1:45 PM, Joe Perches j...@perches.com wrote:
#define dprintk(flg, fmt, ...) \
do { if (0) pr_debug(fmt, ##__VA_ARGS__); } while
On Tue, 2014-03-18 at 07:52 +0100, Hannes Reinecke wrote:
On 03/17/2014 11:11 PM, Jeremy Linton wrote:
On 3/15/2014 3:51 AM, Hannes Reinecke wrote:
Add a flag 'vpd_invalid' to the SCSI device to indicate that
the VPD data needs to be refreshed. This is required if
either a manual rescan
On Tue, 2014-03-18 at 14:13 +0100, Geert Uytterhoeven wrote:
no_printk keeps all side effects like
performing any function calls made by the
statement or accessing any volatiles.
That's true...
Using
do { if (0) no_printk(fmt, ##__VA_ARGS__); } while (0)
does not have any
Does anyone still have a device listed in the blacklist with
BLIST_SINGLELUN?
From reading the source code I'm not sure the code actually works as
expected currently, or did for a long time.
While scsi_target_queue_ready makes sure to only queue commands to the
right lun as long as
On 03/17/2014 11:11 PM, Jeremy Linton wrote:
I didn't study the whole code path but does the VPD data get
updated on a 6/2900? I suspect it should be. I can imagine a
number of cases where the luns changed check condition gets
preempted/lost by a device reset. I guess much of that
On Fri, Mar 14, 2014 at 01:52:48PM -0700, Dan Williams wrote:
Tejun says:
At least for libata, worrying about suspend/resume failures don't make
whole lot of sense. If suspend failed, just proceed with suspend. If
the device can't be woken up afterwards, that's that. There isn't
On Tue, Mar 18, 2014 at 9:03 AM, Tejun Heo t...@kernel.org wrote:
On Fri, Mar 14, 2014 at 01:52:48PM -0700, Dan Williams wrote:
Tejun says:
At least for libata, worrying about suspend/resume failures don't make
whole lot of sense. If suspend failed, just proceed with suspend. If
the
On 03/18, Tetsuo Handa wrote:
Oleg Nesterov wrote:
If we need the urgent hack to fix the regression, then I suggest to change
scsi_host_alloc() temporary until mptsas (or whatever) is fixed.
Device initialization taking longer than 30 seconds is possible and is not a
hang up. It is
This patch fixes an compiler warning with APM X-Gene host controller
driver when compiled with DEBUG enabled.
Signed-off-by: Loc Ho l...@apm.com
---
drivers/ata/ahci_xgene.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/ahci_xgene.c
On Tue, Mar 18, 2014 at 12:14:37PM -0600, Loc Ho wrote:
This patch fixes an compiler warning with APM X-Gene host controller
driver when compiled with DEBUG enabled.
Signed-off-by: Loc Ho l...@apm.com
Applied to libata/for-3.15.
Thanks.
--
tejun
--
To unsubscribe from this list: send the
On Fri, Mar 14, 2014 at 01:52:48PM -0700, Dan Williams wrote:
Tejun says:
At least for libata, worrying about suspend/resume failures don't make
whole lot of sense. If suspend failed, just proceed with suspend. If
the device can't be woken up afterwards, that's that. There isn't
It's easier to use kcalloc for allocating arrays. While at it
also remove useless casting value.
Signed-off-by: Matei Oprea e...@opreamatei.ro
Cc: ROSEdu Kernel Community fire...@lists.rosedu.org
---
drivers/scsi/lpfc/lpfc_init.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Tue, 18 Mar 2014, Joe Perches wrote:
On Tue, 2014-03-18 at 13:55 +0100, Geert Uytterhoeven wrote:
#define dprintk(flg, fmt, ...) no_printk(fmt, ##__VA_ARGS__)
Fine, but with a correction.
no_printk keeps all side effects like performing any function calls made
by the statement
On Wed, 2014-03-19 at 10:14 +1100, Finn Thain wrote:
As for side-effects, chip register accesses would be affected if dprintk()
expanded to no_printk() when NDEBUG flg == 0.
E.g. NCR5380.c line 1213:
dprintk(NDEBUG_INTR, scsi : unknown interrupt, BASR 0x%X, MR 0x%X, SR
0x%x\n,
On Tue, 18 Mar 2014, Joe Perches wrote:
But using if (0) prevents the no_printk from occurring at all so there
would be no side-effects and the format args would still be verified
by the compiler.
I'd prefer this (for symmetry and clarity):
#if NDEBUG
#define dprintk(flg, fmt, ...) \
On Wed, 2014-03-19 at 12:46 +1100, Finn Thain wrote:
On Tue, 18 Mar 2014, Joe Perches wrote:
But using if (0) prevents the no_printk from occurring at all so there
would be no side-effects and the format args would still be verified
by the compiler.
I'd prefer this (for symmetry and
On Tue, 2014-03-18 at 14:58 +0200, Sagi Grimberg wrote:
If during data-transfer a data-integrity error was detected we
must fail the command with CHECK_CONDITION and not execute
the command.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Reported-by: Or Gerlitz ogerl...@mellanox.com
---
35 matches
Mail list logo
