On 03/31/2014 05:03 PM, James Bottomley wrote:
[lets split the thread]
On Mon, 2014-03-31 at 16:37 +0200, Hannes Reinecke wrote:
On 03/31/2014 03:33 PM, Alan Stern wrote:
On Mon, 31 Mar 2014, Hannes Reinecke wrote:
On 03/28/2014 08:29 PM, Alan Stern wrote:
On Fri, 28 Mar 2014, James
On 4/1/2014 4:19 AM, Nicholas A. Bellinger wrote:
On Mon, 2014-03-31 at 17:53 +, Quinn Tran wrote:
On 3/28/14 6:24 PM, sagi grimberg sa...@mellanox.com wrote:
On 3/29/2014 3:53 AM, Quinn Tran wrote:
SNIP
+}
+}
+
if (lun-lun_se_dev != NULL) {
On 4/1/2014 4:11 AM, Nicholas A. Bellinger wrote:
SNIP
+
+if (scsi_host_get_prot(lport-qla_vha-host)) {
+tpg-se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT|
+TARGET_DIF_TYPE1_PROT|TARGET_DIF_TYPE2_PROT|
+TARGET_DIF_TYPE3_PROT);
+
+
In case of error, the bnx2fc_allocate_hash_table() didn't free
all the memory it allocated.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git
hash_table_size is not used by the bnx2fc_free_hash_table() function.
Signed-off-by: Maurizio Lombardi mlomb...@redhat.com
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index
If bnx2fc_allocate_hash_table() for some reasons fails, it is possible that the
hash_tbl_segments or the hash_tbl_pbl pointers are NULL.
In this case bnx2fc_free_hash_table() will panic the system.
this patch also fixes a memory leak, the hash_tbl_segments pointer was never
freed.
Signed-off-by:
PATCH 1/3 removes a unused variable from the bnx2fc_free_hash_table() function,
PATCH 2/3 fixes a memory leak and some NULL pointer dereferences in the
bnx2fc_free_hash_table() function
that may happen if bnx2fc_allocate_hash_table() fails.
PATCH 3/3 fixes a memory leak in the
When the driver reads state values from the hw it might happen that
different values are read in subsequent reads and this can cause problems,
this may lead to a timeout in this function and a non working adapter.
Cc: Adam Radford aradf...@gmail.com
Signed-off-by: Tomas Henzl the...@redhat.com
This patch consists of the usual driver updates (megaraid_sas,
scsi_debug, qla2xxx, qla4xxx, lpfc, bnx2fc, be2iscsi, hpsa, ipr) plus an
assortment of minor fixes and the first precursors of SCSI-MQ (the code
path simplifications) and the bug fix for the USB oops on remove (which
involves an
On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote:
The format strings for various printk()s make use of a temporary
variable that is declared 'static'. This is probably not intended,
so fix those.
Actually, it was intended. It was to work around an assignment to const
gcc bug: some
On 04/01/2014 12:29 AM, Alan Stern wrote:
On Mon, 31 Mar 2014, Hannes Reinecke wrote:
Ah. Correct. But that's due to the first patch being incorrect.
Cf my response to the original first patch.
See my response to your response. :-)
Okay, So I probably should refrain from issueing a
On 1 April 2014 16:10, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote:
The format strings for various printk()s make use of a temporary
variable that is declared 'static'. This is probably not intended,
so fix those.
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
Sagi I originally wrote the code to support that. But it got left
Sagi behind since I figured it is not an interesting use-case. If your
Sagi beckend doesn't support T10-PI why should the target publish it
Sagi support it and ask the device
On 4/1/2014 8:09 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
Sagi I originally wrote the code to support that. But it got left
Sagi behind since I figured it is not an interesting use-case. If your
Sagi beckend doesn't support T10-PI why should the
On Tue, 2014-04-01 at 11:04 +0300, Sagi Grimberg wrote:
On 4/1/2014 4:11 AM, Nicholas A. Bellinger wrote:
SNIP
+
+if (scsi_host_get_prot(lport-qla_vha-host)) {
+tpg-se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT|
+
On Tue, 2014-04-01 at 20:27 +0300, sagi grimberg wrote:
On 4/1/2014 8:09 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
Sagi I originally wrote the code to support that. But it got left
Sagi behind since I figured it is not an interesting use-case. If
The patchset looks good. Thanks.
Acked-by: Eddie Wai eddie@broadcom.com
On Tue, 2014-04-01 at 13:58 +0200, Maurizio Lombardi wrote:
PATCH 1/3 removes a unused variable from the bnx2fc_free_hash_table()
function,
PATCH 2/3 fixes a memory leak and some NULL pointer dereferences in the
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected
to GND).
This will be used by wd719x driver.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/misc/eeprom/eeprom_93cx6.c | 62 +++-
include/linux/eeprom_93cx6.h
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI
SCSI controllers based on WD33C296A chip.
Tested with WD7193 card.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/Kconfig |8 +
drivers/scsi/Makefile |1 +
drivers/scsi/wd719x.c | 1008
Hello,
this is a new driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI
controllers based on WD33C296A chip. These nice cards never worked good with
Linux.
It's based on old and ugly wd719x driver written back in 2.0 days, then hacked
to 2.2 and finally to 2.4 kernels. Most of the
On Tue, 1 Apr 2014, Hannes Reinecke wrote:
So if the above reasoning is okay then this patch should be doing
the trick:
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 771c16b..0e72374 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
On 03/31/2014 07:46 AM, Christoph Hellwig wrote:
This series adds support for sharing tags (and thus requests) between
multiple request_queues. We'll need this for SCSI, and I think Martin
also wants something similar for nvme.
Besides the mess with request contructors/destructors the major
22 matches
Mail list logo
