RE: [PATCH] scsi: bfa: bfa_fcs_lport.c: Fix for possible null pointer dereference

2014-05-21 Thread Anil Gurumurthy
Thanks for the patch. Acked-by: Anil Gurumurthy anil.gurumur...@qlogic.com -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] Sent: 18 May 2014 21:36 To: Anil Gurumurthy; Sudarsana Kalluru Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi;

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-21 Thread Hannes Reinecke
On 05/21/2014 05:18 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of James Bottomley Sent: Tuesday, May 20, 2014 9:22 PM To: Yoshihiro YUNOMAE Cc: Hannes Reinecke; Prarit

回复: [PATCH v2] [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for enum pci_interrupt_cause

2014-05-21 Thread 管雪涛
I checked these two files, and this patch looks good. And, I'll put it into unicore32 repo. Reviewed-by: Xuetao Guan g...@mprc.pku.edu.cn - Chen Gang gang.chen.5...@gmail.com 写道: The direct cause is IRQ_SPI is already defined as a macro in unicore32 architecture (also, blackfin and mips

[PATCH V2 0/5] lpfc 10.2.8001.0: Update lpfc to revision 10.2.8001.0

2014-05-21 Thread James Smart
Update lpfc version to driver version 10.2.8001.0 Note: we've revised our version number string... This patch set updates the lpfc driver to revision 10.2.8001.0 The patches for 10.2.8001.0 contain: - Fix for cleaning up stale ring flag and sp_queue_event entries. - Fix for initializing RRQ

[PATCH V2 1/5] lpfc 10.2.8001.0: Fix for cleaning up stale ring flag and sp_queue_event entries.

2014-05-21 Thread James Smart
Fix for cleaning up stale ring flag and sp_queue_event entries. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 48 lpfc_sli.c |1 + 2 files changed, 49 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c

[PATCH V2 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver.

2014-05-21 Thread James Smart
Reworked per Christoph's suggestions. -- Removed obsolete PCI IDs from the driver. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 83 +++- 1 file changed, 49 insertions(+), 34 deletions(-) diff -upNr

[PATCH V2 2/5] lpfc 10.2.8001.0: Fix for initializing RRQ bitmap

2014-05-21 Thread James Smart
Fix for initializing RRQ bitmap Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c |3 +++ 1 file changed, 3 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2014-05-12

[PATCH V2 4/5] lpfc 10.2.8001.0: Fix ExpressLane priority setup

2014-05-21 Thread James Smart
Fix ExpressLane priority setup Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |2 +- lpfc_sli.c |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c

[PATCH V2 5/5] lpfc 10.2.8001.0: Update lpfc version to driver version 10.2.8001.0

2014-05-21 Thread James Smart
Update lpfc version to driver version 10.2.8001.0 Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h ---

[PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-21 Thread Bart Van Assche
scmd-abort_work is only scheduled after the block layer has marked the request associated with a command as complete and for commands that are not on the eh_cmd_q list. A SCSI command is only requeued after the scmd-abort_work handler has started (requeueing clears the complete flag). This means

Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-21 Thread Andy Whitcroft
On 16 May 2014 16:39, Ian Abbott abbo...@mev.co.uk wrote: These changes to the Microsoft Hyper-V storage driver in Ubuntu Saucy's 3.13 kernel look useful for the mainline kernel, especially as they enable 'TRIM' support. Andy Whitcroft (2): scsi: hyper-v storvsc switch up to SPC-3 scsi:

Re: dangling pointers and/or reentrancy in scmd_eh_abort_handler?

2014-05-21 Thread Mark Wu
Is it possible that when scsi_done is invoked, the scsi command or the request has been freed and then reallocated for a new I/O request? Because of this the bit flag REQ_ATOM_COMPLETE becomes unreliable. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the

Re: [scsi:for-next 82/88] drivers/scsi/hpsa.c:3038 hpsa_update_scsi_devices() warn: impossible condition '(rescan_hba_mode 0) = (0-255 0)'

2014-05-21 Thread Christoph Hellwig
Stephen, can you look at these warnings? If the answer is this is all fixes in the other pending patches we'll just need to find another reviewer for them. On Wed, May 21, 2014 at 10:13:44AM +0300, Dan Carpenter wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

Re: [scsi:for-next 82/88] drivers/scsi/hpsa.c:3038 hpsa_update_scsi_devices() warn: impossible condition '(rescan_hba_mode 0) = (0-255 0)'

2014-05-21 Thread scameron
On Wed, May 21, 2014 at 04:26:50PM +0200, Christoph Hellwig wrote: Stephen, can you look at these warnings? Yeah, I'm looking at it right now. -- steve If the answer is this is all fixes in the other pending patches we'll just need to find another reviewer for them. On Wed, May 21, 2014

[PATCH 2/3] hpsa: return -ENOMEM not -1 on kzalloc failure in hpsa_get_device_id

2014-05-21 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Reported-by: Dan Carpenter dan.carpen...@oracle.com --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH 1/3] hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices

2014-05-21 Thread Stephen M. Cameron
From: Joe Handzik joseph.t.hand...@hp.com rescan_hba_mode was defined as a u8 so could never be less than zero: rescan_hba_mode = hpsa_hba_mode_enabled(h); if (rescan_hba_mode 0) goto out; Signed-off-by: Joe Handzik joseph.t.hand...@hp.com Signed-off-by: Stephen

[PATCH 3/3] hpsa: fix handling of hpsa_volume_offline return value

2014-05-21 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Make return value an int instead of an unsigned char so that we do not lose negative error return values. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Reported-by: Dan Carpenter dan.carpen...@oracle.com ---

Re: [Scst-devel] Qlogic's 16G FC/FCoE HBA support

2014-05-21 Thread Dr. Greg Wettstein
On May 21, 7:40am, Steve Magnani wrote: } Subject: Re: [Scst-devel] Qlogic's 16G FC/FCoE HBA support Thanks Duane, and QLogic. Hi, hope the day is going well for everyone. A thank you to Qlogic from us as well for this work. I was going to reply back to Duane's note last night but after a

Re: dangling pointers and/or reentrancy in scmd_eh_abort_handler?

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 16:16, Mark Wu ha scritto: Is it possible that when scsi_done is invoked, the scsi command or the request has been freed and then reallocated for a new I/O request? Because of this the bit flag REQ_ATOM_COMPLETE becomes unreliable. Thanks! It is up to the driver to ensure that

[Bug 76681] New: Adaptec 7805H SAS HBA (pm80xx) cannot survive ACPI S3 or ACPI S4

2014-05-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=76681 Bug ID: 76681 Summary: Adaptec 7805H SAS HBA (pm80xx) cannot survive ACPI S3 or ACPI S4 Product: IO/Storage Version: 2.5 Kernel Version: 3.14.3 Hardware: All

[PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi MST, MKP, Paolo Co, Here is the v2 patch series for adding T1O protection information (PI) SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric endpoints. Following MST's recommendation, it includes the changes for using bytes

[PATCH-v2 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a virtio_scsi_cmd_req_pi header as recommened by Paolo that contains do_pi_niov + di_pi_niov elements used for signaling when protection information buffers are expected to preceed the data buffers. Also add new VIRTIO_SCSI_F_T10_PI

[PATCH-v2 2/6] vhost/scsi: Move sanity check into vhost_scsi_map_iov_to_sgl

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Move the overflow check for sgl_count TCM_VHOST_PREALLOC_SGLS into vhost_scsi_map_iov_to_sgl() so that it's based on the total number of SGLs for all IOVs, instead of single IOVs. Also, rename TCM_VHOST_PREALLOC_PAGES - TCM_VHOST_PREALLOC_UPAGES to

[PATCH-v2 3/6] vhost/scsi: Add preallocation of protection SGLs

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates tcm_vhost_make_nexus() to pre-allocate per descriptor tcm_vhost_cmd-tvc_prot_sgl[] used to expose protection SGLs from within virtio-scsi guest memory to vhost-scsi. Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini

[PATCH-v2 4/6] vhost/scsi: Add T10 PI IOV - SGL memory mapping logic

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds vhost_scsi_map_iov_to_prot() to perform the mapping of T10 data integrity memory between virtio iov + struct scatterlist using get_user_pages_fast() following existing code. As with vhost_scsi_map_iov_to_sgl(), this does sanity checks

[PATCH-v2 5/6] vhost/scsi: Enable T10 PI IOV - SGL memory mapping

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates vhost_scsi_handle_vq() to check for the existance of virtio_scsi_cmd_req_pi comparing vq-iov[0].iov_len in order to calculate seperate data + protection SGLs from data_num. Also update tcm_vhost_submission_work() to pass the

[PATCH-v2 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

2014-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates virtscsi_probe() to setup necessary Scsi_Host level protection resources. (currently hardcoded to 1) It changes virtscsi_add_cmd() to attach outgoing / incoming protection SGLs preceeding the data payload, and is using the new

[ANNOUNCE]: SCST 2.2 pre-release freeze

2014-05-21 Thread Vladislav Bolkhovitin
Hi All, I'm glad to announce SCST 3.0 pre-release code freeze in the SCST SVN branch 3.0.x You can get it by command: $ svn co https://scst.svn.sourceforge.net/svnroot/scst/branches/3.0.x It is going to be released after few weeks of testing, if nothing bad found. SCST is alternative SCSI

[no subject]

2014-05-21 Thread Christian Organization
Good day, We are Christian organization, we give loan to those who are dedicated Christians, contact us at mercantilefinanceloanserv...@yahoo.com Regard Mercantile -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org