On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote:
Although these patches involve 3 subsystems with different
maintainers (scsi, iser, target) I would prefer seeing these
patches included together.
Why? Because they break wire compatibility?
I hate to say it but even if
Hi,
How about the patch?
From: Xiangliang Yu yxlr...@gmail.com
Date: 2014-04-24 21:27 GMT+08:00
Subject: [PATCH 1/3] libsas: modify SATA error handler
To: t...@kernel.org, jbottom...@parallels.com
Cc: dan.j.willi...@intel.com, todd.e.bra...@intel.com,
lukasz.do...@intel.com,
On Tue, Jun 3, 2014 at 9:16 AM, Roland Dreier rol...@purestorage.com wrote:
On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote:
Although these patches involve 3 subsystems with different
maintainers (scsi, iser, target) I would prefer seeing these
patches included together.
Older HBAs are only capable of supporting 16-bit LUNs,
so we need to make sure to adjust max_lun accordingly.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Chad Dupuis chad.dup...@qlogic.com
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne emi...@redhat.com
---
scsilun_to_int() has an error which prevents it from generating
correct LUN numbers for 64bit values.
Also we should remove the misleading comment about portions of
the LUN being ignored; the initiator should treat the LUN as
an opaque value.
And, finally, the example given should use the correct
Sequential scan for more than 256 LUNs is very fragile as
LUNs might not be numbered sequentially after that point.
SAM revisions later than SCSI-3 impose a structure on
LUNs larger than 256, making LUN numbers between 256
and 16384 illegal.
SCSI-3, however allows for plain 64-bit numbers with
no
Obsolete; either use 'max_lun' if the host supports only a
limited number of LUNs or BLIST_NOLUN if the target has
problems addressing more than one LUN.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne emi...@redhat.com
---
Now that we're using 64-bit LUNs internally we need to increase
the size of max_luns to 64 bits, too.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne emi...@redhat.com
---
drivers/message/i2o/i2o_scsi.c | 2 +-
Il 03/06/2014 03:00, Martin K. Petersen ha scritto:
Paolo == Paolo Bonzini pbonz...@redhat.com writes:
+ sdev_printk(KERN_ERR, sdev,
+ %s: VPD page 0x83 NAA descriptor not found\n, __func__);
+
+ return;
Paolo I suspect this error will be relatively common.
You're right. But we would like
This is a fix for commit:
39c60a0948cc06139e2fbfe084f83cb7e7deae3b sd: fix array cache flushing bug
causing performance problems
We must notify the block layer via q-flush_flags after temporary change the
cache_type to write through.
If not, SYNCHRONIZE CACHE command will still be generated.
Update the st driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Cc: Kai Mäkisara kai.makis...@kolumbus.fi
---
drivers/scsi/st.c | 605
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/scsi_ioctl.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
index d9564fb..1aaaf43 100644
--- a/drivers/scsi/scsi_ioctl.c
+++
Hi all,
this is the first patch of my SCSI logging cleanup.
The basic idea here is to use dev_printk() and friends
throughout the midlayer, so that any logging messages
are attached with the correct device information.
Hannes Reinecke (6):
scsi: Implement sr_printk()
scsi: Implement
Update the ch driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/ch.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
Using dev_printk variants prefixes the logging message with
the originating device, which makes debugging easier.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/hosts.c | 15 ++--
drivers/scsi/scsi.c | 18 ++---
drivers/scsi/scsi_error.c | 179
Update the sg driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Cc: Doug Gilbert dgilb...@interlog.com
---
drivers/scsi/sg.c | 189
Update the sr driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Cc: Jens Axboe ax...@kernel.dk
---
drivers/scsi/sr.c| 61
On Saturday 31 May 2014 18:30:49 Vyacheslav Dubeyko wrote:
By the way, what about NILFS2? Is NILFS2 ready for suggested approach
without any changes?
nilfs2 and a lot of other file systems don't need any changes for
this, because they don't assign the inode time stamp fields to
a 'struct
On 14-06-03 07:22 AM, Hannes Reinecke wrote:
Update the sg driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Cc: Doug Gilbert dgilb...@interlog.com
Acked-by: Douglas Gilbert
On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote:
On 06/02/2014 12:55 PM, Arnd Bergmann wrote:
The bit that is really going to hurt is every single ioctl that uses a
timespec.
Honestly, though, I really don't understand the point with struct
inode_time. It seems like the
On Tue, 3 Jun 2014, Arnd Bergmann wrote:
I think John Stultz and Thomas Gleixner have already started looking
at how the timekeeping code can be updated. Once that is done, we should
be able to add a functional 64-bit gettimeofday/settimeofday syscall
pair. While I definitely agree this is
On Tuesday 03 June 2014 14:33:10 Joseph S. Myers wrote:
On Tue, 3 Jun 2014, Arnd Bergmann wrote:
I think John Stultz and Thomas Gleixner have already started looking
at how the timekeeping code can be updated. Once that is done, we should
be able to add a functional 64-bit
On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote:
On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote:
On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote:
On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote:
Thanks for fixing this. The
2014-06-03 4:11 GMT+09:00 Martin K. Petersen martin.peter...@oracle.com:
@@ -2755,6 +2765,10 @@ static int sd_revalidate_disk(struct gendisk *disk)
blk_queue_flush(sdkp-disk-queue, flush);
+ max_xfer = min_not_zero((unsigned int)sdp-host-max_sectors,
+
From: Daniel Walter dwal...@google.com
Subject: [PATCH v2 09/11] [drivers/scsi] replace strict_strto calls
Replace obsolete strict_strto with more appropriate kstrto calls
Signed-off-by: Daniel Walter dwal...@google.com
---
Resubmit to the mailing list (was submitted to MAINTAINER entry
On Tue, Jun 3, 2014 at 12:13 AM, Xiangliang Yu yuxia...@marvell.com wrote:
Hi,
How about the patch?
I'll take a look today. Sorry for the latency.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 06/01/2014 11:19 AM, Sagi Grimberg wrote:
+/*
+ * data integrity helpers
+ */
+static inline unsigned
+iscsi_prot_len(unsigned data_len, unsigned sector_size)
+{
+ switch (sector_size) {
+ case 512:
+ return (data_len 9) * 8;
+ case 1024:
+
On 06/01/2014 11:19 AM, Sagi Grimberg wrote:
/**
+ * iscsi_adjust_dl - Adjust SCSI data length to include PI
+ * @sc: scsi command.
+ * @data_length: command data length.
+ *
+ * Adjust the data length to account for how much data
+ * is actually on the wire.
+ *
+ * returns the adjusted
-static char *sg_version_date = 20061027;
+static char *sg_version_date = 20140603;
static int sg_proc_init(void);
static void sg_proc_cleanup(void);
@@ -74,6 +72,11 @@ static void sg_proc_cleanup(void);
#define SG_MAX_DEVS 32768
+/* SG_MAX_CDB_SIZE should be 260 (spc4r37 section 3.1.30
On Tue, 2014-06-03 at 10:54 -0400, Neil Horman wrote:
On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote:
On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote:
On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote:
On Fri, May 30, 2014 at
Even though the virtio-scsi spec guarantees that all requests related
to the TMF will have been completed by the time the TMF itself completes,
the request queue's callback might not have run yet. This causes requests
to be completed more than once, and as a result triggers a variety of
BUGs or
From: Venkatesh Srinivas venkate...@google.com
change_queue_depth allows changing per-target queue depth via sysfs.
It also allows the SCSI midlayer to ramp down the number of concurrent
inflight requests in response to a SCSI BUSY status response and allows
the midlayer to ramp the count back
From: Ulrich Obergfell uober...@redhat.com
After scsi_try_to_abort_cmd returns, the eh_abort_handler may have
already found that the command has completed in the device, causing
the host_byte to be nonzero (e.g. it could be DID_ABORT). When
this happens, ORing DID_TIME_OUT into the host byte
From: Ming Lei tom.leim...@gmail.com
Access to tgt-req_vq is strictly serialized by spin_lock
of tgt-tgt_lock, so the ACCESS_ONCE() isn't necessary.
smp_read_barrier_depends() in virtscsi_req_done was introduced
to order reading req_vq and decreasing tgt-reqs, but it isn't
needed now because
Sorry for the delay, mostly caused by the discussion and testing of
patch 5. That's the most important of the bunch, and debugging the
problem also led to the discovery of a midlayer bug fixed by patch 4.
I hope these can make their way into 3.16. Thanks!
resend: forgot linux-scsi. :(
Paolo
In init_sd function, if kmem_cache_create or mempool_create_slab_pools
calls fail, the error will not be correclty reported because
class_register previously set the value of err to 0.
Signed-off-by: Clément Calmels clement.calm...@free.fr
---
drivers/scsi/sd.c | 2 ++
1 file changed, 2
Andreas == Andreas Gruenbacher andreas.gruenbac...@gmail.com writes:
Andreas,
Andreas The combined tag size in this case is 6 bytes; fix the loop.
I just posted a patch series that removes the tagging functions because
nobody was using them. Are you?
The patch looks good otherwise.
Acked-by:
https://bugzilla.kernel.org/show_bug.cgi?id=64141
Bjorn Helgaas bhelg...@google.com changed:
What|Removed |Added
Component|PCI |Other
On Tue, Nov 5, 2013 at 11:44 AM, Bjorn Helgaas bhelg...@google.com wrote:
On Tue, Nov 5, 2013 at 6:06 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 31 Oct 2013, Bjorn Helgaas wrote:
Attached is dmesg output leading to timeouts (that are cured by my
original patch in this thread) and lspci.
Martin,
2014-06-04 0:50 GMT+02:00 Martin K. Petersen martin.peter...@oracle.com:
Andreas == Andreas Gruenbacher andreas.gruenbac...@gmail.com writes:
Andreas,
Andreas The combined tag size in this case is 6 bytes; fix the loop.
I just posted a patch series that removes the tagging
When the SG_IO ioctl was copied into the block layer and
later into the bsg driver, subtle differences emerged.
One difference is the way injected commands are queued through
the block layer (i.e. this is not SCSI device queueing nor SATA
NCQ). Summarizing:
- SG_IO in the block layer:
Hi, some notes below:
On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote:
Add support for SATA port softreset and port multiplier error
handling.
Some more detailed notes about the approach and any caveats would be
appreciated.
Signed-off-by: Xiangliang Yu
https://bugzilla.kernel.org/show_bug.cgi?id=1898
Andreas Hartmetz ahartm...@web.de changed:
What|Removed |Added
Regression|--- |No
--- Comment #4 from
https://bugzilla.kernel.org/show_bug.cgi?id=1898
--- Comment #5 from Andreas Hartmetz ahartm...@web.de ---
Yeah, that was me clicking the wrong button. If you read from the second
[PATCH] fdomain screwup, you have the proper commit message.
--
You are receiving this mail because:
You are
On Tue, May 27, 2014 at 12:51 PM, Dolev Raviv dra...@codeaurora.org wrote:
Introduces the API for sending queries with descriptors.
A descriptor is a block or page of parameters that describe the device.
The descriptors are classified into types and can range in size
from 2 bytes through 255
On Tue, May 27, 2014 at 12:51 PM, Dolev Raviv dra...@codeaurora.org wrote:
Check query response status before copying the response.
Add descriptor query response size check, before copying it to buffer.
Signed-off-by: Dolev Raviv dra...@codeaurora.org
Signed-off-by: Raviv Shvili
On Tue, May 27, 2014 at 12:51 PM, Dolev Raviv dra...@codeaurora.org wrote:
Some of the UFS devices may support different number of commands
that can be queued per LU. At the current implementation,
SW configure each of the UFS devices LU's according to the
controller capability.
In this
On Tue, May 27, 2014 at 12:51 PM, Dolev Raviv dra...@codeaurora.org wrote:
Some UFS devices may expose bLUQueueDepth field as zero indicating
that the queue depth depends on the number of resources available
for LUN at a particular instant to handle the outstanding transfer
requests.
On 06/04/2014 12:12 AM, Martin K. Petersen wrote:
Hannes == Hannes Reinecke h...@suse.de writes:
Hannes Hi all, this is the first patch of my SCSI logging cleanup. The
Hannes basic idea here is to use dev_printk() and friends throughout
Hannes the midlayer, so that any logging messages are
49 matches
Mail list logo
