On Fri, Jun 06, 2014 at 01:03:41AM +, Elliott, Robert (Server Storage)
wrote:
In _scsih_probe, delay the call to scsi_add_host until
the host template has been completely filled in.
Beside scsi-mq not picking up the queue depth callng scsi_add_host
on a not fully setup host also is
On Wed, May 28, 2014 at 06:27:52PM +0400, James Bottomley wrote:
I'm happy with eliminating Unhanndled Error Code because that is
misleading ... we should only get there if we have a DID_X return and
they're all fatal errors which will be printed.
I'm less happy removing Unhandled Sense
During IO with fabric faults, one generally sees several Unhandled error
code messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] Unhandled error code
sd 4:0:6:2: [sdbw] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
sd 4:0:6:2: [sdbw] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00
On Wed, Jun 04, 2014 at 12:49:46PM -0400, Joe Lawrence wrote:
Fixes the following smatch warning:
drivers/message/fusion/mptctl.c:1369 mptctl_getiocinfo() warn:
possible info leak 'karg'
This is a false positive. I will push a fix for this in Smatch next
week.
regards,
dan
a jump to 'free_memory' is apparently missing
Signed-off-by: Tomas Henzl the...@redhat.com
---
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index ac54cf5..442982d 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -4209,6
commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path
fixed an potential junk pointer free if mgmt_get_if_info() returned an error
fix it on one more place
Signed-off-by: Tomas Henzl the...@redhat.com
---
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
Hi
Now I have some time to check on this.
I do not make a fuss or anything, but thought nonetheless provide some feedback.
1) I did not know that Linux had strlcpy, much better choice, of course!
2) It was not clear that this was done in the code. And my thought
was, rather, just that you were
Hi
I did not know that Linux had strlcpy, much better choice, of course!
It was not clear that this was done in the code. And my thought was,
rather, just that you were not sure if there was a null character
because it used strlcpy. if this can not possibly happen would be
almost as well to
Your Urgent Attention Please.
Dear. I got your contact through yahoo tourist search when I was
searching for a foreign partner, although I don't now if you can keep
this transaction personally secret till you get it into you bank
account Well I have a deal worth 5.5m$ from the dormant account in
Turns out git-am didn't like your patch, although I don't understand
why. I just manually reapplied it and also applied it to mpt2sas while
at it, find the two patches I put into the tree below.
LSI folks: can you look over this? I also think the sas_remove_host
and scsi_remove_host calks in
On Fri, Jun 06, 2014 at 02:06:30PM +0200, Tomas Henzl wrote:
a jump to 'free_memory' is apparently missing
Signed-off-by: Tomas Henzl the...@redhat.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of
On Fri, Jun 06, 2014 at 02:22:44PM +0200, Tomas Henzl wrote:
commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path
fixed an potential junk pointer free if mgmt_get_if_info() returned an error
fix it on one more place
Signed-off-by: Tomas Henzl the...@redhat.com
Looks good,
On Jun 6, 2014, at 7:22 AM, Tomas Henzl the...@redhat.com wrote:
commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path
fixed an potential junk pointer free if mgmt_get_if_info() returned an error
fix it on one more place
Signed-off-by: Tomas Henzl the...@redhat.com
---
diff
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org;
From: Ken Helias kenhel...@firemail.de
Many places in the code uses list_add_tail/list_add to insert an entry
before/after another entry. This confuses the reader because these are usually
used to add an item to a list_head and not an entry. Better use the self
explaining function name.
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote:
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org;
From: Shirish Pargaonkar shirishpargaon...@gmail.com
Do not log error for netevents that need no action such as
NETDEV_REGISTER 0x0005, NETDEV_CHANGEADDR, and NETDEV_CHANGENAME.
It results in logging error messages such as these
[ 35.315872] bnx2fc: Unknown netevent 5
[ 35.315935] bnx2fc:
On 2014-06-06 11:52, James Bottomley wrote:
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote:
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Vasu,
This series generates SAM_STAT_TASK_SET_FULL status for lport-tt.seq_send()
failures in DataIN + response status codepaths, which is done in order to get
the initiator to
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes ft_queue_data_in() to set SAM_STAT_TASK_SET_FULL
status upon a lport-tt.seq_send() failure, where it will now stop
sending subsequent DataIN, and immediately
On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote:
On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote:
debugfs caught this:
WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0()
ODEBUG: free active (active state 0) object type: work_struct
hint:
On Fri, 2014-06-06 at 13:51 -0700, Vasu Dev wrote:
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes ft_queue_data_in() to set SAM_STAT_TASK_SET_FULL
status upon a lport-tt.seq_send() failure, where it will
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes ft_queue_status() to set SAM_STAT_TASK_SET_FULL
status upon lport-tt.seq_send( failure, and return -EAGAIN to notify
target-core to attempt to requeue the
On Fri, 2014-06-06 at 13:38 -0700, Vasu Dev wrote:
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Vasu,
This series generates SAM_STAT_TASK_SET_FULL status for lport-tt.seq_send()
failures in DataIN + response status
On Fri, 2014-06-06 at 14:03 -0700, Vasu Dev wrote:
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes ft_queue_status() to set SAM_STAT_TASK_SET_FULL
status upon lport-tt.seq_send( failure, and return -EAGAIN
Hi All,
I noticed that the sysfs file cache_type is not is sync with the information in
the mode page. If we change the WCE attribute in the mode page (sdparm
--set=WCE /dev/sda and sdparm --clear=WCE /dev/sda) it does not reflect this
in the sysfs file.
$ cat
On Thu, 5 Jun 2014 02:34:29 -0700
Christoph Hellwig h...@infradead.org wrote:
diff --git a/drivers/message/fusion/mptsas.h
b/drivers/message/fusion/mptsas.h
index 57e86ab..c396483 100644
--- a/drivers/message/fusion/mptsas.h
+++ b/drivers/message/fusion/mptsas.h
@@ -110,7 +110,7 @@
Minimized the use of snprintf()
And removed a variable that was only used for the temporary storage.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/bfa/bfad_attr.c | 114 --
1 file changed, 66 insertions(+), 48
Hi
Several have remarked in the other patch for strncpy I posted. That
there is a strlcpy that works exactly as one would like to strncpy was
done :)
And the return value is like for snprintf, but quite a lot faster!
So I submit patches based with it instead, and did a couple more
exchanges of
Suman Tripathi (2):
libahci: Implement the restart_engine to restart the port dma engine.
ata: Fix the dma state machine lockup for the PIO mode commands.
drivers/ata/ahci_xgene.c | 17 +++--
drivers/ata/libahci.c | 13 +
drivers/ata/libata-core.c | 10 ++
This patch implements the function restart_engine function to add the
flexibility to restart the port dma engine from the libata framework.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
---
drivers/ata/libahci.c | 11 +++
include/linux/libata.h |
This patches fixes the dma state machine lockup due to the PIO mode
commands. The contoller is unable to clear the BSY bit after receiving the
PIO Setup FIS and results the dma state machine to go into the
CMFatalErrorUpdate state resulting in dma state machine lockup.
Signed-off-by: Loc Ho
On Sat, Jun 07, 2014 at 02:58:53AM +0530, Suman Tripathi wrote:
This patch implements the function restart_engine function to add the
flexibility to restart the port dma engine from the libata framework.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
On Sat, Jun 07, 2014 at 02:58:54AM +0530, Suman Tripathi wrote:
@@ -5072,6 +5072,16 @@ int ata_qc_complete_multiple(struct ata_port *ap, u32
qc_active)
if (qc) {
ata_qc_complete(qc);
nr_done++;
+ /*
+
On Fri, 2014-06-06 at 17:14 -0400, Pai wrote:
Hi All,
I noticed that the sysfs file cache_type is not is sync with the information
in the mode page. If we change the WCE attribute in the mode page (sdparm
--set=WCE /dev/sda and sdparm --clear=WCE /dev/sda) it does not reflect this
in
Hi,
I'm Miss Tanisha, I am a young woman who is looking for friendship and maybe
more. I am well pleased to contact you after i came across your e-mail. I will
like to further communication with you for us to know each other if you wouldn't
mind and if you share the same view with me. You can
36 matches
Mail list logo
