Re: [RESEND][PATCH 06/10][SCSI]mpt2sas: For 2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive

2014-07-15 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth Also coming to first point i.e. the usage of scsi_get_lba() Sreekanth API instead of parsing the CDB. During an experiment I Sreekanth observe that when I use the 'sg_dd if=/dev/sg0 of=/dev/null Sreekanth count=1'

Re: [RESEND][PATCH 06/10][SCSI]mpt2sas: For 2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive

2014-07-15 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth I have tried with this diff. And I still observe the invalid Sreekanth LBA (i.e. 0x) with scsi_get_lba() API when I used Sreekanth the sg_dd with input file specified as /dev/sg0. Yeah, I now remember that

[PATCH] SCSI: Add a blacklist flag which enables VPD page inquiries

2014-07-15 Thread Martin K. Petersen
Despite supporting modern SCSI features some storage devices continue to claim conformance to an older version of the SPC spec. This is done for compatibility with legacy operating systems. Linux by default will not attempt to read VPD pages on devices that claim SPC-2 or older. Introduce a

Re: [RESEND][PATCH 10/10][SCSI]mpt2sas: Bump mpt2sas driver version to 18.100.00.00

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Bump mpt2sas driver version to 18.100.00.00. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [RESEND][PATCH 1/8][SCSI]mpt3sas: MPI2.5 Rev G (2.5.2) specifications

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Below is the change set in MPI2.5 Rev G specification and Sreekanth 2.00.31 header files Sreekanth 1) Added SCSIStatusQualifier to SCSI IO Error Reply message. Sreekanth 2) Added ATA Security Freeze Lock to IO Unit

Re: [RESEND][PATCH 2/8][SCSI]mpt3sas: Clear PFA Status on SGPIO when PFA Drive is Removed or Replaced

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Added code to send an SEP message that turns off the Sreekanth Predictive Failure LED when a drive is removed (if Predictive Sreekanth Failure LED was turned on). Sreekanth Added a new flag 'pfa_led_on' per device

Re: [RESEND][PATCH 5/8][SCSI]mpt3sas: Copyright in driver sources is updated for year the 2014

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Copyright in driver sources is updated for year the 2014. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [RESEND][PATCH 6/8][SCSI]mpt3sas: Added OEM branding Strings

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Added following branding Strings for Intel custom HBAs Sreekanth support Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [RESEND][PATCH 4/8][SCSI]mpt3sas: MPI2.5 Rev H (2.5.3) specifications

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Below is the change set in MPI2.5 Rev H specification and Sreekanth 2.00.32 header files [...] Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [RESEND][PATCH 3/8][SCSI]mpt3sas: Bump mpt3sas driver version to 03.100.00.00

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Bump mpt3sas driver version to 03.100.00.00. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [RESEND][PATCH 8/8][SCSI]mpt3sas: Bump mpt3sas driver version to 04.100.00.00

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth Bump mpt3sas driver version to 04.100.00.00. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [RESEND][PATCH 06/10][SCSI]mpt2sas: For 2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive

2014-07-15 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth But still I observe the invalid LBA when we send IOs using Sreekanth sg_dd with input file specified as /dev/sg0 as shown below In the latest patch I get the LBA from CDB32 in the MPI request so that shouldn't happen.

Re: [PATCH v2] scsi_debug: support scsi-mq, queues and locks

2014-07-15 Thread Martin K. Petersen
Rob == Elliott, Robert (Server Storage) elli...@hp.com writes: Rob, Rob When resp_unmap is the caller, though, there is no guarantee that Rob the data will change. Rob Maybe another modparam should be included to cause the driver to Rob purposely ignore unmap requests? That might help more

Re: [RESEND][PATCH 08/10][SCSI]mpt2sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state

2014-07-15 Thread Martin K. Petersen
Sreekanth == Reddy, Sreekanth sreekanth.re...@avagotech.com writes: Sreekanth The driver would send IOC facts only if HBA is in operational Sreekanth or ready state. If it is in fault state, a diagnostic reset Sreekanth would be issued. It would wait for 10 seconds to exit out of Sreekanth reset

ANNOUNCE: SCSI XCOPY support for the kernel and device mapper

2014-07-15 Thread Mikulas Patocka
Hi I annouce that I released the first version of a patch set that makes it possible to use SCSI XCOPY offload for the block layer and device mapper. The patchset is at http://people.redhat.com/~mpatocka/patches/kernel/xcopy/series.html It requires kernel version at least 3.16-rc4. It was

Re: ANNOUNCE: SCSI XCOPY support for the kernel and device mapper

2014-07-15 Thread Christoph Hellwig
On Tue, Jul 15, 2014 at 02:33:13PM -0400, Mikulas Patocka wrote: Hi I annouce that I released the first version of a patch set that makes it possible to use SCSI XCOPY offload for the block layer and device mapper. The patchset is at

Re: ANNOUNCE: SCSI XCOPY support for the kernel and device mapper

2014-07-15 Thread Mikulas Patocka
On Tue, 15 Jul 2014, Christoph Hellwig wrote: On Tue, Jul 15, 2014 at 02:33:13PM -0400, Mikulas Patocka wrote: Hi I annouce that I released the first version of a patch set that makes it possible to use SCSI XCOPY offload for the block layer and device mapper. The patchset is at

[PATCH 0/15] SCSI XCOPY support for the kernel and device mapper

2014-07-15 Thread Mikulas Patocka
This patch series makes it possible to use SCSI XCOPY offload for the block layer and device mapper. It is based on Martin Petersen's work https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopyid=0bdeed274e16b3038a851552188512071974eea8, but it is changed significantly so

[PATCH 2/15] block copy: use two bios

2014-07-15 Thread Mikulas Patocka
This patch changes the architecture of xcopy so that two bios are used. There used to be just one bio that held pointers to both source and destination block device. However a bio with two block devices cannot really be passed though block midlayer drivers (dm and md). When we need to send the

[PATCH 1/15] block copy: initial XCOPY offload support

2014-07-15 Thread Mikulas Patocka
This is Martin Petersen's xcopy patch (https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopyid=0bdeed274e16b3038a851552188512071974eea8) with some bug fixes, ported to the current kernel. This patch makes it possible to use the SCSI XCOPY command. We create a bio that has

[PATCH 4/15] block copy: use a timer to fix a theoretical deadlock

2014-07-15 Thread Mikulas Patocka
The block layer creates two bios for each copy operation. The bios travel independently through the storage stack and they are paired at the block device. There is a theoretical problem with this - the block device stack only guarantees forward progress for a single bio. When two bios are sent,

[PATCH 3/15] block copy: report the amount of copied data

2014-07-15 Thread Mikulas Patocka
This patch changes blkdev_issue_copy so that it returns the number of copied sectors in the variable copied. The kernel makes best effort to copy as much data as possible, but because of device mapper mapping, it may be possible that copying fails at some stage. If we just returned the error

[PATCH 5/15] block copy: use merge_bvec_fn for copies

2014-07-15 Thread Mikulas Patocka
We use merge_bvec_fn to make sure that copies do not split internal boundaries of device mapper devices. There is no possibility to split a copy bio (splitting would complicate the design significantly), so we must use merge_bvec_fn to make sure that the bios have appropriate size for the device

[PATCH 6/15] block copy: use asynchronous notification

2014-07-15 Thread Mikulas Patocka
block copy: use asynchronous notification In dm-snapshot target there may be large number of copy requests in progress. If every pending copy request consumed a process context, it would put too much load on the system. To avoid this load, we need asynchronous notification when copy finishes -

[PATCH 8/15] dm: introduce dm_ask_for_duplicate_bios

2014-07-15 Thread Mikulas Patocka
[ this isn't connected to XCOPY, but it is requires for the following device mapper patches to apply cleanly ] This function can be used if the target needs to receive another duplicate of the current bio. Signed-off-by: Mikulas Patocka mpato...@redhat.com --- drivers/md/dm.c |

[PATCH 7/15] dm: remove num_write_bios

2014-07-15 Thread Mikulas Patocka
[ this isn't connected to XCOPY, but it is requires for the following device mapper patches to apply cleanly ] The target can set the function num_write_bios - dm will issue this callback to ask the target how many bios does it want to receive. This was intended for the dm-cache target, but it

[PATCH 9/15] dm: implement copy

2014-07-15 Thread Mikulas Patocka
This patch implements basic copy support for device mapper core. Individual targets can enable copy support by setting ti-copy_supported. Device mapper device advertises copy support if at least one target supports copy and for this target, at least one underlying device supports copy.

[PATCH 10/15] dm linear: support copy

2014-07-15 Thread Mikulas Patocka
Support copy operation in the linear target. Signed-off-by: Mikulas Patocka mpato...@redhat.com --- drivers/md/dm-linear.c |1 + 1 file changed, 1 insertion(+) Index: linux-3.16-rc4/drivers/md/dm-linear.c === ---

[PATCH 11/15] dm stripe: support copy

2014-07-15 Thread Mikulas Patocka
Support the copy operation for the stripe target. In stripe_merge, we verify that the underlying device supports copy. If it doesn't, we can fail fast without any bio being contructed. Signed-off-by: Mikulas Patocka mpato...@redhat.com --- drivers/md/dm-stripe.c | 11 ++- 1 file

[PATCH 13/15] dm kcopyd: support copy offload

2014-07-15 Thread Mikulas Patocka
This patch adds copy offload support to dm-kcopyd. If copy offload fails, copying is performed using dm-io, just like before. There is a module parameter copy_offload that can be set to enable or disable this feature. It can be used to test performance of copy offload. Signed-off-by: Mikulas

[PATCH 14/15] dm kcopyd: change mutex to spinlock

2014-07-15 Thread Mikulas Patocka
job-lock is only taken for a finite amount of time and the process doesn't block while holding it, so change it from mutex to spinlock. This change is needed for the next patch that makes it possible to call segment_complete from an interrupt. Taking mutexes inside an interrupt is not allowed.

[PATCH 12/15] dm kcopyd: introduce the function submit_job

2014-07-15 Thread Mikulas Patocka
We move some code to a function submit_job. It is needed for the next patch that calls submit_job from another place. Signed-off-by: Mikulas Patocka mpato...@redhat.com --- drivers/md/dm-kcopyd.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) Index:

[PATCH 15/15] dm kcopyd: call copy offload with asynchronous callback

2014-07-15 Thread Mikulas Patocka
Change dm kcopyd so that it calls blkdev_issue_copy with an asynchronous callback. There can be large number of pending kcopyd requests and holding a process context for each of them may put too much load on the workqueue subsystem. This patch changes it so that blkdev_issue_copy returns after it

[PATCH net-next 3/4] libcxgbi: Add ipv6 api to driver

2014-07-15 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com Signed-off-by: Karen Xie k...@chelsio.com Signed-off-by: Manoj Malviya manojmalv...@chelsio.com --- drivers/scsi/cxgbi/libcxgbi.c | 237 ++ drivers/scsi/cxgbi/libcxgbi.h | 37 ++- 2 files changed, 253

[PATCH net-next 1/4] cxgb4/iw_cxgb4: Move common defines to cxgb4

2014-07-15 Thread Anish Bhatt
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication Signed-off-by: Anish Bhatt an...@chelsio.com Acked-by: Steve Wise sw...@opengridcomputing.com --- drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 1 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 + 2 files changed, 1

[PATCH net-next 0/4] cxgb4i: Add ipv6 support

2014-07-15 Thread Anish Bhatt
Hi, The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports symbols needed by cxgb4i for ipv6 support from cxgb4. Patch 3 4 deal with actual

[PATCH net-next 4/4] cxgb4i: Add ipv6 code to driver, call into libcxgbi ipv6 api

2014-07-15 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com Signed-off-by: Karen Xie k...@chelsio.com Signed-off-by: Manoj Malviya manojmalv...@chelsio.com --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 353 + 1 file changed, 314 insertions(+), 39 deletions(-) diff --git

[PATCH net-next 2/4] cxgb4: Export symbols required by cxgb4i for ipv6 support and required defines

2014-07-15 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 4 drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 2 ++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git