[PATCH 0/3] scsi_debug: review fixes for scsi-mq changes

2014-08-05 Thread Douglas Gilbert
This series of patches is a result of feedback from the large patch titled [PATCH v2] scsi_debug: support scsi-mq, queues and locks sent to the list on 20140707. That patch is now in Christoph's drivers-for-3.17 repository. 1/3: scsi_cmnd-cmnd check and casts unnecessary 2/3: give unit

[PATCH 1/3] scsi_debug: scsi_cmnd-cmnd check and casts unnecessary

2014-08-05 Thread Douglas Gilbert
This patch removes a NULL check for the scsi_cmnd::cmnd pointer since many other instances in this driver and elsewhere assume it is valid. Also redundant casts to 'unsigned char *' are removed as the pointer has that type. Signed-off-by: Douglas Gilbert dgilb...@interlog.com ---

[PATCH 2/3] scsi_debug: give unit attention and other errors precedence over TSF

2014-08-05 Thread Douglas Gilbert
Give existing errors priority over the generation of Task Set Full (TSF) errors. So that max_queue is not exceeded, existing errors may be sent back in the invocation thread. This is done so errors like Unit Attentions are not hidden and lost by either max_queue exceeded or real/injected TSFs.

[PATCH 3/3] scsi_debug: bump inquiry version to SPC-4, update version descriptors

2014-08-05 Thread Douglas Gilbert
Since a lot of functionality from SPC-4 is supported by this driver (e.g. LBP and PI) then bump the default INQUIRY version from SPC-3 to SPC-4. Also update the INQUIRY version descriptors. Signed-off-by: Douglas Gilbert dgilb...@interlog.com --- drivers/scsi/scsi_debug.c | 14 +++---

Re: [PATCH 1/1] iscsi class: Fix freeing of skb in get host error path

2014-08-05 Thread Hannes Reinecke
On 08/04/2014 01:37 AM, micha...@cs.wisc.edu wrote: From: Mike Christie micha...@cs.wisc.edu If get_host_stats failes we are using kfree to free the skb. We should be using kfree_skb. This patch was made over Christoph's scsi-queue drivers-for-3.17 branch. Signed-off-by: Mike Christie

Re: [PATCH] scsi/arcmsr: Add timeout module parameter

2014-08-05 Thread Ari Sundholm
On Mon, 4 Aug 2014, Christoph Hellwig wrote: To modify the timeout on a queue please use blk_queue_rq_timeout in the slave_configure method instead of poking directly into the block timer, which won't work e.g. for the blk-mq path. I see. It seems the way the driver Areca offers on its

Re: [PATCH] eata: remove driver_lock

2014-08-05 Thread Hannes Reinecke
On 07/14/2014 10:26 AM, Christoph Hellwig wrote: port_detect is only called from the module_init routine and thus implicitly serialized, so remove the driver lock which was held over potentially sleeping function calls. Signed-off-by: Christoph Hellwig h...@lst.de Reported-by: Arthur Marsh

Re: [RESEND][PATCH 7/8][SCSI]mpt3sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-05 Thread Tomas Henzl
On 06/25/2014 12:41 PM, Reddy, Sreekanth wrote: Up to now, Driver allocates a single contiguous block of memory pool for all reply queues and passes down a single address in the ReplyDescriptorPostQueueAddress field of the IOC Init Request Message to the firmware. When firmware receives this

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-05 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth, Patch was mangled and I had to apply every single hunk by hand. Please use git send-email. +static int dma_mask; + +static int +_base_wait_for_doorbell_int(struct MPT2SAS_ADAPTER *ioc, int timeout, +

RE: Bad tag value in scsi-mq.4

2014-08-05 Thread Handzik, Joe
Yeah, we thought about that one. We call scsi_activate_tcq if our scsi_device has tagged_supported set within hpsa_change_queue_type (our .change_queue_type entry into the scsi_host_template). Also made sure I was booting with the scsi_mod.use_blk_mq=Y option, which makes no difference either

Re: Bad tag value in scsi-mq.4

2014-08-05 Thread h...@infradead.org
On Tue, Aug 05, 2014 at 06:04:07PM +, Handzik, Joe wrote: Hey Christoph, Using the scsi-mq.4 branch from git://git.infradead.org/users/hch/scsi.git, I'm getting a -1 returned from from scsi_cmnd-request-tag...very unsure why that would be. It happens without any drives attached to the

[PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Chad Dupuis
Set this to 1 for now as we've observed crashes when this is set to the default value of 0. Signed-off-by: Chad Dupuis chad.dup...@qlogic.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Venkatesh Srinivas
On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is set to the default value of 0. What sorts of crashes have you seen with no_async_abort=0 (default)? At which kernel versions? Thanks, -- vs; -- To

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Chad Dupuis
On Tue, 5 Aug 2014, Venkatesh Srinivas wrote: On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is set to the default value of 0. What sorts of crashes have you seen with no_async_abort=0 (default)? At which

Re: [PATCH 1/15] block copy: initial XCOPY offload support

2014-08-05 Thread Mikulas Patocka
On Mon, 4 Aug 2014, Pavel Machek wrote: On Tue 2014-07-15 15:34:47, Mikulas Patocka wrote: This is Martin Petersen's xcopy patch (https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopyid=0bdeed274e16b3038a851552188512071974eea8) with some bug fixes, ported to the

[PATCH 10/15] scsi: fix decimal printf format specifiers prefixed with 0x

2014-08-05 Thread Hans Wennborg
The prefix suggests the number should be printed in hex, so use the %x specifier to do that. Found by using regex suggested by Joe Perches. Signed-off-by: Hans Wennborg h...@hanshq.net --- drivers/scsi/cxgbi/libcxgbi.c | 2 +- drivers/scsi/nsp32.c | 2 +-