Re: Debugging scsi abort handling ?

2014-08-26 Thread Hans de Goede
Hi, On 08/25/2014 05:41 PM, James Bottomley wrote: On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote: Il 25/08/2014 13:26, Hans de Goede ha scritto: Thanks Bart and Paolo, your insights into this are greatly appreciated. So with uas there are separate usb transaction for cmd, data in,

Re: [PATCH] scsi: fix various kernel-doc problems in scsi_error.c

2014-08-26 Thread Hannes Reinecke
On 08/16/2014 11:15 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Convert spaces to tabs in kernel-doc notation. Correct duplicated (copy-paste) kernel-doc comments that are incorrect. Fix kernel-doc warning: Warning(..//drivers/scsi/scsi_error.c:1647): No description found

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-26 Thread Hannes Reinecke
On 08/22/2014 02:39 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Yoshihiro YUNOMAE Sent: Friday, 08 August, 2014 6:50 AM Subject: [RFC PATCH -logging 00/10] scsi/constants:

Re: [PATCH] drivers: scsi: #define missing include guards

2014-08-26 Thread Hannes Reinecke
On 08/22/2014 02:37 PM, Rasmus Villemoes wrote: The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under drivers/scsi/ contain two-thirds of an include guard, but do not elsewhere. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/aha1542.h | 1 +

RE: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread David Laight
From: Alan Stern On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage could set capacity as UNDETERMINED/

Re: [Xen-devel] [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-26 Thread David Vrabel
On 23/08/14 01:40, Konrad Rzeszutek Wilk wrote: On Fri, Aug 22, 2014 at 02:21:55PM -0700, Nicholas A. Bellinger wrote: For the XEN scsiback parts as a new target fabric driver, feel free to add my: Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org So I assume this will be merged for

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread Oliver Neukum
On Tue, 2014-08-26 at 09:58 +, David Laight wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for the READ CAPACITY(10) to report a value less

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Ching Huang
On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This

RE: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread David Laight
From Oliver Neukum [mailto:oneu...@suse.de] On Tue, 2014-08-26 at 09:58 +, David Laight wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Tomas Henzl
On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl

Re: [PATCH 0/6] qla2xxx device removal fixups

2014-08-26 Thread Joe Lawrence
On Wed, 18 Jun 2014 10:02:13 -0400 Joe Lawrence joe.lawre...@stratus.com wrote: Hi Chad, Giri, et al. Stratus has been testing the upstream qla2xxx driver against surprise device removal and has found a few minor issues along the way. With this patchset, results have been good. Although

RES: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread Alfredo Dal Ava Junior
On Mon, 26 Aug 2014, David Leight wrote: I wonder what the manufacturer would saw in response the bug where windows shows the incorrect size when trying to partition the disk? I contacted enclosure manufacturer (Welland) some weeks ago, they are supposed to escalate my questions to

Re: [PATCH 0/6] qla2xxx device removal fixups

2014-08-26 Thread Christoph Hellwig
On Tue, Aug 26, 2014 at 09:20:55AM -0400, Joe Lawrence wrote: The final four patches are more invasive and modify the scsi_qla_host structure to avoid device removal race conditions. These changes were written to demonstrate the problem at hand and minimally fix them in order to continue

Re: [Xen-devel] [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-26 Thread Christoph Hellwig
On Tue, Aug 26, 2014 at 11:13:15AM +0100, David Vrabel wrote: nods When I chatted with Christopher Hellwig he recommended it be done that way. Did he give a reason? The driver has more scsi bits in it than Xen bits really. There's Xen core changes and a scsi initiator driver and a target

Re: [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread David Vrabel
On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-26 Thread Hannes Reinecke
On 08/22/2014 09:54 PM, Douglas Gilbert wrote: On 14-08-12 11:13 PM, Yoshihiro YUNOMAE wrote: Hi Douglas, Thank you for your comment. (2014/08/08 22:07), Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread Juergen Gross
On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread Alan Stern
On Mon, 25 Aug 2014, Oliver Neukum wrote: On Mon, 2014-08-25 at 16:21 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an

Re: [PATCH v8 3/3] ahci_xgene: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-08-26 Thread Tejun Heo
On Tue, Aug 26, 2014 at 12:17:35PM +0530, Suman Tripathi wrote: Didn't I ask you to update the comment to explain what's going on? [suman] : can you specifically tell which part of the comment is not clear and need more explanation? The comment on top of the function doesn't seem to match

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread James Bottomley
On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote: On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com ---

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread David Vrabel
On 26/08/14 17:37, James Bottomley wrote: On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote: On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by:

Re: Debugging scsi abort handling ?

2014-08-26 Thread James Bottomley
On Tue, 2014-08-26 at 10:13 +0200, Hans de Goede wrote: Hi, On 08/25/2014 05:41 PM, James Bottomley wrote: On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote: Il 25/08/2014 13:26, Hans de Goede ha scritto: Thanks Bart and Paolo, your insights into this are greatly appreciated. So

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-26 Thread Eddie Wai
On Mon, 2014-08-25 at 15:15 -0400, Chad Dupuis wrote: On Fri, 22 Aug 2014, Eddie Wai wrote: On Fri, 2014-08-22 at 20:12 +0200, Maurizio Lombardi wrote: Hi Chad, On 08/22/2014 02:08 PM, Chad Dupuis wrote: Eddie, Maurizio, Since it looks like there can be a difference in the pdev

Re: Debugging scsi abort handling ?

2014-08-26 Thread Hans de Goede
Hi, On 08/26/2014 08:34 PM, James Bottomley wrote: On Tue, 2014-08-26 at 10:13 +0200, Hans de Goede wrote: Hi, On 08/25/2014 05:41 PM, James Bottomley wrote: On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote: Il 25/08/2014 13:26, Hans de Goede ha scritto: Thanks Bart and Paolo, your

Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-26 Thread Dale R. Worley
This is almost certainly a form of the problem reported in AS2105-based enclosure size issues with 2TB HDDs. I'm repeating my original message here so linux-usb can see it, and so it can be connected to the older thread. I'll address it in another message. I've appended James Bottomley's

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-26 Thread James Bottomley
On Tue, 2014-08-26 at 15:39 -0400, Dale R. Worley wrote: This is almost certainly a form of the problem reported in AS2105-based enclosure size issues with 2TB HDDs. I'm repeating my original message here so linux-usb can see it, and so it can be connected to the older thread. I'll address

[PATCH RESEND 0/6] qla2xxx device removal fixups

2014-08-26 Thread Joe Lawrence
Resending patchset against scsi-queue/drivers-for-3.18 with Acked-by and Cc stable annotations. Joe Lawrence (6): qla2xxx: Fix shost use-after-free on device removal qla2xxx: Use qla2x00_clear_drv_active on probe failure qla2xxx: Collect PCI register checks and board_disable scheduling

[PATCH RESEND 1/6] qla2xxx: Fix shost use-after-free on device removal

2014-08-26 Thread Joe Lawrence
Once calling scsi_host_put, be careful to not access qla_hw_data through the Scsi_Host private data (ie, scsi_qla_host base_vha). Fixes: fe1b806f4f71 (qla2xxx: Refactor shutdown code so some functionality can be reused) Cc:

[PATCH RESEND 2/6] qla2xxx: Use qla2x00_clear_drv_active on probe failure

2014-08-26 Thread Joe Lawrence
Take advantage of commit fe1b806f4f71 (qla2xxx: Refactor shutdown code so some functionality can be reused) to remove an inlined copy of qla2x00_clear_drv_active in the driver's probe hardware error path. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Chad Dupuis

[PATCH RESEND 5/6] qla2xxx: Prevent removal and board_disable race

2014-08-26 Thread Joe Lawrence
Introduce mutual exclusion between the qla2xxx_remove_one PCI driver callback and qla2x00_disable_board_on_pci_error, which is scheduled as board_disable work by qla2x00_check_reg{32,16}_for_disconnect: * Leave the driver-specific data attached to the underlying PCI device intact in

[PATCH RESEND 4/6] qla2xxx: Schedule board_disable only once

2014-08-26 Thread Joe Lawrence
There are various callers of qla2x00_check_reg{32,16}_for_disconnect that may schedule board removal on PCI-disconnect. Test-and-set a dedicated flag before scheduling board_disable so it is invoked only once. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Chad Dupuis

[PATCH RESEND 3/6] qla2xxx: Collect PCI register checks and board_disable scheduling

2014-08-26 Thread Joe Lawrence
Add an uint16_t variant of qla2x00_check_reg_for_disconnect and use these routines to check and schedule a PCI-disconnected board from a centralized place. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Chad Dupuis chad.dup...@qlogic.com --- drivers/scsi/qla2xxx/qla_gbl.h |3

[PATCH RESEND 6/6] qla2xxx: Prevent probe and board_disable race

2014-08-26 Thread Joe Lawrence
The PCI register read checking introduced in commit fe1b806f4f71 (qla2xxx: Disable adapter when we encounter a PCI disconnect) is active during driver probe. Hold off scheduling any board removal until the driver probe has completed. This ensures that the the board_disable work structure is

RE: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-26 Thread KY Srinivasan
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Tuesday, August 19, 2014 10:55 AM To: KY Srinivasan Cc: h...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; linux-scsi@vger.kernel.org;

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread Juergen Gross
On 08/26/2014 07:12 PM, David Vrabel wrote: On 26/08/14 17:37, James Bottomley wrote: On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote: On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer

Re: [PATCH 1/5] ipr: Add support for async scanning to speed up boot

2014-08-26 Thread Anton Blanchard
Hi Brian, Switch device scanning logic in the ipr driver to use the async scan API. This speeds up boot times, particularly on large systems. Signed-off-by: Brian King brk...@linux.vnet.ibm.com This reduces the boot time on my box by over 3 seconds. I'm sure it reduces it much more after

Re: [PATCH 3/5]: ipr: kexec boot speed improvements

2014-08-26 Thread Anton Blanchard
Hi Brian, Currently when performing a kexec boot with an ipr adapter, the adapter gets shutdown completely, flushing all write cache, as well as performing a full hardware reset of the card during the shutdown phase of the old kernel. This forces the new kernel to then wait for the adapter