Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-27 Thread Oliver Neukum
On Tue, 2014-08-26 at 10:47 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Oliver Neukum wrote: Just set US_FL_NEEDS_CAP16. If READ CAPACITY(16) fails in that case, it is clear that something is wrong. It must be set or READ CAPACITY(10) alone would be taken as giving a valid answer. You

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Matthieu CASTET
Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) [ 1073.606668] PM: Entering mem sleep [ 1073.606742] Suspending console(s) (use no_console_suspend to debug) [ 1073.607146] sd 1:0:0:0: [sda] Synchronizing SCSI cache [ 1073.639076] sd 1:0:0:0: [sda]

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Tomas Henzl
On 08/27/2014 10:19 PM, Ching Huang wrote: On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote:

[PATCH RESEND] bnx2fc: do not add shared skbs to the fcoe_rx_list

2014-08-27 Thread Maurizio Lombardi
In some cases, the fcoe_rx_list may contains multiple instances of the same skb (the so called shared skbs). the bnx2fc_l2_rcv thread is a loop that extracts a skb from the list, modifies (and destroys) its content and the proceed to the next one. The problem is that if the skb is shared, the

Re: [PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 06:59 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com commit 73af08e11c6638e2abd6b1fa13cdab58c2bbdbf8 Author: Jayamohan Kallickal jayamohan.kallic...@emulex.com Date: Mon May 5 21:41:26 2014 -0400 be2iscsi: Fix interrupt Coalescing

Re: [PATCH 2/5] be2iscsi: Fix the copyright year

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 06:59 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Change the copyright year to 2014 Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be.h

Re: [PATCH 4/5] be2iscsi: Fix processing CQE before connection resources are freed

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 07:00 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Driver should process the completion queue entries before a connection resources are freed. While running mixed traffic due to latency, driver processes the CQE after the connection

Re: [PATCH 3/5] be2iscsi: Fix updating the boot enteries in sysfs

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 07:00 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com During port async event driver should check if there is any boot target configured on the adapter. Update sysfs enteries with the boot target parameters. Signed-off-by: Minh Tran

Re: [PATCH 5/5] be2iscsi: Bump the driver version

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 07:00 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Bump the driver version Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.h | 2 +-

Re: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: A device name is output like sda: Sense Key : Medium Error [current] in __scsi_print_sense(), but it should be [sda] Sense Key : Medium Error [current] because other printk messages output a device name like [sda] foo. Signed-off-by: Yoshihiro

Re: [RFC PATCH 02/10] scsi/constants: Cleanup printk message in scsi_decode_sense_extras()

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: If sense_flags and fixed_valid are zero, the kernel does not need to output a printk message. So, if those conditions are met, it just returns. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc:

Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because [%s] Unrecognized sense data (in hex): %s message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because [%s] CDB: %s\n message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-27 Thread Tomas Henzl
On 08/19/2014 09:25 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2...@areca.com.tw --- Hi Ching, please look at the comments below - } @@ -1039,7 +1147,60 @@ static void

Re: [RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Douglas Gilbert
On 14-08-27 04:40 AM, Matthieu CASTET wrote: Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) [ 1073.606668] PM: Entering mem sleep [ 1073.606742] Suspending console(s) (use no_console_suspend to debug) [ 1073.607146] sd 1:0:0:0: [sda] Synchronizing

Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: sd_print_sense_hdr() calls scsi_show_extd_sense(), but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). We can get same result, so we delete it. Note: Calling scsi_show_extd_sense() is introduced in fdd8b297. Signed-off-by: Yoshihiro

Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Current SCSI trace has hostbyte table and driverbyte table, so we don't need to have the same table in scsi/constants.c. - Result examples Before (printk) sd 2:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE After (ftrace)

Re: [RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous sense messages can be mixed into other sense messages, because continuous printk (KERN_CONT) was used. To avoid the problem, patch d87f3a6f51 introduced a local buffer in Hannes's baranch (*1). But using local buffers can induce stack

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 03:07 PM, Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI printk messages in upstream kernel can be divided by and mixed with other messages. Even if

Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous printk messages of SCSI command can be mixed into other printk messages because multiple printk messages are output for it. To avoid the problem, patch 4e64bb8d6 in Hannes' branch(*1) introduced a local buffer. But using local buffers can

Re: [RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-27 Thread Hannes Reinecke
On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: There are no mean that additional sense code and additional sense code qualifier are output as different messages of sense key, so those information are added. Note: scsi_show_extd_sense() is changed from export symbol to non-export symbol. -

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-27 Thread Hannes Reinecke
On 08/19/2014 07:54 PM, Christoph Hellwig wrote: On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: The host asks the guest to scan when a LUN is removed or added. The only way a guest can identify the removed LUN is when an I/O is attempted on a removed LUN - the SRB status code

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Oliver Neukum wrote: I don't think we want to add another SCSI flag to say that READ CAPACITY(10) is unreliable. Why not? It would only be friendly to tell the upper layer of a malfunction if we know about it. To what end? What will the upper layer do with this

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-27 Thread Douglas Gilbert
On 14-08-27 10:23 AM, Hannes Reinecke wrote: On 08/08/2014 03:07 PM, Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI printk messages in upstream kernel can be

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Matthieu CASTET wrote: Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) The usb storage driver call scsi_report_bus_reset after device reset, but because of commit dfcf7775 4, we don't ignore unit attention if sshdr.asc

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Douglas Gilbert wrote: The unit attention doesn't look like a problem, it looks correct. If the system is unable to detect removable media being changed while the system is suspended, then If the media has a unique identifier, then this unit attention at wakeup

[PATCH] ibmraid: fix writeable attribute with no store method

2014-08-27 Thread Alan
https://bugzilla.kernel.org/show_bug.cgi?id=81311 [ 0.603157] WARNING: at drivers/base/core.c:601 device_create_file+0x8d/0xa0() [ 0.603158] Attribute adapter_id: write permission without 'store' [ 0.603159] Modules linked in: i915(+) i2c_algo_bit drm_kms_helper drm mpt2sas(+) pmcraid(+)

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-08-27 Thread James Smart
Mike, Can you confirm - the nulls this patch correct are because the probe_one and error_detect threads are running concurrently, thus battling ? If so - this fix looks insufficient and we should rework it. Q: why are they allowed to run concurrently ? I could see this solved at the

Re: [PATCH RESEND] libiscsi: Don't retry if xmit_task return a non-transient error code

2014-08-27 Thread Mike Christie
On 08/17/2014 10:23 AM, Sagi Grimberg wrote: Allow transport callback xmit_task to return a non-transient error code -EINVAL to inform us not to retry the task. For any other error code keep the current retry behavior. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Dale R. Worley
From: James Bottomley james.bottom...@hansenpartnership.com Did you try read capacity 16 on it? What happened? (the AS2105 rejects read capacity 16, so there's no reliable way to deduce the capacity of drives over 2TB). OK, I had to track down which package contains sg_readcap. The

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Dale R. Worley
What I find interesting is that Windows (at least, Windows 7 Professional) seems to be able to handle the deficient adapter. What I'd like to do is log the disk commands during the mounting sequence, preferably at both the SCSI and USB layers. Then at least we'll know exactly what the driver is

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread James Bottomley
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote: From: James Bottomley james.bottom...@hansenpartnership.com Did you try read capacity 16 on it? What happened? (the AS2105 rejects read capacity 16, so there's no reliable way to deduce the capacity of drives over 2TB). OK, I

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Dale R. Worley wrote: What I find interesting is that Windows (at least, Windows 7 Professional) seems to be able to handle the deficient adapter. So does Linux. The difference is that Windows believes the values in the partition table in preference to what the hardware

Re: [PATCH] fusion: fix excess parameter kernel-doc warning

2014-08-27 Thread Randy Dunlap
On 08/18/14 10:07, Ewan Milne wrote: On Sat, 2014-08-16 at 14:15 -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix kernel-doc excess parameter warning: Warning(..//drivers/message/fusion/mptbase.c:1411): Excess function parameter 'prod_name' description in

Re: [PATCH] fusion: fix excess parameter kernel-doc warning

2014-08-27 Thread Christoph Hellwig
On Wed, Aug 27, 2014 at 04:47:24PM -0700, Randy Dunlap wrote: Goes with commit c9834c70efbaaa1461ec04289d97a842244fb294. Reviewed-by: Ewan D. Milne emi...@redhat.com Christoph, did you pick up this patch or should I merge it with my documentation patches? I did as mentioned in my reply

Re: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:12), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Current SCSI trace has hostbyte table and driverbyte table, so we don't need to have the same table in scsi/constants.c. - Result examples Before (printk) sd 2:0:0:0: [sda] Result: hostbyte=DID_OK

Re: Re: [RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:15), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous sense messages can be mixed into other sense messages, because continuous printk (KERN_CONT) was used. To avoid the problem, patch d87f3a6f51 introduced a local buffer in Hannes's baranch (*1).

Re: Re: [RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: There are no mean that additional sense code and additional sense code qualifier are output as different messages of sense key, so those information are added. Note: scsi_show_extd_sense() is changed

Re: Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous printk messages of SCSI command can be mixed into other printk messages because multiple printk messages are output for it. To avoid the problem, patch 4e64bb8d6 in Hannes' branch(*1) introduced

[Bug 83391] New: Oops on sd_mod

2014-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=83391 Bug ID: 83391 Summary: Oops on sd_mod Product: SCSI Drivers Version: 2.5 Kernel Version: 2.6.32 Hardware: i386 OS: Linux Tree: Mainline Status:

[Bug 83391] Oops on sd_mod

2014-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=83391 --- Comment #1 from tomsun tomsunc...@gmail.com --- Created attachment 148621 -- https://bugzilla.kernel.org/attachment.cgi?id=148621action=edit the function disassemble info -- You are receiving this mail because: You are watching the

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Wed, 2014-08-27 at 14:29 +0200, Tomas Henzl wrote: On 08/27/2014 10:19 PM, Ching Huang wrote: On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang

[PATCH V6 5/5] add xen pvscsi maintainer

2014-08-27 Thread Juergen Gross
Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com Acked-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1ff06de..0ae6238 100644 ---

[PATCH V6 0/5] Add XEN pvSCSI support

2014-08-27 Thread Juergen Gross
This series adds XEN pvSCSI support. With pvSCSI it is possible to use physical SCSI devices from a XEN domain. The support consists of a backend in the privileged Domain-0 doing the real I/O and a frontend in the unprivileged domU passing I/O-requests to the backend. The code is taken (and

[PATCH V6 2/5] Add XEN pvSCSI protocol description

2014-08-27 Thread Juergen Gross
Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). This header was originally provided by Fujitsu for XEN based on Linux 2.6.18. Changes are: - added comment - adapt to Linux style guide - add support

[PATCH V6 1/5] xen/events: support threaded irqs for interdomain event channels

2014-08-27 Thread Juergen Gross
Export bind_interdomain_evtchn_to_irq() so drivers can use threaded interrupt handlers with: irq = bind_interdomain_evtchn_to_irq(remote_dom, remote_port); if (irq 0) /* error */ ret = request_threaded_irq(...); Signed-off-by: Juergen Gross jgr...@suse.com Acked-by: David Vrabel

[PATCH V6 3/5] Introduce xen-scsifront module

2014-08-27 Thread Juergen Gross
Introduces the XEN pvSCSI frontend. With pvSCSI it is possible for a XEN domU to issue SCSI commands to a SCSI LUN assigned to that domU. The SCSI commands are passed to the pvSCSI backend in a driver domain (usually Dom0) which is owner of the physical device. This allows e.g. to use SCSI tape

[PATCH V6 4/5] Introduce XEN scsiback module

2014-08-27 Thread Juergen Gross
Introduces the XEN pvSCSI backend. With pvSCSI it is possible for a XEN domU to issue SCSI commands to a SCSI LUN assigned to that domU. The SCSI commands are passed to the pvSCSI backend in a driver domain (usually Dom0) which is owner of the physical device. This allows e.g. to use SCSI tape