Re: [PATCH 14/14] sd: Honor block layer integrity handling flags

2014-09-11 Thread Sagi Grimberg
On 9/11/2014 3:07 AM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: [Back from vacation] Hey Martin, + [SCSI_PROT_WRITE_PASS] = SCSI_PROT_TRANSFER_PI | + SCSI_PROT_GUARD_CHECK | + SCSI_PROT_REF_CHECK | + SCSI_PROT_REF_INCREMENT | +

Re: Updated linux uas driver, please test

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 10:54 PM, Douglas Gilbert wrote: On 14-09-10 08:13 AM, Hans de Goede wrote: Hi All, I'm mailing all of you because you've reported various problems with the new uas support in kernel 3.16 and later. I've been working on making the uas driver more resilient to errors, as

RE: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Kashyap Desai
-Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl Cc: Elliott, Robert (Server Storage); Sumit Saxena; linux-scsi@vger.kernel.org; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com;

[PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Hans de Goede
Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h index 1e298ec..8a6f371 100644 ---

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: I've applied the patch, this results in the following new dmesg output when using uas: [ 120.602632] initialized host-wide tag map! Thank you for looking into this. So

Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Bjørn Mork
Hans de Goede hdego...@redhat.com writes: --- a/drivers/usb/storage/uas-detect.h +++ b/drivers/usb/storage/uas-detect.h @@ -73,8 +73,8 @@ static int uas_use_uas_driver(struct usb_interface *intf, * broken on the ASM1051, use the number of streams to differentiate. * New

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Tomas Henzl
On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl Cc: Elliott, Robert (Server Storage); Sumit Saxena; linux-scsi@vger.kernel.org; martin.peter...@oracle.com;

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Tomas Henzl
On 09/11/2014 04:48 AM, Kashyap Desai wrote: On Wed, Sep 10, 2014 at 8:36 PM, Tomas Henzl the...@redhat.com wrote: On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Problem statement: MFI link list in megaraid_sas driver is used from mfi-mpt pass-through commands. This list can be

Re: [PATCH V3 09/16] scsi: ufs: introduce well known logical unit in ufs

2014-09-11 Thread Akinobu Mita
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static void ufshcd_set_queue_depth(struct scsi_device *sdev) +{ + int ret = 0; + u8 lun_qdepth; + struct ufs_hba *hba; + + hba = shost_priv(sdev-host); + + lun_qdepth = hba-nutrs; + ret =

Re: [PATCH V3 11/16] scsi: ufs: refactor configuring power mode

2014-09-11 Thread Akinobu Mita
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static int ufshcd_config_pwr_mode(struct ufs_hba *hba, + struct ufs_pa_layer_attr *desired_pwr_mode) +{ + struct ufs_pa_layer_attr final_params = { 0 }; + int ret; + + if

[PATCH] xen-scsifront: don't deadlock if the ring becomes full

2014-09-11 Thread David Vrabel
scsifront_action_handler() will deadlock on host-host_lock, if the ring is full and it has to wait for entries to become available. Signed-off-by: David Vrabel david.vra...@citrix.com --- This was found with sparse. I've not tested it. --- drivers/scsi/xen-scsifront.c |3 ++- 1 file changed,

Re: [PATCH] xen-scsifront: don't deadlock if the ring becomes full

2014-09-11 Thread Juergen Gross
On 09/11/2014 03:31 PM, David Vrabel wrote: scsifront_action_handler() will deadlock on host-host_lock, if the ring is full and it has to wait for entries to become available. Signed-off-by: David Vrabel david.vra...@citrix.com --- This was found with sparse. I've not tested it. Test might be

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Tomas Henzl
On 09/11/2014 05:59 AM, Ching Huang wrote: On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Christoph Hellwig
On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: So we're initializing the tag map, but scsi_activate_tcq doesn't pick it up. I can't really come up with a good explanation for it, but there even without that there is an elephant in the room: as part of the scsi-mq series I

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Kashyap Desai
On Thu, Sep 11, 2014 at 4:50 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl Cc: Elliott, Robert (Server Storage); Sumit

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Vivek Goyal
On Thu, Sep 11, 2014 at 10:09:27PM +0530, Kashyap Desai wrote: [..] OK, just keep in mind that the is_kdump_kernel() is not yet in mainline. Sure I read that part, but when I check kernel source I found is_kdump_kernel() is available.

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Kashyap Desai
On Thu, Sep 11, 2014 at 5:53 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 04:48 AM, Kashyap Desai wrote: On Wed, Sep 10, 2014 at 8:36 PM, Tomas Henzl the...@redhat.com wrote: On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote: Problem statement: MFI link list in megaraid_sas

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Tomas Henzl
On 09/11/2014 06:39 PM, Kashyap Desai wrote: On Thu, Sep 11, 2014 at 4:50 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal [mailto:vgo...@redhat.com] Sent: Wednesday, September 10, 2014 9:17 PM To: Tomas Henzl

Re: [PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-11 Thread Kashyap Desai
On Fri, Sep 12, 2014 at 12:28 AM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 06:39 PM, Kashyap Desai wrote: On Thu, Sep 11, 2014 at 4:50 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 11:02 AM, Kashyap Desai wrote: -Original Message- From: Vivek Goyal

Re: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Tomas Henzl
On 09/11/2014 08:41 PM, Kashyap Desai wrote: On Thu, Sep 11, 2014 at 5:53 PM, Tomas Henzl the...@redhat.com wrote: On 09/11/2014 04:48 AM, Kashyap Desai wrote: On Wed, Sep 10, 2014 at 8:36 PM, Tomas Henzl the...@redhat.com wrote: On 09/06/2014 03:25 PM, sumit.sax...@avagotech.com wrote:

RE: [PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-11 Thread Kashyap Desai
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Friday, September 12, 2014 12:50 AM To: Kashyap Desai Cc: Sumit Saxena; linux-scsi@vger.kernel.org; Martin K. Petersen; Christoph Hellwig; jbottom...@parallels.com; aradford Subject: Re: [PATCH 10/11]

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread James Bottomley
On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote: On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote: On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote: The thing is that we have to have dynamic mechanism to listen for device attachments no matter what and such

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote: On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote: On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote: On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote: The thing is that we have to have

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 1:23 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: There are elements in common, but by and large the biggest headaches at least in large device number boots have already been tackled by the enterprise crowd (they don't like their S390's or 1024 core NUMA

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 01:42:20PM -0700, Luis R. Rodriguez wrote: On Thu, Sep 11, 2014 at 1:23 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: There are elements in common, but by and large the biggest headaches at least in large device number boots have already been tackled by

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 1:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Sep 11, 2014 at 01:42:20PM -0700, Luis R. Rodriguez wrote: On Thu, Sep 11, 2014 at 1:23 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: There are elements in common, but by and large the

Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Greg Kroah-Hartman
On Thu, Sep 11, 2014 at 11:06:12AM +0200, Hans de Goede wrote: Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) You forgot the reported-by line, I'll go add it...

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: More than two years have gone by on growing design and assumptions on top of that original commit. I'm not sure if *systemd folks* yet believe its was a design regression? I don't think so. udev should not

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: More than two years have gone by on growing design and assumptions on top of that original commit. I'm not sure if *systemd folks* yet believe

RE: [PATCH V3 01/16] scsi: support well known logical units

2014-09-11 Thread Subhash Jadavani
This is the defintion of the field in SPC (does the UFS spec duplicate all of SPC?), Yes, UFS device specification (both 1.1 and 2.0) supports [SAM], INCITS T10 draft standard: SCSI Architecture Model - 5 (SAM-5), Revision 05, 19 May 2010 [SPC], INCITS T10 draft standard: SCSI Primary Commands

Re: [PATCH 14/14] sd: Honor block layer integrity handling flags

2014-09-11 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: Sagi, Sagi That's still a dependence on prot_type (type 0...). Notice that Sagi you set SCSI_PROT_REF_INCREMENT in every op index (except Sagi SCSI_PROT_NORMAL) so my point is that it's strange to see this Sagi association. I still don't

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Ching Huang
On Thu, 2014-09-11 at 16:21 +0200, Tomas Henzl wrote: On 09/11/2014 05:59 AM, Ching Huang wrote: On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Fri, Sep 12, 2014 at 12:26 AM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen t...@jklm.no wrote: How about simply introducing a new flag to finit_module() to indicate that the caller does not care about asynchronicity. We could then pass