Re: [PATCH 2/6] blk-mq: call blk_mq_start_request from -queue_rq

2014-09-15 Thread Ming Lei
On Sun, Sep 14, 2014 at 7:40 AM, Christoph Hellwig h...@lst.de wrote: When we call blk_mq_start_request from the core blk-mq code before calling into -queue_rq there is a racy window where the timeout handler can hit before we've fully set up the driver specific part of the command. It is

Re: [PATCH 2/6] blk-mq: call blk_mq_start_request from -queue_rq

2014-09-15 Thread Ming Lei
On Sun, Sep 14, 2014 at 7:40 AM, Christoph Hellwig h...@lst.de wrote: When we call blk_mq_start_request from the core blk-mq code before calling into -queue_rq there is a racy window where the timeout handler can hit before we've fully set up the driver specific part of the command. One

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-15 Thread Tejun Heo
On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote: [suman] : So the posted version is acceptable ? Any others comments on this patch ? I'm suggesting setting ctx-cs_mux to NULL on failure. IOW, if (res) { ctx-csr_mux = devm_ioremap_resources();

[PATCH fix for 3.17 v4] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Hans de Goede
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command. https://bugzilla.kernel.org/show_bug.cgi?id=79511 https://bbs.archlinux.org/viewtopic.php?id=183190 While at it also add missing documentation for the u value for

[PATCH fix for 3.17 v4] uas: Add a quirk for rejecting ATA_12 and ATA_16

2014-09-15 Thread Hans de Goede
Hi Greg, Sorry for the high number of iterations on this one. After the documentation issues pointed out during review, I've just received a report from a user that (as I already suspected) another seagate disk enclosure also benifits from this quirk. So this version sets the quirk for 2

RE: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread David Laight
From: Alan Stern ... p = quirks; while (*p) { @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, unsigned long *fflags) case 's': f |= US_FL_SINGLE_LUN; break; + case 't': +

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-15 Thread Russell King - ARM Linux
On Mon, Sep 15, 2014 at 04:44:52PM +0900, Tejun Heo wrote: On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote: [suman] : So the posted version is acceptable ? Any others comments on this patch ? I'm suggesting setting ctx-cs_mux to NULL on failure. IOW, if (res) {

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it is relative to

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
On 09/15/2014 06:34 AM, Ching Huang wrote: On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: On 09/12/2014 10:22 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it

Re: [PATCH V3 09/16] scsi: ufs: introduce well known logical unit in ufs

2014-09-15 Thread Dolev Raviv
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static void ufshcd_set_queue_depth(struct scsi_device *sdev) +{ + int ret = 0; + u8 lun_qdepth; + struct ufs_hba *hba; + + hba = shost_priv(sdev-host); + + lun_qdepth = hba-nutrs; + ret =

[PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change since v4: 1. add spin_lock in arcmsr_done4abort_postqueue for protect doneq_index. 2. fix

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-15 Thread Dolev Raviv
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static inline void ufshcd_enable_irq(struct ufs_hba *hba) +{ + if (!hba-is_irq_enabled) { + enable_irq(hba-irq); + hba-is_irq_enabled = true; + } +} + +static inline void

Re: [PATCH V3 11/16] scsi: ufs: refactor configuring power mode

2014-09-15 Thread Dolev Raviv
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static int ufshcd_config_pwr_mode(struct ufs_hba *hba, + struct ufs_pa_layer_attr *desired_pwr_mode) +{ + struct ufs_pa_layer_attr final_params = { 0 }; + int ret; + + if

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Oliver Neukum
On Mon, 2014-09-15 at 08:42 +, David Laight wrote: From: Alan Stern You must not add an aditional value for a module parameter without documenting it in Documentation/kernel-parameters.txt. How can this work as a 'module parameter'? It cannot. This parameter is an aid to debugging.

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 12:36 PM, Ching Huang wrote: On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 13:50 +0200, Tomas Henzl wrote: On 09/15/2014 12:36 PM, Ching Huang wrote: On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Hans de Goede
Hi, On 09/15/2014 10:42 AM, David Laight wrote: From: Alan Stern ... p = quirks; while (*p) { @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, unsigned long *fflags) case 's': f |= US_FL_SINGLE_LUN;

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Tomas Henzl
On 09/10/2014 11:58 AM, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding concern, and I'd really like to merge the arcmsr

Re: [PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
On 09/15/2014 01:05 PM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change since v4: 1. add spin_lock in

[PATCH fix for 3.17 v5] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Hans de Goede
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command. https://bugzilla.kernel.org/show_bug.cgi?id=79511 https://bbs.archlinux.org/viewtopic.php?id=183190 While at it also add missing documentation for the u value for

Re: [PATCH fix for 3.17 v5] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote: And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command. https://bugzilla.kernel.org/show_bug.cgi?id=79511

Re: [PATCH fix for 3.17 v5] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Hans de Goede
Hi, On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote: On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote: And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command.

Re: [PATCH V3 09/16] scsi: ufs: introduce well known logical unit in ufs

2014-09-15 Thread Akinobu Mita
2014-09-15 19:39 GMT+09:00 Dolev Raviv dra...@codeaurora.org: 2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static void ufshcd_set_queue_depth(struct scsi_device *sdev) +{ + int ret = 0; + u8 lun_qdepth; + struct ufs_hba *hba; + + hba =

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Alan Stern
On Mon, 15 Sep 2014, Oliver Neukum wrote: On Mon, 2014-09-15 at 08:42 +, David Laight wrote: From: Alan Stern You must not add an aditional value for a module parameter without documenting it in Documentation/kernel-parameters.txt. How can this work as a 'module parameter'?

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Christoph Hellwig
On Mon, Sep 15, 2014 at 03:23:36PM +0200, Tomas Henzl wrote: Christoph, you may add my 'reviewed-by' to the arcmsr series http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr with the '[PATCH v5 2/2] arcmsr: simplify of updating doneq_index and

review-ping: Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-15 Thread Christoph Hellwig
Can I get some reviews for this patch so that we can get into 3.17-rc? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-15 Thread Webb Scales
On 9/12/14 7:00 PM, Christoph Hellwig wrote: Please try the fix below, looks like the commit broke TCQ for all drivers using block-level tagging. --- From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig h...@lst.de Date: Fri, 12 Sep 2014 16:00:19 -0700

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-15 Thread Hans de Goede
Hi, On 9/12/14 7:00 PM, Christoph Hellwig wrote: Please try the fix below, looks like the commit broke TCQ for all drivers using block-level tagging. --- From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig h...@lst.de Date: Fri, 12 Sep 2014

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-15 Thread Jeff Moyer
Christoph Hellwig h...@infradead.org writes: Please try the fix below, looks like the commit broke TCQ for all drivers using block-level tagging. --- From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig h...@lst.de Date: Fri, 12 Sep 2014 16:00:19

Re: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-15 Thread Rickard Strandqvist
2014-09-15 0:38 GMT+02:00 Elliott, Robert (Server Storage) elli...@hp.com: -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] How do you mean? strncpy zeroes throughout the remainder of the string from until the length off to_length, or

[PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909

2014-09-15 Thread Anish Bhatt
Just like CNIC, tristate of these two modules is also dependent on IPV6. These need to be handled separately as they select CNIC, which can override tristate for CNIC from 'm' to 'y', which can cause build failures when ipv6 is compiled as a module even if CNIC's Kconfig will only 'm' or 'n' when

[PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6

2014-09-15 Thread Anish Bhatt
Just like CNIC bnx2i/bnx2fc also have their tristate dependent on IPV6, however using the same solution as CNIC can cause recursive dependecies during make. Based on suggestions by Randy Dunlap, SCSI_NETLINK now depends on NET instead of selecting NET. Second patch fixes the actual randconfig

[PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET

2014-09-15 Thread Anish Bhatt
Required for avoiding recursive dependencies in the Kconfig, brought out by fixing randconfig error for bnx2i/bnx2fc in the patch that follows. As suggested by Randy Dunlap Signed-off-by: Anish Bhatt an...@chelsio.com --- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ANNOUNCE] scsi patch queue tree updated

2014-09-15 Thread Christoph Hellwig
Hi James, I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc. One is a regression fix for drivers using block layer tagging when not using blk-mq introduced in the blk-mq series, and the other

[PATCH 1/4] target: Remove unneeded check in sbc_parse_cdb

2014-09-15 Thread Andy Grover
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd-execute_cmd isn't also set. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1

[PATCH 4/4] target: Add a user-passthrough backstore

2014-09-15 Thread Andy Grover
Add a LIO storage engine that presents commands to userspace for execution. This would allow more complex backstores to be implemented out-of-kernel, and also make experimentation a-la FUSE (but at the SCSI level -- SUSE?) possible. It uses a mmap()able UIO device per LUN to share a command ring

[PATCH 2/4] uio: Export definition of struct uio_device

2014-09-15 Thread Andy Grover
In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover agro...@redhat.com ---

[PATCH 3/4] target: Add documentation on the target userspace pass-through driver

2014-09-15 Thread Andy Grover
Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Thanks to Richard W. M. Jones for review, and supplementing this doc with the first two paragraphs. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu-design.txt |

[PATCH 0/4] Userspace Passthrough backstore for LIO

2014-09-15 Thread Andy Grover
Hi all, Here is version three of the userspace passthrough backstore code I've been working on. I think it's ready to be considered for upstream. If you are wondering what this is, patch 3 is documentation that should explain, at both a high- and low-level. There are other pieces needed for

[PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread Randy Dunlap
From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: drivers/built-in.o: In function `scsi_nl_rcv_msg': scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack' scsi_netlink.c:(.text+0x185105): undefined

[PATCH scsi] cxgb4i : Avoid holding mutex in interrupt context

2014-09-15 Thread Anish Bhatt
cxgbi_inet6addr_handler() can be called in interrupt context, so use rcu protected list while finding netdev Applies on top of core-for-3.18 Signed-off-by: Anish Bhatt an...@chelsio.com Signed-off-by: Karen Xie k...@chelsio.com Fixes: fc8d0590d914 (libcxgbi: Add ipv6 api to driver) Fixes:

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 10:05 -0700, Christoph Hellwig wrote: On Mon, Sep 15, 2014 at 03:23:36PM +0200, Tomas Henzl wrote: Christoph, you may add my 'reviewed-by' to the arcmsr series http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr with the

RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread Anish Bhatt
From : Randy Dunlap [rdun...@infradead.org] Sent: Monday, September 15, 2014 5:20 PM To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David Miller Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com; jim.ep...@gmail.com Subject: [PATCH 3] scsi: fix

Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread Randy Dunlap
On 09/15/14 20:00, Anish Bhatt wrote: Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig You mean these kconfig warnings? quote After merging the net tree, today's

Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 17:20:42 -0700 From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: ... Signed-off-by: Randy Dunlap rdun...@infradead.org Applied, thanks a lot Randy. --

RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread Anish Bhatt
From: Randy Dunlap [rdun...@infradead.org] Sent: Monday, September 15, 2014 8:17 PM To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David Miller Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com;